Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Hardware & Software > Software players

Closed Thread
 
Thread Tools Search this Thread Display Modes
Old 25th July 2009, 17:46   #8721  |  Link
ar-jar
Registered User
 
Join Date: Mar 2009
Location: Vreta kloster, Sweden
Posts: 332
Quote:
Originally Posted by tetsuo55 View Post
Anyone with compiling capabilities,

Does MPC-HC still function(or even fully compile) if you compile with these settings:

x86: "/SAFESEH /O2 /GS /arch:SSE2 /EHa"
x64 AMD: "/favor:AMD64 /O2 /GS /EHa"
x64 INTEL: "/favor:INTEL64 /O2 /GS /EHa"
x64 universal(SLOW): "/favor:blend /O2 /GS /EHa"
This is what I get when plugging in the options from the first line (x86):

3>Linking...
3>dsutilRU.lib(a_yuv2rgb.obj) : error LNK2026: module unsafe for SAFESEH image.
3>dsutilRU.lib(convert_a.obj) : error LNK2026: module unsafe for SAFESEH image.
3>d2vsourceRU.lib(idctmmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>Mpeg2DecFilterRU.lib(motion_comp_mmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>Mpeg2DecFilterRU.lib(idct_mmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(lpc_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(bitreader_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(cpu_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(CompilatorVersion.o) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(mpc_helper.o) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(parser.o) : error LNK2026: module unsafe for SAFESEH image.

... and so on with a whole bunch of other .o files in MPCVideoDecRU.lib.

Without the /SAFESEH option to the linker, everything seems to work ok.
-A
ar-jar is offline  
Old 25th July 2009, 18:13   #8722  |  Link
gngn
the hedgehog
 
gngn's Avatar
 
Join Date: Apr 2008
Posts: 163
Quote:
Originally Posted by Casimir666 View Post
New test build with all this changes available from here : http://www.zshare.net/download/6313488079dc9738/
the problems with XP+nvidia+DXVA introduced in r1141 ( post #8320) are now fixed.
only that the max ReFrames for XP seems to be now 14. videos with ReFrames=15 or above wont play.
__________________
Athlonx2@2,9Ghz,2G DDRAM2@800Mhz,WinXPSP3 x86,GF8600GTS-256M,Nvidiadrivers 295.73
latest MPC-HC (MVS2010 SP1, GCC 4.7.1)
VMR9renderless+VMR9MixerMode+YUVMixing,VSync+AccurateVSync,all GPUflushes on
gngn is offline  
Old 25th July 2009, 18:16   #8723  |  Link
The1n
Registered User
 
Join Date: Nov 2005
Posts: 74
@The1n
Could you try again with new test build (if not ok would you post your screenshot on imageshark or something your previous attachement is still waiting validation)?

New test build with all this changes available from here : http://www.zshare.net/download/6313488079dc9738/

Hi Casimir666 , when trying out your latest test build it looked a little better but still error frames with original bluray films, here is a zshare link for you.

http://www.zshare.net/download/63146496f464ec2b/

The1n
The1n is offline  
Old 25th July 2009, 18:36   #8724  |  Link
Casimir666
Registered User
 
Join Date: Jan 2007
Posts: 455
@ Mercury
I fixed the True HD and LPCM mapping. The Eac3 is still 5.1 instead of 7.1 because ffmpeg return only 6 channels! Back and side surround channel are out on back.
Cannot fix the DTS, because it's decoded by libdts that didn't support 7.1.

I didn't understand for the AC3 sample : are you sure it's wrong? Can you try with original mpc because the original mapping is used in this case and i would be surprise if it's wrong. Your file is 5.1 and not 7.1?


@ All
I fixed other small issues on DXVA, and if no major bugs are detected this build will became next stable release :
http://www.zshare.net/download/6314672884c0d9d9/
__________________
Tired of tearing?
Try this Media Player Classic mod : http://mpc-hc.sourceforge.net
Casimir666 is offline  
Old 25th July 2009, 18:41   #8725  |  Link
tetsuo55
MPC-HC Project Manager
 
Join Date: Mar 2007
Posts: 2,317
Quote:
Originally Posted by ar-jar View Post
This is what I get when plugging in the options from the first line (x86):

3>Linking...
3>dsutilRU.lib(a_yuv2rgb.obj) : error LNK2026: module unsafe for SAFESEH image.
3>dsutilRU.lib(convert_a.obj) : error LNK2026: module unsafe for SAFESEH image.
3>d2vsourceRU.lib(idctmmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>Mpeg2DecFilterRU.lib(motion_comp_mmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>Mpeg2DecFilterRU.lib(idct_mmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(lpc_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(bitreader_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(cpu_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(CompilatorVersion.o) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(mpc_helper.o) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(parser.o) : error LNK2026: module unsafe for SAFESEH image.

... and so on with a whole bunch of other .o files in MPCVideoDecRU.lib.

Without the /SAFESEH option to the linker, everything seems to work ok.
-A
Those command tell the compiler to : Prefer speed over size, and security over both.
Those erroring files need to be recompiled with this setting enabled using VS2008SP1
__________________
MPC-HC, an open source project everyone can improve. Want to help? Test Nightly Builds, submit patches or bugs and chat on IRC
tetsuo55 is offline  
Old 25th July 2009, 19:09   #8726  |  Link
hoborg
Registered User
 
Join Date: Nov 2008
Posts: 454
Quote:
Originally Posted by Casimir666 View Post

@ All
I fixed other small issues on DXVA, and if no major bugs are detected this build will became next stable release :
http://www.zshare.net/download/6314672884c0d9d9/
Casimit, just tryed and bad news - no changes at all Still get wrong frames order on all h.264 MKV i have :/
__________________
Working machine: Win10x64 + Intel Skull Canyon
My HTPC.

How to start with Bitcoin
hoborg is offline  
Old 25th July 2009, 20:11   #8727  |  Link
Mercury_22
Registered User
 
Join Date: Dec 2007
Posts: 1,122
Quote:
Originally Posted by Casimir666 View Post
@ Mercury
I fixed the True HD and LPCM mapping. The Eac3 is still 5.1 instead of 7.1 because ffmpeg return only 6 channels! Back and side surround channel are out on back.
Cannot fix the DTS, because it's decoded by libdts that didn't support 7.1.

I didn't understand for the AC3 sample : are you sure it's wrong? Can you try with original mpc because the original mapping is used in this case and i would be surprise if it's wrong. Your file is 5.1 and not 7.1?


@ All
I fixed other small issues on DXVA, and if no major bugs are detected this build will became next stable release :
http://www.zshare.net/download/6314672884c0d9d9/
Yes I'm sure about AC3 ! Also MPC 6.4.9.0 (original mpc) has the same WRONG mapping ! If it helps FFDShow has the correct mapping for Ac3 (Dolby Digital)
Yes the TEST file is 5.1 ! AFAIK AC3 (Dolby Digital) has MAX 6 channels http://en.wikipedia.org/wiki/Ac3 or http://www.dolby.com/consumer/techno...y_digital.html

Ac3 (Dolby Digital) wrong mapped channels:
1 - REAR RIGHT wrong mapped to FRONT RIGHT
2 - REAR LEFT wrong mapped to FRONT LEFT
= No rear channels!

Test 5.1 AC3 (Dolby Digital)


I can confirm TrueHD and LPCM (and E-AC3 since "ffmpeg return only 6 channels" ) now are working correct !

About DTS, please can't you at least make it like E-AC3 : "Back and side surround channels are out on back." ?

DTS (-HD HR MA) wrong mapped channels:
1 - SIDE RIGHT wrong mapped to FRONT RIGHT
2 - REAR RIGHT wrong mapped to FRONT RIGHT
3 - SIDE LEFT wrong mapped to FRONT LEFT
4 - REAR LEFT wrong mapped to FRONT LEFT

Test 7.1 DTS-HD HR

P.S. PLEASE can you compile a x64 version too ?
__________________
Windows 10 x64 CU, HD7790 Crimson 17.6.2, HDMI Full RGB 4:4:4

Last edited by Mercury_22; 25th July 2009 at 22:18.
Mercury_22 is offline  
Old 25th July 2009, 20:40   #8728  |  Link
73ChargerFan
Registered User
 
73ChargerFan's Avatar
 
Join Date: Dec 2006
Posts: 505
Sorry for OT, but my HTPC is getting old, and I'm tired of tearing with my BD rips. This is the only application I run on it, except for Opera.

Current: AMD 4600X2, 2gb DDR memory, ATI 4850, Windows XP MCE 2005.

I purchased a Athlon 2 X2 250 to upgrade, with 4gb DDR2, re-use my ATI 4850, Windows 7 (x86 or 64). $185.

Will this be blazing fast, enough that I can ignore DXVA? Or should I return it and upgrade to the AMD max, a Phenom 945? This would be $300. Money is a consideration...
73ChargerFan is offline  
Old 25th July 2009, 22:28   #8729  |  Link
_xxl
ffdshow user
 
_xxl's Avatar
 
Join Date: Oct 2005
Location: Romania
Posts: 818
Quote:
Those command tell the compiler to : Prefer speed over size, and security over both.
Those erroring files need to be recompiled with this setting enabled using VS2008SP1
What part of mpc-hc could benefit from those compiler optimizations?
_xxl is offline  
Old 25th July 2009, 22:31   #8730  |  Link
tetsuo55
MPC-HC Project Manager
 
Join Date: Mar 2007
Posts: 2,317
Quote:
Originally Posted by _xxl View Post
What part of mpc-hc could benefit from those compiler optimizations?
Overall optimization could mean the difference between jittering and stable playback on slower systems.

some parts are very system intensive like the internal subtitle renderer, this can use any optimization it can get.

Mostly it's for security though, to prevent any exploits from things like malformed avi/wmv/mkv files or http links.
__________________
MPC-HC, an open source project everyone can improve. Want to help? Test Nightly Builds, submit patches or bugs and chat on IRC
tetsuo55 is offline  
Old 25th July 2009, 22:34   #8731  |  Link
_xxl
ffdshow user
 
_xxl's Avatar
 
Join Date: Oct 2005
Location: Romania
Posts: 818
I get some crashes with internal avi spitter and xvid avi files. If avi spitter is disabled no crash. This is happening also with Haali's avi splitter, but not with MS one.
_xxl is offline  
Old 25th July 2009, 22:36   #8732  |  Link
_xxl
ffdshow user
 
_xxl's Avatar
 
Join Date: Oct 2005
Location: Romania
Posts: 818
Quote:
Overall optimization could mean the difference between jittering and stable playback on slower systems.
Maybe I should add a vc project file that uses all optimizations?
_xxl is offline  
Old 25th July 2009, 22:40   #8733  |  Link
tetsuo55
MPC-HC Project Manager
 
Join Date: Mar 2007
Posts: 2,317
Yes the project file should be updated, but only after we confirm no new problems arise, and any new warnings have to be fixed too.

these warnings point to possible exploitable security problems.

Also if you use the ARCH:SSE2 by default anyone with a CPU that does not have SSE2 will not be able to use MPC-HC
__________________
MPC-HC, an open source project everyone can improve. Want to help? Test Nightly Builds, submit patches or bugs and chat on IRC
tetsuo55 is offline  
Old 25th July 2009, 23:24   #8734  |  Link
Casimir666
Registered User
 
Join Date: Jan 2007
Posts: 455
Quote:
Originally Posted by _xxl View Post
Maybe I should add a vc project file that uses all optimizations?
Be careful playing with optimisation, it's really hard to know if it improve things or not and could have side effect. I prefer not to commit theses tests in SVN
__________________
Tired of tearing?
Try this Media Player Classic mod : http://mpc-hc.sourceforge.net
Casimir666 is offline  
Old 26th July 2009, 00:20   #8735  |  Link
_xxl
ffdshow user
 
_xxl's Avatar
 
Join Date: Oct 2005
Location: Romania
Posts: 818
Quote:
Be careful playing with optimization, it's really hard to know if it improve things or not and could have side effect. I prefer not to commit theses tests in SVN
True, stability is more important than speed.
_xxl is offline  
Old 26th July 2009, 03:11   #8736  |  Link
thuan
Registered User
 
Join Date: Sep 2005
Location: Vietnam, HCM City
Posts: 262
@73ChargerFan:
If you don't want to rely on DXVA then that CPU will not be enough in some cases, as mine, a Xeon E3110 (equal the Core 2 Duo E8400), isn't enough in some cases either, with libavcodec from ffdshow or MPC-HC internal. I mostly use DXVA now with my nvidia card (9500GT), and it works nearly perfect with MPC-HC. DXVA from ATI card I owned previously (HD2400XT) was really erratic, not to mention the chroma upsampling problem. I wonder if the latter problem is fixed now?
thuan is offline  
Old 26th July 2009, 05:54   #8737  |  Link
Snowknight26
Registered User
 
Join Date: Aug 2007
Posts: 1,373
r1179 doesn't downmix AC3 or DTS anymore. Even though I have both filters set to decode to stereo, the audio renderer shows 6 channels.

And on a separate note, I've noticed that several Blu-rays of mine show subtitles only in the MPEG PS splitter but not in the Subtitles menu, so subsequently they can't be enabled.

Samples on request.

Last edited by Snowknight26; 26th July 2009 at 06:11.
Snowknight26 is offline  
Old 26th July 2009, 07:07   #8738  |  Link
73ChargerFan
Registered User
 
73ChargerFan's Avatar
 
Join Date: Dec 2006
Posts: 505
Thanks thuan, hc & tetsuo55 - I decided to exchange the Athlon II X2 250 for a Phenom II X3 720 BE.
73ChargerFan is offline  
Old 26th July 2009, 08:04   #8739  |  Link
tetsuo55
MPC-HC Project Manager
 
Join Date: Mar 2007
Posts: 2,317
Quote:
Originally Posted by Casimir666 View Post
Be careful playing with optimisation, it's really hard to know if it improve things or not and could have side effect. I prefer not to commit theses tests in SVN
Quote:
Originally Posted by _xxl View Post
True, stability is more important than speed.
Yes we have to be absolutely sure first.

Please not that:
/arch:[SSE|SSE2] Without this command SSE and other features of chips supporting this are completely unused (unless hand coded into the source). Also for the X64 builds the SSE2 option is enabled by default. (so we can be relatively sure that this works)

/favor (Optimize for x64) This option should provide an increase in speed by dropping backwards compatibility with x86 (this should have been enabled by default )

/GS This is purely a security feature, buffer protection, it can be and should be enabled by default.

/EHa this is a security feature too, exeption handling, this actually changes code and could lead to breaks.

/O2, enabled by default on release builds, slightly different meanings between x86 and x64, could break things.

/SAFESEH security feature that is enabled by default on x64

As you can see, almost all of it should be safe, and a lot of it has been tested on the x64 builds (or has been causing some of the x64 build bugs!)
__________________
MPC-HC, an open source project everyone can improve. Want to help? Test Nightly Builds, submit patches or bugs and chat on IRC
tetsuo55 is offline  
Old 26th July 2009, 09:28   #8740  |  Link
Spec-Chum
Registered User
 
Join Date: Jan 2009
Posts: 60
Revision: 1188

Fixed : support for custom mmco, improved ATI multislice (this rev is broken on ATI+XP)

Links:
x64
x86
Spec-Chum is offline  
Closed Thread

Tags
dxva, h264, home cinema, media player classic, mpc-hc

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 19:59.


Powered by vBulletin® Version 3.8.9
Copyright ©2000 - 2017, vBulletin Solutions, Inc.