nnedi3 plugin for VapourSynth

[jackoneill]

Originally Posted by Are_

I guess I did nothing wrong:
[...]
And indeed the output for opt=4 is wrong, chroma missplacement to the right and interlacing artifacts.

Oops. There was a mistake in the FMA4 functions. I replaced the links.

[Are_]

No problems now. Even if the output is not bit identical, neither is the one from opt=1 with the one from opt=2, I can't spot a single difference.

16bit2opt
Output 2001 frames in 37.40 seconds (53.50 fps)
Output 2001 frames in 37.48 seconds (53.39 fps)
16bit4opt
Output 2001 frames in 32.51 seconds (61.55 fps)
Output 2001 frames in 32.62 seconds (61.35 fps)
8bit2opt
Output 2001 frames in 31.70 seconds (63.12 fps)
Output 2001 frames in 30.97 seconds (64.61 fps)
8bit4opt
Output 2001 frames in 25.44 seconds (78.67 fps)
Output 2001 frames in 25.32 seconds (79.03 fps)

[kolak]

Only 25% speed difference between 8 and 16bit- looks like a good result.

So can we have yadifmod now working at 16bit?

[Reel.Deel]

Originally Posted by kolak

So can we have yadifmod now working at 16bit?

Yadifmod supports 9-16 bits since r2.

Edit: also, here's the appropriate thread: http://forum.doom9.org/showthread.php?t=171028

[kolak]

Heh- I had a long break from avisynth/vapoursynth. I can remember now (I was chasing for it). Great!

[MonoS]

Originally Posted by Are_

No problems now. Even if the output is not bit identical, neither is the one from opt=1 with the one from opt=2, I can't spot a single difference.

It's expected for the output to not be bit identical cause FMA instruction have higher precision than a mul followed than an add [that's because the fpu have infinite precision while fp register have finite precision IIRC]

[jackoneill]

v3 is here.

   * Use FMA (fused multiply-add) instructions in some functions. Speeds up the float paths a bit.
   * Add another SIMD function for a little more speed with 16 bit input.
   * Automatically select the best functions if opt=True, use only C functions if opt=False.
   * Don't embed the weights into the DLLs. "nnedi3 weights.bin" needs to be in the same folder as the DLL.

"nnedi3 weights.bin" can be downloaded from Github: https://github.com/dubhater/vapoursy...%20weights.bin It's the same file that's embedded in the Avisynth plugin.

There is theoretical support for architectures other than x86 now. Little endian ones. If anyone wants to run nnedi3 on something big endian, that can be arranged too, I think. You'll just have to volunteer to test it a bit.

[mawen1250]

With 9-16bit input and FMA3 opt, nnedi3 produces corrupt result. From what I observed, the pixels interpolated by nn predictor are either white or black.

[jackoneill]

Here is v4.

   * Fix copy-paste error in the FMA functions
   * Rename "nnedi3 weights.bin" to "nnedi3_weights.bin"

Due to an unforeseen limitation of Automake, the weights file has been renamed. v4 expects the new name.

The broken output reported in the post above is fixed.

[jackoneill]

Here is v5.

   * Adjust the frame durations when doubling the frame rate.
   * Fix buffer overflow with images wider than 8192 pixels or so (inherited from the Avisynth plugin).
   * Hopefully prevent crashes with images that require more than 2 GiB per plane.
   * Refuse to create clips longer than INT_MAX (often 2**31-1).
   * Use the _FieldBased frame property to determine each frame's field order, for sources where it changes.

If the _FieldBased property is present in the input clip and you need to force a different field order, use std.ModifyFrame to overwrite the _FieldBased property.

[lansing]

the separate link for nnedi3_weights.bin file is broken in the download page

[jackoneill]

Originally Posted by lansing

the separate link for nnedi3_weights.bin file is broken in the download page

Thanks. Fixed it.

[lansing]

it works now, the underscore is missing in the downloaded bin file name, and I'm also getting a "libwinpthread-1.dll is missing" error message

[jackoneill]

Originally Posted by lansing

it works now, the underscore is missing in the downloaded bin file name, and I'm also getting a "libwinpthread-1.dll is missing" error message

The link is in the v3 release notes, so I made it point to the version of the file that works with v3, which has a space instead of underscore. I'll add links to the v4 and v5 release notes too.

I uploaded new builds of v5. The error message is no more.

[lansing]

I'd encounter problem again. I got a "no attribute with the name nnedi3 exists" error with v5. With v4, the video loads fine but crash on seek.

[Are_]

Try with vapoursynth R27.

[lansing]

I installed vapoursynth R27 rc1 and it gave me a series of error on startup on plugins

VapourSynth plugins manager: Failed to get pointer to the plugin Plugin1!
VapourSynth plugins manager: Failed to get pointer to the plugin Plugin10!
...

[jackoneill]

Originally Posted by lansing

I installed vapoursynth R27 rc1 and it gave me a series of error on startup on plugins

VapourSynth plugins manager: Failed to get pointer to the plugin Plugin1!
VapourSynth plugins manager: Failed to get pointer to the plugin Plugin10!
...

That comes from the editor. Please report it here: http://forum.doom9.org/showthread.php?t=170965&page=5

Does it still crash when seeking?

[jeremy33]

Hello,

I try to use nnedi3 with VapourSynth on Linux and this is what I get :



What can do this ?
I'm on Netrunner 14 x64 (Kubuntu derivative) with nvidia 349.16 drivers, MPV 0.91 and VapourSynth 27 from this ppa https://launchpad.net/~djcj/+archive/ubuntu/vapoursynth

[jackoneill]

Originally Posted by jeremy33

Hello,

I try to use nnedi3 with VapourSynth on Linux and this is what I get :



What can do this ?
I'm on Netrunner 14 x64 (Kubuntu derivative) with nvidia 349.16 drivers, MPV 0.91 and VapourSynth 27 from this ppa https://launchpad.net/~djcj/+archive/ubuntu/vapoursynth

Pretty. Please post your VapourSynth script. Also, what version of nnedi3 is that? Does it happen with opt=False?