ffdshow tryouts project: Discussion & Development

[haruhiko_yamagata]

Originally Posted by clsid

I rather have a warning than a mess of files.

No problem.

[haruhiko_yamagata]

@clsid,
Rev 4390 fixes the dialog, but current libavcodec is more complicated.

    /**
     * Error recognition; may misdetect some more or less valid parts as errors.
     * - encoding: unused
     * - decoding: Set by user.
     */
    int err_recognition;
#define AV_EF_CRCCHECK  (1<<0)
#define AV_EF_BITSTREAM (1<<1)
#define AV_EF_BUFFER    (1<<2)
#define AV_EF_EXPLODE   (1<<3)

#define AV_EF_CAREFUL    (1<<16)
#define AV_EF_COMPLIANT  (1<<17)
#define AV_EF_AGGRESSIVE (1<<18)

This cannot be implemented as a combo box. We need six check boxes (not seven, because AV_EF_CAREFUL is not used). But even if we implement six check boxes, who can use them correctly?
AV_EF_CRCCHECK seems to do CRC check for AC3, TTA and wavpack. I don't know what other stuffs do.
I would suggest two options:

• Remove the option completely
• One check box to enable all error recognition (disabled by default)

[haruhiko_yamagata]

Index: src/settings/filters/TdeinterlaceSettings.h
===================================================================
--- src/settings/filters/TdeinterlaceSettings.h	(revision 4390)
+++ src/settings/filters/TdeinterlaceSettings.h	(working copy)
@@ -32,7 +32,7 @@
     int deinterlaceAlways;
     int swapfields;
     int cfgId;
-    static const int cfgIdDef=2;
+    static const int cfgIdDef=14; // yadif
     static const TmethodProps &getMethod(int cfgId);
     int tomsmocompSE,tomsmocompVF;
     char_t dscalerFlnm[MAX_PATH];

Do you agree?

[fastplayer]

Originally Posted by haruhiko_yamagata

I would suggest two options:

• Remove the option completely
• One check box to enable all error recognition (disabled by default)

I can't speak for clsid, but please remove it from the GUI and leave it at ffmpeg's/libav's default setting. It is a usability catastrophe.

[haruhiko_yamagata]

Originally Posted by fastplayer

I can't speak for clsid, but please remove it from the GUI and leave it at ffmpeg's/libav's default setting. It is a usability catastrophe.

Yes, basically it shouldn't be exposed to users. I don't know what the default is.
Here's copy from "avplay -h".

-err_detect        <flags> set error detection flags
   crccheck                verify embedded CRCs
   bitstream               detect bitstream specification deviations
   buffer                  detect improper bitstream length
   explode                 abort decoding on minor error detection

So perhaps explode shouldn't be the default.
CRC check is ideal but eats CPU time.
bitstream and buffer are optional

[nevcairiel]

Just don't touch the value at all when creating the context, and it'll remain whatever is the default.

[clsid]

I am fine with removing obscure options. Less is better. Both error recognition and concealment could be removed. Perhaps also the greyscale option.

[Midzuki]

@ haruhiko:

Could you please confirm (or infirm, why not) the problem described in the post

http://forum.doom9.org/showthread.ph...71#post1565971 ?

Originally Posted by Midzuki

...
Besides:

In VirtualDub ++ the latest QuickTime plugin,

ffdshow (r4382) w/ wmv9 decoder shows only a sequence of black frames

ffdshow w/ libavcodec, && "easy" vc-1,
first frame = green

ffdshow w/ libavcodec, && "difficult" vc-1,
VirtualDub crashes

[haruhiko_yamagata]

Originally Posted by Midzuki

@ haruhiko:

Could you please confirm (or infirm, why not) the problem described in the post

http://forum.doom9.org/showthread.ph...71#post1565971 ?

VC1 isn't supposed to be handled in VFW, is it? I won't fix anything about VC1 in VitualDub.
What is VirtualDub ++?

I would appreciate it, if you write more kind and easy to read report. It is hard to understand for which file, what you do, what you experience and how your computer is set up.

[haruhiko_yamagata]

Originally Posted by clsid

I am fine with removing obscure options. Less is better. Both error recognition and concealment could be removed. Perhaps also the greyscale option.

Simply removed at rev 4396.

[Midzuki]

Originally Posted by haruhiko_yamagata

VC1 isn't supposed to be handled in VFW, is it?

According to the VfW applet of ffdshow,
the answer is *YES*, sir.

It is hard to understand for which file, what you do, what you experience and how your computer is set up.

I don't think so.

[LigH]

LigH offers two cups of Earl Grey to calm down the nerves on both sides...

[haruhiko_yamagata]

Thanks, LigH.

Originally Posted by Midzuki

According to the VfW applet of ffdshow,
the answer is *YES*, sir.

VC1 as well as H.264 are listed there. But sorry, we do not guarantee that they work. They may or may not work.
If you stuff VC1 or H.264 into AVI container forcibly, it may or may not work. VFW dialog is similar stuff.

[FlashGordon]

Originally Posted by haruhiko_yamagata

So perhaps explode shouldn't be the default.
CRC check is ideal but eats CPU time.
bitstream and buffer are optional

http://web.archiveorange.com/archive...28didl1agye0kh according to that, maybe AV_EF_CAREFUL is meant only for CRC checks?

[Midzuki]

^
^ Okay, let's just hope:

1) fccHandler wants to improve his QT-input plugin ;

2) an "inertial patch" by means of an updated Libav will eventually happen ;

[ !-- end of discussion -- ]

[haruhiko_yamagata]

Originally Posted by FlashGordon

http://web.archiveorange.com/archive...28didl1agye0kh according to that, maybe AV_EF_CAREFUL is meant only for CRC checks?

Thanks for the link. Yes, but the topic applies to FFmpeg.
Libav does not use AV_EF_CAREFUL at all. Most part of ffdshow's libavcodec is based on Libav.
Rev 4396 does not change the behavior related to CRC checking because the commit does not affect audio part.

[ryrynz]

Originally Posted by ryrynz

Haruhiko, I can reproduce another Rundll32 error. Simply rename any default preset and press enter, DO NOT click apply, then press ALT + F4.

Originally Posted by haruhiko_yamagata

I can reproduce the crash. Thanks.

Did you want me to file a bug report for this? I know it's minor but it's still there.

[haruhiko_yamagata]

Originally Posted by ryrynz

Did you want me to file a bug report for this? I know it's minor but it's still there.

Yes. I tried to fix, but it wasn't so easy.

[CruNcher]

https://forum.doom9.org/showpost.php...ostcount=19119

im still trying to get a higher resolution of the problem @ work here but it seems just that ffdshow gets prefetched causes this problem it doesn't need to be inside the graph @ all just getting called (on graph buildup once) seems to cause this Black Screen (the question is why). This made me almost crazy i really wondered why i always got a black screen i thought it was the splitters fault but now it shows to be ffdshow and very clearly

i will try to make a clearer chain and a video showing this strange issue

so if anyone in MPC-HC gets a mysterious black screen (especially with DXVA involved in the rendering chain) and doesn't know why (playback continues but video rendering stays black then try to block ffdshow (even if you don't have uncompressed rendering active) it might be the answer)

PS: Another test disabled all decoder in ffdshow still black screen if it's in the preferred status on the external filter list, no matter above or bellow the main decoder (Cyberlink) for the current active stream (preferred) , reseted MPC-HC and the whole custom chain doing more tests.

Yep same 2 filter in the external list setting ffdshow to preferred causes the black screen

[haruhiko_yamagata]

Originally Posted by CruNcher

https://forum.doom9.org/showpost.php...ostcount=19119

Where should I start reading in the thread?