Avisynth+

[StainlessS]

There is a little bit of inconsistency between function names, some use xxxxExist, and some xxxExists.

Exist                     "s"
FunctionExists            "s"
InternalFunctionExists    "s"
VarExist                  "s"

RT_ uses RT_FunctionExist() which was chosen to match the then existing Exist() function.

[real.finder]

Originally Posted by ChaosKing

A check with AddAutoloadDir whould detect Avisynth Neo also as Avisynth+ (it basically is avs+ with cuda stuff) while AvsPlusVersionNumber returns 0. VersionString() returns on avs neo: "Avisynth Neo 0.1 (r2882, Neo, i386)"
It this case a check with AddAutoloadDir would be prefered.
https://github.com/nekopanda/AviSynthPlus/releases

ok, so I did this, it will be in next SMDegrain update, nekopanda already did the damage so forget about my old post

function IsAvsNeo()
{
      FindStr(VersionString, "AviSynth Neo")  != 0
}

function IsAvsPlus()
{
      FindStr(VersionString, "AviSynth+")  != 0 || IsAvsNeo
}

function AvsPlusVersionNumber()
{
    IsAvsNeo ? eval(MidStr(VersionString(),20,4)) : IsAvsPlus ? eval(MidStr(VersionString(),17,4)) : 0
}

can you test it to see if it report the number correctly?

[ChaosKing]

Yes it works, I made a small mistake. Correct is: "AviSynth Neo"
IsAvsPlus and IsAvsNeo returning true for AviSynth Neo.

[real.finder]

Originally Posted by ChaosKing

Yes it works, I made a small mistake. Correct is: "AviSynth Neo"
IsAvsPlus and IsAvsNeo returning true for AviSynth Neo.

and the revision number?

[ChaosKing]

Originally Posted by real.finder

and the revision number?

returns 2822

[real.finder]

Originally Posted by pinterf

The old bug is back, but now it's dither_lut16 is the culprit.
It seems that under Win10 (?) configuration it understands only the decimal separator of the current input local.

Just replace the decimal point to commas in yexpr parameter and it will work fine. (the used ReplaceStr is built-in in AVS+)

function Dither_Luma_Rebuild (clip src, float "s0", float "c",int "uv", bool "lsb", bool "lsb_in", bool "lsb_out", int "mode", float "ampn", bool "slice"){
[...]
src
lsb ? (lsb_in ? Dither_lut16  (yexpr=ReplaceStr(e,".",","),expr="x 32768 - 32768 * 28672 / 32768 +",y=3, u=uv, v=uv)                 : \
                Dither_lut8   (yexpr=ReplaceStr(e,".",","),expr="x 128 - 32768 * 112 / 32768 +"    ,y=3, u=uv, v=uv))                : \
                avs26 ? mt_lut(yexpr=e,expr="x range_half - range_half * 112 scaleb / range_half +",y=3, u=uv, v=uv) : \
                        mt_lut(yexpr=e,expr="x 128 - 128 * 112 / 128 +"        ,y=3, u=uv, v=uv)

[...]
}

Originally Posted by real.finder

btw, will this make the systems that use dot has wrong outputs?

so, the final solution for this? rebuild dither.dll with vc15 ?

[pinterf]

Dunno, probably yes. Do those lines really improve anything or it is just kept and copied over many years? Could Zopti (Formerly Avisynth optimizer) help deciding it? No, I'm not volunteering for it . Still working on the "Layer" stuff.

[real.finder]

Originally Posted by pinterf

Dunno, probably yes. Do those lines really improve anything or it is just kept and copied over many years? Could Zopti (Formerly Avisynth optimizer) help deciding it? No, I'm not volunteering for it . Still working on the "Layer" stuff.

they doing good job in dark area

btw, don't tell me that masktools lut (and avs+ expr) has this problem too!

if it only the dither one did this update here fix the problem?

[pinterf]

No, as far as I know masktools is working properly. There have been problems with dither tools' decimal separator, which I'm not sure it it was fixed or not.

[real.finder]

Originally Posted by pinterf

No, as far as I know masktools is working properly. There have been problems with dither tools' decimal separator, which I'm not sure it it was fixed or not.

ok, can someone test? someone that has regional setting use comma for decimal separator

edit: simple test

ColorBars(pixel_type="yv12")
a=Mt_makediff(Dither_Luma_Rebuild(),coloryuv(levels="TV->PC"),u=3,v=3)
b=Mt_makediff(Dither_Luma_Rebuild(lsb=true),coloryuv(levels="TV->PC"),u=3,v=3)
StackVertical(a.Subtitle("luma rebuild vs avs tv to pc"),b.Subtitle("luma rebuild lsb vs avs tv to pc"),Mt_makediff(a,b,u=3,v=3).Subtitle("lsb vs 8bit"))

in case of avs tv to pc vs luma rebuild (whether with or without lsb) there are small difference here and there, so anyone test better post image of it

[ChaosKing]

How should one test it exactly? just call Dither_Luma_Rebuild() ?

[real.finder]

Originally Posted by ChaosKing

How should one test it exactly? just call Dither_Luma_Rebuild() ?

I know that someone will ask that, see my edit I just made above

[ChaosKing]

[real.finder]

Originally Posted by ChaosKing

https://i.imgur.com/bZfmVX9.jpg

it's same I got, my system use dot (Iraq)

btw, what avs you use and what dither.dll?

[ChaosKing]

Win10 x64 german which uses comma as decimal separator, avs+ 2772, 32bit dither.dll (CRC32: 20008b02) is from here http://ldesoras.free.fr/prod.html#src_ditheravsi

[real.finder]

Originally Posted by ChaosKing

Win10 x64 german which uses comma as decimal separator, avs+ 2772, 32bit dither.dll (CRC32: 20008b02) is from here http://ldesoras.free.fr/prod.html#src_ditheravsi

so that mean the problem already fixed? it was bug in win10 that fixed in later updates or what? let's see what pinterf and tormento said