BDSup2Sub - convert and tweak bitmap subtitle streams (VobSub,BD-SUP,BDN XML,HD-SUP)

[hubblec4]

Ok fine, I thought you ignore me :-)

[amichaelt]

Originally Posted by hubblec4

Ok fine, I thought you ignore me :-)

Nope. Also one of your issues was not an issue (running on Linux as it already can) and the other was one I had already been fixed and committed and will be in the future build (embedding the version info in the exe itself rather than relying on the file name). The other two I have put on my backlog of stuff to do.

[BizkitBoy]

Sorry if this has been posted/reported before, but I have searched the forum and didn't manage to find an answer.

I have an issue with BDSup2Sub++ 1.0.2
The Global Forced Flags setting isn't working properly when importing an XML file and then trying to export it as SUP.
Although the XML file does contain for each PNG the Forced flag which is set to either Forced="False" or Forced="True", when selecting in BDSup2Sub++ 1.0.2 the Force All flag to "keep" and exporting to SUP, it just marks as forced all the PNGs. Actually, this happens no matter what value you set in the Force All flag.

I noticed this happens only when importing XML files.

Has anyone found a fix or workaround?

[r0lZ]

Indeed, the ++ version has a bug. Just tried to convert an XML with the first subtitle forced and all others normal. In the GUI, the forced: yes or no information is correct, but when the stream is saved as a BD SUP, all subtitles are marked as forced. The Export Only Forced option works correctly.
The Java version of BDSup2Sub (v5.1.2) has not that bug.

[von Suppé]

I can confirm BDSup2Sub++'s behaviour as BizkitBoy told.
It even doesn't recognize the forced lines in it's own created XML-PNG (with forced flags).

Indeed the Java version works for this.
BTW, I always check the "Change frame rate" window and set both "FPS Source" - and "FPS Target" rates, even when no framerate change is needed.

amichaelt will be busy...

[amichaelt]

Originally Posted by BizkitBoy

Sorry if this has been posted/reported before, but I have searched the forum and didn't manage to find an answer.

I have an issue with BDSup2Sub++ 1.0.2
The Global Forced Flags setting isn't working properly when importing an XML file and then trying to export it as SUP.
Although the XML file does contain for each PNG the Forced flag which is set to either Forced="False" or Forced="True", when selecting in BDSup2Sub++ 1.0.2 the Force All flag to "keep" and exporting to SUP, it just marks as forced all the PNGs. Actually, this happens no matter what value you set in the Force All flag.

I noticed this happens only when importing XML files.

Has anyone found a fix or workaround?

The fix will be me debugging the code. Don't be sorry, I appreciate all these reports. Please keep them coming.

https://github.com/amichaeltm/BDSup2SubPlusPlus/issues

I finished up all the current cleanup stuff I want to do and I'll tag a 1.3 release later today and then start working on the next version in the coming days.

[hubblec4]

Originally Posted by von Suppé

BTW, I always check the "Change frame rate" window and set both "FPS Source" - and "FPS Target" rates, even when no framerate change is needed.

Yes I can confirm this and this little workaround is used in my cE.

[hubblec4]

Thanks for the new version. Why is the exe(x64 over 15mb) so big? Version 1.02 is smaller then 4mb.

[amichaelt]

Originally Posted by hubblec4

Thanks for the new version. Why is the exe(x64 over 15mb) so big? Version 1.02 is smaller then 4mb.

Forgot to run UPX on it. Will fix that and reupload.

Also, despite what I said earlier about Linux binaries since I got Travis-CI working I'm now working on getting it to output appimages for Linux. Will need other people to test though since I don't run Linux anymore and I'm not gonna make a bunch of distro-specific packages.

Edit to add: The uploaded files are now fixed.

[hubblec4]

Originally Posted by amichaelt

...
Also, despite what I said earlier about Linux binaries since I got Travis-CI working I'm now working on getting it to output appimages for Linux. Will need other people to test though since I don't run Linux anymore and I'm not gonna make a bunch of distro-specific packages.
...

Thats sounds great, I will use it for my cE on Linux. I can/will test some feaures. I use LinuxMint (and I will try the new Ubuntu).

[amichaelt]

Originally Posted by hubblec4

Thats sounds great, I will use it for my cE on Linux. I can/will test some feaures.

Thanks. I'll let you know when it's ready if you can be my first tester.

[amichaelt]

AppImage build finally worked and deployed. It can be grabbed here. Please let me know if it works or has any issues.

[von Suppé]

amichaelt, call me stupid, but where the heck can I find the latest for Windows?
I don't know what file I must download?

[r0lZ]

Originally Posted by von Suppé

BTW, I always check the "Change frame rate" window and set both "FPS Source" - and "FPS Target" rates, even when no framerate change is needed.

As far as I know, only the Java versions are affected by that bug. The ++ version sets correctly the FPS Target to the same frame rate as the FPS Source, and therefore there is no need to force the conversion of the frame rate to avoid the small timecode changes due to the alignment of the timecodes to the video frames.
IMO, there is nothing to fix here.

[von Suppé]

Originally Posted by r0lZ

As far as I know, only the Java versions are affected by that bug. The ++ version sets correctly the FPS Target to the same frame rate as the FPS Source, and therefore there is no need to force the conversion of the frame rate to avoid the small timecode changes due to the alignment of the timecodes to the video frames.
IMO, there is nothing to fix here.

I agree.
But as I am using both versions I sometimes forget or get confused what version has what bugs to take into account. So, to avoid problems I got myself used to always do this framerate setting. Thanks for the reminder r0lZ.

[r0lZ]

Originally Posted by von Suppé

amichaelt, call me stupid, but where the heck can I find the latest for Windows?
I don't know what file I must download?

Click the "4 releases" link just above the red line. You will be redirected here.

[jpsdr]

@amichaelt
Didn't you say you wanted to create a specific thread specific for the ++ version, discussion bugs, etc...

[hubblec4]

Originally Posted by amichaelt

AppImage build finally worked and deployed. It can be grabbed here. Please let me know if it works or has any issues.

My first quick tests works perfect. Many thanks.

EDIT:
Could you also the linux binary(exe) named BDSup2Sub++ only?

[amichaelt]

Yeah, I’ll fix the naming on the appimage when I push the next next version.

Also, I’ve been able to fix two of the more egregious bugs from r0lz fairly easily. The one where subtitle positions would get messed up was a lack of an absolute value being applied to the X and Y offsets after transparency cropping. The one with the borked up XML+PNG with empty PNGs was do to the coden iterating over a map of the composition objects incorrectly. I’m moving on now to the forced flags issues from hubble. Once I get those figured out I’ll push out a test build for people to beat on and start a new thread then.

[r0lZ]

Thanks. Very good news! I can't wait for the new version...