Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 25th January 2014, 20:36   #21  |  Link
SEt
Registered User
 
Join Date: Aug 2007
Posts: 374
Shift compensation in original nned3_rpow2 is wrong. I hope my transform in latest nnedi3x_rpow2 is correct – try it.
SEt is offline   Reply With Quote
Old 25th January 2014, 23:05   #22  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
I've kept original code, if something was incorect in it, it's still here. If you know what to fix, you can tell me. I think you're probably talking about the vshift and hshift value. If there is better values than actual ones, i'm all ears.

Last edited by jpsdr; 25th January 2014 at 23:08.
jpsdr is offline   Reply With Quote
Old 25th January 2014, 23:09   #23  |  Link
SEt
Registered User
 
Join Date: Aug 2007
Posts: 374
As I said, my version of shift compensation can be found in nnedi3x_rpow2. Feel free to check the changes.
SEt is offline   Reply With Quote
Old 26th January 2014, 08:45   #24  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
@SEt
Ok, i've tried, but i don't understand your code and how it's working, i'm unable to connect/relate it with the existing C code, so, i've no idea what the changes are...
Just a little question, out of curiosity. How have you been able to reduce the size of the weights trained datas to a so small value ? The datas are 12,9MB, and compression with zip, rar or 7zip is not very efficient, size stay at leat at 8MB, and your dll file is only 790kB. Where have you put the neural network weights trained datas ?
Unless... of course, i didn't get the right file. I've downloaded the nnedi3ocl_20131208.zip file.

Edit : I think i begin to understand a very little. If i understand properly, all this part is done in the .avsi file. It seems that you're working with Y/C planar separately, during all the process, even the resize if cshift is asked, contrary to original, where cshift is not made sperately for Y/C. I'll try to dig more and to understand more.

Last edited by jpsdr; 26th January 2014 at 09:59.
jpsdr is offline   Reply With Quote
Old 26th January 2014, 09:58   #25  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
@sqrt(9801)
Original code has a fixed shift, independant of rfactor, for RGB24. I've applied the same for YV24 and Y8.
But, maybe it's related to something else as you said changes are dependant of rfactor. I'll put a 0.9.4.7 later, i think i may have done a little thing improperly with YV24 and Y8. Well, indeed, i didn't realy know how to do, but you may have given me the answer. When avaible, try the new version and tell me if things changes. And, it's probably not related to the chroma shift.
jpsdr is offline   Reply With Quote
Old 26th January 2014, 23:01   #26  |  Link
sqrt(9801)
Registered User
 
Join Date: Jun 2013
Posts: 24
I just gave it a shot. The issue seems to have been resolved.

Nice job.
sqrt(9801) is offline   Reply With Quote
Old 27th January 2014, 08:28   #27  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
Good, otherwise, i would have no idea what to do...

Last edited by jpsdr; 27th January 2014 at 08:32.
jpsdr is offline   Reply With Quote
Old 28th January 2014, 08:50   #28  |  Link
lansing
Registered User
 
Join Date: Sep 2006
Posts: 1,151
what's with the intel compiled version? Is it faster compares to other if I have a intel cpu?
lansing is offline   Reply With Quote
Old 28th January 2014, 11:59   #29  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
As said in txt, it's compiled with Intel compiler, targeting a specific cpu. Intel compiler is theoricaly better, but i've not made benchmark, so i don't realy know if there is real improvement in this case.
jpsdr is offline   Reply With Quote
Old 2nd February 2014, 11:48   #30  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
I've made a little benchmark with v0.9.4.7, out of curiosity.
Input video : 720x480 YV12 Ut Video codec.
CPU : i7@980
OS :
- Windows XP SP3 for x86.
- Windows XP64 SP2 for x64.

Results :
Code:
[General info]
Log file created with:   AVSMeter 1.7.5 (AVS 2.6, x64)
Avisynth version:        AviSynth+ 0.1 (r1576, x64)


[Clip info]
Number of frames:                 4077
Length (hhh:mm:ss.ms):   000:02:50.045
Frame width:                       960
Frame height:                      720
Framerate:                      23.976 (24000/1001)
Interlaced:                         No
Colorspace:                       YV12


[Runtime info]
Frames processed:               4077 (0 - 4076)
FPS (min | max | average):      32.14 | 99.02 | 59.54
CPU usage (average):            50%
Thread count:                   38
Physical Memory usage (peak):   92 MB
Virtual Memory usage (peak):    93 MB
Time (elapsed):                 000:01:08.476


[Script]
SetMemoryMax(64)
AVISource("Ken - 101.avi",False,"YV12").SetPlanarLegacyAlignment(True)
nnedi3_rpow2(rfactor=2,cshift="Spline36Resize",fwidth=960,fheight=720,nsize=0,nns=3,qual=2)
Code:
[General info]
Log file created with:   AVSMeter 1.7.5 (AVS 2.6, x86)
Avisynth version:        AviSynth 2.60, build:Sep 18 2013 [17:36:36]


[Clip info]
Number of frames:                 4077
Length (hhh:mm:ss.ms):   000:02:50.045
Frame width:                       960
Frame height:                      720
Framerate:                      23.976 (24000/1001)
Interlaced:                         No
Colorspace:                       YV12


[Runtime info]
Frames processed:               4077 (0 - 4076)
FPS (min | max | average):      27.97 | 65.55 | 45.79
CPU usage (average):            40%
Thread count:                   37
Physical Memory usage (peak):   76 MB
Virtual Memory usage (peak):    79 MB
Time (elapsed):                 000:01:29.034


[Script]
SetMemoryMax(64)
AVISource("Ken - 101.avi",False,"YV12").SetPlanarLegacyAlignment(True)
nnedi3_rpow2(rfactor=2,cshift="Spline36Resize",fwidth=960,fheight=720,nsize=0,nns=3,qual=2)
jpsdr is offline   Reply With Quote
Old 2nd February 2014, 12:01   #31  |  Link
Groucho2004
►◄
 
Groucho2004's Avatar
 
Join Date: Mar 2006
Location: A wretched hive of scum and villainy
Posts: 4,418
Quote:
Originally Posted by jpsdr View Post
Code:
[Script]
SetMemoryMax(64)
Just curious - Why did you choose this value?
Groucho2004 is offline   Reply With Quote
Old 2nd February 2014, 12:03   #32  |  Link
TurboPascal7
Registered User
 
TurboPascal7's Avatar
 
Join Date: Jan 2010
Posts: 270
I'm not sure what you're benchmarking there. nnedi3_rpow2 uses some built-in functions internally that got faster in avs+. If you want to compare performance on x64 vs x86, you need to use same avisynth versions.
__________________
Me on GitHub | AviSynth+ - the (dead) future of AviSynth
TurboPascal7 is offline   Reply With Quote
Old 2nd February 2014, 15:39   #33  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
@Groucho2004
720x480 in YV12 => 1 frame = 506k.
64MB cache max => cache for around 128 frames.
I think it's big enough for what the script is doing.
(But, maybe i'm wrong).

@TurboPascal7
Ok.
jpsdr is offline   Reply With Quote
Old 7th June 2014, 03:09   #34  |  Link
Reel.Deel
Registered User
 
Join Date: Mar 2012
Location: Texas
Posts: 1,115
Hi jpsdr,

I was wondering if your updated nnedi3 contains -Vit-'s threading fixes? For QTGMC I use his modded plugins almost exclusively and have not had any problems so far. He also compiled some for Avisynth 2.6 but they're no longer compatible with Avisynth 2.6 Alpha4/5. Anyways I'm just curious, if this is no longer a relevant issue please excuse me.
Reel.Deel is offline   Reply With Quote
Old 7th June 2014, 10:28   #35  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
Unfortunately i've no idea. I didn't change the code of the threading part of nnedi3, fortunately for me there was no issue with x64, because for now, threading is still an unknow field for me... All i can say is to try.
When i decided to try to port, i was lucky there was just some asm internal functions to put external and addapt to x64 masm, because that was a field not unknow to me.
jpsdr is offline   Reply With Quote
Old 7th June 2014, 14:44   #36  |  Link
Reel.Deel
Registered User
 
Join Date: Mar 2012
Location: Texas
Posts: 1,115
I checked the difference between vanilla nnedi3 and -Vit-'s mod and the only thing that changed was the 'avisynth.h' and 'nnedi3.vcxproj' files.
For convenience I've uploaded the differences:

avisynth.h
vcxproj

I'm not a programmer so I don't know anymore than that. Maybe someone in the know can shed some light on this...
Reel.Deel is offline   Reply With Quote
Old 8th June 2014, 10:55   #37  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
Ok, i've take a quick look. My port use the new 2.6 API, so a total different avisynth.h, in a way...
I don't know for sure, but i think there is a good chance that the issue you're talking about is not here anymore.
jpsdr is offline   Reply With Quote
Old 8th June 2014, 14:04   #38  |  Link
Reel.Deel
Registered User
 
Join Date: Mar 2012
Location: Texas
Posts: 1,115
yeah, you're most likely right. -Vit- did mention this for his 2.6 modded plugins:
Quote:
Originally Posted by -Vit- View Post
The new interface removes some code that was embedded in every plugin that could cause multi-threading problems. So these plugins may be more stable.....
....these plugins are no longer "modded", they're just up to date...
In any case I've updated nnedi3 to your version and will let you know if I encounter any problems. Thanks for your input jpsdr.
Reel.Deel is offline   Reply With Quote
Old 14th March 2015, 12:13   #39  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,754
A very little update to 0.9.4.8.
jpsdr is offline   Reply With Quote
Old 27th April 2015, 02:50   #40  |  Link
stax76
Registered User
 
stax76's Avatar
 
Join Date: Jun 2002
Location: Germany
Posts: 5,797
It seems the 64-Bit version is working fine on Win7 but crashes on Win8/Win10.
stax76 is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 11:59.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.