Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > General > Audio encoding
Register FAQ Calendar Today's Posts Search

Reply
 
Thread Tools Search this Thread Display Modes
Old 25th January 2012, 20:05   #201  |  Link
amtm
Guest
 
Posts: n/a
Yeah, that's possible. I've updated the code online to provide that. I'll rebuild and repost the binary when I get home.
  Reply With Quote
Old 25th January 2012, 20:07   #202  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 7,277
Nice
__________________
Hybrid here in the forum, homepage
Selur is offline   Reply With Quote
Old 25th January 2012, 22:18   #203  |  Link
Sparktank
47.952fps@71.928Hz
 
Sparktank's Avatar
 
Join Date: Mar 2011
Posts: 940
Oooh, the first page is looking really nice with updates and info
__________________
Win10 (x64) build 19041
NVIDIA GeForce GTX 1060 3GB (GP106) 3071MB/GDDR5 | (r435_95-4)
NTSC | DVD: R1 | BD: A
AMD Ryzen 5 2600 @3.4GHz (6c/12th, I'm on AVX2 now!)
Sparktank is offline   Reply With Quote
Old 25th January 2012, 22:25   #204  |  Link
phate89
Registered User
 
Join Date: Apr 2009
Posts: 153
in the list of switches the -same is missing
phate89 is offline   Reply With Quote
Old 25th January 2012, 23:04   #205  |  Link
amtm
Guest
 
Posts: n/a
Quote:
Originally Posted by phate89 View Post
in the list of switches the -same is missing
Yeah it's always been missing and I meant to fix that in the readme. Will do that now.

Be home in about 90 minutes and I'll post the new binary. Assuming no regressions or new bugs it means I will start with the additional changes and new features.

Last edited by amtm; 25th January 2012 at 23:07.
  Reply With Quote
Old 26th January 2012, 01:51   #206  |  Link
amtm
Guest
 
Posts: n/a
Got home late. Here is the new version.
  Reply With Quote
Old 26th January 2012, 01:54   #207  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 7,277
https://github.com/downloads/athomas...ycut1.4.3.5.7z -> gives me a 404
__________________
Hybrid here in the forum, homepage
Selur is offline   Reply With Quote
Old 26th January 2012, 04:41   #208  |  Link
amtm
Guest
 
Posts: n/a
Really? Argh, github. Sorry about that, link should be fixed now.

Last edited by amtm; 26th January 2012 at 04:50.
  Reply With Quote
Old 26th January 2012, 08:44   #209  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 7,277
works now, thanks!

another thing that changed, before I called:
Code:
delaycut -fixcrc fix -o "D:\Encoding Temp\Test-AC3-5.1__aid_1__09_09_18_151_02.ac3" -i "D:\Encoding Temp\Test-AC3-5.1__aid_1__09_09_18_151_01.ac3"
and ended up with a file named: "D:\Encoding Temp\Test-AC3-5.1__aid_1__09_09_18_151_02_fixed.ac3"
now the output name is: "D:\Encoding Temp\Test-AC3-5.1__aid_1__09_09_18_151_02.ac3"
is this intended? (no problem if so, I even prefer this)

Cu Selur
__________________
Hybrid here in the forum, homepage

Last edited by Selur; 26th January 2012 at 09:38.
Selur is offline   Reply With Quote
Old 26th January 2012, 15:14   #210  |  Link
amtm
Guest
 
Posts: n/a
Yes, that is the way it is intended since that makes more sense to me. What you specify via -o is what the output file name is. Like before, though, if you don't specify -o it'll just do the appended _fixed to the end.
  Reply With Quote
Old 26th January 2012, 15:16   #211  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 7,277
Okay, thanks for the info.
__________________
Hybrid here in the forum, homepage
Selur is offline   Reply With Quote
Old 26th January 2012, 15:26   #212  |  Link
amtm
Guest
 
Posts: n/a
You're welcome. Let me know if you find any issues.
  Reply With Quote
Old 26th January 2012, 15:42   #213  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 7,277
Sure, but up-to-now everything I used seems to work like intended.
__________________
Hybrid here in the forum, homepage
Selur is offline   Reply With Quote
Old 26th January 2012, 16:01   #214  |  Link
amtm
Guest
 
Posts: n/a
Just to give some hints, along a few of the new features and some feature changes, I'm also looking into a few efficiency optimizations (though it is fairly fast as is). Things like not reading and writing a single frame at a time, which is a terrible way to do IO, and instead reading in a block of audio frames into memory before processing. Also trying out the QtConcurrent::map() function to see if any improvements come with processing those block of frames in parallel before writing back out so if you have a multi-core setup you should get some speed improvement. I'm not sure if this will provide a huge benefit unless you are processing rather large audio files but it's something I'm going to play around with since QtConcurrent looks like an interesting framework.
  Reply With Quote
Old 26th January 2012, 19:56   #215  |  Link
phate89
Registered User
 
Join Date: Apr 2009
Posts: 153
Quote:
Originally Posted by amtm View Post
Just to give some hints, along a few of the new features and some feature changes, I'm also looking into a few efficiency optimizations (though it is fairly fast as is). Things like not reading and writing a single frame at a time, which is a terrible way to do IO, and instead reading in a block of audio frames into memory before processing. Also trying out the QtConcurrent::map() function to see if any improvements come with processing those block of frames in parallel before writing back out so if you have a multi-core setup you should get some speed improvement. I'm not sure if this will provide a huge benefit unless you are processing rather large audio files but it's something I'm going to play around with since QtConcurrent looks like an interesting framework.
a short summary.. so you change or you already changed how the app handles delays, how handles cuts, how handles i/o, how handles gui, how some feature works...
Practically you're going to do an almost complete rewrite
phate89 is offline   Reply With Quote
Old 26th January 2012, 20:05   #216  |  Link
amtm
Guest
 
Posts: n/a
Well there will still be a lot of the original code left especially for the audio processing. Though with the cleanups and refactoring it will look a lot different and hopefully a lot clearer to follow as I will try to comment it more for areas that, at least for me, were confusing upon first looking at it. Also, I will replace a lot of the magic hex numbers littered throughout the code with constants to make those easier to figure what they are for.

BTW, I tagged the latest release so for anyone compiling from source will want to use that. There was a fix for building on non-Windows platforms that I slipped in as well for a bug that would cause a compile error.

Last edited by amtm; 26th January 2012 at 20:08.
  Reply With Quote
Old 26th January 2012, 20:30   #217  |  Link
phate89
Registered User
 
Join Date: Apr 2009
Posts: 153
Quote:
Originally Posted by amtm View Post
Well there will still be a lot of the original code left especially for the audio processing. Though with the cleanups and refactoring it will look a lot different and hopefully a lot clearer to follow as I will try to comment it more for areas that, at least for me, were confusing upon first looking at it. Also, I will replace a lot of the magic hex numbers littered throughout the code with constants to make those easier to figure what they are for.

BTW, I tagged the latest release so for anyone compiling from source will want to use that. There was a fix for building on non-Windows platforms that I slipped in as well for a bug that would cause a compile error.
Thanks for commenting it.. maybe when you will finish the reorganization i will look at it and try again to understand how it works
phate89 is offline   Reply With Quote
Old 27th January 2012, 06:18   #218  |  Link
amtm
Guest
 
Posts: n/a
For anyone who wants to play with it, here is a test version that supports using audio frames as input type. Valid values when specifying inputtype via CLI are now "milliseconds", "seconds", "audioframes" and "videoframes". There are also a few tweaks and bugfixes in this, too (for example end delay value wasn't being applied properly *doh*).

Last edited by amtm; 27th January 2012 at 15:41.
  Reply With Quote
Old 27th January 2012, 14:32   #219  |  Link
amtm
Guest
 
Posts: n/a
New test version here with some fixes.

Edit: Updated once more for a CLI fix for the audioframes input type to check startcut and endcut lengths.

Last edited by amtm; 27th January 2012 at 15:49.
  Reply With Quote
Old 27th January 2012, 19:42   #220  |  Link
phate89
Registered User
 
Join Date: Apr 2009
Posts: 153
i just tried the latests versions but they still have the old -start -end -startsplit -endsplit... the new switches doesn't work... btw when i use -info it crashes to me..
phate89 is offline   Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 02:47.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.