Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > New and alternative a/v containers

Reply
 
Thread Tools Search this Thread Display Modes
Old 12th January 2014, 17:46   #16801  |  Link
Kinjal
Light Alloy developer
 
Kinjal's Avatar
 
Join Date: Oct 2009
Location: Russia
Posts: 11
nevcairiel
I found the spot where Light Alloy failed to open files when LAV 0.60 is used.
Code:
				BeginEnumFilters(m_pGB, pEF, pBF);
				{
					if (CComQIPtr<IPropertyBag> pPB = pBF) {
						CComVariant var;
						m_logger->LOG_INFO(_T("IPropertyBag found, reading ROTATION data..."));
						if (SUCCEEDED(pPB->Read(CComBSTR(_T("ROTATION")), &var, NULL))) { <--- here.
If I comment this line, LAV works fine. Why it is fails - I didn't figured out yet... doesn't work for ones, but work fine for others. And no problem with LAV 0.59.
Kinjal is offline   Reply With Quote
Old 12th January 2014, 17:50   #16802  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,340
0.59 didn't have IPropertyBag yet.

I'm slightly confused by your code though.
http://msdn.microsoft.com/en-us/libr...(v=vs.85).aspx

The Read method takes a LPCOLESTR, which is a "const WCHAR*", and not a BSTR. This may cause the issues here.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders

Last edited by nevcairiel; 12th January 2014 at 17:55.
nevcairiel is offline   Reply With Quote
Old 12th January 2014, 17:57   #16803  |  Link
wanezhiling
Registered User
 
Join Date: Apr 2011
Posts: 1,184
http://i1.tietuku.com/raljyymxr.png
http://i1.tietuku.com/79qfjvdb3.png
Works fine with both
Hmmm... which change led to this issue.. I have no idea now..

Quote:
Originally Posted by nevcairiel View Post
By the way, still works in other players for you, doesn't it?
Yes, works in mpc-be/mpc-hc/potplayer etc.
wanezhiling is offline   Reply With Quote
Old 12th January 2014, 18:12   #16804  |  Link
zallen
Registered User
 
Join Date: Mar 2013
Posts: 9
0.60 appeared on off.page for download. LAV Splitter 0.60 does`t connect for Light Alloy 4.7.7 .
LAV Audio 0.60 connect but on Hi10P does`t working without LA int. audio switcher, nevertheless it worked in 59.1 .


Last edited by zallen; 12th January 2014 at 18:22.
zallen is offline   Reply With Quote
Old 12th January 2014, 18:14   #16805  |  Link
Kinjal
Light Alloy developer
 
Kinjal's Avatar
 
Join Date: Oct 2009
Location: Russia
Posts: 11
nevcairiel
>The Read method takes a LPCOLESTR, which is a "const WCHAR*", and not a BSTR. This may cause the issues here.
Nope. Problem was laying in other spot...
CComVariable var; => CComVariable var(""); -- and issue has been fixed. At least for me.
Kinjal is offline   Reply With Quote
Old 12th January 2014, 18:16   #16806  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,340
Weird. Oh well. As long as it works, i guess!
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 12th January 2014, 18:40   #16807  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,340
Quote:
Originally Posted by wanezhiling View Post
http://i1.tietuku.com/raljyymxr.png
http://i1.tietuku.com/79qfjvdb3.png
Works fine with both
Hmmm... which change led to this issue.. I have no idea now..
Can you try this version?
http://files.1f0.de/tmp/LAVSplitter-cc752b5.zip

I added some safety checks to try to fix it on my end for unfixed versions of LightAlloy as well.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 12th January 2014, 18:49   #16808  |  Link
wanezhiling
Registered User
 
Join Date: Apr 2011
Posts: 1,184
Quote:
Originally Posted by nevcairiel View Post
Can you try this version?
http://files.1f0.de/tmp/LAVSplitter-cc752b5.zip

I added some safety checks to try to fix it on my end for unfixed versions of LightAlloy as well.
Works now!

http://i1.tietuku.com/qsqr5ak1p.png
wanezhiling is offline   Reply With Quote
Old 12th January 2014, 19:39   #16809  |  Link
zallen
Registered User
 
Join Date: Mar 2013
Posts: 9
nevcairiel rebuild lav splitter and Vortex at the same time rebuild Light Alloy. Now works lav filters first version.


Last edited by zallen; 12th January 2014 at 19:42.
zallen is offline   Reply With Quote
Old 12th January 2014, 19:48   #16810  |  Link
PetitDragon
Registered User
 
Join Date: Sep 2006
Posts: 81
Nine Muse "works" for me too.
PetitDragon is offline   Reply With Quote
Old 12th January 2014, 19:49   #16811  |  Link
DragonQ
Registered User
 
Join Date: Mar 2007
Posts: 934
Quote:
Originally Posted by nevcairiel View Post
If you can give me a sample file where this is rather obvious, i could have a look why its happening, and possibly fix it.
Here's a sample. At the edit boundary (00:08) you can see the frame freeze and then the channel logo and graphics at the top half of the screen flash on and off for a bit before going back to normal when using LAV Splitter/Video/Audio in MPC-HC. The effect seems a bit different depending on whether I'm using EVR-CP or MadVR but it's there with both.

When playing the file in MediaPortal (using MediaPortal's TSReader & LAV Video/Audio), the edit is clean.

EDIT: Using DXVA2 Native by the way but I don't think it matters.
__________________
TV Setup: LG OLED55B7V; Onkyo TX-NR515; ODroid N2+; CoreElec 9.2.7

Last edited by DragonQ; 12th January 2014 at 20:05.
DragonQ is offline   Reply With Quote
Old 12th January 2014, 20:25   #16812  |  Link
zallen
Registered User
 
Join Date: Mar 2013
Posts: 9
Quote:
Originally Posted by nevcairiel View Post
LAV Splitter updated without problems clings to LA 4.7.7 RC

Last edited by zallen; 12th January 2014 at 20:29.
zallen is offline   Reply With Quote
Old 12th January 2014, 20:39   #16813  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,340
Quote:
Originally Posted by DragonQ View Post
Here's a sample. At the edit boundary (00:08) you can see the frame freeze and then the channel logo and graphics at the top half of the screen flash on and off for a bit before going back to normal when using LAV Splitter/Video/Audio in MPC-HC.
I can tell you why this happens (because there is no IDR frame to seperate the two scenes, so they get mixed up), but i can't fix it, because you muxed it into a MKV. TS files get a bit of special handling, where it might be able to detect it. MKVs, not so much.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 12th January 2014, 20:47   #16814  |  Link
DragonQ
Registered User
 
Join Date: Mar 2007
Posts: 934
Quote:
Originally Posted by nevcairiel View Post
I can tell you why this happens (because there is no IDR frame to seperate the two scenes, so they get mixed up), but i can't fix it, because you muxed it into a MKV. TS files get a bit of special handling, where it might be able to detect it. MKVs, not so much.
I remux most recordings to MKV mainly to save space, except for when it causes problems (A/V synch being out or duration being wrong being the two most common ones).

It must be possible to fix because it works using other software, but are you saying that there's no way to fix it in LAV because of how it's coded? MediaPortal is open source; perhaps it's possible to figure out how that handles it and why it works? Could it be something to do with the player rather than splitter/codecs?
__________________
TV Setup: LG OLED55B7V; Onkyo TX-NR515; ODroid N2+; CoreElec 9.2.7

Last edited by DragonQ; 12th January 2014 at 20:51.
DragonQ is offline   Reply With Quote
Old 12th January 2014, 21:25   #16815  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,340
You said their TS reader makes it work, a TS reader can read MKV files?

TS files have a bit more information specific to broadcast, which is quite possibly lost when remuxing.
The MKV is read 1:1 as it was encoded, so if it doesn't play properly, its obviously muxed wrong. MKVs don't carry any metadata to signal if there was a stream break, while TS files may.

So no, I can't fix it if its in a MKV.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders

Last edited by nevcairiel; 12th January 2014 at 21:30.
nevcairiel is offline   Reply With Quote
Old 12th January 2014, 21:55   #16816  |  Link
DragonQ
Registered User
 
Join Date: Mar 2007
Posts: 934
Quote:
Originally Posted by nevcairiel View Post
You said their TS reader makes it work, a TS reader can read MKV files?

TS files have a bit more information specific to broadcast, which is quite possibly lost when remuxing.
The MKV is read 1:1 as it was encoded, so if it doesn't play properly, its obviously muxed wrong. MKVs don't carry any metadata to signal if there was a stream break, while TS files may.

So no, I can't fix it if its in a MKV.
The "MediaPortal File Reader" uses a file called TSReader.ax, so I assumed it just read all files in MediaPortal. After doing some digging it looks like it's actually using LAV Splitter...in which case, LAV Splitter does seem to handle the edit fine in that application. Perhaps it's just MPC-HC that handles it incorrectly?
__________________
TV Setup: LG OLED55B7V; Onkyo TX-NR515; ODroid N2+; CoreElec 9.2.7
DragonQ is offline   Reply With Quote
Old 12th January 2014, 22:01   #16817  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,340
If i use EVR-CP in MPC-HC, I also don't really see the effect. It freezes briefly, but if you don't know that its there, you wouldn't notice.
With normal EVR, you see the flashing effect.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 12th January 2014, 22:41   #16818  |  Link
DragonQ
Registered User
 
Join Date: Mar 2007
Posts: 934
Quote:
Originally Posted by nevcairiel View Post
If i use EVR-CP in MPC-HC, I also don't really see the effect. It freezes briefly, but if you don't know that its there, you wouldn't notice.
With normal EVR, you see the flashing effect.
Agreed but this happens to be a sample where barely anything changes in the video when the cut happens. The effect can be majorly obvious with other material.

Would you agree that the problem is worst with MadVR?
__________________
TV Setup: LG OLED55B7V; Onkyo TX-NR515; ODroid N2+; CoreElec 9.2.7
DragonQ is offline   Reply With Quote
Old 13th January 2014, 02:27   #16819  |  Link
romulous
Registered User
 
Join Date: Oct 2012
Posts: 179
Hi Nev,

Thanks for the new version.

Quote:
Originally Posted by nevcairiel View Post
LAV Filters 0.60
Code:
- Additional metadata from the source file is exported through IPropertyBag (including "ROTATION" for video orientation information)
Does this mean that the video will be decoded in the correct orientation, or is support still required in the renderer (ie we're still waiting on madshi)?

Thanks!
romulous is offline   Reply With Quote
Old 13th January 2014, 08:45   #16820  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,340
All it does is allow the player to read the metadata, anything else is up to the player.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Reply

Tags
decoders, directshow, filters, splitter

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 09:48.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.