Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
|
|
Thread Tools | Search this Thread | Display Modes |
3rd January 2019, 10:40 | #4663 | Link |
Suptitle, MediaPlayer.NET
Join Date: Nov 2001
Posts: 1,721
|
Any idea where that information comes from? We can decide how to pass that info to the scripts once we know where to get it from.
The thing with interfaces is they must be defined at compile time. I was thinking of something that would allow us to grab all info regardless of how useful they are and dump them into a dictionary. It's the scripts that will decide how useful the info is. |
3rd January 2019, 11:00 | #4665 | Link |
Registered User
Join Date: Dec 2013
Posts: 753
|
No I meant something similar to:
Code:
IHDRParameters hdr_params = video.info as IHDRParameters; Code:
IHDRParameters hdr_params = video.requestInfo<IHDRParameters>(); Sure the interfaces need to be known at compile time, but that's no different from needing to know the parameter names that the information would otherwise be in. I might be overcomplicating things though, it's just that this would prevent a lot of guesswork when reading the parameters. |
3rd January 2019, 11:42 | #4666 | Link |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,348
|
From here:
https://github.com/Nevcairiel/LAVFil...ediaSideData.h Note that if you provide a custom allocator (which renderers typically do), you'll need to make sure the IMediaSamples it allocates actually implement the IMediaSideData interface.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders |
5th January 2019, 09:08 | #4668 | Link |
Suptitle, MediaPlayer.NET
Join Date: Nov 2001
Posts: 1,721
|
Nev, do we need to copy and cache pData in STDMETHOD(SetSideData)(GUID guidType, const BYTE *pData, size_t size) PURE;
or can we simply hold the pointer and size to pData and expect pData to be valid throughout the lifetime of the IMediaSample? |
5th January 2019, 10:59 | #4669 | Link |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,348
|
You need to copy and save it. The caller of SetSideData has no clue about the ultimate lifetime of the object, since its reference counted.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders |
10th January 2019, 08:41 | #4671 | Link |
Suptitle, MediaPlayer.NET
Join Date: Nov 2001
Posts: 1,721
|
We can't seem to get assfiltermod to call ISubRenderConsumer.Connect. Xysubfilter on the other hand has no problems doing so.
Nevermind. Found the problem after reading the source code of assfiltermod - it's expecting the consumer to implement ISubRenderConsumer2. IMHO it should be checking for ISubRenderConsumer interface, not ISubRenderConsumer2. Last edited by Zachs; 10th January 2019 at 12:33. |
11th January 2019, 14:32 | #4672 | Link |
Registered User
Join Date: Oct 2012
Posts: 7,926
|
interesting it just worked out of the box with madVR. madshi didn't even know this renderer was a thing.
that'S the spec if i'm not mistaken: http://madshi.net/SubRenderIntf.h |
12th January 2019, 04:26 | #4673 | Link |
Suptitle, MediaPlayer.NET
Join Date: Nov 2001
Posts: 1,721
|
The documentation isn't ambiguous but it was misinterpreted by assfiltermod's author.
MPDN didn't need the Clear method so did not implement the ISubRenderConsumer2 interface. Assfiltermod however only looks for that interface, when the Connect method actually belongs to the ISubRenderConsumer interface. Last edited by Zachs; 12th January 2019 at 04:29. |
28th January 2019, 12:04 | #4674 | Link |
Registered User
Join Date: Dec 2018
Posts: 58
|
This is by far the greatest player I ever tested. Never got MPC-HC or BE to work properly with madVR.
MPDN has all the usefull settings already integrated and works very stable. The playback is the best possible in my setup. The only thing I'm missing is a way to play my DVD's. Is there an addon somewhere which makes VIDEO_TS folder playback including menus etc possible ? I archived my whole music DVD collection in the regular dvd format (VTS/VOB files) and most of those shows will most likely never see a Blu-ray release. thanks in adavnce for your help regards |
28th January 2019, 20:13 | #4675 | Link |
Registered User
Join Date: Dec 2013
Posts: 753
|
Not sure if the VTS files will work since DVD menus are not supported (and will probably remain unsupported for the near future). I'm pretty sure that the LAV filters should be able to handle the VOB files though, so those should work.
|
30th January 2019, 04:27 | #4676 | Link |
Capture, Deinterlace
Join Date: Feb 2002
Location: Right there
Posts: 1,971
|
Would you mind pointing out some MPDN extensions which are used in mpv (and the mpv code which uses things from MPDN)? I'm somewhat familiar with mpv code, and I don't recall anything which came from MPDN...
|
30th January 2019, 04:45 | #4677 | Link |
Registered User
Join Date: Oct 2012
Posts: 7,926
|
here you go: https://gist.github.com/igv
these are the easy ones even i can find. |
30th January 2019, 09:35 | #4678 | Link | |
Capture, Deinterlace
Join Date: Feb 2002
Location: Right there
Posts: 1,971
|
Quote:
It's like I'll write some JS code which can run in Firefox and then advertise/claim that Firefox is using my code... |
|
30th January 2019, 12:02 | #4680 | Link |
Capture, Deinterlace
Join Date: Feb 2002
Location: Right there
Posts: 1,971
|
Surely not with the official windows distribution at https://mpv.srsfckn.biz/ .
If you or some other third party wants to distribute an mpv build with a collection of shaders from MPDN, you can do that, but it cannot be considered part of mpv itself... |
Tags |
direct3d, mpdn, nnedi3, opencl, reclock |
|
|