Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
|
|
Thread Tools | Search this Thread | Display Modes |
7th September 2008, 21:54 | #981 | Link |
Registered User
Join Date: Jul 2007
Posts: 552
|
kemuri-_9
Try to make 2pass encoding of small sample (500 frames is enough) with --threads 128 (128 because more threads more visible is quality degradation of few frames after 30-frame) without and with this patch. Probably than you will see the difference at frames 31 and few others. |
7th September 2008, 22:40 | #982 | Link |
Compiling Encoder
Join Date: Jan 2007
Posts: 1,348
|
and why would i realistically do that insane number of threads besides seeing at how many resources are being wasted by threads that can't be executed on my processors (being held in wait state)?
and not to mention all the processing time overhead from the thread swapping since the scheduler will probably swap them frequently with that large of a number of them. Last edited by kemuri-_9; 7th September 2008 at 22:47. |
7th September 2008, 23:47 | #983 | Link |
Registered User
Join Date: Jan 2004
Posts: 849
|
You are right, kemuri, most of us can't use that many threads. Still, I do know people who run their encodes on Sun's servers (when they are idling at their workplace), which do run 128 threads per box, so they would care about that.
__________________
Geforce GTX 260 Windows 7, 64bit, Core i7 MPC-HC, Foobar2000 |
8th September 2008, 01:07 | #985 | Link | |
Registered User
Join Date: Jul 2007
Posts: 552
|
Quote:
It is simply fix the crash (division by zero) when width or height of the source is 32 (17-32) when you encode with B-frames (and don't use --no-b-adapt). |
|
8th September 2008, 01:32 | #986 | Link |
Registered User
Join Date: Feb 2007
Location: ::1
Posts: 1,236
|
Thanks.
But this is very annoying... the patches are a mess of dependencies. Still trying to get it working, but jeez. EDIT: Alright, I admit defeat. Every damn patch wants to bring in its friends, or it'll whine at me. komisar, if you read this, please help give me a way to test/use... I only want: x264_dll_alignment_fix.01.diff (no problem with your patches) 999.log_param.diff x264_progress.indication_r957.diff x264_32x32samples_crash.r870.diff x264_multithreading_Nth_pass_ratecontrol.r870.diff (maybe) bm_x264_thread_pool.r870.diff (maybe) x264_hrd_pulldown.09_interlace.diff x264_psy_rdo_0.6_r956.diff x264_new_bframe_decision_04.7.diff However, there are tons of dependencies... I really don't want to use the VAQ2mod, or fix_stats_file_work, or your version of the new b-frame decision patch... Thanks Last edited by Ranguvar; 8th September 2008 at 01:45. |
8th September 2008, 04:25 | #987 | Link |
Compiling Encoder
Join Date: Jan 2007
Posts: 1,348
|
some of these, like the 32x32sample and Npass ratecontrol patches,
are fixes and I think the developers should look into implementing them into the repository. (granted they work as intended still) the logfile patch would be a feature they could add in if they whimmed it. |
8th September 2008, 11:04 | #991 | Link | |
Registered User
Join Date: Aug 2008
Location: Minsk, Belarus
Posts: 235
|
My used patches:
Quote:
x264_psy_rdo_0.6_r956.diff x264_new_bframe_decision_04.7.diff x264_hrd_pulldown.09_interlace.diff Some as posted in this thread. I only make this compatible with my patched build. P.S. I add prefix "k.XX...." because this patches (in original) not clear apply and I make them more compatible. Or I make this patch by myself. P.P.S. Original version of some patches "by MasterNobody/BugMaster" found here: [x264-devel] BugMaster's patches (fix various problems) And mirror of MasterNobody/BugMaster patches (next message) found here: http://komisar.gin.by/x.patch/BugMaster/20080908/ Last edited by komisar; 8th September 2008 at 14:04. |
|
8th September 2008, 12:25 | #992 | Link |
Registered User
Join Date: Jul 2007
Posts: 552
|
Here are updated versions of my patches (which I use to build x264vfw): http://stashbox.org/208351/bm_x264_p...ction.r965.zip
In this archive you will find independent versions of some patches (for example, x264_thread_pool.r965.diff) List of patches in collection: Code:
01_x264_32x32samples_crash.r965.diff 01_x264_cosmetic.r965.diff 01_x264_debug_defines.r965.diff 01_x264_fix_stats_file_work.r965.diff 01_x264_multithreading_bug_check.r965.diff 01_x264_multithreading_Nth_pass_ratecontrol.r965.diff 02_bm_x264_error_memoryleaks.02.r965.diff 03_bm_x264_thread_pool.r965.diff 04_bm_x264_vaqmod.01.r965.diff 05_bm_x264_psy_rdo_0.6.r965.diff 06_bm_x264_new_bframes_decision.04.7.r965.diff Independent\ x264_32x32samples_crash.r965.diff x264_cosmetic.r965.diff x264_debug_defines.r965.diff x264_error_memoryleaks.02.r965.diff x264_fix_stats_file_work.r965.diff x264_multithreading_bug_check.r965.diff x264_multithreading_Nth_pass_ratecontrol.r965.diff x264_thread_pool.r965.diff x264_vaqmod.01.r965.diff |
8th September 2008, 16:11 | #994 | Link |
Registered User
Join Date: Feb 2007
Location: ::1
Posts: 1,236
|
Thanks very much, BugMaster - that may be what I'm looking for. I'll test ASAP.
Will all your updated patches be here always? http://komisar.gin.by/x.patch/BugMaster/ Last edited by Ranguvar; 8th September 2008 at 16:14. |
8th September 2008, 17:02 | #995 | Link |
Linux Encoder
Join Date: Feb 2004
Posts: 78
|
I am compiling/encoding on a 64-bit Ubuntu quad-core machine.
Using x264_new_bframe_decision_04.7.diff causes the following error: libx264.c: In function 'X264_init': libx264.c: 165: error: X264_param_t has no member named 'b_bframe_adaptive' (after compiling x264 and then when compiling mplayer to use x264 with mencoder) Have I done something wrong? |
8th September 2008, 17:47 | #996 | Link |
Registered User
Join Date: Dec 2006
Posts: 32
|
I just wanted to let you know that there is an updated version of the progress indication patch here.
The difference is only that the code is now enclosed in #ifdef _WIN32 so that it can compile on other OS. I guess you have to fix this updated version the same way you've done with the previous version as well. |
8th September 2008, 17:54 | #997 | Link |
Mr. Sandman
Join Date: Sep 2003
Location: Haddonfield, IL
Posts: 11,768
|
it's useless for him since he's on ubuntu
__________________
MPEG-4 ASP Custom Matrices: EQM V1(old), EQM AutoGK Sharpmatrix (aka EQM V2), EQM V3HR (updated 01/10/2004), EQM V3LR, EQM V3ULR (updated 04/02/2005), EQM V3UHR (updated 17/12/2004) and EQM V3EHR (updated 05/10/2004) Info about my ASP matrices. MPEG-4 AVC Custom Matrices: EQM AVC-HR Info about my AVC matrices My x264 builds. Mooo!!! |
8th September 2008, 18:07 | #999 | Link |
Mr. Sandman
Join Date: Sep 2003
Location: Haddonfield, IL
Posts: 11,768
|
was the patching successfull?
__________________
MPEG-4 ASP Custom Matrices: EQM V1(old), EQM AutoGK Sharpmatrix (aka EQM V2), EQM V3HR (updated 01/10/2004), EQM V3LR, EQM V3ULR (updated 04/02/2005), EQM V3UHR (updated 17/12/2004) and EQM V3EHR (updated 05/10/2004) Info about my ASP matrices. MPEG-4 AVC Custom Matrices: EQM AVC-HR Info about my AVC matrices My x264 builds. Mooo!!! |
Tags |
h.264, x264, x264 builds, x264 patches, x264 unofficial builds |
|
|