Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
8th March 2011, 08:10 | #13181 | Link |
Registered Developer
Join Date: Sep 2006
Posts: 9,140
|
FWIW, I've tried yesterday to get a patch committed to ffmpeg to enable optional float output to the AC3 and E-AC3 decoders. So far I've not succeeded. However, as a reaction Michael Niedermayer actually suggested to change all native float decoders to always output float instead of int16 *right now*. Unfortunately he's not the leader, anymore, and some other guys seem to prefer to wait (for a sample conversion framework to be implemented/completed) before implementing such a change. Not sure yet how it will play out. But it looks like everyone agrees that ultimately ffmpeg native float decoders (ac3, e-ac3, dts, aac, vorbis, wma, ...) should output float. It's only a matter of time when this gets implemented. If we have good luck, it can happen today. If we have bad luck, the change can be delayed another few months (or years). Anyway, I've tried.
@STaRGaZeR, I don't really understand what problem you have now. The patch clsid implemented seems to work well, it has no theoretical or practical disavantages. It does improve audio quality. Maybe the improvement is not audible to your ears on your hardware but that doesn't mean nobody can hear a difference. Your ear/hardware alone can not be the judge for the rest of the world. Furthermore the patch does what ffmpeg will do in the (hopefully near) future, anyway. And implementing the patch in ffdshow has *ZERO* effect on ffmpeg/libav. Just because ffdshow implemented such a patch does not mean that the "real" fix in ffmpeg/libav will be delayed even one second. So there is no damage done by implementing the patch in ffdshow now. (Thanks to Reimar for his constructive way of posting in the ffmpeg-devel mailing list.) |
8th March 2011, 11:42 | #13182 | Link |
4:2:0 hater
Join Date: Apr 2008
Posts: 1,302
|
If ffmpeg outputting float is so inmediate, there should have been no commits to ffdshow. If this is in no way inmediate as almost everything in ffmpeg, putting even more custom stuff/patches/workarounds (call it what you want) in ffdshow that it already has is the number one thing you should not do.
The quality argument wasn't to justify float vs integer, get it already ffs. |
8th March 2011, 12:38 | #13183 | Link |
Registered User
Join Date: Nov 2006
Posts: 799
|
Instead of reducing the number of /* ffdshow custom code */ comments in the code, we have now added half a dozen of these "things"... IMO the goal should be to stay as close as possible to ffmpeg. If they think that 16-bit int is a reasonable trade-off between quality and performance, then I don't see why we should deviate from that position. Most certainly not to please a vocal minority...
|
8th March 2011, 13:05 | #13184 | Link | |
Registered Developer
Join Date: Sep 2006
Posts: 9,140
|
Quote:
If you browse through the last few pages you'll find that STaRGaZeR and you seem to be the vocal minority. Ok, I'm out of this discussion now. |
|
8th March 2011, 13:46 | #13185 | Link | |
Moderator
Join Date: Nov 2001
Location: Netherlands
Posts: 6,364
|
Quote:
|
|
8th March 2011, 14:15 | #13187 | Link |
German doom9/Gleitz SuMo
Join Date: Oct 2001
Location: Germany, rural Altmark
Posts: 6,784
|
Do you remember why BeSweet was developed? Besides joining decoder and encoder DLLs, processing the audio in floating-point format for optimal quality was one of those reasons. This is all just a little bit of history repeating... |
8th March 2011, 14:23 | #13188 | Link | |
Moderator
Join Date: Nov 2001
Location: Netherlands
Posts: 6,364
|
Quote:
|
|
8th March 2011, 15:27 | #13189 | Link | |
*****
Join Date: Feb 2005
Posts: 5,647
|
Quote:
__________________
MPC-HC 2.2.1 |
|
8th March 2011, 19:35 | #13190 | Link | |
4:2:0 hater
Join Date: Apr 2008
Posts: 1,302
|
Quote:
Have fun managing that custom code. I'm outta this ffdshow comedy. |
|
8th March 2011, 19:43 | #13191 | Link |
Registered User
Join Date: Apr 2008
Posts: 1,106
|
Hi guys, when using ffdshow video decoder with mpc-hc, when I right click on the player and choose "Filters" -> "ffdshow Video Decoder" -> I see audio information rather than video information. ie i'm watching a h264 mkv file atm and ffdshow video decoder submenu is showing me ac3 audio information... Is it something thats known about or easy to fix?
|
8th March 2011, 19:52 | #13192 | Link | |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,348
|
Quote:
__________________
LAV Filters - open source ffmpeg based media splitter and decoders |
|
9th March 2011, 16:39 | #13194 | Link | |
*****
Join Date: Feb 2005
Posts: 5,647
|
Quote:
It could be a bug in the code that determines what should be shown in that context menu. Its shared code between audio/video decoder. If it was intentional, I don't remember what the exact rationale was for it. Maybe albain can explain if he is still around.
__________________
MPC-HC 2.2.1 |
|
9th March 2011, 17:47 | #13196 | Link |
*****
Join Date: Feb 2005
Posts: 5,647
|
That is true. But I wasn't talking about showing video info there, but hiding the audio info (and show it only in the audio decoder).
__________________
MPC-HC 2.2.1 |
9th March 2011, 22:17 | #13198 | Link |
*****
Join Date: Feb 2005
Posts: 5,647
|
The FLV4 issue is not a decoding bug. The video was padded to make it mod16 and needs to be cropped. ffdshow will automatically crop based on info signaled by the splitter, but only if the video render is not Overlay Mixer, which does not support it properly.
__________________
MPC-HC 2.2.1 |
9th March 2011, 22:32 | #13199 | Link |
Registered User
Join Date: Feb 2004
Posts: 399
|
Thanks for checking it. I tested with VMR9 and EVR, the issue is there with both renderers, meaning ffdshow doesn't crop properly then?
Or is it a splitter bug? The On2 flv4 directshow decoder is free of this bug but I'd really rather use ffdshow for everything. ^^;
__________________
XP SP3 / Geforce 8500 / Zoom Player |
9th March 2011, 23:31 | #13200 | Link |
*****
Join Date: Feb 2005
Posts: 5,647
|
It indeed doesn't work. If I remember correctly it used to work, so you could try some old builds to see where things got broken.
__________________
MPC-HC 2.2.1 |
Tags |
ffdshow, ffdshow tryouts, ffdshow-mt, ffplay, icl |
|
|