Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 28th November 2024, 13:41   #61  |  Link
WaxCyl
Registered User
 
Join Date: Mar 2016
Posts: 21
It works! Thanks pinterf, greatly appreciated.
Edit: I have no found no other issues, I like what it does for the chroma as well.

Last edited by WaxCyl; 28th November 2024 at 13:44.
WaxCyl is offline   Reply With Quote
Old 28th November 2024, 16:46   #62  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,885
Quote:
Originally Posted by pinterf View Post
Challenge accepted. Try this one and report back.
Great! Will test ASAP.
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 28th November 2024, 17:58   #63  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,418
Uploaded to Github as well. Code cleanup and further build enhancements: not now.

https://github.com/pinterf/amDCT
pinterf is offline   Reply With Quote
Old 28th November 2024, 18:30   #64  |  Link
poisondeathray
Registered User
 
Join Date: Sep 2007
Posts: 5,607
Thanks for the early x-mas gift pinterf, nice to see you around !
poisondeathray is offline   Reply With Quote
Old 28th November 2024, 23:53   #65  |  Link
anton_foy
Registered User
 
Join Date: Dec 2005
Location: Sweden
Posts: 721
Quote:
Originally Posted by pinterf View Post
Uploaded to Github as well. Code cleanup and further build enhancements: not now.

https://github.com/pinterf/amDCT
Awesome thanks!
anton_foy is offline   Reply With Quote
Old 29th November 2024, 13:45   #66  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,885
Quote:
Originally Posted by pinterf View Post
Uploaded to Github as well. Code cleanup and further build enhancements: not now.
Would you please consider to switch/add Intel Compiler builds? The Community edition is completely free.

I find them faster, both on Intel and AMD.
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 29th November 2024, 14:04   #67  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,418
Quote:
Originally Posted by tormento View Post
Would you please consider to switch/add Intel Compiler builds? The Community edition is completely free.

I find them faster, both on Intel and AMD.
Nth priority, but yes. I usually make abandoned sources to be compilable with gcc/clang/intel and support C-only non-Intel use cases.
pinterf is offline   Reply With Quote
Old 3rd December 2024, 16:43   #68  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,885
Quote:
Originally Posted by pinterf View Post
(20241127) v1.4.1
Would be of much effort to expand to hbd and rgb?

I am testing it in 8 bits but it hasn't the precision I would like to.

I have a small issue:

SetMemoryMax()
SetCacheMode(0)
SetFilterMTMode("DEFAULT_MT_MODE", 2)
LoadPlugin("D:\Eseguibili\Media\DGDecNV\DGDecodeNV.dll")
DGSource("M:\In\Monster ~BDGE\1-1-01.dgi",ct=0,cb=0,cl=240,cr=240)
z_ConvertFormat(resample_filter="spline64", pixel_type="yuv420p16")
Resize8(720,540, kernel="z_Spline36Resize", noring=true, noring_c=true, fullc=true)
z_ConvertFormat(resample_filter="spline64",dither_type="error_diffusion",pixel_type="YUV420P16")
fmtc_bitdepth (bits=8,dmode=8)
amDCT(adapt=31,shift=5,quality=4,quant=9,matrix=8,expand=16,sharpWpos=6,sharpTpos=7,sharpWAmt=24,sharpTAmt=31,brightStart=205,brightAmt=30)
Prefetch(2,6)


Where I get:

amDCT: out of memory
__________________
@turment on Telegram

Last edited by tormento; 3rd December 2024 at 16:48.
tormento is offline   Reply With Quote
Old 10th December 2024, 13:01   #69  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,418
Quote:
Originally Posted by tormento View Post
Would be of much effort to expand to hbd and rgb?

I am testing it in 8 bits but it hasn't the precision I would like to.

I have a small issue:

SetMemoryMax()
SetCacheMode(0)
SetFilterMTMode("DEFAULT_MT_MODE", 2)
LoadPlugin("D:\Eseguibili\Media\DGDecNV\DGDecodeNV.dll")
DGSource("M:\In\Monster ~BDGE\1-1-01.dgi",ct=0,cb=0,cl=240,cr=240)
z_ConvertFormat(resample_filter="spline64", pixel_type="yuv420p16")
Resize8(720,540, kernel="z_Spline36Resize", noring=true, noring_c=true, fullc=true)
z_ConvertFormat(resample_filter="spline64",dither_type="error_diffusion",pixel_type="YUV420P16")
fmtc_bitdepth (bits=8,dmode=8)
amDCT(adapt=31,shift=5,quality=4,quant=9,matrix=8,expand=16,sharpWpos=6,sharpTpos=7,sharpWAmt=24,sharpTAmt=31,brightStart=205,brightAmt=30)
Prefetch(2,6)


Where I get:

amDCT: out of memory
As responded on your github issue: the "out of memory" was a false error. your clip must have mod8 dimensions: width and height must be multiple of 8.

On the other hand, doesn't amDCT have to be the first filter in the chain, to be able to catch the original 8x8 blocks before any resize and other operation? Or you are not using this feature of the plugins where this counts?
pinterf is offline   Reply With Quote
Old 10th December 2024, 13:03   #70  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,418
New release 1.4.2.
https://github.com/pinterf/amDCT/releases

This changeset was a hard and long process, mainly involving assembler rewrites and tests. And the many small items. It took about another 30-35 hours of work, so I'm just taking a rest now before the further cleanups.

Code:
## Changelog
- (20241210) v1.4.2
  - Rewrite all external assembly codes (fdct, idct, h263 and mpeg quant-dequants) to Intel intrinsics.
    It's now quicker - sometimes significantly - than the original.
  - Source: changed Windows specific threading code into C 17 version.
  - Source cleanup: removed lots of never used test codes from the source, rewrite some others. Move to cpp.
  - Add ability to pass Avisynth+ frame properties
  - Add support for any 8 bit planar YUV(A) or Y format (was: YV12 only)
  - Copy A alpha plane as well, if exists. (The filter works only on luma channel, other planes are simply copied)
  - Fix: add meaningful error message (Issue #2) for clips with non-mod8 width or height dimensions (was: out of memory)
  - Add Clang-cl LLVM build option, make source Clang friendly
  - Speedup examples:
  
| qtype | 32 bit clangcl | 32 bit msvc | 32 bit old 1.3 | 64 bit clangcl |
|-------|----------------|-------------|----------------|----------------|
| 1     | 6.12 fps       | 5.49 fps    | 5.40 fps       | 6.56 fps       |
| 2     | 6.67 fps       | 5.93 fps    | 5.28 fps       | 7.08 fps       |
| 3     | 4.09 fps       | 3.61 fps    | 3.22 fps       | 4.29 fps       |
| 4     | 6.66 fps       | 5.98 fps    | 5.29 fps       | 7.16 fps       |

Last edited by pinterf; 10th December 2024 at 13:20.
pinterf is offline   Reply With Quote
Old 10th December 2024, 19:26   #71  |  Link
WaxCyl
Registered User
 
Join Date: Mar 2016
Posts: 21
Thank you Pinterf. I can't thank
you enough!
WaxCyl is offline   Reply With Quote
Old 11th December 2024, 14:52   #72  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 7,571
Vapoursynth support would be cool.
__________________
Hybrid here in the forum, homepage, its own forum
Selur is offline   Reply With Quote
Old 26th January 2025, 19:25   #73  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 3,190
i7 6700 4c/8th on Windows XP Professional x86

source: 1920x1080 FULL HD yv12 8bit planar BT709 SDR

Tortmento's settings:
amDCT(adapt=31,shift=5,quality=4,quant=9,matrix=8,expand=16,sharpWpos=6,sharpTpos=7,sharpWAmt=24,sharpTAmt=31,brightStart=205,brightAmt=30)

old version: 0.7fps
new version: 1.0fps


Looks like 1.4.2 rocks.
Thank you for supporting Windows XP with the "x86_from_2019" builds by the way.
It may only have up to SSE4.2 but it definitely feels it.

Last edited by FranceBB; 26th January 2025 at 19:32.
FranceBB is offline   Reply With Quote
Old 27th January 2025, 11:04   #74  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,418
Quote:
Originally Posted by FranceBB View Post
Thank you for supporting Windows XP with the "x86_from_2019" builds by the way.
It may only have up to SSE4.2 but it definitely feels it.
Doesn't v1.4.2 work on XP out of box?
pinterf is offline   Reply With Quote
Old 27th January 2025, 11:49   #75  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,885
I think that a nice speed bump could come from a ICC build, that proved to be fine both on Intel and AMD cpus.
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 27th January 2025, 12:32   #76  |  Link
Jamaika
Registered User
 
Join Date: Jul 2015
Posts: 848
amDCT(adapt=31,shift=5,quality=4,quant=9,matrix=8,expand=16,sharpWpos=6,sharpTpos=7,sharpWAmt=24,sharpTAmt=31,brightStart=205,brightAmt=30)
What am I doing wrong?
Assertion failed: IsClip(), file interface.cpp, line 827

Last edited by Jamaika; 27th January 2025 at 21:15.
Jamaika is offline   Reply With Quote
Old 28th January 2025, 19:48   #77  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 3,190
Quote:
Originally Posted by pinterf View Post
Doesn't v1.4.2 work on XP out of box?
nope, x86_from_2019 works just fine, however x86_msvc fails to load as it's missing the following kernel functions:

ReleaseSRWLockExclusive
ReleaseSRWLockShared
AcquireSRWLockExclusive
AcquireSRWLockShared
GetThreadId




here's the x86_from_2019 build instead which shows everything as green and indeed loads just fine:

FranceBB is offline   Reply With Quote
Old 29th January 2025, 08:44   #78  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,418
Quote:
Originally Posted by FranceBB View Post
nope, x86_from_2019 works just fine, however x86_msvc fails to load as it's missing the following kernel functions:

ReleaseSRWLockExclusive
ReleaseSRWLockShared
AcquireSRWLockExclusive
AcquireSRWLockShared
GetThreadId

here's the x86_from_2019 build instead which shows everything as green and indeed loads just fine:
Ahh, yes, there is threading code in this plugin. I could have thought of that. I'm gonna add xp build.

EDIT:
Reuploded to github: package updated with WinXP builds. Let's hope the best.

Last edited by pinterf; 29th January 2025 at 10:08. Reason: updated release pack
pinterf is offline   Reply With Quote
Old 29th January 2025, 17:57   #79  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 3,190
Works like a charm!
FranceBB is offline   Reply With Quote
Old 4th February 2025, 12:08   #80  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,611
in case pinterf didn't receive github notifications https://github.com/pinterf/amDCT/issues/3
__________________
See My Avisynth Stuff
real.finder is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 04:57.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2025, vBulletin Solutions Inc.