Deathray - OpenCL GPU accelerated spatial/temporal non-local means de-noising

[Jawed]

I could make a 64-bit version, but I don't know what you could use it for, since Deathray only works with Avisynth and that's 32-bit only. Isn't it?

How would you use a 64-bit version?

Avisynth+ has had 64-bit builds for a while now.

[Jawed]

Does Deathray work with Avisynth+ ?

[Groucho2004]

Originally Posted by Jawed

Does Deathray work with Avisynth+ ?

Sure, no problem.

Originally Posted by Jawed

Does Deathray work with Avisynth+ ?

Wouldn't see why not. One of the main selling points is plugin compatibility.

[Magik Mark]

I guess there's only one way to find out

Is it possible to have a template similar to light, medium, and strong as a starting point?


Sent from my iPhone using Tapatalk

[Jawed]

I believe that I would have to create a new version of Deathray to be able to support 64-bit Avisynth+, because I would be linking against Avisynth+'s 64-bit lib. Instead of Avisynth's 32-bit lib.

These are two completely different pieces of software.

I have no idea how much work that involves.

[Jawed]

Originally Posted by Magik Mark

I guess there's only one way to find out

Is it possible to have a template similar to light, medium, and strong as a starting point?

Start here:

deathray(hy=0.3, huv=0.3, ty=0, tuv=0, s=1, x=1, l=false, c=false, z=true, b=true) # light

If you don't have colour noise, set huv=0.

Set hy as low as 0.1 or as high as you like. Similar for huv.

Set ty to 3 or 5 if you want to try temporal denoising (lots of frames). Set tuv similarly if you have colour noise:

deathray(hy=0.5, huv=0.5, ty=3, tuv=3, s=1, x=1, l=false, c=false, z=true, b=true) # medium

Try x=2 (don't use higher) for another way to increase strength:

deathray(hy=1, huv=1, ty=5, tuv=5, s=1, x=2, l=false, c=false, z=true, b=true) # heavy

I don't think there's any reason to go beyond 5 for ty and tuv.

I prefer MDegrain3.

By far my favourite is Deathray2 making a calm clip for MDegrain3 with a very light post-denoise by Deathray. That combination is on a whole other level.

[ultim]

Originally Posted by Jawed

I believe that I would have to create a new version of Deathray to be able to support 64-bit Avisynth+, because I would be linking against Avisynth+'s 64-bit lib. Instead of Avisynth's 32-bit lib.

These are two completely different pieces of software.

I have no idea how much work that involves.

The headers are the same for both x32 and x64, and a plugin never needs to link with the Avisynth .lib at all. So the extra effort is as small as just compiling with the x64 toolchain (doing an extra build) without any code changes, assuming that your own code is x64-compatible.

[Jawed]

Originally Posted by ultim

The headers are the same for both x32 and x64, and a plugin never needs to link with the Avisynth .lib at all. So the extra effort is as small as just compiling with the x64 toolchain (doing an extra build) without any code changes, assuming that your own code is x64-compatible.

Thanks, you're right I had a look and the external libs include OpenCL and AMD APP, but not Avisynth.

I will have a quick play...

[Jawed]

My avisynth.h has the following line 347:

void* operator new(unsigned size);

And when I try to compile for 64-bit I get the error message:

error C2821: first formal parameter to 'operator new' must be 'size_t'

So, I've changed it to:

void* operator new(size_t size);

Which compiles. I have no idea if that's broken it (I'm assuming that the 64-bit avisynth uses the same fix...)

Now, anyone who'd like to experiment, go here:

https://github.com/JawedAshraf/Death...4-experimental

and right-click the Deathray.dll file and save the target file.

So if you're feeling brave, see what happens when you use this experimental 64-bit release. I don't know how to test it...

(I have written other non-Avisynth 64-bit DLLs that work fine (using OpenCL), so I'm pretty hopeful about this.)

[Groucho2004]

You should use the latest AVS+ header from here.

[Jawed]

OK, tomorrow night, nearly my bedtime.

[Magik Mark]

Thanks for the preset. It makes our testing a lot easier. By the way,. How will you classify video grain? Luminance noise? Will the light setting be able to take care of this?


Sent from my iPhone using Tapatalk

[Jawed]

Originally Posted by Magik Mark

Thanks for the preset. It makes our testing a lot easier. By the way,. How will you classify video grain? Luminance noise? Will the light setting be able to take care of this?

I made an error in the heavy preset:

deathray(hy=1, huv=3, ty=5, tuv=5, s=1, x=2, l=false, c=false, z=true, b=true) # heavy

huv should be set to 1. I've corrected that.

There is no classification of video grain or luminance noise.

I'm afraid these "presets" are literally just starting points.

Also, bear in mind that apart from a very light preset and as a pre-processor, I don't use Deathray. I certainly wouldn't use it as the sole de-noiser. Except for a quick and dirty de-noise.

[Jawed]

Originally Posted by Groucho2004

You should use the latest AVS+ header from here.

Thanks.

As I expected, there was quite a bit more effort involved than simply using the new header. The commits show the gory detail.

So, I've updated the DLL. See post 111 for instructions on getting this DLL. I haven't tested it.

Have fun!

[Groucho2004]

Originally Posted by Jawed

As I expected, there was quite a bit more effort involved than simply using the new header. The commits show the gory detail

Looking at the commits, it's pretty much the usual things required for updating AVS2.5 filters to the AVS2.6 interface.

Thanks for the update, I'll give it a whirl soon.

[spiralout]

Anybody get the 64bit Deathray working?