Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 30th June 2009, 17:08   #41  |  Link
SEt
Registered User
 
Join Date: Aug 2007
Posts: 374
Rebuilt version 2009.06.19 with new header to correct threading problems.
SEt is offline   Reply With Quote
Old 3rd July 2009, 23:27   #42  |  Link
MyCometG3
Registered User
 
Join Date: May 2008
Posts: 35
SEt
Thank you for your effort.
I have ported this plug-in to GCC. Impemented into my CoreVF framework, under MacOS X env. It runs well. Great!

One thing, Warp() function seems to check CPU is SSSE3 ready every line inside asm, is this required?
I have split SSSE3 loop and SSE2 loop, seems to run well. It could be faster.

(I am not sure, but original code does not run well under CoreDuo - no SSSE3 support; Of course not original, but gas rewritten code though. Splitting loops works well both on Core2Duo and CoreDuo)
MyCometG3 is offline   Reply With Quote
Old 4th July 2009, 03:41   #43  |  Link
SEt
Registered User
 
Join Date: Aug 2007
Posts: 374
There should be no problem with that conditional jump - any modern cpu should be able to always correctly predict it so it will consume no time at all. And even mispredicted once per line is very small cost. What you are observing might be cache related - it has far more serious impact on performance. But of course it's only a theory.
SEt is offline   Reply With Quote
Old 15th July 2009, 23:45   #44  |  Link
Monamona
Registered User
 
Join Date: Aug 2002
Posts: 34
Is there any chance that the filter will be modified to work under YUY2?
Monamona is offline   Reply With Quote
Old 16th July 2009, 07:07   #45  |  Link
lych_necross
ZZZzzzz...
 
lych_necross's Avatar
 
Join Date: Jan 2007
Location: USA
Posts: 302
I like the rewritten aWarpSharp. Now, if only Toon.dll would get updated to support the new version...
lych_necross is offline   Reply With Quote
Old 18th July 2009, 16:47   #46  |  Link
SEt
Registered User
 
Join Date: Aug 2007
Posts: 374
I'm not going to add YUY2 support, but probably will add YV16.
SEt is offline   Reply With Quote
Old 20th July 2009, 22:28   #47  |  Link
Lynx Pardinus
Registered User
 
Join Date: Dec 2008
Posts: 16
You mean YV16, wich won't be supported until Avisynth 2.60, or the planar YUY2 supported by MVTools, masktools and many others ?
Lynx Pardinus is offline   Reply With Quote
Old 21st July 2009, 02:57   #48  |  Link
SEt
Registered User
 
Join Date: Aug 2007
Posts: 374
YV16 of Avisynth 2.60+.
SEt is offline   Reply With Quote
Old 21st July 2009, 07:09   #49  |  Link
lych_necross
ZZZzzzz...
 
lych_necross's Avatar
 
Join Date: Jan 2007
Location: USA
Posts: 302
Supporting yv16 instead of yuy2 is odd, but okay. I waited 1+ years for for 2.58, whats another couple of years
lych_necross is offline   Reply With Quote
Old 21st July 2009, 20:13   #50  |  Link
thewebchat
Advanced Blogging
 
Join Date: May 2009
Posts: 483
Mapping of parameters to original aws

In the awarpsharp.txt file included with your filter, you mention that the mapping between "thresh" in aWarpSharp2 and aWarpSharp is "aWarpSharp2 value * 256" but the aWarpSharp documentation says that thresh goes from 0.0 to 1.0. How does this work?

Edit: Oh, sorry, read the equation the wrong away around. Sorry about that. Someone can delete this post.

Edit2: I am getting an access violation (reading from 0x0 at 0xfaa1415) when setting blur to "1". The documentation says that values from 0 to 100 are supported.

Edit3: Oh wait, that's just a mod16 error.

Last edited by thewebchat; 21st July 2009 at 20:59.
thewebchat is offline   Reply With Quote
Old 26th July 2009, 14:52   #51  |  Link
Soulhunter
Bored...
 
Soulhunter's Avatar
 
Join Date: Apr 2003
Location: Unknown
Posts: 2,812
I thought green border artifact bug was fixed years ago... >.>
__________________

Visit my IRC channel
Soulhunter is offline   Reply With Quote
Old 26th July 2009, 21:55   #52  |  Link
SEt
Registered User
 
Join Date: Aug 2007
Posts: 374
As requested, i've updated Toon to use aWarpSharp2 instead of aWarpSharp. As i don't see the sources - made it by patching the dll, so no optimizations or bugfixes in this v1.1.

lych_necross, YUY2 is very inconvenient format for vectorized processing (MMX/SSE) while YV16 has no such problems and adding its support to YV12 code is almost trivial.
SEt is offline   Reply With Quote
Old 27th July 2009, 07:16   #53  |  Link
lych_necross
ZZZzzzz...
 
lych_necross's Avatar
 
Join Date: Jan 2007
Location: USA
Posts: 302
Oh, I didn't know that. Thats cool as I usually use YV12 anyways.
P.S. SWEET!!! new toon.dll!! I think Soulhunter originally posted toon.dll, so he would probably have the sources.

Last edited by lych_necross; 27th July 2009 at 07:22. Reason: added ps
lych_necross is offline   Reply With Quote
Old 27th July 2009, 18:24   #54  |  Link
Adub
Fighting spam with a fish
 
Adub's Avatar
 
Join Date: Sep 2005
Posts: 2,685
Soulhunter didn't make Toon, he just posted it on behalf of the author, who I'm pretty sure is mf.
__________________
FAQs:Bond's AVC/H.264 FAQ
Site:Adubvideo
Adub is offline   Reply With Quote
Old 28th July 2009, 14:39   #55  |  Link
Soulhunter
Bored...
 
Soulhunter's Avatar
 
Join Date: Apr 2003
Location: Unknown
Posts: 2,812
Quote:
Originally Posted by Adub View Post
Soulhunter didn't make Toon, he just posted it on behalf of the author, who I'm pretty sure is mf.
...who was banned here some time ago
...so he cant post here anymore
...so I do it for him

But, the aWarpSharp version in his dumpster (2nd Google result when searching for aWarpSharp.dll) should already contain the fixed version I mentioned in my last post... So, is there really a reason to update Toon.dll besides the minimal (the old aWarpSharp already runs way above realtime, doesn't it?) speed gain?
__________________

Visit my IRC channel
Soulhunter is offline   Reply With Quote
Old 29th July 2009, 04:14   #56  |  Link
SEt
Registered User
 
Join Date: Aug 2007
Posts: 374
I don't see any fixed version of aWarpSharp.dll. I prefer to have one WarpSharp filter for everything and it's always better to be faster.
SEt is offline   Reply With Quote
Old 30th April 2010, 20:09   #57  |  Link
Great Dragon
Registered User
 
Great Dragon's Avatar
 
Join Date: Feb 2005
Location: Ukraine, Lviv
Posts: 121
Hi guys.
I have VD crash with this script:
Code:
s=AVISource("h:\dt_314.avi")
a1=trim(s,0,13566).crop(10,0,-6,0)
a2=trim(s,13567,22584).crop(6,0,-10,0)
a3=trim(s,22585,32818).crop(8,0,-8,0)
a1++a2++a3
mergechroma(awarpsharp2(blur=16,thresh=128, type=1))
and if I put mergechroma code right after input clip like this:
Code:
a1=AVISource("h:\dt_314.avi").mergechroma(awarpsharp2(blur=16,thresh=128, type=1)).trim(0,13566).crop(10,0,-6,0)
a2=AVISource("h:\dt_314.avi").mergechroma(awarpsharp2(blur=16,thresh=128, type=1)).trim(13567,22584).crop(6,0,-10,0)
a3=AVISource("h:\dt_314.avi").mergechroma(awarpsharp2(blur=16,thresh=128, type=1)).trim(22585,32818).crop(8,0,-8,0)
a1++a2++a3
I have an error: "Invalid arguments to function "awarpsharp2".

In same with simple usage like this:
Code:
AVISource("h:\dt_314.avi")
mergechroma(awarpsharp2(blur=16,thresh=128, type=1))
filter works like a charm.

Last edited by Great Dragon; 30th April 2010 at 20:12.
Great Dragon is offline   Reply With Quote
Old 30th April 2010, 20:33   #58  |  Link
Gavino
Avisynth language lover
 
Join Date: Dec 2007
Location: Spain
Posts: 3,380
Quote:
Originally Posted by Great Dragon View Post
if I put mergechroma code right after input clip like this:
Code:
a1=AVISource("h:\dt_314.avi").mergechroma(awarpsharp2(blur=16,thresh=128, type=1)).trim(0,13566).crop(10,0,-6,0)
...
I have an error: "Invalid arguments to function "awarpsharp2".
That's because the input clip for the call to awarpsharp2() is not explicitly provided, and 'last' is not defined at that point in the script.
You need to do it like this:
Code:
AVISource("h:\dt_314.avi") 
mergechroma(awarpsharp2(blur=16,thresh=128, type=1))
a1=trim(0,13566).crop(10,0,-6,0)
a2=trim(13567,22584).crop(6,0,-10,0)
a3=trim(22585,32818).crop(8,0,-8,0)
a1++a2++a3
Don't know why VD should crash with your original script though.
Gavino is offline   Reply With Quote
Old 30th April 2010, 20:43   #59  |  Link
Keiyakusha
契約者
 
Keiyakusha's Avatar
 
Join Date: Jun 2008
Posts: 1,567
This script crashes for me even without aWarpsharp2.

Quote:
s=AVISource("something.avi")
a1=trim(s,0,13566).crop(10,0,-6,0)
a2=trim(s,13567,22584).crop(6,0,-10,0)
a3=trim(s,22585,32818).crop(8,0,-8,0)
a1++a2++a3
Access Violation in Decoder ffdshow (libavcodec or xvid) for divx 720p video. When awarpsharp2 is present, Access Violation is reported for awarpsharp2

EDIT: oops, quoted wrong script. now is fine.

Last edited by Keiyakusha; 30th April 2010 at 20:46.
Keiyakusha is offline   Reply With Quote
Old 1st May 2010, 21:34   #60  |  Link
Great Dragon
Registered User
 
Great Dragon's Avatar
 
Join Date: Feb 2005
Location: Ukraine, Lviv
Posts: 121
Gavino, Thanks man. I still need to learn avisynth language a lot.
Great Dragon is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 10:17.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.