Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
12th November 2009, 23:24 | #10441 | Link |
*****
Join Date: Feb 2005
Posts: 5,643
|
What about line 2288 in RTS.cpp?
__________________
MPC-HC 2.1.7.2 |
12th November 2009, 23:42 | #10442 | Link |
Advanced Blogging
Join Date: May 2009
Posts: 480
|
@gngn: The problem is that the subtitle code in MPC-HC is totally failed. The option to have "pre-buffered" subtitles with animations enabled was added, but in fact, this does nothing but waste lots of CPU cycles (more than without this "pre-buffering"). The reason checking "disable animations" fixes this is because it forces the old (functional) code path which isn't totally failed. There is a bug on the tracker about this.
Edit: Also, the subtitle rendering code lets you use animated subtitles in SRT and other simple formats, simply because it parses everything as ASS, so there are in fact no "always static" formats as far as the renderer is concerned. Last edited by thewebchat; 12th November 2009 at 23:44. |
13th November 2009, 04:23 | #10444 | Link | |
Registered User
Join Date: Dec 2006
Posts: 523
|
Quote:
|
|
13th November 2009, 07:00 | #10445 | Link |
Registered User
Join Date: Feb 2006
Posts: 293
|
Well, I have an opposite opinion on subtitle renderer. While it's not as good as I want it to be, it is the only way to get animated subtitle going smoothly with desktop resolution texture size. It maybe use more CPU cycle, sure, but it's far more than "doing nothing". Since there is a way to disable it, I don't really see a problem with it.
__________________
Spec: Intel Core i5-3570K, 8g ram, Intel HD4000, Samsung U28D590 4k monitor+1080p Projector, Windows 10. |
13th November 2009, 08:08 | #10447 | Link | |||
MPC-HC Project Manager
Join Date: Mar 2007
Posts: 2,317
|
That might help, but like thewebchat says, according to the people who really understand the subtitle renderer it does indeed have 2 unique codepaths, one that never animates and one that always animates.
Quote:
Quote:
See if the users can still reproduce if all hdd power saving options are disabled. Quote:
__________________
MPC-HC, an open source project everyone can improve. Want to help? Test Nightly Builds, submit patches or bugs and chat on IRC Last edited by tetsuo55; 13th November 2009 at 08:12. |
|||
13th November 2009, 10:48 | #10448 | Link | ||
Registered User
Join Date: Feb 2006
Posts: 293
|
Quote:
Quote:
However, anything below 1920x1080 texture size is smooth, and it is the only way to get it smooth with animation on. I didn't test it throughly but with zero-buffer size + disable animation, it's more of a problem with the hdd can't keep up more than the rendering can't keep up. In fact, not only I get skipping with animated subtitle, but with regular static subtitle too. I should've test this with SSD and see if anything is different. Anyway, this was the reason why I jumped to Beliyaal build quite sometime before his patch was merged to main SVN. I defend it here because I want the developers to keep it.
__________________
Spec: Intel Core i5-3570K, 8g ram, Intel HD4000, Samsung U28D590 4k monitor+1080p Projector, Windows 10. |
||
13th November 2009, 11:02 | #10449 | Link |
MPC-HC Project Manager
Join Date: Mar 2007
Posts: 2,317
|
In any case its clear that we desperately need someone to join mpc-hc and work on the subtitle renderer.
__________________
MPC-HC, an open source project everyone can improve. Want to help? Test Nightly Builds, submit patches or bugs and chat on IRC |
13th November 2009, 11:08 | #10450 | Link |
Registered User
Join Date: Apr 2007
Posts: 220
|
Hi,
the 1312 code from beliyaal uses a different method for locking directx access in the vsync code. This causes problems for some people, myself included as the timing of the vsync code is affected (especially if one uses shaders and resizing). For the time being i stick with 1311. This has nothing to do with subtitles. I already got some screenshots and info to beliyaal - i hope this is getting resolved. I would advise using 1311 for the time being, if you have problems with stuttering and/or tearing with newer versions. regards, Casshern |
13th November 2009, 14:47 | #10451 | Link |
Registered User
Join Date: Sep 2004
Posts: 32
|
Since the new suggestion link does not work, I have to post here.
The free container OGV includes Theora video, Vorbis audio and Kate subtitle. Is there any plan to support this format, especially Kate subtitle. mpc-hc with haali can decode theora video and vorbis audio, but it can not render Kate subtitle. Right now the only software player which supports Kate subtitle is VLC (1.0.3 version). |
13th November 2009, 19:12 | #10454 | Link | |
_
Join Date: May 2008
Location: France
Posts: 692
|
Quote:
Is subtitle renderer another renderer or it just works thanks to renderer job ? In fact, you mean MPC-HC needs someone to create subtitle support for EVR renderer, no ? |
|
13th November 2009, 19:35 | #10455 | Link |
*****
Join Date: Feb 2005
Posts: 5,643
|
The video renderer only does the last step in the whole process: adding a subtitle image on top of the video.
The conversion from text to an image, using the right font, size and color, is done by the subtitle renderer. And that is just the 'easy' stuff. There is animation, positioning, line breaking, and other complex stuff to take care of as well. But all that code is already in place. The problem is that it is inefficient and often does unnecessary calculations.
__________________
MPC-HC 2.1.7.2 |
13th November 2009, 20:07 | #10456 | Link |
MPC-HC Project Manager
Join Date: Mar 2007
Posts: 2,317
|
Yes clsid is right
On top of that there are some behavioural differences between internal/external renderer and some missing features here in there. Mostly its the performance that needs some help
__________________
MPC-HC, an open source project everyone can improve. Want to help? Test Nightly Builds, submit patches or bugs and chat on IRC |
14th November 2009, 09:34 | #10457 | Link |
戦場ヶ原蕩れ
Join Date: Aug 2009
Location: Tokyo
Posts: 3
|
I'm sorry. The corruption turned out to be x264 bug. Now it's fixed.
Hi I tried weightp, the new feature of x264, but MPC-HC can't decode the encoded video correctly with DXVA. ffdshow decodes the video correctly. ffdshow PNG DXVA PNG My environment * Windows XP SP3 * MPC-HC r1335 * Renderer is VMR9 Renderless * Radeon HD 4670 + Catalyst 9.10 the encoded video and the source the encoded video only Last edited by boiled_sugar; 16th November 2009 at 02:48. |
14th November 2009, 09:47 | #10458 | Link |
Registered User
Join Date: Dec 2007
Posts: 215
|
boiled_sugar: Your sample actually works fine here. Both the internal H.264 DXVA decoder and Windows 7's built-in H.264 DXVA decoder show the video fine.
EVR-CP. Windows 7. Haali Media Splitter OR Windows 7's built-in mp4 splitter. Geforce 8800GT (ForceWare 190.62). |
14th November 2009, 11:00 | #10460 | Link |
MPC-HC Project Manager
Join Date: Mar 2007
Posts: 2,317
|
i tested several samples succesfully but boiled_sugar's breaks for me too when the cat scene begins
i used 1337 on win7 x64
__________________
MPC-HC, an open source project everyone can improve. Want to help? Test Nightly Builds, submit patches or bugs and chat on IRC Last edited by tetsuo55; 14th November 2009 at 11:06. |
Tags |
dxva, h264, home cinema, media player classic, mpc-hc |
Thread Tools | Search this Thread |
Display Modes | |
|
|