Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > (HD) DVD, Blu-ray & (S)VCD > One click suites for DVD backup and DVD creation

Reply
 
Thread Tools Search this Thread Display Modes
Old 30th May 2018, 16:20   #3101  |  Link
Groucho2004
 
Join Date: Mar 2006
Posts: 3,717
Quote:
Originally Posted by thescrapyard View Post
Attached is the file I'm trying to add back in as either AVstoDVD internal or as an added subs file. Either way the subs fail and are displayed as nothing but "?????????" on the video
Approval of the attachment could take a while, why don't you upload it somewhere else?
Groucho2004 is offline   Reply With Quote
Old 31st May 2018, 13:10   #3102  |  Link
MrC
AVStoDVD Dev
 
MrC's Avatar
 
Join Date: Apr 2006
Location: Italy
Posts: 1,271
@thescrapyard

I guess the issue is related to the fact that SubtitlesCreator, the app used to convert from SRT to SUP, accepts only ANSI formatted text. If the input SRT file is formatted in UTF format (and your file should be like that), than A2D converts the content to ANSI. During conversion many special chars are lost, very likely cyrillic chars are lost as well.

BTW to be sure of that guess, let's wait for the russian subs file.



Bye
__________________
MrC

AVStoDVD Homepage
AVStoDVD @ Doom9 Forum
MrC is offline   Reply With Quote
Old 31st May 2018, 13:57   #3103  |  Link
Groucho2004
 
Join Date: Mar 2006
Posts: 3,717
Quote:
Originally Posted by MrC View Post
I guess the issue is related to the fact that SubtitlesCreator, the app used to convert from SRT to SUP, accepts only ANSI formatted text.
A program that deals with subtitles and doesn't support UTF-8 is ridiculous.
Isn't there another free program that can do that?
Groucho2004 is offline   Reply With Quote
Old 3rd June 2018, 17:23   #3104  |  Link
MrC
AVStoDVD Dev
 
MrC's Avatar
 
Join Date: Apr 2006
Location: Italy
Posts: 1,271
A fresh 2.8.8 release hotfix is available to download. It should address (very likely all) the issues manolito has kindly and with expertise highlighted about NTSC to PAL conversions.

There's also an implementation of FFmpeg stderr capture within VB code. No more need to go thru an external text file.



Bye
__________________
MrC

AVStoDVD Homepage
AVStoDVD @ Doom9 Forum
MrC is offline   Reply With Quote
Old 4th June 2018, 03:58   #3105  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,163
Quote:
Originally Posted by MrC View Post
It should address (very likely all) the issues manolito has kindly and with expertise highlighted about NTSC to PAL conversions.
Yes, this build does handle ALL the issues about NTSC to PAL conversions when importing OGM chapter files. Beautiful, this must have been a lot of work...

Quote:
Originally Posted by MrC View Post
There's also an implementation of FFmpeg stderr capture within VB code. No more need to go thru an external text file.
This feature does not work (yet) when my FF_Mod hack is active. I get an error window telling me
Runtime error 5, Invalid procedure call or invalid argument

Please note that this is not an FFmpeg error, it is an AVStoDVD error message. Running the hacked FFmpeg version with the command line issued by AVStoDVD causes no problems.


Cheers
manolito

Last edited by manolito; 4th June 2018 at 22:29.
manolito is offline   Reply With Quote
Old 5th June 2018, 13:39   #3106  |  Link
MrC
AVStoDVD Dev
 
MrC's Avatar
 
Join Date: Apr 2006
Location: Italy
Posts: 1,271
Quote:
Originally Posted by manolito View Post
This feature does not work (yet) when my FF_Mod hack is active. I get an error window telling me
Runtime error 5, Invalid procedure call or invalid argument

Please note that this is not an FFmpeg error, it is an AVStoDVD error message. Running the hacked FFmpeg version with the command line issued by AVStoDVD causes no problems.
The new VB routine to grab stderr output tries to grab the ffmpeg.exe.mod (renamed to ffmpeg.exe) stderr, but a bat file with exe camouflage has no stderr output.

BTW I have added in the Peak Level Check routine few lines to check if there is _ffmpeg.exe and if yes, then _ffmpeg.exe will be called instead of ffmpeg.exe, only for that scope.

Hotfix



Bye
__________________
MrC

AVStoDVD Homepage
AVStoDVD @ Doom9 Forum
MrC is offline   Reply With Quote
Old 6th June 2018, 00:20   #3107  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,163
Quote:
Originally Posted by MrC View Post
BTW I have added in the Peak Level Check routine few lines to check if there is _ffmpeg.exe and if yes, then _ffmpeg.exe will be called instead of ffmpeg.exe, only for that scope.
Thanks MrC for this hotfix, and yes, it does of course fix the issue...

But I have the feeling that you are not all that eager to employ such workarounds (I wouldn't for sure). In the end it all comes down to another ugly rant about how the FFmpeg devs handle things...

Why in the world can't they just add a "logfile" parameter where users can specify a file location and name just like everybody else does? Instead they use stderr which must be redirected to a file. Even this is not done well, normally one would expect that only errors end up in stderr, the normal progress logging should go to stdout instead. But whatever, these guys will do what they want anyways, maybe they need to do it this way because FFmpeg needs to be multi-platform.

In this special case the executable which actually writes to stderr is the grandchild of the executable which A2D actually calls. Is there a way in VB6 to intercept stderr output of child or grandchild processes? Probably not...

For my audio analyzing needs I usually use BS1770Gain. For decoding it is based on FFmpeg, but it writes its results to a file directly, and it analyzes peak level and BS1770 (EBU R128) levels in one single pass. It is part of my Wavi_Mod plugin.


For the peak level analysis I do have one more request. Right now A2D offers to bring up the audio level to 0dB. If the final result is uncompressed PCM then this is fine. But for MP2 or AC3 output you should never go up to 0dB, a little headroom of at least 1dB is required.

For the old A2D normalizing there is a setting to only normalize to a lower value. But this value is a percentage, while the FFmpeg analysis and the AmplifydB command use Decibels. There is no linear relationship between these two, so it will be difficult to take the percentage (like 0.95) from the A2D audio settings and apply this reduction to the dB value of Amplifydb - like AmplifydB(FFmpeg peak result - 1). Maybe you should give up on the old AviSynth normalize altogether and instead use FFmpeg analysis -> AmplifyDB exclusively.


Cheers
manolito
manolito is offline   Reply With Quote
Old 6th June 2018, 23:38   #3108  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,163
Two more issues found with the Audio Peak Level detection...
(This time it is not related to the FFmpeg-Mod hack)

1. If a title has more than 1 audio track then after analyzing the second track A2D will throw an error message:
Error 5 Invalid Procedure Call or Invalid Argument

2. If the title has been trimmed using the AviSynth tab then the selection will not be honored by the analysis. FFmpeg will analyze the whole audio track without regard to the selection.


Cheers
manolito
manolito is offline   Reply With Quote
Old Yesterday, 17:15   #3109  |  Link
MrC
AVStoDVD Dev
 
MrC's Avatar
 
Join Date: Apr 2006
Location: Italy
Posts: 1,271
@manolito

the 1st issue has uncovered some weaknesses in general management of multiple audio tracks. A good amount of code lines has been refactored The 2nd issue was way easier to fix.

See the new hotfix.

As you suggested, I'm thinking about to drop classic AviSynth normalization and keep only the Peak Level Check + AmplifyDB routine. That's a more lean approach, I like the idea to drop the normalization option in Edit Title sections... but I would have to drop the normalization option in Preferences too... Still have to digest it ... I'm an old conservative man... and some users with the habit to normalize the world may complain. Do you have any advise?



Bye
__________________
MrC

AVStoDVD Homepage
AVStoDVD @ Doom9 Forum
MrC is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 01:08.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.