Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > General > Subtitles

Reply
 
Thread Tools Search this Thread Display Modes
Old 11th April 2018, 10:22   #921  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 996
Quote:
Originally Posted by iakoboss7 View Post
thank you for your work, any chance you can integrate that into "XySubFilter Beta3" ( 3.1.0.746 ) that is the latest version?
I have no insight to the history of this project, nor what it does aside being an Avs plugin. I have simply took the last version which I was said that worked as an Avisynth plugin and tried to build and mod it. Are there really important fixes? (the code history and project arrangement I'm seeing on github is not clear to me)
pinterf is offline   Reply With Quote
Old 11th April 2018, 11:51   #922  |  Link
ryrynz
Registered User
 
ryrynz's Avatar
 
Join Date: Mar 2009
Posts: 2,878
Yeah there are some good additions and fixes since that release.

Features & Changes
Add support for reporting if the subtitles are Bitmaps or Movable
Support Animated Vobsub
Update Boost, UnRAR, and log4cplus Libraries
Significantly improved parsing speed
Slightly faster \clip \iclip
Support Yasm 1.3.0
Query the EVR Presenter for ISubRenderConsumer
Update Boost & UnRAR Libraries

Bug Fixes
Fix override tag argument splitting
Add ISubRenderFrame to NonDelegatingQueryInterface
Certain PGS subtitles display an opaque background instead of transparent.
Avoid loading .sub as MicroDVD text when VOBSUB .idx present
Revert Insane Border Support (temporary crash fix)
Rare crash during border rendering
Allow 'Auto' to disable internal RGB matrix correction when needed
Various minor parser issues
Do not flag SSA/ASS subtitles as movable
Fix typo which broke \r tag in 3.1.0.744

Last edited by ryrynz; 11th April 2018 at 11:53.
ryrynz is offline   Reply With Quote
Old 11th April 2018, 17:50   #923  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 996
O.k., I didn't want to spend any more time on this project but fortunately it was easier than I had thought.

So. Source differences were synchronized (on file level, no git was involved, just the published sources; the old project and the commits were not clear to me), then made it work again under Visual Studio 2017.

Download xy-VSFilter / XySubFilter v3.1.0.800

This build has two dlls now. VsFilter.dll and XySubFilter.dll.
Please report if something is wrong, test it first, I can give no warranty that this XySubFilter works 100% the same way as it worked in the old builds. You are the ones who have all the knowledge of the subtitling world.

Please report the troubles, differences and also the fact when it works.

Happy testing
Code:
# xy-VSFilter v3.1.0.800 (20180411)
https://github.com/pinterf/xy-VSFilter/

A modification by pinterf: 
- xy-vsfilter 3.0.0.306 (https://github.com/Cyberbeing/xy-VSFilter/releases/tag/3.0.0.306) => 
  pfmod:VS2017 + VSFilter-TextSub 10/16bit Avisynth extension => 
  apply XySubfilter-3.1.0.746<->3.0.0.306 file differences =>
  make VSFilter work again as an Avisynth plugin
- Forum: https://forum.doom9.org/showthread.php?t=168282
- Other useful link: https://avisynth.org.ru/docs/english/externalfilters/vsfilter.htm
- All credits to the previous authors.

Info:
- Package contains VSFilter.dll and XySubFilter.dll (x86 and x64 versions)
- VSFilter.DLL: Included Avisynth filters (name and parameter signature)
  VobSub "cs"
  TextSub "c[file]s[charset]i[fps]f[vfr]s"
  TextSubSwapUV "b"
  MaskSub "[file]s[width]i[height]i[fps]f[length]i[charset]i[vfr]s[pixel_type]s"
- Warning by the XySubFilter-3.1.0.746 beta authors (on forum's 1st post, from 2015):
  "Note: XySubFilter requires a compatible subtitle consumer. We recommend madVR 0.87.5+ or MPC-HC 1.7.2+ (EVR-CP)
  After downloading XySubFilter BETA3, you must ensure to run the 'Install' bat (not only replace) or else 
  XySubFilter's autoload helper required for entering the DirectShow graph with external subtitles will not be installed."


Change log:
- v3.1.0.800 (20180411)
-- apply XySubFilter-3.1.0.746<->xy-VSFilter 3.0.0.306 file differences
-- get it work again under VS2017
-- make VSFilter work again as an Avisynth plugin
-- Versioning: 3.1.0 prefix is kept, build number goes from 800 and up for my mod manually in src/filters/transform/vsfilter/version_in.h

- v3.0.0.400 (20180405) (work in February 2018)
-- Get the last known xy-vsfilter version (3.0.0.306) which worked as the Avisynth plugin.
   Plan: have a native 10/16 bit compatible Avisynth TextSub filter.
-- xy-vsfilter 3.0.0.306 rebuilt with Visual Studio 2017
-- Avisynth+ headers
-- Native support for YUV420P10 and YUV420P16 formats in Avisynth filter TextSub and probably VobSub.
   Internal conversion to and from P010 and P016 with SSE2 support
-- Still doesn't work in any MT mode (I think): automatically registers itself as MT_SERIALIZED to prevent troubles
-- Avisynth filter MaskSub: new pixel_type (default: "RGB32") parameter. Can be set to "YUV420P10" or "YUV420P16"
-- Versioning: 3.0.0 prefix kept, build number goes from 400 and up for my mod manually in src/filters/transform/vsfilter/version_in.h

Last edited by pinterf; 11th April 2018 at 17:59.
pinterf is offline   Reply With Quote
Old 11th April 2018, 20:28   #924  |  Link
YxP
Registered User
 
Join Date: Oct 2012
Posts: 97
Incredible this project lives! Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaim very happy about this
YxP is offline   Reply With Quote
Old 11th April 2018, 23:02   #925  |  Link
amayra
Quality Checker
 
amayra's Avatar
 
Join Date: Aug 2013
Posts: 206
Quote:
Originally Posted by YxP View Post
Incredible this project lives! Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaim very happy about this
nope all what he did is make VSFilter work again as an avs+ plugin
there no change in playback side
i wish if he did this with assfiltermod instead
__________________
I love Doom9
amayra is online now   Reply With Quote
Old 12th April 2018, 10:51   #926  |  Link
Atak_Snajpera
RipBot264 author
 
Atak_Snajpera's Avatar
 
Join Date: May 2006
Location: Poland
Posts: 6,609
Quote:
Originally Posted by amayra View Post
nope all what he did is make VSFilter work again as an avs+ plugin
there no change in playback side
i wish if he did this with assfiltermod instead
That's not true. Old VSfilter didn't support 10bit color.
Atak_Snajpera is offline   Reply With Quote
Old 12th April 2018, 14:12   #927  |  Link
amayra
Quality Checker
 
amayra's Avatar
 
Join Date: Aug 2013
Posts: 206
Quote:
Originally Posted by Atak_Snajpera View Post
That's not true. Old VSfilter didn't support 10bit color.
neither avisynth vanilla
__________________
I love Doom9
amayra is online now   Reply With Quote
Old 12th April 2018, 16:56   #928  |  Link
Atak_Snajpera
RipBot264 author
 
Atak_Snajpera's Avatar
 
Join Date: May 2006
Location: Poland
Posts: 6,609
Quote:
Originally Posted by amayra View Post
neither avisynth vanilla
and...? Thanks to printerf we have working VSfilter in 10 bit color space so do not write that "all what he did is make VSFilter work again as an avs+ plugin". He did more than that!

Last edited by Atak_Snajpera; 12th April 2018 at 17:01.
Atak_Snajpera is offline   Reply With Quote
Old 12th April 2018, 18:31   #929  |  Link
sneaker_ger
Registered User
 
Join Date: Dec 2002
Posts: 5,111
@pinterf
Madshi made a small fix for italics in srt. I assume it is not included?
https://forum.doom9.org/showpost.php...ostcount=48444
sneaker_ger is offline   Reply With Quote
Old 13th April 2018, 08:05   #930  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 996
Quote:
Originally Posted by sneaker_ger View Post
@pinterf
Madshi made a small fix for italics in srt. I assume it is not included?
https://forum.doom9.org/showpost.php...ostcount=48444
I don't think it's included. Nevertheless the link contains only binaries (two DLLs).
pinterf is offline   Reply With Quote
Old 13th April 2018, 10:15   #931  |  Link
amayra
Quality Checker
 
amayra's Avatar
 
Join Date: Aug 2013
Posts: 206
Quote:
Originally Posted by Atak_Snajpera View Post
and...? Thanks to printerf we have working VSfilter in 10 bit color space so do not write that "all what he did is make VSFilter work again as an avs+ plugin". He did more than that!
well my mistake what i mean there no change in playback side this is answer for YxP
and this project is without question is dead unless someone decide to rewrite spaghetti code
__________________
I love Doom9
amayra is online now   Reply With Quote
Old 13th April 2018, 10:42   #932  |  Link
clsid
Registered User
 
Join Date: Feb 2005
Posts: 4,824
Do these changes use existing 10bit code of xy-VSFilter, or would it also be applicable to vanilla VSFilter?
clsid is offline   Reply With Quote
Old 13th April 2018, 11:49   #933  |  Link
sneaker_ger
Registered User
 
Join Date: Dec 2002
Posts: 5,111
While xy-vsfilter could overlay over 10 bit was there actually 10 bit subtitle rendering in the first place?

@pinterf
I pinged madshi about the source/patch.
sneaker_ger is offline   Reply With Quote
Old 13th April 2018, 19:37   #934  |  Link
huhn
Registered User
 
Join Date: Oct 2012
Posts: 4,994
xy vsfilter was able to render 10 bit correctly outside of AVS not sure about AVS.
huhn is offline   Reply With Quote
Old 15th April 2018, 08:37   #935  |  Link
tuanden0
Registered User
 
Join Date: Oct 2016
Posts: 86
Can I use xy-vsfilter for Vapoursynth?
tuanden0 is online now   Reply With Quote
Old 15th April 2018, 11:16   #936  |  Link
sneaker_ger
Registered User
 
Join Date: Dec 2002
Posts: 5,111
There are mods for it:
https://github.com/HomeOfVapourSynth...ilter/releases
https://www.nmm-hd.org/newbbs/viewtopic.php?t=1823
https://github.com/Tsuki/VapourSynth-XY-VSFilter


But the VapourSynth package already includes other plugins for rendering subtitles, so vsfilter is only needed if you are somehow not happy with the result of those:
http://www.vapoursynth.com/doc/plugins/subtext.html
sneaker_ger is offline   Reply With Quote
Old 16th April 2018, 03:04   #937  |  Link
tuanden0
Registered User
 
Join Date: Oct 2016
Posts: 86
@sneaker_ger
thank you very much
tuanden0 is online now   Reply With Quote
Old 18th April 2018, 22:14   #938  |  Link
cyberbeing
Broadband Junkie
 
Join Date: Oct 2005
Posts: 1,850
Quote:
Originally Posted by sneaker_ger View Post
@pinterf
Madshi made a small fix for italics in srt. I assume it is not included?
https://forum.doom9.org/showpost.php...ostcount=48444
Sorry that was my fault, I was busy and forgot to push it. The build from that post is outdated since it had some issues with ASS subtitles, which was fixed a week later. The latest madshi patch is now on the RC4 branch.

I'll need to figure out what to do about making a new release soon with at least the SRT italic fix. We got sidetracked with possible HDR rendering support for awhile, but that never materialized (see discussion on Libass issue tracker). pinterf if you could make a few pull requests on github at some point for changes you'd consider stable, that would be helpful.

One thing to note though, is I remember that xy-VSFilter built from the XySubFilter branches had some bugs. It's been so long now, but I believe some of the rendering features we were using in XySubFilter didn't function correctly in xy-VSFilter builds, and I also remember crashes. It would be nice if the XySubFilter codebase could be stabilized for xy-VSFilter builds, but unfortunately it was something which was never done before the project died.

That said, I'd suggest treating pinterf's xy-VSFilter v3.1.0.800 as extremely experimental at least in terms of directshow usage, compared to his xy-VSFilter 3.0.0.400 build which is based on a stable branch and should be safe.

Last edited by cyberbeing; 19th April 2018 at 00:07.
cyberbeing is offline   Reply With Quote
Old 13th May 2018, 08:31   #939  |  Link
hello_hello
Registered User
 
Join Date: Mar 2011
Posts: 3,683
pinterf,
I'm having an issue with VSFilter 3.1.0.800.
Full XP discloser: I'm running XP.

If I have VSFilter in a script it results in the following error when I try to preview it in MeGFUI or AvsPmod:

LoadPlugin: unable to load "C:\Program Files\MeGUI\tools\avisynth_plugin\VSFilter.dll", error=0x3e6

If I open the script with MPC-HC, VitrualDub, or VirtualDubMod there's no error and the subtitles are displayed.

VSFilter 3.0.0.306 works fine, but I haven't tried any other more recent versions.

Any idea what the cause might be?

Cheers.
hello_hello is offline   Reply With Quote
Old 9th June 2018, 08:47   #940  |  Link
gfxnow
Registered User
 
Join Date: Jul 2004
Posts: 33
Quote:
Originally Posted by cyberbeing View Post
I'll need to figure out what to do about making a new release soon with at least the SRT italic fix.
Best news of the year!
gfxnow is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 12:10.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.