Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
11th November 2008, 12:44 | #5001 | Link |
Registered User
Join Date: Sep 2008
Posts: 496
|
Oops, Sorry about that.
Here is an updated patch: http://iknowu.net/files/public/ffdsh...-BGR24-RC2.zip build: http://iknowu.net/files/public/ffdsh...-BGR24-RC2.exe Last edited by tal.aloni; 11th November 2008 at 12:54. |
11th November 2008, 13:16 | #5002 | Link | |
4:2:0 hater
Join Date: Apr 2008
Posts: 1,302
|
Quote:
|
|
11th November 2008, 13:43 | #5003 | Link | |||
Registered User
Join Date: Feb 2006
Location: Japan
Posts: 1,560
|
Quote:
libavcodec flags progressive if "Picture" progressive flag is set. libmpeg2 works better for me, but as tal.aloni has pointed, my samples have been gathered from weird places. Quote:
Quote:
|
|||
11th November 2008, 14:19 | #5004 | Link |
*****
Join Date: Feb 2005
Posts: 5,643
|
Haruhiko, could you update our copy of libswscale? There have been lots of changes to it in the past few months, including several bug fixes. There is some custom code in it from you, and you know about the code than the other devs.
__________________
MPC-HC 2.1.7.2 |
11th November 2008, 14:47 | #5006 | Link | |
Registered User
Join Date: Feb 2006
Location: Japan
Posts: 1,560
|
Quote:
Code:
case FF_CSP_BGR24 : safe_packed_conv( (uint8_t*)src, src_stride, image->y, image->u, image->v, edged_width, edged_width2, width, height, interlacing?(jpeg?TpackedFuncPtrRGB<JPEG>::rgbi_to_yv12:TpackedFuncPtrRGB<CCIR>::abgri_to_yv12) :(jpeg?TpackedFuncPtrRGB<JPEG>::abgr_to_yv12:TpackedFuncPtrRGB<CCIR>::rgb_to_yv12), interlacing?(jpeg?TpackedFuncPtrRGB<JPEG>::rgbi_to_yv12_c:TpackedFuncPtrRGB<CCIR>::abgri_to_yv12_c):(jpeg?TpackedFuncPtrRGB<JPEG>::abgr_to_yv12_c:TpackedFuncPtrRGB<CCIR>::rgb_to_yv12_c), 3); By the way, I found a mess. FF_CSP_RGB24 = PIX_FMT_BGR24 FF_CSP_RGB32 = PIX_FMT_BGR32 RGB and BGR is upside down in ffdshow. FF_CSP seems to be wrong. Of course this is not related to your patch. |
|
11th November 2008, 14:47 | #5007 | Link |
Registered User
Join Date: Sep 2004
Posts: 1,295
|
I have updated my ffdshow to rev 2301.
Two things: 1-The "Process frames flagged as progressive" check box only works when the "Deinterlacing" check box is checked, right? If it's this way, I think it should be placed inside the "Deinterlacing" group box, and not side-by-side with the "Deinterlacing" word over the group box line... 2-In the Presets dialog, when we rename a preset there is a little bug. We cannot change the case of a word. I have created a "dvd" preset, then I wanted to change it to "DVD" but it always appeared as "dvd". I renamed it to "ddd" and then to "DVD", and then it accepted it. |
11th November 2008, 14:54 | #5008 | Link | ||
4:2:0 hater
Join Date: Apr 2008
Posts: 1,302
|
Quote:
Quote:
I agree, everything can be bad flagged. But the goal is to find the most reliable method. In MPEG-2 it's progressive_sequence, that is good as it is now in libmpeg2. But for H.264 the SEI messages, while more detailed and reliable than MPEG-2 flags, are not 100% reliable either. You can do nothing if interlaced material is not flagged as PAFF/MBAFF, but you can guarantee that if the stream has PAFF/MBAFF identifiers is because there is interlaced video at some point, and thus flagging all of them will solve 99,999999% of the issues. What I suggest is a separate option like "Force bob", not to include this in the auto detection method, just to clarify. Last edited by STaRGaZeR; 11th November 2008 at 14:57. |
||
11th November 2008, 15:02 | #5009 | Link |
Registered User
Join Date: Sep 2008
Posts: 496
|
You are correct,
here is an updated patch: http://iknowu.net/files/public/ffdsh...-BGR24-RC3.zip Yea, it is a mess, RGB was already called BGR, so I called the BGR routines RGB. I can "make it right", if you prefer it that way, but it will be a very long patch, and it would change dozens of files. (at first that's what I did, but when I saw the magnitude of the change, I was afraid it won't be accepted) Tal Last edited by tal.aloni; 11th November 2008 at 15:30. |
11th November 2008, 15:47 | #5010 | Link | |
Registered User
Join Date: Feb 2006
Location: Japan
Posts: 1,560
|
Quote:
Please wait, not now, as I'm updating libswscale. It would cause too much conflicts with my local copy. |
|
11th November 2008, 15:53 | #5011 | Link | |
Registered User
Join Date: Sep 2008
Posts: 496
|
you are right, it is the FF_CSP that's wrong, see here:
Code:
struct TimgExportBMP :public TimgExport { virtual int requiredCSP() {return FF_CSP_RGB24|FF_CSP_FLAGS_VFLIP;} Code:
struct TimgExportPNG :public TimgExportLibavcodec { virtual int requiredCSP() {return FF_CSP_BGR24;} Quote:
Tal Last edited by tal.aloni; 11th November 2008 at 16:19. |
|
11th November 2008, 16:33 | #5012 | Link | |
Registered User
Join Date: Sep 2003
Posts: 267
|
Quote:
__________________
"Do everything by hand, even when using the computer." - Hayao Miyazaki |
|
11th November 2008, 16:59 | #5014 | Link |
Registered User
Join Date: Sep 2003
Posts: 267
|
I run it through DGIndex and it looks like the interlaced frames are flagged as interlaced though. I don't know a better way to check.
__________________
"Do everything by hand, even when using the computer." - Hayao Miyazaki |
11th November 2008, 19:52 | #5015 | Link | |
4:2:0 hater
Join Date: Apr 2008
Posts: 1,302
|
Quote:
For MPEG2 --> Everything that is not progressive_sequence=1 (even if it is soft telecined, at some point it may have interlaced frames like that sample). For H.264 --> Every PAFF/MBAFF stream, regardless of picture timing SEI. For VC-1 --> I can't find the specification. I really think lots of people would find this option useful. A more refined "force bob" and "Process frames flagged as progressive". |
|
11th November 2008, 19:59 | #5016 | Link |
Registered User
Join Date: Sep 2008
Posts: 496
|
I don't believe that the video is flagged correcly, If you claim it is, please introduce me to the tools who shows this information.
That's not true, many deinterlacers (linear blending for example) will deinterlace immediately. Last edited by tal.aloni; 11th November 2008 at 20:03. |
11th November 2008, 20:30 | #5017 | Link | |
Software Developer
Join Date: Jun 2005
Location: Last House on Slunk Street
Posts: 13,248
|
Quote:
In the very first frame, when there's no previous frame to compare against, simply all pixels need to be interpolated...
__________________
Go to https://standforukraine.com/ to find legitimate Ukrainian Charities 🇺🇦✊ Last edited by LoRd_MuldeR; 11th November 2008 at 20:35. |
|
11th November 2008, 21:09 | #5018 | Link |
Registered User
Join Date: Sep 2003
Posts: 267
|
I used DGindex's preview to step through the stream and the frames that show interlacing were reported in the information window as interlaced. Is there something incorrect with this?
__________________
"Do everything by hand, even when using the computer." - Hayao Miyazaki |
11th November 2008, 21:55 | #5019 | Link | ||
Registered User
Join Date: Sep 2008
Posts: 496
|
Yes, here DGIndex clearly shows that there many interlaced frames flagged as progressive:
http://iknowu.net/files/public/ffdsh...rePulldown.jpg Quote:
I'm not familiar with any delayed deinterlacing issue, and I think we have none. Quote:
again, I'm pretty sure most of the others will too, but I'm not familiar with them. Last edited by tal.aloni; 11th November 2008 at 22:30. |
||
11th November 2008, 22:28 | #5020 | Link |
Registered User
Join Date: Sep 2003
Posts: 267
|
Wow, that's not what I get. http://img517.imageshack.us/img517/5601/bad1el0.png
I also checked it ignoring the pulldown flags since I thought that was closer to the behavior of ffdshow anyway and still it came out as interlaced http://img517.imageshack.us/img517/8388/bad2wo8.png I wonder what the discrepancy is since the version of DGindex I'm using seems to get it right?
__________________
"Do everything by hand, even when using the computer." - Hayao Miyazaki |
Tags |
ffdshow, ffdshow tryouts, ffdshow-mt, ffplay, icl |
Thread Tools | Search this Thread |
Display Modes | |
|
|