Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > (HD) DVD, Blu-ray & (S)VCD > One click suites for DVD backup and DVD creation

Reply
 
Thread Tools Search this Thread Display Modes
Old 23rd April 2018, 09:55   #3081  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,143
From the AVStoDVD help file:

Quote:
Anyway, if there is already an old or broken mscomctl.ocx file, the Installer will not overwrite it. In that case AVStoDVD will complain. You have to:

Delete any previous mscomctl.ocx files in your system folders (e.g. C:\Windows\System32 for Win32 or C:\Windows\SysWOW64 for Win64)
Run as administrator .\AVStoDVD\Lib\mscomctl_reg.bat file
Have you tried to delete old versions of mscomctl.ocx in System32 and/or SysWOW64 before running the batch file?


Cheers
manolito
manolito is offline   Reply With Quote
Old 12th May 2018, 17:38   #3082  |  Link
MrC
AVStoDVD Dev
 
MrC's Avatar
 
Join Date: Apr 2006
Location: Italy
Posts: 1,265
AVStoDVD 2.8.8 Alpha 180508 is available to download.

Change log:

- Some bugs fixed
- Added 'Audio Peak Level Check' feature in 'Title Edit'/'Audio' section
- Added support to OGG chapters txt format (timestamps) in 'Title Edit'/'Chapters'/'Import Chapters' routine
- Improved 'Title Edit'/'Chapters'/'Export Chapters' routine
- Improved source chapters detection routine (now it works again for IFO/DVD files)
- MKVToolNix updated to release 23.0.0
- MediaInfo updated to release 18.03



Bye

MrC
__________________
MrC

AVStoDVD Homepage
AVStoDVD @ Doom9 Forum

Last edited by MrC; 12th May 2018 at 17:50.
MrC is offline   Reply With Quote
Old 12th May 2018, 21:40   #3083  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,143
Thanks MrC for the new Alpha...

Did a few quick tests, this is what I found so far:

I will have to update the German language file, give me a few days.

After a long time you finally managed to break my FF_VBR and WaviMod plugins...
The audio peak level check will not work if my plugins are installed. The reason is that you use the redirection character in the FFmpeg params. The way I intercept all FFmpeg commands in my plugins requires that I retrieve the original command line. In a batch file there is no way to do this correctly if the command line contains special characters like the pipe character or the redirection character.

So far I do not see any workaround for this. Myself I do not care because I use external tools to analyze my audio sources, and I also pretty much abandoned simple peak normalizing.

For the new chapter import and export routines I did not have the time yet to test them, will do this ASAP.

Cheers
manolito
manolito is offline   Reply With Quote
Old 13th May 2018, 20:31   #3084  |  Link
MrC
AVStoDVD Dev
 
MrC's Avatar
 
Join Date: Apr 2006
Location: Italy
Posts: 1,265
Hi manolito, of course it did not intend to break the plugins... from my side I will try to find a way to redirect FFmpeg stderr to a VB variable instead of going thru batch text file saving. Not easy, but I will try.

I will wait for your kind german translations.

And please let me know your opinion about the new features (Import OGG Chapters and Peak Level Check).

Thanks for your neverending support.



Bye
__________________
MrC

AVStoDVD Homepage
AVStoDVD @ Doom9 Forum
MrC is offline   Reply With Quote
Old 13th May 2018, 22:15   #3085  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,143
Quote:
Originally Posted by MrC View Post
Hi manolito, of course it did not intend to break the plugins...
Hi MrC,

of course you didn't, I was trying to be funny...

I tried a few more tricks today, but nothing worked (escaping special characters, using delayed expansion, creating new processes for my batch files). I am just hitting the limitations of batch files, which somehow was to be expected.

What would work is to edit your A2DPeakLevel.bat to call _FFmpeg.exe (the renamed original FFmpeg.exe). But this would mean that you had to integrate a check in A2D if my FFmpeg hack is installed and then call the appropriate executable. Not really desirable...

Anyways, anybody who uses my Wavi_Mod plugin has no need to check the audio peak level from within A2D. And for users who have not installed my plugins it does not matter anyways.

A suggestion:
Currently you employ the AviSynth "Normalize" function after the peak level check. This wastes a lot of time. If the peak level is already known you could use the "AmplifyDB" function instead.


Another unrelated thing for the MCJMFPS.avsi:
According to this post
https://forum.doom9.org/showthread.p...52#post1841952
the quality improves a little bit after adding these params to the two MSuper calls:
Quote:
sharp=1, rfilter=4
The lines would then look like this:
Quote:
super = MSuper(source, hpad = 16, vpad = 16, levels = 1, sharp = 1, rfilter = 4) # one level is enough for MRecalculate
superfilt = MSuper(prefiltered, hpad = 16, vpad = 16, sharp = 1, rfilter = 4) # all levels for MAnalyse
I did a few short tests, I found it hard to see a difference. Maybe you could give it a whirl, you might have better eyes than I do...


Alright, I will report back with more test results.

Cheers
manolito
manolito is offline   Reply With Quote
Old 14th May 2018, 01:11   #3086  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,143
Alright, here is the updated German language file:
https://files.videohelp.com/u/172211/German.lang.ini.7z

I noticed one small glitch with this entry:
Quote:
120011 Right-Click to manage Titles
When A2D is started in German then the translation for this entry does not kick in, I see the English text. Clicking "View->Select Language->German" fixes it, now I do see the German translation.


I also played a little with the new chapter import/export routines, but this stuff seems awfully complex, at least when you do not live in NTSC land...

What I tried so far was to convert a PAL title with chapters every 3 minutes to NTSC. When I had NTSC SpeedDown activated of course the OGG chapters added about 4sec to every chapter point, I did expect this. But when I imported an OGG chapter file I had saved earlier with chapters at exactly every 3 minutes then I got chapter points with about 40 sec added to every original chapter.

Still Batchmux handled these chapters gracefully. I did not expect this because I know that Muxman refuses to author streams with chapters beyond the video length.

Whatever, I think that some folks from NTSC land will have to join in here to test this new feature.


Cheers
manolito
manolito is offline   Reply With Quote
Old 14th May 2018, 13:30   #3087  |  Link
Sir Didymus
Registered User
 
Join Date: Mar 2004
Location: Italy
Posts: 948
<<
...Still Batchmux handled these chapters gracefully. I did not expect this because I know that Muxman refuses to author streams with chapters beyond the video length...
>>

Indeed, this is intriguing...

The total number of chapters identified are reported in the BM log file as: "Segment #... - Total Nr of Chapters --> ...".

Just out of curiosity I browsed a little bit deeper in the C code where the chapter points are validated... Well, plenty of code is present in BM to validate the timecode entries. Believe me, there are many checks (and warnings/errors printed out in case of issues). Nevertheless, there is no explicit validation of the individual time points of the chapter lists against the duration of the related video segments. In other terms, as you are pointing out, the BM session (preparation of the mxp script) should not stop...

It is an intended behavior: in case of problems related to chapter points outside of the range of the video segment duration, the complains are all left to MuxMan...

Last edited by Sir Didymus; 14th May 2018 at 14:57.
Sir Didymus is offline   Reply With Quote
Old 14th May 2018, 23:32   #3088  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,143
Hi Sir Didymus,

good to see you back here after about 2 years...

You are right, all credits for handling these out of range chapters go to BatchMux, not to MuxMan.

Did another test which confirmed it. The source file was PAL, length was 6min 10sec. It had chapters at 2:00, 4:00 and 6:00. I exported these chapters to the OGG format. Then fired up AVStoDVD and told it to create an NTSC DVD structure. A2D used soft pulldown (correctly, the source was progressive). Then I imported the previously saved OGG chapters file, and the chapters window told me that I had chapters at 2:30, 5:00 and 7:30.

After the conversion which went without errors I played the DVD, and it had chapters at 2:30 and 5:00. The last chapter at 7:30 had not been included.

Had I tried to mux these chapters only using Muxman then Muxman woud have refused to mux and author this project. So it was really BatchMux which protected Muxman from receiving a chapter point outside of the video length. Very cool...


But of course it is still not correct how A2D handles this case. The whole point of using a chapter file which is based on absolute time stamps (as opposed to frame numbers which need to change with the target FPS) is to be independent of the target FPS. Right now A2D does not handle these OGG chapter files correctly when using pulldown.

In another test I used hard FPS conversion to NTSC with ChangeFPS. This time after importing the OGG chapter file the chapter points were correct. Looks like FPS conversion using pulldown needs to be fixed when importing OGG chapters.


Cheers
manolito
manolito is offline   Reply With Quote
Old 15th May 2018, 09:11   #3089  |  Link
Sir Didymus
Registered User
 
Join Date: Mar 2004
Location: Italy
Posts: 948
Hem... No, no... Thanks for the credits, but I think there should be something else in the chain which is filtering out the last chapter.

Possibly it is the analysis and the conversions of AVS2DVD. Please get a look at the input chapter files provided to BM to confirm...


About BM I was saying the opposite of your (kind) understanding infact: as far as I can say, BM is NOT checking the duration of the video, so it is not removing the last chapter. If you look at the .mxp (output) file produced by BM, you should be able to see the presence of a scene at the time 7:30.

Cheers,
Sir Didymus is offline   Reply With Quote
Old 15th May 2018, 21:21   #3090  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,143
@ Sir Didymus

Yes, you are correct. I repeated my tests keeping all the temp files, and indeed it was AVStoDVD which removed the last (out of range) chapter from the conversion. BatchMux was called without this last chapter, so MuxMan had no problem. Still this is not the desired outcome, the chapters are not at the positions where they should be...


@ MrC

After some long hours of testing I do know why I had this feeling that implementing OGG chapter import would be a major task...

AVStoDVD is so advanced now, it offers many methods for FPS conversion, and all of these methods require a different handling of importing OGG chapters which are based on time codes.

From my understanding the goal must be:
When I import an OGG chapter file into A2D, then the chapters must appear at the same position of the video in the conversion result. If A2D does not speed up or slow down the video then the chapters must appear at the same point in time (which is also the same position in the video). But if A2D does speed up or slow down the video, then the chapters should still be at the same position of the video. But of course the time stamps for the chapter points should be different to reflect the now different length of the clip. Do we agree on this?


Alright, I tested most of the possible scenarios with the current Alpha, this is what I found so far:

Test environment:
Source file was a short 6min 9sec clip. I created an OGG chapter file with chapters at 2:00, 4:00 and 6:00 min. From this source clip I made different clips for the different use cases:

PAL progressive (interlaced was not needed, it made no difference)
NTSC with soft pulldown 25 -> 29.97 ("irregular" pulldown)
NTSC with soft pulldown 23.976 -> 29.97 ("regular" 3:2 pulldown)
NTSC without soft pulldown, either hard telecined or pure progressive)

I then loaded the desired source clip into A2D and imported the previously created OGG chapter file.


Results:

PAL to NTSC

Using the default soft pullown:
Chapters were way off. MuxMan did not crash though because A2D removed the out-of-range chapters.

Using hard FPS conversion (either hard telecine or ChangeFPS). Also applies to interlaced sources:
No problem


NTSC to PAL

Genuine 29.97 source without pulldown flags (progressive or interlaced):
A2D uses hard FPS conversion, no problem.

Soft telecined source:
A: Telecined 23.976 -> 29.97

A1: Using DGDecode
Pulldown flags are honored, A2D sees the source as 29.97 and uses hard FPS conversion. Chapter points are correct

A2: Using DSS2Mod with LAVFilters
MediaInfo recognizes the frame rate as 23.976, DSS2 removes the pulldown flags, and A2D will either use PAL speedup or 23.976 -> 25 pulldown. In both cases the chapter points are off (by about 4% with PAL speedup, much worse when using 23.976 -> 25 pulldown).

B: Telecined 25 -> 29.97
MediaInfo does not recognize the pulldown flags. A2D sees the source as 29.97 and will use hard FPS conversion. No problems with the chapter points.


Generally it looks like hard FPS conversions are handled correctly by the current implementation. When soft pulldown or speedup/slowdown gets used then the problems start. There are probably some more use cases which will need special attention, but right now I am not in the shape for more testing (my head is buzzing already...).


Cheers
manolito

Last edited by manolito; 16th May 2018 at 18:53.
manolito is offline   Reply With Quote
Old 16th May 2018, 17:32   #3091  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Posts: 2,143
Quote:
Originally Posted by manolito View Post
A1: Using DGDecode
Pulldown flags are honored, A2D sees the source as 29.97 and uses hard FPS conversion. Chapter points are correct

A2: Using DSS2Mod with LAVFilters
MediaInfo recognizes the frame rate as 23.976, DSS2 removes the pulldown flags, and A2D will either use PAL speedup or 23.976 -> 25 pulldown. In both cases the chapter points are off (by about 4% with PAL speedup, much worse when using 23.976 -> 25 pulldown).
Realizing once again that NTSC is still a strange beast to me...
What is the "most correct" way to handle a progressive (film) NTSC clip which is encoded at 23.976fps with 3:2 pulldown flags?

In AVStoDVD the different source filters depend on the MediaInfo information. When DGIndex/DGDecode is used then the "Honor Pulldown Flags" option is set. AviSynth sees a 29.97fps clip which looks "interlaced" due to the repeated fields. For fps conversion to PAL framerate A2D uses the selected "hard" conversion method (default is MCJMFPS).

Is this a good way to do it? Or shouldn't DGIndex use the "Force Film" option instead to serve the 23.976 clip without the repeated fields to AviSynth?

//EDIT//
I had falsely assumed that AVStoDVD actively edits DGIndex.ini to make sure that "Honor Pulldown Flags" is set. This is not true, A2D does not touch the "Field Operation" setting. A user can change this setting to "Force Film" before starting AVStoDVD, and this will make sure that only the encoded frames without the repeated fields will be served to AviSynth.
//END EDIT//


The other method using DSS2Mod and LAVFilters also raises a few questions. In this case MediaInfo reports 23.976fps and 3:2 pulldown for the source clip. A2D adds the "fps=23.976" to the DSS2Mod source filter command. Does this command return the correct frames? Without the "fps=23.976" DSS2Mod would return a rate of 29.97 (like DGIndex with "Honor Pulldown Flags"). Is forcing 23.976 in the source filter command the equivalent of removing the pulldown flags? I have my doubts... I am afraid that DSS2Mod first decodes to 29.97 and afterwards just drops frames to reach the specified frame rate of 23.976.

BTW DirectShowSource and FFmpegSource behave the same way as DSS2Mod.


Whatever, I am mighty glad to live in PAL land where I do not have to deal with those things...


Cheers
manolito

Last edited by manolito; 16th May 2018 at 18:21.
manolito is offline   Reply With Quote
Old 16th May 2018, 21:31   #3092  |  Link
MrC
AVStoDVD Dev
 
MrC's Avatar
 
Join Date: Apr 2006
Location: Italy
Posts: 1,265
Thanks manolito for the German translation and extensive testing. PAL<->NTSC conversions are a nightmare for many reasons, chapters affaire is just the top of the iceberg...

Now I just have to find a couple of hours to go thru your investigations and solve all (?) the possible fps conversion scenarios within the new OGG chapters import routine.

About the Peak Level Check feature, I agree with you that it would better trigger the AmplifyDB() instead of Normalize(). There is also the possibility to move that routine directly in the AviSynth tab > Audio > Amplify Audio option, as preliminary prompt to the user.



Bye
__________________
MrC

AVStoDVD Homepage
AVStoDVD @ Doom9 Forum
MrC is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 07:38.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.