ffdshow tryouts project: Discussion & Development

[foxyshadis]

I swear this thread generates more side threads than anything else in the forum. New hardware discussion.

KZ, so there actually is a DXVA colorprimary flag? Is it part of VideoInfoHeader2?

Both RFEs have been filed: Use stream information with: ffdshow conversion to RGB and passing YUV along to video card.

[Dr Pizza]

Originally Posted by akupenguin

The C parts of libavcodec are definitely LLP64 clean: The only codec that uses (long) at all is the faad wrapper.

I'll take a look at the current source, maybe the situation isn't as grim as it was before.

[clsid]

"make 64BIT=yes" should select the appropriate blocks of assembly code. Note that I haven't been able to test it, but unless I forgot something or screwed up somewhere it should work.

The makefile should also be modified with different GCC parameters to set the correct target architecture. That hasn't been done yet.

[haruhiko_yamagata]

Originally Posted by SealTooGreat

With:
ffdshow_rev1050_20070319_clsid_sse_icl9.exe
ffdshow_beta2a_20070322_clsid.exe
ffdshow_beta2_20070319_clsid.exe
.... using MPC+Haali splitter, I can't watch my anamorphic encodes(it doesn't stretch to correct AR) and also there's some green line in right border.
Using same ffdshow video presets I don't have that issue with:
ffdshow_beta1_20061211_clsid.exe
Any idea why?!

It works for me. Which video renderer do you use?
Could you upload the sample?
What is the OS and version of the directShow?
What is the video card?

[haruhiko_yamagata]

Originally Posted by fastplayer

@Devs:
Should the download links (in changelog and tryouts homepage) be updated to the new beta2a build?

Yes, please do so.

[haruhiko_yamagata]

Originally Posted by Leak

To Haruhiko or whoever has a better understanding of MPEG2 decoding:

If I'm using ffdshow to decode DVDs I've noticed that the only events getting fired from the DVD Navigator are BeginFlush/EndFlush, but the video decoder pin doesn't handle those, so I don't think libmpeg2 or anything else is actually waiting for a keyframe after seeking - that might explain why there's still quite some macroblocking going on when seeking around on a DVD.

Incidentally, that also prevents my filter from just dropping the remaining buffered frames and makes it process them, which is quite wasteful - should we perhaps add an onFlush() method (like the existing onStop and onSeek) to TimgFilter(s) that gets called on BeginFlush(), or should we at least call onSeek() in that case?

TvideoCodecLibmpeg2:: onSeek and TimgFilterAvisynth:: onSeek are called when we seek on mpeg2 ps/ts/vob and almost any files except DVD . It's a bug of the DVD decoding.
I don't think onFlush is necessary as long as DVD can be handled properly.

[Leak]

Originally Posted by haruhiko_yamagata

I don't think onFlush is necessary as long as DVD can be handled properly.

So by "handled properly" you mean onSeek being fired on the next incoming sample when the pin gets a BeginFlush? At least that would be my idea of working around this.

[haruhiko_yamagata]

Originally Posted by Leak

So by "handled properly" you mean onSeek being fired on the next incoming sample when the pin gets a BeginFlush? At least that would be my idea of working around this.

I don't know. It's not that easy, I guess.
We have to study the code of MPC or DScaler.
I'm not willing to implement full DVD decoding feature.

[albain]

Sorry for the compilation errors : I messed up with the merge (modifications have been made on the files I have been working on, and the merge tool made some weird things...)

It is repaired now : revision 1064

Just one precision : those modifications imply that you have the last version of Windows SDK : v6.0, that includes headers for Vista.
Maybe it will still compile with older SDKs though...

[cc979]

with rev1064

the baseclasses are un-compilable with gcc
tried updating to vista's sdk and converting the libs ... to many errors

like
d:/msys/1.0/dx/Include/objbase.h:1003: error: '__in' was not declared in this scope
d:/msys/1.0/dx/Include/objbase.h:1004: error: '__in' was not declared in this scope
d:/msys/1.0/dx/Include/objbase.h:1005: error: '__in' was not declared in this scope
d:/msys/1.0/dx/Include/objbase.h:1006: error: '__deref_out' was not declared in this scope
d:/msys/1.0/dx/Include/objbase.h:1006: error: initializer expression list treated as compound expression

its beyond me, any clues anyone?

[KillerZero]

[QUOTE=foxyshadis;974086]

Originally Posted by foxyshadis

KZ, so there actually is a DXVA colorprimary flag?

obviously yes.

Originally Posted by foxyshadis

Both RFEs have been filed: Use stream information with: ffdshow conversion to RGB and passing YUV along to video card.

You filled it wrong.
1) ffdshow always use Rec601 when does SW RGB conversion.
2) more important than DXVA_VideoPrimaries (which set color of RGB values) is DXVA_VideoTransferMatrix (which set which matrix should be used for YV12-->RGB conversion)
Both these values should be set.

[Inventive Software]

@Devs: Can I suggest a separate branch for a Vista so as not to break compilation, so to speak? Vista's screwy already without helping to break other operating systems.

[albain]

Originally Posted by cc979

with rev1064

the baseclasses are un-compilable with gcc
tried updating to vista's sdk and converting the libs ... to many errors

like
d:/msys/1.0/dx/Include/objbase.h:1003: error: '__in' was not declared in this scope
d:/msys/1.0/dx/Include/objbase.h:1004: error: '__in' was not declared in this scope
d:/msys/1.0/dx/Include/objbase.h:1005: error: '__in' was not declared in this scope
d:/msys/1.0/dx/Include/objbase.h:1006: error: '__deref_out' was not declared in this scope
d:/msys/1.0/dx/Include/objbase.h:1006: error: initializer expression list treated as compound expression

its beyond me, any clues anyone?

Does it compile correctly under MSVC ?

I am using the base classes from ffdshow with the last windows sdk and I didn't have this problem (using MSVC)

I didn't try with gcc : gcc does not work in Vista for now

Concerning the idea of opening a separate branch for Vista, I hope that this could be avoided, because it will split the work of developers.

Things can be done to avoid compilation problems, by using preprocessor macros basing on the OS version. However the last SDK (the one for Vista) should be working under XP

[cc979]

@albain
i don't use MSVC or vista, before i tried updating the mingw headers & libs it did'nt work either

as mingw as its own win32 headers it clashes/or is incompatible with new the windows sdk v6 - mingw headers might get updated later

not sure what to do now - as it a bit over my head

is it possible to alter your edits to keep gcc compatiblity?

or maybe edit it to work with latest dx sdk(feb 2007) but not platform sdk as its that whats breaking gcc - the latest dx sdk is ok with gcc as i used it rev1058 no problem

cheers

[albain]

OK I will try to think about a workaround : maybe by copying the needed content of those headers into a dedicated ffdshow header file.

Maybe your solution is to put your mingw headers directories before windows sdk ones.

Before doing anything, could you try this :
copy functiondiscoverykeys.h and Mmdeviceapi.h to your mingw include directory and remove any references to Windows SDK and compile ffdshow ?

If it does not work, my bet is to extract the used interfaces in my modifications

[cc979]

just tried include them 2 headers but it errors with

d:/msys/1.0/dx/Include/functiondiscoverykeys.h:11: error: expected constructor, destructor, or type conversion before '(' token

d:/msys/1.0/dx/Include/Mmdeviceapi.h:126: error: 'PROPERTYKEY' does not name a type

d:/msys/1.0/dx/Include/Mmdeviceapi.h:198: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:198: error: expected ',' or '...' before 'pwstrDeviceId'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:204: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:204: error: expected ',' or '...' before 'pwstrDeviceId'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:208: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:208: error: expected ',' or '...' before 'pwstrDeviceId'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:212: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:212: error: expected ',' or '...' before 'flow'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:220: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:220: error: expected ',' or '...' before 'pwstrDeviceId'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:343: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:343: error: expected ',' or '...' before '&' token
d:/msys/1.0/dx/Include/Mmdeviceapi.h:353: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:353: error: expected ',' or '...' before 'stgmAccess'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:359: error: '__deref_out' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:359: error: expected ',' or '...' before '*' token
d:/msys/1.0/dx/Include/Mmdeviceapi.h:363: error: '__out' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:363: error: expected ',' or '...' before '*' token
d:/msys/1.0/dx/Include/Mmdeviceapi.h:476: error: '__out' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:476: error: expected ',' or '...' before '*' token
d:/msys/1.0/dx/Include/Mmdeviceapi.h:480: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:480: error: expected ',' or '...' before 'nDevice'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:573: error: '__out' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:573: error: expected ',' or '...' before '*' token
d:/msys/1.0/dx/Include/Mmdeviceapi.h:654: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:654: error: expected ',' or '...' before 'dataFlow'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:662: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:662: error: expected ',' or '...' before 'dataFlow'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:670: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:670: error: expected ',' or '...' before 'pwstrId'
d:/msys/1.0/dx/Include/Mmdeviceapi.h:676: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:676: error: expected ',' or '...' before '*' token
d:/msys/1.0/dx/Include/Mmdeviceapi.h:680: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:680: error: expected ',' or '...' before '*' token
d:/msys/1.0/dx/Include/Mmdeviceapi.h:803: error: '__in' has not been declared
d:/msys/1.0/dx/Include/Mmdeviceapi.h:803: error: expected ',' or '...' before '&' token
make[1]: *** [baseclasses_all.o] Error 1
make[1]: Leaving directory `/home/User/svn/ffdshow-tryout/ffdshow-tryout/src/baseclasses'
make: *** [lib] Error 2

maybe you could try - if not defined them to headers compile for xp or gcc, or something - but looks like it could be tricky problem

cheers

[albain]

Okay, I know why : there are more than those 2 headers, but if I create a new header with only the needed interfaces and constants, it should work

[cc979]

would there be copyright issues distributing ms headers - if remember milan_cutka told me something about it on sourceforge somewhere

[clsid]

The baseclasses in ffdshow are also Microsoft code. So it shouldn't be a problem.

Albain, please create the custom header. Then I could postpone my hardware upgrade a little while till after the Intel price drops

[cc979]

i think i got the baseclasses compiled by compiling it on its own but when try build the rest

i get this error

../subtitles/Tstream.h: In member function 'virtual long int TstreamFile::length() const':
../subtitles/Tstream.h:97: error: 'filelength' was not declared in this scope
TbitrateDlg.cpp: In member function 'virtual void TbitrateDlg::init()':
TbitrateDlg.cpp:54: error: 'filelength' was not declared in this scope
make[1]: *** [ffdshow_dialog_all.o] Error 1
make[1]: Leaving directory `/home/User/svn/ffdshow-tryout/ffdshow-tryout/src/dialog'
make: *** [lib] Error 2

not sure what this one is ?