Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Video Encoding > MPEG-4 AVC / H.264

Reply
 
Thread Tools Search this Thread Display Modes
Old 28th March 2019, 20:00   #2121  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,684
Unless i've missed it in the code, but it seems that there is no check value on --output-depth, you can put whatever you want ! Didn't see any check on i_bitdepth, and i also didn't see anything on validate_parameters in encoder.c file...
Don't you think you should add a check on allowed value ? And the help maybe more specific, instead of "just int value"
__________________
My github.
jpsdr is offline   Reply With Quote
Old 28th March 2019, 23:09   #2122  |  Link
MasterNobody
Registered User
 
Join Date: Jul 2007
Posts: 514
Quote:
Originally Posted by jpsdr View Post
Unless i've missed it in the code, but it seems that there is no check value on --output-depth, you can put whatever you want ! Didn't see any check on i_bitdepth, and i also didn't see anything on validate_parameters in encoder.c file...
Don't you think you should add a check on allowed value ? And the help maybe more specific, instead of "just int value"
check
MasterNobody is offline   Reply With Quote
Old 29th March 2019, 10:15   #2123  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,684
Thanks, i had missed it, it was odd that i didn't find any check, it makes more sense indeed like this...
__________________
My github.
jpsdr is offline   Reply With Quote
Reply

Tags
coding, development, x264 dev

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 21:14.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.