Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
|
|
Thread Tools | Search this Thread | Display Modes |
27th May 2020, 16:12 | #1441 | Link |
Registered User
Join Date: Jan 2014
Posts: 2,309
|
KNLMeansCL needs to be rebuilt for AviSynth+ 3.6
https://forum.doom9.org/showthread.p...98#post1909698 Until it is done officially, you can download it from my repository |
27th May 2020, 16:42 | #1442 | Link |
Registered User
Join Date: Nov 2019
Posts: 16
|
Thanks pinterf!I updated to your KNLMeansCL.
But it also made error: Script error:expected ')' ((null),line 1,column 4) (AviSynth+/plugins64+/srestore v2.796.avsi,line 79) (QTGMC 3.364.avsi,line 186) (my.avs line 25:QTGMC(preset="Very Slow", InputType=0,sourceMatch=3).SelectEven()) |
27th May 2020, 19:24 | #1443 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
__________________
See My Avisynth Stuff |
|
11th June 2020, 20:03 | #1445 | Link |
Registered User
Join Date: Oct 2001
Location: Germany
Posts: 7,259
|
KNLMeansCL is still crashing for me with:
Code:
Avisynth error : KNLMeansCL: fatal error! (oclUtilsGetPlaformDeviceIDs: OCL_UTILS_UNKNOWN_ERROR) (E:\Temp\tempPreviewAvisynthFile08_26_19_695.avs, line 11) Couldn't import -1 (1) Since it there hasn't been a driver version since February that works for me with KNLMeansCL anyone has an idea how to get it working again? (Problem is only with 32bit Avisynth, works fine in 64bit Vapoursynth) => found the problem here, I had an abandoned old OpenCL.dll in the same folder as KNLMeansCL which caused the problem, after removing the OpenCL.dll it's working again Last edited by Selur; 12th June 2020 at 11:40. |
6th September 2020, 13:42 | #1446 | Link |
Registered User
Join Date: Oct 2001
Location: Region 2
Posts: 427
|
I'm using Ripbot264 which incluses the KNLMeansCL plugin, but the filter does not work well on my AMD VEGA GPU. (i believe it did not work on my previous AMD RX480 card either).
When i enable KNLMeansCL by using mono noise 2, then the output image gets very dark, almost completely black. It seems to be minor issue though, because is soon as i resize the video from 1920x1080 to 1904x1072 for example, the output image is normal and the denoising works! It even works fine if i resize to higher resolution. So resizing is a workaround. But i would like to keep original 1920x1080 resolution, so it's not a good workaround for me. Does anyone know a better way to fix this issue? |
6th September 2020, 20:35 | #1447 | Link |
Registered User
Join Date: Jul 2003
Location: Italy
Posts: 1,135
|
Maybe it's due to a not mod16 resolution? You can workaround with padding, adding borders to the image (just the minimum needed, for example, does it work at 1920x1088?), filters and then crop the borders away to restore the original image.
|
7th September 2020, 09:39 | #1448 | Link |
Registered User
Join Date: Oct 2001
Location: Region 2
Posts: 427
|
Thanks, that's a good idea.
I would think 1920x1088 would be better, but that resolution did not fix it. But I know that resizing to 1936x1090 works. So i added 16 and 10, and that works! video=video.AddBorders(0,0,16,10) video=KNLMeansCL(video,d=1, a=2, s=4, h=2, device_type="GPU", device_id=0) video=video.Crop(0,0,-16,-10) |
9th September 2020, 17:03 | #1449 | Link | |
Acid fr0g
Join Date: May 2002
Location: Italy
Posts: 2,542
|
Quote:
Unfortunately no orphaned opencl*.* around. Reverted to 452.06 and everything works again.
__________________
@turment on Telegram |
|
16th October 2020, 12:37 | #1451 | Link |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
bug when using rclip and prefetch at least with https://github.com/pinterf/KNLMeansCL (didn't test the others since they not work with last avs+ now)
Code:
ColorBars(width=640, height=480, pixel_type="yv24").Trim(0,1000).Subtitle("Testing",align=5,size=200) Animate(0, 500, "Crop", \ 0, 0, 300,400, \ 316, 0, 300,400) KNLMeansCL(rclip=Blur(1)) prefetch(8) the problem is there even without rclip, but it's worst with rclip and it also showed with d=0 using SetFilterMTMode("KNLMeansCL",3,true) or SetFilterMTMode("KNLMeansCL",2,true) will fix it edit: with real encoding, even SetFilterMTMode("KNLMeansCL",3,true) is not fully fix it, it only make it showed in less frames edit: I tried with another device with only opencl on cpu, and it work fine! the one above was using intel gpu edit: seems it also showed in opencl on cpu device, but not in the frame that I refreshed but in next 2 or 3
__________________
See My Avisynth Stuff Last edited by real.finder; 16th October 2020 at 13:06. |
22nd October 2020, 22:39 | #1452 | Link |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
also I note that KNLMeansCL (at least with mcKNLMeansCL) in very complex scripts even without prefetch case random deadlock but the cpu usage will stay high in x264/avspmod with no progress
__________________
See My Avisynth Stuff |
12th November 2020, 13:56 | #1453 | Link | |
Registered User
Join Date: Jan 2014
Posts: 2,309
|
Quote:
https://github.com/pinterf/KNLMeansC...es/tag/v1.1.1e |
|
13th November 2020, 03:23 | #1454 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
__________________
See My Avisynth Stuff |
|
17th December 2020, 09:41 | #1455 | Link | |
Registered User
Join Date: Nov 2014
Posts: 440
|
Quote:
I'm joking, of course. EDIT. Seriously, I have never added support for 9-15 bits formats because I think it is a waste of memory. In the best of scenarios, they are as fast as the 16-bit format... so why bother?
__________________
github.com Last edited by Khanattila; 17th December 2020 at 09:57. |
|
17th December 2020, 14:48 | #1457 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
I have same question and also https://forum.doom9.org/showthread.php?t=182126
__________________
See My Avisynth Stuff |
|
17th December 2020, 15:52 | #1459 | Link |
I'm Siri
Join Date: Oct 2012
Location: void
Posts: 2,633
|
Even first going up to int16 or directly to fp32, then simply applying truncation to convert the bitdepth to something like int10 before encoding would be better than an int10 processing line. clueless users should be banned from touching filters before they understand how error propagation works.
|
18th December 2020, 12:07 | #1460 | Link | ||
Registered User
Join Date: Nov 2014
Posts: 440
|
Quote:
Anyway, you are probably right; I wrote the program 6 years ago, while I was studying C and OpenCL, and anyone can notice it by style in which I wrote it. Quote:
To talk about KNLMeansCL ... I don't think it's worth it. Let me be clear, I am glad that there is someone who takes care of it but OpenCL support is a complete disaster, and will not improve. If today I work on it actively, I will try to do it again in C ++ and Vulkan. "Tensorflow on open source GPUs" - David Airlie (LCA 2020)
__________________
github.com Last edited by Khanattila; 18th December 2020 at 12:42. |
||
Thread Tools | Search this Thread |
Display Modes | |
|
|