Intel QuickSync Decoder - HW accelerated FFDShow decoder with video processing

[cybersans]

rainydog: right. never use windowsupdate driver installation. they just use basic driver without any custom settings and add-ons

egur: i forgot about that.
QS works well for all mp4, mkv movie i just play, accept 1 mkv files seems like the video is fast than sound. when i check the movie fps @ ffdshow video vonfiguration/info & cpu, it says 59.99
i think that might be a problem with that video and not decoder itself since others video just fine.
the funny things is, if i change to libavcodec for h.264, the video become slower/stutter than audio movie fps seems like around 29.99, drop to 12, and then 15, back to 29 and so on.

[pulbitz]

Originally Posted by pulbitz

strange...

I test MPC-HC, KMPlayer and PotPlayer with LAV splitter 32bit.

Only ffdshow QuickSync like yadif output mode 25p/30p.
Other(LAV QuickSync, PotPlayer QuickSync, DXVA and libavcodec) like yadif output mode 50p/60p.

I tested new 0.32 beta.
movies fps is double frame rate.
but motion is 25p/30p. (not doubling frame rate)

moviefps.png:

sample files
20090725.Music_Core.IU.You_know.MPEG2.ts
http://www.sendspace.com/file/qg251f
premiere-paff.AVC.ts
http://www.sendspace.com/file/pvw8xb

[egur]

Originally Posted by cybersans

...
QS works well for all mp4, mkv movie i just play, accept 1 mkv files seems like the video is fast than sound. when i check the movie fps @ ffdshow video vonfiguration/info & cpu, it says 59.99
i think that might be a problem with that video and not decoder itself since others video just fine.
the funny things is, if i change to libavcodec for h.264, the video become slower/stutter than audio movie fps seems like around 29.99, drop to 12, and then 15, back to 29 and so on.

Please share your faulty clip or part of it.

Originally Posted by pulbitz

I tested new 0.32 beta.
movies fps is double frame rate.
but motion is 25p/30p. (not doubling frame rate)

moviefps.png:

sample files
20090725.Music_Core.IU.You_know.MPEG2.ts
http://www.sendspace.com/file/qg251f
premiere-paff.AVC.ts
http://www.sendspace.com/file/pvw8xb

I made sure that the output is truly 60p on true 60i content - each of the 60 frames is different. I'll check your clips and report back.

Update
The problem is my limited testing. The new frames do have time stamps. This is fine with EVR (on these clips too) but EVR-CP doesn't use those frames and displays 30p.
I'll add time stamps to the missing frames. I hope this doesn't complicate LAV's time stamp correction...
I'll also add a chicken bit to disable the time stamp interpolation.

[egur]

I'm wondering what's the "forced DI" behavior should be:
* On progressive source -> mark as tff/bff according to config and send to DI. Output normal/double rate according to config.
* On interlaced source - do not override tff/bff flags. Normal DI operation.
* On 3:2 content - perform soft telecine.Output 23.976p.

Anyone has suggestions/comments on this behavior?
I'm not using this feature myself so I'm not aware of the use cases...

Update:
By mistake, the detail filter is working at 50% in the last ffdshow build (only the 0.32 build).

[nevcairiel]

Soft Telecine should also be DI'ed when force is on, although only single rate.

[cybersans]

EDITED: the video has been uploaded at my latest posts.

[egur]

Originally Posted by nevcairiel

Soft Telecine should also be DI'ed when force is on, although only single rate.

Do you mean output 29.97fps for 3:2 content?
How is that possible when there are only ~24 frames per second?
Why not repeat behavior for double rate?
What's he use case? Where does this happen?

[cybersans]

guys,

here is the mkv video i told you about:
https://rapidshare.com/files/1911724...00h19m38s_.mkv

using latest ffdshow, decode using quicksync video become faster than sound.
decode using libavcodec its stutter.

[nevcairiel]

Originally Posted by egur

Do you mean output 29.97fps for 3:2 content?

Why would the number of frames increase just because i deinterlace them? Just send the 24 frames through the deinterlacer, so that a wrong encoded movie will get its interlacing artifacts removed.
The fps or any other attributes should be irrelevant. If you deinterlace, you either produce one frame per field (double rate), or one frame per two fields (single rate), either doubling the fps, or well, not. Which FPS that is, is irrelevant.

[egur]

Originally Posted by cybersans

guys,

here is the mkv video i told you about:
https://rapidshare.com/files/1911724...00h19m38s_.mkv

using latest ffdshow, decode using quicksync video become faster than sound.
decode using libavcodec its stutter.

I'll take a look.

Originally Posted by nevcairiel

Why would the number of frames increase just because i deinterlace them? Just send the 24 frames through the deinterlacer, so that a wrong encoded movie will get its interlacing artifacts removed.
The fps or any other attributes should be irrelevant. If you deinterlace, you either produce one frame per field (double rate), or one frame per two fields (single rate), either doubling the fps, or well, not. Which FPS that is, is irrelevant.

No problem, just wanted to get his right.

[egur]

@cybersans,
This clip uses an H264 feature which I didn't encounter yet - frame doubling.
ffdshow's telecine manager (with libavcodec as decoder) thinks it's 3:2 so it performs soft inverse telecine (to 23.976fps) wrongly.
My decoder improperly treats this flag causing the DI to fail and output 29.97fps. I didn't see any playback problem or sync issues when using EVR as render under ZoomPlayer.
The flags that come out out my decoder mark this clip as interlaced and left to the mercy of the renderer's deinterlacer.

The clip itself is marked as 59.94fps with real 29.97fps and every frame doubled.
I'll have a fix in a few days.

[cybersans]

egur: thank you for your response. i think like that too, because previous version ffdshow can play that clip flawlessly.
will wait for your latest release.

[nevcairiel]

Originally Posted by egur

No problem, just wanted to get his right.

Looks good so far.
One option i'm still missing right now is an option to override the field order for all content, not just when "force" is on. Sometimes the flags in the files are wrong, and an option to override that is a quick fix.

Oh, and for the forced mode i would prefer it to only overwrite the tff/bff flags if none was deteremined from the bitstream, so that i can activate force on interlaced material without the flags being overwritten.

Aaand another problem. It seems to crash when i try to play an interlaced file with DI (and all other VPP) turned off. Progressive seems fine.

[egur]

Originally Posted by nevcairiel

Looks good so far.
One option i'm still missing right now is an option to override the field order for all content, not just when "force" is on. Sometimes the flags in the files are wrong, and an option to override that is a quick fix.

Oh, and for the forced mode i would prefer it to only overwrite the tff/bff flags if none was deteremined from the bitstream, so that i can activate force on interlaced material without the flags being overwritten.

Aaand another problem. It seems to crash when i try to play an interlaced file with DI (and all other VPP) turned off. Progressive seems fine.

I can implement the features.
I can't reproduce a crash, please detail the setup used.

[nevcairiel]

Originally Posted by egur

I can't reproduce a crash, please detail the setup used.

Debug build of LAV here:
http://files.1f0.de/lavf/LAVFilters-QSDI-debug.zip

Options are tied into the QS settings, if i set deinterlacing to none/weave, it just crashes.

Sample used:
http://files.1f0.de/samples/Test_cli...94.ac3.5.1.mkv

It only crash if:
- bEnableVideoProcessing is 1
- bVppEnableDeinterlacing is 0
- Detail/Noise options are 0

If i set bEnableVideoProcessing to 0, or activate one of the processor options, it works.

[egur]

Originally Posted by nevcairiel

Debug build of LAV here:
http://files.1f0.de/lavf/LAVFilters-QSDI-debug.zip

Options are tied into the QS settings, if i set deinterlacing to none/weave, it just crashes.

Sample used:
http://files.1f0.de/samples/Test_cli...94.ac3.5.1.mkv

It only crash if:
- bEnableVideoProcessing is 1
- bVppEnableDeinterlacing is 0
- Detail/Noise options are 0

If i set bEnableVideoProcessing to 0, or activate one of the processor options, it works.

I'll take a look tonight.

Regarding overriding TFF/BFF flags, it's strange that you don't want to override them in forced mode if they exist - they may be wrong - isn't this the purpose of this feature?
I can do this either way (always override and override when missing), your call.

[nevcairiel]

Originally Posted by egur

Regarding overriding TFF/BFF flags, it's strange that you don't want to override them in forced mode if they exist - they may be wrong - isn't this the purpose of this feature?
I can do this either way (always override and override when missing), your call.

"Force" mode is mostly to send progressive frames through DI, in case someone encoded interlaced frames as progressive (it happens).
On the other hand i don't want to influence the deinterlacing of an interlaced file even when "Force" is active.

I just want those two options to be separate, so they can be used independently. Force DI, and Force a specific field order.
A user might activate "Force", but still leave field order at "Auto". He may then play a normal interlaced file, and he would not want the field order flags overriden. Especially in broadcasts, it also happens that half of the frames are marked progressive, the other half interlaced, yet all need to be deinterlaced. In this situation, i would want to obey the flags from the interlaced frames, and only set the fallback flag for the progressive frames that don't have any.

So to conclude, you really need 3 options:

- Force DI
- Field Order
- Force Field Order

Field Order would then only be used when its not available otherwise (ie. on progressive frames), or when force field order is true.

[egur]

Originally Posted by nevcairiel

"Force" mode is mostly to send progressive frames through DI, in case someone encoded interlaced frames as progressive (it happens).
On the other hand i don't want to influence the deinterlacing of an interlaced file even when "Force" is active.

I just want those two options to be separate, so they can be used independently. Force DI, and Force a specific field order.
A user might activate "Force", but still leave field order at "Auto". He may then play a normal interlaced file, and he would not want the field order flags overriden. Especially in broadcasts, it also happens that half of the frames are marked progressive, the other half interlaced, yet all need to be deinterlaced. In this situation, i would want to obey the flags from the interlaced frames, and only set the fallback flag for the progressive frames that don't have any.

So to conclude, you really need 3 options:

- Force DI
- Field Order
- Force Field Order

Field Order would then only be used when its not available otherwise (ie. on progressive frames), or when force field order is true.

OK.
BTW, aren't the DI options in LAV mutually exclusive: Force DI/Aggressive DI/force progressive?

[nevcairiel]

Originally Posted by egur

BTW, aren't the DI options in LAV mutually exclusive: Force DI/Aggressive DI/force progressive?

Yes they are, but that says nothing about field order

All these options need to be able to be on all the time (especially aggressive is active for quite some people), without breaking decoding of properly flagged interlaced material, which is why i want "Forced DI" to be separate from the "Force Field Order" flag.

[egur]

Committed r57 to SVN:
* Fixed several issues/bugs with deinterlacing - also checked with LAV debug posted earlier.
* Added support for H264 frame doubling/tripling flags.
* Added support for forcing a field order (bForceFieldOrder) - independent of actual deinterlacing. Options are auto (do nothing), bff, tff via new config parameter (eFieldOrder).
* Forced DI behavior - convert progressive and 3:2 frames to interlaced using either the first frame's interlaced flag (if not progressive) or the eFieldOrder config parameter. Setting eFieldOrder to auto will cause forced DI to use TFF.

Note - field order is only visible in true interlaced content (e.g. a frame consists of 2 field from different times) and the output is full rate (50p, 60p).

DI full rate operation is capped at 60i.
Forcing DI on 24p will result in 48p. There's no check for input frame rate other than it's equal or smaller than 30fps.

Performed limited testing, if all goes well I'll build a new test version (0.33).