ffdshow tryouts project: Discussion & Development

[clsid]

In other places this is used for C99 code that MSVC doesn't like:

#if __STDC_VERSION__ >= 199901L
// original code
#else
// MSVC code
#endif

[STaRGaZeR]

Originally Posted by fastplayer

Wait a sec. This custom code is only to make libavcodec "compatible" for MSVC, right? If yes, au revoir "custom code"!
If somebody needs a MSVC debug/release version of libavcodec, he or she can figure out how to circumvent those compile errors temporarily, IMO.

Yep. But this custom code (the .something stuff MSVC doesn't support like in here) is already in basically all decoders, making copy/paste updates impossible aka making ffmpeg updates a pain in the ass. I think nobody has compiled libavcodec with MSVC in a loooong time, otherwise this would be fixed. What to do?

[tetsuo55]

We compile libavcodec with msvc all the time over at MPC-HC, maybe you could take a look at the code?

[clsid]

The errors are only in the recently added AAC decoder. I don't mind any extra custom code to allow MSVC compilation.

[STaRGaZeR]

There are also unresolved externals because libavutil (cpu.c) is outdated, because it can't find log2f and exp2f, etc. Have you considered creating a new folder (like libavcodec_msvc or something like that) with all these changes to compile libavcodec with MSVC and keep the normal one clear?

[clsid]

That would mean extra work. Getting it to compile with MSVC is not a high priority right now. It will get fixed eventually.

[STaRGaZeR]

Yeah, also it wouldn't make much sense. Now that I've taken a closer look at it there's custom code everywhere, not related to MSVC compilation.

[_xxl]

Originally Posted by STaRGaZeR

Yeah, also it wouldn't make much sense. Now that I've taken a closer look at it there's custom code everywhere, not related to MSVC compilation.

That is true. FFdshow has a lot of custom code...

[Sebastiii]

hi STaRGaZeR,

I try to compil 3600 but i have an error, i build with the .bat (build_x86.bat), i go to try with the sln.
Thanks,
Seb.

Ps: i didn't know if it's 3600 that break the compil.
It's the innosetup, if i compil the .exe with .iss it's ok

Ok found it lol : in batch @cd bin\distrib\innosetup but for me it's @cd bin\distrib

Edit : Thanks for the fix

[STaRGaZeR]

Fixed

[rica]

Guys, i must have missed something.
ffdshow 3574 decodes DTSHD-MA; downsamples 96 to 48 but not 24 to 16 with libdts.
Is it correct?

[nevcairiel]

All it decodes is dts core, which only contains 48Khz samples. But at least it provides full bit depth in decoding, afaik (remember, lossy formats don't have a pre-defined bit depth, you should decode with as much precision as you can)

[rica]

Yes, that is still what it's doing. Thx.

[Ap3 n1nja]

Hi, I not sure if this goes here but there seems to be a certain problem getting ffdshow's AAC libavcodec to work with the KMPlayer. I think the problem might be with the internal KMP MKV Splitter since I tested it with MatroskaSplitter.ax and its internal MOV/MP4 splitter and it worked fine.

Versions Used:
KMPlayer 3.0.0.1438
ffdshow rev3600 20100925 xhmikosr icl11

[dann23]

I have a problem when using LAVFSplitter. External subtitles don't work when using ffdshow dxva and when I use normal ffdshow I can't choose beetwen external subtitles present in the same folder as the movie(one subtitles is choosen but I can't choose another one. I have no context menu present). I also posted in LAVFSplitter's thread but nevcairiel said that it's possible that ffdshows is the culprit.
Also is good to know that I'm using wmp11.

[dansrfe]

I'm still having major problems with .ASS or .SSA karoke subtitle tags showing up all over the place.

[Mr. Monte]

I just recently installed FFDSHOW 3572_20100913_clsid. I was using AVStoDVD for converting my MKV's to DVD5's. All of a sudden I was getting AVS script errors. Using graphedit, I was able to determine that FFDSHOW was no longer decoding DTS or AC3 audio. I looked at the configuration and libdts and liba52 is selected. Installing AC3Filter fixed the isues.

Is there anyway to determine why FFDSHOW stopped working with DTS & AC3 (works fine with AAC). Moreover, how to restore it?

TIA

[leeperry]

Originally Posted by STaRGaZeR

To all, testing time again! I've enabled libavcodec's floating point MP1,2,3 decoder instead of the integer one. It should play everything the old one des, but test it and report your findings.

Build: http://www.mediafire.com/?k8y1fakk2ayqoie

cool! if you could do the same for AC3/DTS, this would be really fantastic

[Keiyakusha]

STaRGaZeR
Just a little suggestion. I never saw floating-point build yet but if it will work, could you please keep both variants (16 and 32 bit) if 32bit any slower? Maybe it will be possible to add switch "libavcodec (16bit)" and "libavcodec (32bit)" like it is done for h264 in case of libavcodec and ffmpeg-mt. Also if you know better solution - just skip this post. Thanks.

[leeperry]

Originally Posted by Keiyakusha

I never saw floating-point build yet but if it will work

the only reason to go 32fp for lossy audio is this: http://mp3decoders.mp3-tech.org/24bit.html

it provides a more accurate decoding w/ less rounding errors, very important if you down-upmix/resample/post-process/use Reclock. There isn't a single good reason to decode lossy audio to 16int.