Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
15th February 2017, 09:12 | #102 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
AWarpSharp2 for VapourSynth already has 16 bit and c code, this maybe can make things less hard for port
__________________
See My Avisynth Stuff |
|
20th April 2017, 10:54 | #104 | Link |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
isn't the aWarpSharp2 turn come yet?
__________________
See My Avisynth Stuff |
23rd June 2017, 15:32 | #106 | Link |
Registered User
Join Date: Mar 2011
Posts: 4,829
|
pinterf,
When I use the following in a script (NTSC DVD source) I get an error message "both sources must have the colorspace". It's copy and pasted from the readme. aWarp4(nnedi3_rpow2(rfactor=2).nnedi3_rpow2(rfactor=2), aSobel().aBlur(), depth=2) This works fine though. ConvertToYV16() aWarp4(nnedi3_rpow2(rfactor=2).nnedi3_rpow2(rfactor=2), aSobel().aBlur(), depth=2) The same thing happens with version 2015.12.30. Am I missing something? Cheers. |
8th September 2017, 00:19 | #107 | Link | |
Registered User
Join Date: Nov 2008
Posts: 101
|
Quote:
|
|
27th September 2017, 10:39 | #112 | Link |
Registered User
Join Date: Jan 2014
Posts: 2,314
|
I see that you started investigating this plugin.
Back in May I made some additions, not sync'd up to github yet (avisynth+ headers, high bit depth constants, some helper function) but these are not really used, just prepared them as the first step of the transition. Another modification is that I have moved aSobel to intrinsics (I don't like inline asm, mainly for maintenance reasons, it's more difficult to understand/modify for high bit depth and the possible speed gain (if any) is neglible (at least for aSobel which I have ported already) This was my todo list: - have C versions (either from jackoneill's Vapoursynth port/rewrite or from an earlier version of aWarpSharp, or reverse engineering asm) - move inline asm to intrinsics - Drop tricky asm path such as SSSE3, keep SSE2 only. It's too much work to keep SSSE3, too tricky to understand those shuffles. We are over SSSE3 era, I prefer adding avx2 code instead. - get it work for high bit depth - add new user requests to the plugin |
27th September 2017, 15:15 | #113 | Link | |
Professional Code Monkey
Join Date: Jun 2003
Location: Kinnarps Chair
Posts: 2,555
|
Quote:
1. The VapourSynth port has effectively done all the work but oh noooo, open source acting like open source and APPROPRIATING ALL THE USEFUL WORK RIGHT NOW! is far too much to expect apparently... 2. The idea of a unified codebase never seems to have crossed your mind. It would be fairly simple to add in avs+ support to many existing VapourSynth plugins with a small and menial patch. Even other lesser coders could possibly be convinced to help. But nope. Not gonna do that either. 3. The insane idea to base the new C code off the asm. Most original C to asm conversions weren't tested for being identical with the C version because asm is typo prone and testing isn't for Avisynth developers. Therefore starting from the most likely to be wrong code is hilarious to me 4. ZOMG OPTIMIZE is a horrible strategy in general. I bet your avx2 version at most will be 3% faster than the same sse2 code for warpsharp. 5. If you can't grasp ssse3, then how do you expect to effectively use a superset of it with split lanes in avx2? 6. Seriously dude, what desired feature apart from avs+ compatibility didn't jackoneill implement already?
__________________
VapourSynth - proving that scripting languages and video processing isn't dead yet |
|
27th September 2017, 16:03 | #114 | Link | ||
Registered User
Join Date: Jan 2014
Posts: 2,314
|
Quote:
Personally, I never had to deal with open source things previously, perhaps I'm too old to accept immediately the obvious rules of (not so) current trends, but I'll try to, I promise In the past I tried to avoid the situation when someone - whose work and time I really appreciate - is spending weeks or months on brand new things and the product then appears elsewhere only with the effort of porting. Quote:
Nor did I analyze the code yet, whether avx2 is feasible or not for warpsharp or for any components. When someone who wins this project will plunge into the details, will see whether avx2 is usable or not and in which parts. |
||
27th September 2017, 16:21 | #115 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,316
|
Yes, for now, i'm just moving inline asm in external asm files, and the purpose is to break nothing doing this.
Others things will come later. I didn't thought of searching previous versions for C code, but i will search if such a thing exist. It could be eventualy a good complement to the C vapoursynth version. |
27th September 2017, 20:56 | #116 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
but tp7 said that prunedtree can give the source for deen (also made by Marc FD maybe he is the same person) if you talk to him in rizon IRC even though awarpsharp2 is less bugs than original awarpsharp, I note that original awarpsharp give better warp for chroma with same settings
__________________
See My Avisynth Stuff |
|
27th September 2017, 23:03 | #117 | Link |
Professional Code Monkey
Join Date: Jun 2003
Location: Kinnarps Chair
Posts: 2,555
|
MarcFD and prunedtree is the same person
__________________
VapourSynth - proving that scripting languages and video processing isn't dead yet |
27th September 2017, 23:28 | #118 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,316
|
I took a closer look at the vapoursynth C code. Finaly it seems proper and well made, trying to keep the names of the variables and the structure as close as possible from the original code. It a very good job well made by jackoneill.
|
|
|