Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
4th November 2012, 14:19 | #1001 | Link | ||
Registered User
Join Date: Oct 2001
Location: Germany
Posts: 7,277
|
Quote:
Quote:
|
||
4th November 2012, 14:31 | #1002 | Link |
Registered User
Join Date: May 2012
Location: Here
Posts: 257
|
I suppose it helps nothing, since we cannot compare (and you know what my preferences are ), but for example Handbrake detects this source autocropping as 696x426 (not mod4, but they don't use mplayer but some internals) and PAR 5568x3905 (?), that is 1.426. The reported DAR is 2.32:1
Does this help? |
4th November 2012, 14:47 | #1004 | Link |
Registered User
Join Date: May 2012
Location: Here
Posts: 257
|
Well, if we can manually adjust the cropping and keep filtering, it would be enough for these difficult sources.
My problem now is how to overcome the problem when mediainfo reports a wrong PAR (probably because the flag in the source is wrong). Did you take a look at the source sample?. Does it give you the same results as it did with me?. |
4th November 2012, 14:59 | #1005 | Link | |||
Registered User
Join Date: Oct 2001
Location: Germany
Posts: 7,277
|
Quote:
Width : 720 pixels Height : 576 pixels Pixel aspect ratio : 1.896 Display aspect ratio : 2.370 Display aspect ratio : 2.40:1 Quote:
Problem might be rooted in: 1. Copy protection that writes wrong headers, which are not fixed by the ripper you use 2. MediaInfo simply misinterpreting the headers. -> 1st thing I would try is to use another application to rip the dvd to hdd an check if the headers change. Quote:
|
|||
4th November 2012, 15:09 | #1006 | Link | |||
Registered User
Join Date: May 2012
Location: Here
Posts: 257
|
Quote:
Did you try autocrop?. Is autocrop done exclusively in mplayer/mencoder, or is there any detection algorithm in Hybrid to detect cropping? Quote:
Quote:
|
|||
4th November 2012, 15:17 | #1007 | Link | |
Registered User
Join Date: Oct 2001
Location: Germany
Posts: 7,277
|
Quote:
Cu Selur Ps.: uploaded new version for testing PPs.: seems like ffprobe detects the aspect ratio properly,... same for mplayer during playback, but not with -frames 0 (where only the headers get checked), so seems like the headers are wrong, and the aspect ratio stored in the stream itself is correct,.. Last edited by Selur; 4th November 2012 at 15:28. |
|
4th November 2012, 16:57 | #1010 | Link |
Registered User
Join Date: May 2012
Location: Here
Posts: 257
|
Don't ask me difficult questions...
I'm in the (confortable) user side. I would compare mplayer and ffprobe output, and in case of discrepancies, ask for user input. Of course it may lead to errors, it's better to offer a single solution and not depend on variable user skill or taste. I assume that sometimes a bad PAR encoded signal in stream may be corrected with a correct PAR signal in header, isn't it?. Or will PAR in stream be always correct? As you see I have no skills in this matter, just from the user point of view. Just thinking in loud voice... |
4th November 2012, 16:59 | #1011 | Link |
Registered User
Join Date: Oct 2001
Location: Germany
Posts: 7,277
|
adding ffprobe would mean adding another dependency,.. not really looking forward to that, if I find the time I'll look with a hex editor at the file to see if may be MediaInfo is just wrong
-> added a 'bug' to the mediainfo bug tracker zenitram can probably tell better what is going on. Last edited by Selur; 4th November 2012 at 17:13. |
4th November 2012, 17:19 | #1012 | Link |
Registered User
Join Date: May 2012
Location: Here
Posts: 257
|
I tried last version.
When I load this problematic source and I set cropping to 704x426 it disables filtering. When changing it to 704x428, filtering is back again. Good!! Some button in the GUI, as there's in the resizing part, to adjust vertical cropping to mod4?. [I hope this did not sound as the typical irritating suggestion from an user 'asking' things to developer. Just a sugestion if you find it may improve Hybrid...] |
4th November 2012, 17:23 | #1013 | Link | |
Registered User
Join Date: Oct 2001
Location: Germany
Posts: 7,277
|
Quote:
|
|
4th November 2012, 17:35 | #1015 | Link |
Registered User
Join Date: Oct 2001
Location: Germany
Posts: 7,277
|
Right, it does not hinder you from using non-mod4 values. Hybrid assumes that you know what you are doing.
I think it's a bad idea to add an 'adjust to modulo X' option, simply because sometime you might want to overcrop and sometime you might what to undercrop. If it helps, I could add an option to color the width&height numbers red is non-mod-X values are selected,... |
4th November 2012, 17:49 | #1016 | Link |
Registered User
Join Date: May 2012
Location: Here
Posts: 257
|
Well, it also could be, as a reminder.
It's your (very good) creation, and you're the best one to make it work the way you have it in your brain. Related to Hybrid assuming every user know what is doing... I'm the first one that forgot once to adjust cropping to mod4... |
4th November 2012, 18:08 | #1019 | Link |
Registered User
Join Date: Oct 2001
Location: Germany
Posts: 7,277
|
no, that was a suggestion for a feature I could add.
The latest version I uploaded should enforce mod4 for autocrop on dvd input, it does not hinder you from changing the detected crop values in any way. |
Thread Tools | Search this Thread |
Display Modes | |
|
|