Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
7th March 2017, 12:59 | #141 | Link | |
Registered User
Join Date: Jan 2017
Posts: 10
|
Quote:
In practice this doesn't quite hold, looking for example at the \blur2+, \fax, \fay tags, those are as common as always and then there are the obvious resolution hacks in XySubFilter and AssFilterMod, things which are just too good to not have. Still, both xy-VSFilter and libass aim to be VSFilter compatible and xy-VSFilter is so close, you could consider it standard. Can't say much about XySubFilter, I've tested it once and had problems with subs not being properly placed in some videos but not in others. It's weird, the filter seemed to believe the video is larger than it actually is and there were no shenanigans going on with aspect ratio or script resolution, just a 720p video with a 720p script that doesn't get placed right, except when you use \pos, that somehow fixes the issue. So yeah, I don't use XySubFilter for that reason, development also seems to have stopped. Just for the sake of it and not being completely offtopic, I tested XySubFilter on the above video. It doesn't flicker and it looks identical to the fixed script in xy-VSFilter (well, except for the resolution). edit: Oops, Jtacdf snuck in while I wrote my response, at least it's confirmed now. Last edited by CCat; 7th March 2017 at 13:12. |
|
7th March 2017, 14:36 | #143 | Link | ||
Quality Checker
Join Date: Aug 2013
Posts: 285
|
Quote:
Quote:
ps : i am a little curious about results
__________________
I love Doom9 |
||
7th March 2017, 16:42 | #146 | Link | |
Quality Checker
Join Date: Aug 2013
Posts: 285
|
Quote:
so i think ISR have decent code compare it to VSFilter
__________________
I love Doom9 |
|
8th March 2017, 10:15 | #147 | Link | ||
Registered User
Join Date: Jan 2017
Posts: 10
|
Quote:
Quote:
But just to let you know, the "VSFilter" screenshots are actually from ISR, directly out of MPC-HE and I did also test this 2008 version of VSFilter through AviSynth, same results, both don't flicker, but as clsid already said, this should not surprise, as ISR practically is VSFilter and that's also why I called it that. Also, amayra, if you are so curious, why not open the player yourself, it's really not that hard. P.S. Sorry for derailing the thread, this really isn't about AssFilterMod anymore. |
||
8th March 2017, 14:19 | #149 | Link | |
Quality Checker
Join Date: Aug 2013
Posts: 285
|
Quote:
and there one more think i made improved fork of AssFilterMod and i would try to fix your problem before i send my Pull requests
__________________
I love Doom9 Last edited by amayra; 9th March 2017 at 13:50. Reason: i hate autocomplete |
|
8th March 2017, 19:33 | #150 | Link | |||
Registered User
Join Date: Nov 2011
Posts: 61
|
Quote:
Quote:
Screenshots of the difference: Without experimental: https://i.imgur.com/20wSgYv.jpg With experimental: https://i.imgur.com/iQx9lvV.jpg Quote:
On a good note, the new nightly version of MPC-HC has added my pull request to add AssFilterMod to the list of subtitles renderer. So i won't update my mpc-hc fork and make builds anymore.
__________________
Latest dev builds of AssFilterMod can be found here: https://www.mediafire.com/folder/w1w...s/AssFilterMod Last edited by Blitzker; 8th March 2017 at 19:40. |
|||
8th March 2017, 21:49 | #151 | Link | ||
Registered User
Join Date: Jan 2017
Posts: 10
|
Quote:
I just tested XySubFilter as well and it also has the bigger spacing, so VSFilter/ISR seems to be the odd one out in that regard. Quote:
Or did you test that already when you say you cannot reproduce the problem? The scene where the screenshots with spacing differences come from is at the 00:46.462 to 00:52.636 timemark, but you should see it everywhere. Ah, that's good to hear, because that means it's not a direct issue with harfbuzz. Makes me wonder though if the problem is more of the side of the stroker or of the side of the fonts, maybe there's a reason that there are seemingly random points in those kanji glyphs, but to a layman's eye those look like errors. Last edited by CCat; 8th March 2017 at 22:06. |
||
9th March 2017, 11:17 | #152 | Link |
Registered User
Join Date: Aug 2010
Posts: 49
|
Here is another problematic file that does not play nice with AssFilterMod v0.1, 0.2, 0.3. Probably related to libass.
https://mega.nz/#!UsR1AIoC!jqweOJhzW...3zV3NjC7mv34Uc With the default heavy Kfx ass file, the front/end of each karaoke sentence display as transparent and seems "chopped" off. There is also some misalignment of the white fill fx. Works fine with XySubFilter and MPC-HC/BE ISR.
__________________
Core i7 4790K@4.6Ghz - Asus Maximus VII Formula - AMD R9 290X 4GB Crossfire - Windows 10 Pro x64 Last edited by Jtacdf; 9th March 2017 at 11:21. |
9th March 2017, 18:30 | #153 | Link | |
Registered User
Join Date: Jan 2017
Posts: 10
|
Quote:
From what I know, the "@" is supposed to flip (certain?) kanji on it's side, which has uses in vertical writing I believe, but in this case it seems to also shrink the size of the font, here's a comparison out of Aegisub (xy-VSFilter): If you change the subtitle provider to libass, both fonts are of the larger size, which is the cause for what you're seeing. The OP was designed with (xy-)VSFilter in mind, so the larger font gets cut off on the sides by \clips (which are used for colored stripes in the text) and because the white fx was generated to fit on the smaller font, it's misaligned. |
|
18th April 2017, 22:00 | #154 | Link |
*****
Join Date: Feb 2005
Posts: 5,647
|
A bug report:
https://trac.mpc-hc.org/ticket/6132 |
19th April 2017, 23:08 | #155 | Link | |
Registered User
Join Date: Nov 2011
Posts: 61
|
Quote:
I'll release it when i've made more testing of different UTF-8 strings.
__________________
Latest dev builds of AssFilterMod can be found here: https://www.mediafire.com/folder/w1w...s/AssFilterMod |
|
20th April 2017, 00:18 | #156 | Link |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,346
|
Thats how it is, Windows is internally all UTF-16 (ie. wchar_t), and file access should convert to that, the plain char APIs don't take UTF-8, only plain ASCII. MultiByteToWideChar is what you want to use to go from UTF-8 to UTF-16.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders |
20th April 2017, 21:40 | #157 | Link |
Registered User
Join Date: Nov 2011
Posts: 61
|
Yes, MultiByteToWideChar is what i use to convert UTF-8 to UTF-16. Still, i spent a bit of time wondering what was wrong till i decided to google for that info. At least its something i won't forget!
__________________
Latest dev builds of AssFilterMod can be found here: https://www.mediafire.com/folder/w1w...s/AssFilterMod |
20th April 2017, 21:54 | #158 | Link |
Registered User
Join Date: Nov 2011
Posts: 61
|
Here is a new version of AssFilterMod that should fix the problem with unicode path names. The simple way to do it was to fix libass to support UTF-16 but i'm still not sure if i'll go with that or support it only in assfiltermod (more work).
Anyway, i decided to release a test build so users can test files with unicode paths. x32: assfiltermod_utf-8_x32.zip x64: assfiltermod_utf-8_x64.zip I also made a build with harfbuzz and a new version of the experimental stroker which fix the dots on some japanese fonts. x32: assfiltermod_harfbuzz_x5_x32.zip x64: assfiltermod_harfbuzz_x5_x64.zip
__________________
Latest dev builds of AssFilterMod can be found here: https://www.mediafire.com/folder/w1w...s/AssFilterMod |
9th May 2017, 08:19 | #159 | Link |
Registered User
Join Date: Mar 2017
Posts: 7
|
I am trying to use assfiltermod with kodi dsplayer but it can only display embedded subs. It won't load external srt files. My files srt files are in the correct format ie same file name and 2 letter language code. It is working fine in mpc-hc. Any idea why the external srt files won't display in kodi displayer?
|
12th May 2017, 12:59 | #160 | Link |
Registered User
Join Date: Jun 2007
Posts: 656
|
May I ask why the decision of starting almost from scratch instead of working on improving XySubFilter? Was it not open sourced?
Simple curiosity, not criticism of any kind, as devs are clearly free to do whatever the hell they want with their own time. |
Thread Tools | Search this Thread |
Display Modes | |
|
|