Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Video Encoding > MPEG-4 AVC / H.264

Reply
 
Thread Tools Search this Thread Display Modes
Old 16th June 2008, 10:53   #401  |  Link
wyti
Insane Encoder
 
wyti's Avatar
 
Join Date: Feb 2008
Location: Lausanne (Switzerland)
Posts: 142
Can anyone compile a patch with me-prepass ? Or the patch is actually borked ?
wyti is offline   Reply With Quote
Old 16th June 2008, 11:58   #402  |  Link
Sagittaire
Testeur de codecs
 
Sagittaire's Avatar
 
Join Date: May 2003
Location: France
Posts: 2,419
Quote:
Originally Posted by wyti View Post
Can anyone compile a patch with me-prepass ? Or the patch is actually borked ?
from the author of pre-pass ...

Quote:
ME-prepass is just a simple ugly hack to do tons of hex searches. Its not particularly pretty or efficient
Use most available patch doesn't mean always better quality!
__________________
Le Sagittaire ... ;-)

1- Ateme AVC or x264
2- VP7 or RV10 only for anime
3- XviD, DivX or WMV9
Sagittaire is offline   Reply With Quote
Old 16th June 2008, 12:35   #403  |  Link
wyti
Insane Encoder
 
wyti's Avatar
 
Join Date: Feb 2008
Location: Lausanne (Switzerland)
Posts: 142
True but.
Dark Shikari isn't the author of pre-pass

And I ask this because I tried it, and I use it with a lot of my encodes (I usually encore small clips of 2-3 minutes) and it give me better results than --me esa.
wyti is offline   Reply With Quote
Old 16th June 2008, 13:42   #404  |  Link
Sharktooth
Mr. Sandman
 
Sharktooth's Avatar
 
Join Date: Sep 2003
Location: Haddonfield, IL
Posts: 11,768
dark shikari IS the author... iirc death the sheep just kept it up to date.
Sharktooth is offline   Reply With Quote
Old 16th June 2008, 13:53   #405  |  Link
wyti
Insane Encoder
 
wyti's Avatar
 
Join Date: Feb 2008
Location: Lausanne (Switzerland)
Posts: 142
Thanks for the explanation, but what about this patch itself, is it borked, or no one want to use it ?
wyti is offline   Reply With Quote
Old 16th June 2008, 14:10   #406  |  Link
Dark Shikari
x264 developer
 
Dark Shikari's Avatar
 
Join Date: Sep 2005
Posts: 8,689
Quote:
Originally Posted by wyti View Post
Thanks for the explanation, but what about this patch itself, is it borked, or no one want to use it ?
I'm too lazy to keep it updated with all the changes I've been making to me.c, I never figured out entirely why it worked at all, and people these days aren't exactly demanding more "lots of time for very little quality boost" improvements anyways.
Dark Shikari is offline   Reply With Quote
Old 16th June 2008, 14:37   #407  |  Link
wyti
Insane Encoder
 
wyti's Avatar
 
Join Date: Feb 2008
Location: Lausanne (Switzerland)
Posts: 142
Ok thanks, but i think that with the good speed boost, we can introduce some quality boost too.

if I understand, the patch isn't dead, but someone have to maintain it ?
wyti is offline   Reply With Quote
Old 16th June 2008, 15:03   #408  |  Link
techouse
Strictly Rhythm
 
techouse's Avatar
 
Join Date: Jul 2007
Location: Ljubljana, Slovenia
Posts: 166
A high --merange and --me esa or tesa would probably give you the same results.
__________________
techouse is offline   Reply With Quote
Old 16th June 2008, 15:07   #409  |  Link
wyti
Insane Encoder
 
wyti's Avatar
 
Join Date: Feb 2008
Location: Lausanne (Switzerland)
Posts: 142
Yes but with pre-pass i got about 1.5fps, that was not bad for a 3minutes long clip. But with esa, it is significantly slower, i don't remember the exact numbers, but around 0.8-0.9 fps, with a very slighly better result...
for me umh + prepass was very good.

Now i have to learn how to maintain me-pre-pass patch
wyti is offline   Reply With Quote
Old 16th June 2008, 15:26   #410  |  Link
techouse
Strictly Rhythm
 
techouse's Avatar
 
Join Date: Jul 2007
Location: Ljubljana, Slovenia
Posts: 166
It's quite nasty cause the problem is in the encoder/me.c section which is very SENSITIVE. Good luck.
__________________
techouse is offline   Reply With Quote
Old 16th June 2008, 16:07   #411  |  Link
bob0r
Pain and suffering
 
bob0r's Avatar
 
Join Date: Jul 2002
Posts: 1,337
x264.886.modified.01.exe
x264.886.modified.01.source.zip

x264.psyRDO.0.22.diff
http://forum.doom9.org/showthread.php?t=138293
x264_hrd_pulldown.04_interlace.diff
HRD and pulldown for HD compatibility, updated patch for interlacing
http://forum.doom9.org/showthread.ph...19#post1047919
x264.progress.indication.01.diff
http://forum.doom9.org/showthread.php?t=135905

Link to x264 patches collected: http://files.x264.nl/x264_patches/

Here is the output of the patching process:
http://files.x264.nl/x264.886.modified.01.patch.out.txt

Here is the output of the compiling process:
http://files.x264.nl/x264.886.modifi...ofiled.out.txt


gcc -O4 -ffast-math -Wall -I. -DHAVE_MMX -DARCH_X86 -DSYS_MINGW -DPTW32_STATIC_LIB -DHAVE_PTHREAD -s -fomit-frame-pointer -fprofile-generate -c -o encoder/set.o encoder/set.c
encoder/set.c: In function `x264_sps_init':
encoder/set.c:215: warning: unused variable `cpbBrVclFactor'

gcc -O4 -ffast-math -Wall -I. -DHAVE_MMX -DARCH_X86 -DSYS_MINGW -DPTW32_STATIC_LIB -DHAVE_PTHREAD -s -fomit-frame-pointer -fprofile-use -c -o encoder/encoder.o encoder/encoder.c
encoder/encoder.c: In function `x264_encoder_encode':
encoder/encoder.c:1278: warning: 'cpb_removal_delay' might be used uninitialized in this function


darkorange = x264_hrd_pulldown.04_interlace.diff

The warnings that are not in the GIT code are highlighted with a color, and should not be there.
(The GIT warnings are there because of a bug in Windows, they prevent the usage of extended zones, example: x264 --zones 1,100,bframes=0)
The GIT warnings:

gcc -O4 -ffast-math -Wall -I. -DHAVE_MMX -DARCH_X86 -DSYS_MINGW -DPTW32_STATIC_LIB -DHAVE_PTHREAD -s -fomit-frame-pointer -fprofile-generate -c -o common/common.o common/common.c
common/common.c: In function `x264_param_parse':
common/common.c:252: warning: unused variable `saveptr'

gcc -O4 -ffast-math -Wall -I. -DHAVE_MMX -DARCH_X86 -DSYS_MINGW -DPTW32_STATIC_LIB -DHAVE_PTHREAD -s -fomit-frame-pointer -fprofile-generate -c -o encoder/ratecontrol.o encoder/ratecontrol.c
encoder/ratecontrol.c: In function `parse_zone':
encoder/ratecontrol.c:564: warning: unused variable `saveptr'
encoder/ratecontrol.c: In function `parse_zones':
encoder/ratecontrol.c:607: warning: unused variable `saveptr'
bob0r is offline   Reply With Quote
Old 19th June 2008, 06:59   #412  |  Link
IgorC
Registered User
 
Join Date: Apr 2004
Posts: 1,300
sorry for offtopic
Quote:
Originally Posted by techouse View Post
A high --merange and --me esa or tesa would probably give you the same results.
Could somebody show a clear sample where --merange > 16 and --me (t)esa would be helpfull? Really.
I tested some videos and never have seen where is it so usefull (at all?).

And --me-prepass was more efficient than tesa and merange some time ago.
http://forum.doom9.org/showthread.php?p=1054774

Last edited by IgorC; 19th June 2008 at 07:04.
IgorC is offline   Reply With Quote
Old 19th June 2008, 09:20   #413  |  Link
Sagittaire
Testeur de codecs
 
Sagittaire's Avatar
 
Join Date: May 2003
Location: France
Posts: 2,419
Quote:
Originally Posted by IgorC View Post
sorry for offtopic

Could somebody show a clear sample where --merange > 16 and --me (t)esa would be helpfull? Really.
I tested some videos and never have seen where is it so usefull (at all?).

And --me-prepass was more efficient than tesa and merange some time ago.
http://forum.doom9.org/showthread.php?p=1054774
Well I make a little test with 10 000 frame from Casino Royal (1080p24 at crf 22) and tesa + merange 32 produce something like 1% improvement (lower bitrate and higher metric).
__________________
Le Sagittaire ... ;-)

1- Ateme AVC or x264
2- VP7 or RV10 only for anime
3- XviD, DivX or WMV9
Sagittaire is offline   Reply With Quote
Old 19th June 2008, 18:28   #414  |  Link
IgorC
Registered User
 
Join Date: Apr 2004
Posts: 1,300
Thanks for throw some numbers. I expected practically the same.
But I think it's correct to keep insane settings (tesa, merange). This way user know the limits of encoder and there is no paranoid thoughts about if it's possible to squeeze the last .% of quality when it's necessary.
IgorC is offline   Reply With Quote
Old 20th June 2008, 05:19   #415  |  Link
skystrife
Registered User
 
skystrife's Avatar
 
Join Date: Feb 2007
Posts: 176
x264.889.modified.exe - Source
(alt download link)

Patches:
x264.psyRDO.0.22.diff
x264_hrd_pulldown.04_interlace.diff
x264.progress.indication.01.diff

gcc 3.4.5 fprofiled build

Built in mingw on Windows Vista x64.

Enjoy.

Last edited by skystrife; 21st June 2008 at 10:21. Reason: Added source.
skystrife is offline   Reply With Quote
Old 24th June 2008, 13:13   #416  |  Link
kemuri-_9
Compiling Encoder
 
kemuri-_9's Avatar
 
Join Date: Jan 2007
Posts: 1,348
Hmm.... I think i developed a small patch that relaxes the qpfile to be able to only specify certain frames of the video (i believe this was mentioned as a feature request somewhere)
http://kemuri9.net/dev/x264/x264_qpfile_relax.diff
(based on r889)

if someone else can confirm this for me that would be great

Edit:
Just changed it up a little to increase efficiency on reading the qpfile for only specifying certain frames

Last edited by kemuri-_9; 6th July 2008 at 16:12. Reason: url change
kemuri-_9 is offline   Reply With Quote
Old 25th June 2008, 04:49   #417  |  Link
MythCreator
Registered User
 
Join Date: Dec 2007
Location: Beijing,China
Posts: 77
x264.modified.r891.exe
Source

General thread:
http://forum.doom9.org/showthread.php?t=130364


x264.psyRDO.0.22.diff
http://forum.doom9.org/showthread.php?t=138293
X264_progress.indication.diff
http://forum.doom9.org/showthread.php?t=135905
x264_qpfile_relax.diff.diff
http://forum.doom9.org/showthread.ph...19#post1151919
x264_interlaced_signaling.r886.diff
http://mailman.videolan.org/pipermai...ne/004656.html

Link to x264 patches collected: http://files.x264.nl/x264_patches/


GCC 3.4.5 build fprofiled
MythCreator is offline   Reply With Quote
Old 25th June 2008, 18:18   #418  |  Link
jethro
Registered User
 
Join Date: Mar 2006
Posts: 100
Quote:
Originally Posted by kemuri-_9 View Post
Hmm.... I think i developed a small patch that relaxes the qpfile to be able to only specify certain frames of the video (i believe this was mentioned as a feature request somewhere)
http://kemuri9.net/dev/x264_qpfile_relax.diff
(based on r889)

if someone else can confirm this for me that would be great

Edit:
Just changed it up a little to increase efficiency on reading the qpfile for only specifying certain frames
You mean the feature request in this thread?
http://forum.doom9.org/showthread.php?t=120449

So with your patched qpfile we may e.g., force key frames at specific frames?
jethro is offline   Reply With Quote
Old 25th June 2008, 19:36   #419  |  Link
kemuri-_9
Compiling Encoder
 
kemuri-_9's Avatar
 
Join Date: Jan 2007
Posts: 1,348
Quote:
Originally Posted by jethro View Post
You mean the feature request in this thread?
http://forum.doom9.org/showthread.php?t=120449
Ah yes, there was that thread where I read that.

Quote:
Originally Posted by jethro View Post
So with your patched qpfile we may e.g., force key frames at specific frames?
yes, that's how I've been testing it so far and confirming its success in the stats file.

qpfile (entire file)
Code:
99 I 35
100 I 30
stats
Code:
...
in:99 out:99 type:I q:35.00 itex:326 ptex:0 mv:308 misc:326 imb:1350 pmb:0 smb:0 d:-;
in:100 out:100 type:I q:30.00 itex:224 ptex:0 mv:418 misc:318 imb:1350 pmb:0 smb:0 d:-;
...
I did back-to-back keyframes in an attempt to see if it can override the min-keyint parameter and it does.

The qp for the frame is still mandatory, but that's not too big of a deal in my opinion
kemuri-_9 is offline   Reply With Quote
Old 25th June 2008, 20:05   #420  |  Link
akupenguin
x264 developer
 
akupenguin's Avatar
 
Join Date: Sep 2004
Posts: 2,393
btw, relaxing (qp < 0) to (qp < -1) will let you specify some frames as qp=-1 meaning auto.
It's a bad idea to mix a few auto frames into a lot of forced ones, but the other way around should work.
akupenguin is offline   Reply With Quote
Reply

Tags
h.264, x264, x264 builds, x264 patches, x264 unofficial builds

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 06:34.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.