xy-VSFilter Project (High Performance VSFilter Compatible Subtitle Filters) - Page 9

ryrynz · 27th July 2013, 11:01

Quote:

Originally Posted by madshi

Another option would be to render at video resolution but to blur the subtitles appropriately.

Saw somebopdy suggest that earlier and Cyberbeing said it was on the cards.

cyberbeing · 27th July 2013, 12:29

How to take madVR screenshots with MPC-HC which include XySubFilter subtitles [Updated]

Tornado15550 · 27th July 2013, 19:31

Will there be a 64bit release of xySubFilter?
Right now, I'm running the 64bit release of xy-VSFilter.
Also, is it a must to have MadVR in order for XySubFilter to work?

nevcairiel · 27th July 2013, 20:03

Quote:

Originally Posted by Tornado15550

Also, is it a must to have MadVR in order for XySubFilter to work?

At the moment, madVR is the only thing which supports it, and since madVR is only 32-bit, the 64-bit question answers itself for now.

However, the MPC-HC devs are working on making XySubFilter work with the internal renderers, as well.

Tornado15550 · 28th July 2013, 03:22

Quote:

Originally Posted by nevcairiel

At the moment, madVR is the only thing which supports it, and since madVR is only 32-bit, the 64-bit question answers itself for now.

However, the MPC-HC devs are working on making XySubFilter work with the internal renderers, as well.

Makes sense.
Thanks for the reply.

Asteague · 29th July 2013, 16:06

Quote:

Originally Posted by cyberbeing

I've heard back that MPC-HC will hopefully commit a fix sometime tomorrow.

Just to let everyone know, the mentioned fix has since been committed and xySubFilter works flawlessly even when there's only external subtitles.

Aleksoid1978 · 1st August 2013, 01:28

To developers - filter can't render some subtitle from DVD(VOBSUB). If need - i can upload example of this files.

cyberbeing · 1st August 2013, 06:49

Quote:

Originally Posted by Aleksoid1978

To developers - filter can't render some subtitle from DVD(VOBSUB). If need - i can upload example of this files.

Do your samples work in MPC-BE without XySubFilter/xy-VSFilter? It's quite possible we forgot to merge a bug-fix commit from MPC-BE somewhere, in which case it could be more helpful to just point out what you did to fix this issue. In general when it comes to VOBSUB/PGS/DVB image-based subtitles, we often only merge changes and fix regressions compared to MPC-HC & MPC-BE, and otherwise let these projects be in charge of maintaining this code rather than working on it ourselves.

None the less, if it is broken in all versions of VSFilter, please provide a sample.

Aleksoid1978 · 1st August 2013, 09:53

Yes - it' samples work in MPC-BE. But fail in MPC-HC/XySubFilter/xy-VSFilter.

JEEB · 1st August 2013, 10:44

Please feel free to upload the samples, but can you also check if this fork of xy-VSFilter I'm (trying to) maintain fails them too

?

cyberbeing · 1st August 2013, 11:27

XySubFilter contains all the VOBSUB fixes from JEEB's branch, so it's most likely the same behavior.

I took a quick look, and it seems like we are missing this commit from MPC-BE r1459. Would need a sample to confirm this fixes Aleksoid's issue though.

Aleksoid1978 · 1st August 2013, 13:07

Quote:

Originally Posted by cyberbeing

XySubFilter contains all the VOBSUB fixes from JEEB's branch, so it's most likely the same behavior.

I took a quick look, and it seems like we are missing this commit from MPC-BE r1459. Would need a sample to confirm this fixes Aleksoid's issue though.

Yes - it's changes

Superb · 1st August 2013, 14:12

Am I the only one having trouble following the git development? What are all these (31) branches?
Maybe I'm a git newbie, but using forks/pull/push seems much more organized. Releases should be tagged, and so on...

cyberbeing · 1st August 2013, 18:45

Stable releases have been tagged ever since version 3.0.0.0. Other releases are usually are not tagged, with versioning dependent on our build script. It's always possible to check-out a non-tagged release by the GIT hash we list in our release notes.

At one point in time last year, we ended up with two "master" branches at the same time, which was becoming a problem. When we released 3.0.0.211 our "old" Master was replaced with our "new" Master. Some of the older development branches may appear stranded because of this.

Anything which hasn't been merged into Master branch is not final. New branches are created whenever we are testing new features, or potentially unstable changes.

In general, ignore any branch which haven't been updated since our last release.

Our developer usually does a revert and force push whenever he needs to replace a broken commit on a development branch. He also rarely merges or rebases development branches into each other, rather creating a new branch and commiting each change again from scratch.

xy_sub_filter_rc (branch) = XySubFilter Beta 3.1.0.546

It shouldn't be too hard to follow our GIT development enough to get a general idea of what we've been working on, but the concept of "nightly builds" is not really compatible with our development style. Not a major problem from our point of view, since we don't accept bug reports or offer support on anything but official releases anyway.

Aleksoid1978 · 2nd August 2013, 01:13

Here is a sample - http://aleksoid.voserver.net/Sample/Subtitle/DVD/
Another sample - http://aleksoid.voserver.net/Sample/Subtitle/VOBSUB/, also do not show subtitle, maybe the same bug.

mindbomb · 2nd August 2013, 01:22

Quote:

Originally Posted by nevcairiel

However, the MPC-HC devs are working on making XySubFilter work with the internal renderers, as well.

so, is it just gonna replace the current mpc hc subtitle renderer when it works with the internal renderers?

cyberbeing · 2nd August 2013, 02:52

Quote:

Originally Posted by Aleksoid1978

Here is a sample - http://aleksoid.voserver.net/Sample/Subtitle/DVD/
Another sample - http://aleksoid.voserver.net/Sample/Subtitle/VOBSUB/, also do not show subtitle, maybe the same bug.

Thanks. I've confirmed the MPC-BE r1459 commit resolves the issue with all of these samples. We'll make sure to include this fix in our next release.

krmit · 3rd August 2013, 23:06

"auto-reload sub after detecting modification" option seems broken.
editing subtitle file cause no change at screen (both options checked), but CPU load increasing significantly (about 50-60% per core from 6-12%) and keep that level.
tested with MPC-BE r3149/madVR 0.86.10/LAV 0.58.2/.ass subs

cyberbeing · 4th August 2013, 01:51

Quote:

Originally Posted by krmit

"auto-reload sub after detecting modification" option seems broken

Reproduced this issue in XySubFilter Beta, so I've created Issue #164. Thanks for the report. This is one feature I've never really used before, so I probably wouldn't have noticed it otherwise.

Gagorian · 11th August 2013, 00:10

I'm having a small problem with XySubFilter. When viewed on my 119" white screen I can see some faint horizontal artifacting between letters (two very thin barely visible horizontal lines between the upper and lower parts of the letters). It seems like it's some problem with the transparency of the background. I think I had the same problem on the MPC internal filter and that's actually a reason for the switch.

I'm using MPC-HC and LAV filters with madVR (all latest versions). My GPU is the iGPU on A10-5700. I'm not using DXVA.

Any solutions to the issue?

1st August 2013, 01:28	#167 \| Link
Aleksoid1978 Registered User Join Date: Apr 2008 Location: Russia, Vladivostok Posts: 2,787	To developers - filter can't render some subtitle from DVD(VOBSUB). If need - i can upload example of this files. __________________ AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215

1st August 2013, 09:53	#169 \| Link
Aleksoid1978 Registered User Join Date: Apr 2008 Location: Russia, Vladivostok Posts: 2,787	Yes - it' samples work in MPC-BE. But fail in MPC-HC/XySubFilter/xy-VSFilter. __________________ AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215

1st August 2013, 10:44	#170 \| Link
JEEB もこたんインしたお！ Join Date: Jan 2008 Location: Finland / Japan Posts: 512	Please feel free to upload the samples, but can you also check if this fork of xy-VSFilter I'm (trying to) maintain fails them too ? __________________ [I'm human, no debug]

1st August 2013, 11:27	#171 \| Link
cyberbeing Broadband Junkie Join Date: Oct 2005 Posts: 1,859	XySubFilter contains all the VOBSUB fixes from JEEB's branch, so it's most likely the same behavior. I took a quick look, and it seems like we are missing this commit from MPC-BE r1459. Would need a sample to confirm this fixes Aleksoid's issue though. Last edited by cyberbeing; 1st August 2013 at 11:30.

1st August 2013, 18:45	#174 \| Link
cyberbeing Broadband Junkie Join Date: Oct 2005 Posts: 1,859	Stable releases have been tagged ever since version 3.0.0.0. Other releases are usually are not tagged, with versioning dependent on our build script. It's always possible to check-out a non-tagged release by the GIT hash we list in our release notes. At one point in time last year, we ended up with two "master" branches at the same time, which was becoming a problem. When we released 3.0.0.211 our "old" Master was replaced with our "new" Master. Some of the older development branches may appear stranded because of this. Anything which hasn't been merged into Master branch is not final. New branches are created whenever we are testing new features, or potentially unstable changes. In general, ignore any branch which haven't been updated since our last release. Our developer usually does a revert and force push whenever he needs to replace a broken commit on a development branch. He also rarely merges or rebases development branches into each other, rather creating a new branch and commiting each change again from scratch. xy_sub_filter_rc (branch) = XySubFilter Beta 3.1.0.546 It shouldn't be too hard to follow our GIT development enough to get a general idea of what we've been working on, but the concept of "nightly builds" is not really compatible with our development style. Not a major problem from our point of view, since we don't accept bug reports or offer support on anything but official releases anyway.

27th July 2013, 12:29	#162 \| Link
cyberbeing Broadband Junkie Join Date: Oct 2005 Posts: 1,859	How to take madVR screenshots with MPC-HC which include XySubFilter subtitles [Updated]

27th July 2013, 19:31	#163 \| Link
Tornado15550 Registered User Join Date: Sep 2012 Posts: 12	Will there be a 64bit release of xySubFilter? Right now, I'm running the 64bit release of xy-VSFilter. Also, is it a must to have MadVR in order for XySubFilter to work?

1st August 2013, 14:12	#173 \| Link
Superb Registered User Join Date: Feb 2010 Posts: 364	Am I the only one having trouble following the git development? What are all these (31) branches? Maybe I'm a git newbie, but using forks/pull/push seems much more organized. Releases should be tagged, and so on...

2nd August 2013, 01:13	#175 \| Link
Aleksoid1978 Registered User Join Date: Apr 2008 Location: Russia, Vladivostok Posts: 2,787	Here is a sample - http://aleksoid.voserver.net/Sample/Subtitle/DVD/ Another sample - http://aleksoid.voserver.net/Sample/Subtitle/VOBSUB/, also do not show subtitle, maybe the same bug. __________________ AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215 Last edited by Aleksoid1978; 2nd August 2013 at 01:21.

3rd August 2013, 23:06	#178 \| Link
krmit Registered User Join Date: Jul 2013 Posts: 5	"auto-reload sub after detecting modification" option seems broken. editing subtitle file cause no change at screen (both options checked), but CPU load increasing significantly (about 50-60% per core from 6-12%) and keep that level. tested with MPC-BE r3149/madVR 0.86.10/LAV 0.58.2/.ass subs

11th August 2013, 00:10	#180 \| Link
Gagorian Registered User Join Date: Jul 2013 Posts: 27	I'm having a small problem with XySubFilter. When viewed on my 119" white screen I can see some faint horizontal artifacting between letters (two very thin barely visible horizontal lines between the upper and lower parts of the letters). It seems like it's some problem with the transparency of the background. I think I had the same problem on the MPC internal filter and that's actually a reason for the switch. I'm using MPC-HC and LAV filters with madVR (all latest versions). My GPU is the iGPU on A10-5700. I'm not using DXVA. Any solutions to the issue? Last edited by Gagorian; 11th August 2013 at 00:14.