directshow Bluray disc navigator filter base on libbluray

[Mercury_22]

Originally Posted by dukey

does this happen with all your blurays ? Or just this particular frozen planet one.
I see it throws an exception when the frozen planet one starts to play the main title

No it happens with others too
I think it's better to revert rev 99 for the moment

[dukey]

Well I tracked the issue down. Well partly at least. It hangs on bd_close. Normally when it exits it throws a load of exceptions, on that frozen planet title. But if you press some keys, which happens to work in a separate thread, it hangs. Not sure why. The critical sections should protect against any thread insanity.

The frozen planet doesn't work with the latest edition though. I get this error. Hopefully useful for cb2000 ;p

c:\users\ian\desktop\bluray\trunk\libbluray\src\libbluray\register.c:391: bd_psr
_write(): PSR4 (TITLE_NUMBER) 0x0 -> 0x4
c:\users\ian\desktop\bluray\trunk\libbluray\src\libbluray\bluray.c:2108: PSR cha
nge: psr4 = 4 (03D445F0)
destroyXlet: lookup( org.videolan.BDJXletContext@5ed01d74, /7fff002e/4001/TitleC
hangeHandler ) = framework.title.TitleChangeProxy_stub2[framework.title.TitleCha
ngeProxy@4d277e8f]
startXlet: lookup( org.videolan.BDJXletContext@5ed01d74, /7fff002e/4001/TitleCha
ngeHandler ) = framework.title.TitleChangeProxy_stub2[framework.title.TitleChang
eProxy@4d277e8f]
c:\users\ian\desktop\bluray\trunk\libbluray\src\libbluray\bdj\bdj_util.c:19: Cla
ss org/videolan/StreamInfo constructor not found
c:\users\ian\desktop\bluray\trunk\libbluray\src\libbluray\bdj\bdj_util.c:19: Cla
ss org/videolan/StreamInfo constructor not found
c:\users\ian\desktop\bluray\trunk\libbluray\src\libbluray\bdj\bdj_util.c:19: Cla
ss org/videolan/StreamInfo constructor not found
c:\users\ian\desktop\bluray\trunk\libbluray\src\libbluray\bdj\bdj_util.c:19: Cla
ss org/videolan/StreamInfo constructor not found
Thread died with exception c0000005 at pc 51ef1795 addr 0

Edit:
heres the link to vid, or menu files anyway
http://www7.zippyshare.com/v/82423600/file.html

[cb2000]

use same reversion of libbluray.jar and bluray.dll

[Mercury_22]

Originally Posted by dukey

Well I tracked the issue down. Well partly at least. It hangs on bd_close. Normally when it exits it throws a load of exceptions, on that frozen planet title. But if you press some keys, which happens to work in a separate thread, it hangs. Not sure why. The critical sections should protect against any thread insanity.

The frozen planet doesn't work with the latest edition though. I get this error. Hopefully useful for cb2000 ;p



Edit:
heres the link to vid, or menu files anyway
http://www7.zippyshare.com/v/82423600/file.html

F.P. works with the latest edition here ! except the "stops responding after stop and exit in the main movie" introduced in rev 99 of course

[dukey]

Originally Posted by cb2000

use same reversion of libbluray.jar and bluray.dll

yeah that worked
cb2000 any idea why calling bd_user_input on a separate thread would cause
bd_close to hang ?
It doesn't do it on all titles, just some I think.

[dukey]

Okay I found out exactly what's happening. I assumed libbluray was thread safe since it uses mutexes to protects its internal state, but it's not.

When

void bdj_process_event(BDJAVA *bdjava, unsigned ev, unsigned param)

is called. It calls

(*bdjava->jvm)->AttachCurrentThread(bdjava->jvm, (void**)&env, NULL);

If you are just using a single thread, this is a no-op according to the documentation. But if the current thread has changed it attaches the new one. This is fine, until it exits.

The VM waits until the main thread is the only user thread before it actually unloads. User threads include both Java threads and attached native threads.

So we must use DetachCurrentThread somewhere to fix this. If we can fix this I can probably finish the rest of the control interface

[Mercury_22]

@dukey after your latest changes building it's failing

2>BDSource.obj : error LNK2019: unresolved external symbol "void __cdecl PTSToHMSF(__int64,struct tagDVD_HMSF_TIMECODE *)" (?PTSToHMSF@@YAX_JPAUtagDVD_HMSF_TIMECODE@@@Z) referenced in function "public: virtual long __stdcall CBDSource::GetTotalTitleTime(struct tagDVD_HMSF_TIMECODE *)" (?GetTotalTitleTime@CBDSource@@UAGJPAUtagDVD_HMSF_TIMECODE@@@Z)
2>BDSource.obj : error LNK2019: unresolved external symbol "__int64 __cdecl HMSFToPTS(struct tagDVD_HMSF_TIMECODE *)" (?HMSFToPTS@@YA_JPAUtagDVD_HMSF_TIMECODE@@@Z) referenced in function "public: virtual long __stdcall CBDSource::PlayAtTime(struct tagDVD_HMSF_TIMECODE *)" (?PlayAtTime@CBDSource@@UAGJPAUtagDVD_HMSF_TIMECODE@@@Z)
2>C:\DSLibBluray\Win32\Debug\dslibbluray.ax : fatal error LNK1120: 2 unresolved externals
2>
2>Build FAILED.
2>
2>Time Elapsed 00:00:00.88
========== Build: 1 succeeded, 1 failed, 4 up-to-date, 0 skipped ==========

[dukey]

try now, i added the files, just forgot to submit changes to project files

[Mercury_22]

Originally Posted by dukey

try now, i added the files, just forgot to submit changes to project files

It's working now

[dukey]

Mercury_22,
you got any .m2ts files with enhanced ac3 audio ? I am writing stream parsers at the moment. Finished ac3, but need some test files for e-ac3

[nevcairiel]

E-AC3 on BD doesn't exist in the real world, its only used on the dolby demo disc.

[dukey]

Okay, thanks for the heads up. I'm only parsing the stream headers so its only a few lines of code.

[Mercury_22]

Originally Posted by dukey

Mercury_22,
you got any .m2ts files with enhanced ac3 audio ? I am writing stream parsers at the moment. Finished ac3, but need some test files for e-ac3

Here it is

@ Nev if it's not too much to ask can you help make "dslibbluray" properly decode TrueHD with LAVAudio ?

Originally Posted by nevcairiel

TrueHD is special, the Blu-ray source filter needs to remove the embedded AC3 or it won't work properly.

With LAV I'm getting

[truehd @ 02ad42e0] Invalid nonrestart_substr.
[truehd @ 02ad42e0] mlpparse: Parity check failed.
[truehd @ 02ad42e0] Lossless check failed - expected 85, calculated 5f.
[truehd @ 02ad42e0] mlpparse: Parity check failed.
[truehd @ 02ad42e0] Lossless check failed - expected 19, calculated b7.
...

[nevcairiel]

Originally Posted by Mercury_22

@ Nev if it's not too much to ask can you help make "dslibbluray" properly decode TrueHD with LAVAudio ?

No thanks, my time is already occupied.

[dukey]

If you point me in the right direction can probably write the code

[nevcairiel]

Its actually pretty simple. You need to check the extended stream id in the PES Header.
http://dvd.sourceforge.net/dvdinfo/pes-hdr.html

In PES Extension 2 (at the bottom of the page), the bits marked "Reserved" are the extended stream id.
If the main stream_type == 0x83 (TrueHD) and extended_stream_id == 0x76, then that PES packet is for the AC3 substream, and needs to be skipped.

You can see the parsing in ffmpeg here:
http://git.1f0.de/gitweb?p=ffmpeg.gi...9;hb=HEAD#l913

[dukey]

Thanks, that should help a lot

[nevcairiel]

While i'm here, i have another question about the need of the special EVR Mixer.

Is all its required for the need to mix the RGB Overlays on top of the video image?
Or is there more?

If the RGB overlay is all, i could easily make for example LAV Video do that (without DXVA, at least), giving us way more flexibility in how the graph is setup.
If i could get the EVR requirement removed, it would be quite a bit more interesting for me, i might even start helping the development if you let me. I don't want to start my own BD project, but i want BDs to work.

[Mercury_22]

That will be great and CB2000 knows about the EVR
@dukey Did you manage to do something about the LPCM with LAVAudio ?

[dukey]

Originally Posted by nevcairiel

While i'm here, i have another question about the need of the special EVR Mixer.

Is all its required for the need to mix the RGB Overlays on top of the video image?
Or is there more?

If the RGB overlay is all, i could easily make for example LAV Video do that (without DXVA, at least), giving us way more flexibility in how the graph is setup.
If i could get the EVR requirement removed, it would be quite a bit more interesting for me, i might even start helping the development if you let me. I don't want to start my own BD project, but i want BDs to work.

I think the problem was sometimes the primary video stream stops, and only the substreams render. So with the default evr mixer or vrm9 nothing will render, hence the need for the custom mixer. The custom mixer actually works fairly transparently. You just need to create an instance of it and it pretty much works. I had to make a few changes to get it to work with my custom presenter, ie to make it thread safe with regards to direct3d. I've done a fair bit of work on the mixer, so anyone that uses a custom presenter only minimal changes would be required.