KNLMeansCL: OpenCL NLMeans de-noising algorithm [2018-01-29]

[feisty2]

to have similar results, "h" in v1.0.1 should be around 1.6 ~ 1.8 x "h" in v0.7.7
@Khanattila
is there an explanation for what's happening here?
did you switch from SSE to SAD?

[Khanattila]

Mathematics is the same, there will be a bug somewhere.

[feisty2]

@Khanattila
That doesn't sound good...
Are you planning on fixing it?

[Khanattila]

Originally Posted by feisty2

@Khanattila
That doesn't sound good...
Are you planning on fixing it?

I already found the problem...
You can consider it a side effect of the new channels mode.
The result is correct, I might add an internal multiplier to maintain compatibility with the older versions.

PS. It is more correct the new version instead of the old.

[feisty2]

I did my tests on GRAYS clips...
So that channel thing, will affect GRAY stuff as well?

[Khanattila]

Originally Posted by feisty2

I did my tests on GRAYS clips...
So that channel thing, will affect GRAY stuff as well?

All modes are affected.
As a temporary fix using ~1,732 (square root of 3) as a multiplier for h.

[burfadel]

Originally Posted by Khanattila

All modes are affected.
As a temporary fix using ~1,732 (square root of 3) as a multiplier for h.

Just be aware that a comma is also a thousand separator in half the world. Basically, to many people out there, you said to set h to one thousand seven hundred thirty two (1732) .

Yes it's Wikipedia, but it's good enough:
https://en.wikipedia.org/w/index.php?title=Decimal_mark

Basically it's the exact opposite, where you use commas' as a decimal separator as in your usage, a decimal is used, and where we would use a comma, you use a decimal as a thousands separator.

Makes it confusing when there are multiple different systems (more than just these) around the world. The correct form in Australia for 1,732 is 1 732, although a comma is typically used. Not to confuse things with the comma at the end there for a sentence break! Many people would also write 1 732 as 1,732, but if the number were much larger as in 92,345,764 they would use spaces. The spaces are used as part of the SI system I believe to avoid confusion between the various systems used around the world.

[Khanattila]

Originally Posted by burfadel

Just be aware that a comma is also a thousand separator in half the world. Basically, to many people out there, you said to set h to one thousand seven hundred thirty two (1732) .

Yes it's Wikipedia, but it's good enough:
https://en.wikipedia.org/w/index.php?title=Decimal_mark

Basically it's the exact opposite, where you use commas' as a decimal separator as in your usage, a decimal is used, and where we would use a comma, you use a decimal as a thousands separator.

Makes it confusing when there are multiple different systems (more than just these) around the world. The correct form in Australia for 1,732 is 1 732, although a comma is typically used. Not to confuse things with the comma at the end there for a sentence break! Many people would also write 1 732 as 1,732, but if the number were much larger as in 92,345,764 they would use spaces. The spaces are used as part of the SI system I believe to avoid confusion between the various systems used around the world.

I thank you, but really, I know the difference.
I live in the limbo in which I program using '.' and in the lives of everyday I use ','.

[MysteryX]

Originally Posted by Khanattila

I thank you, but really, I know the difference.
I live in the limbo in which I program using '.' and in the lives of everyday I use ','.

Modern programming languages have no issue with that (as long as you set the right parameters for formatting) but this used to be a major source of frustration with old programming languages. A program would run 100% fine, then on another computer, it would totally crash on every comma.

[KingLir]

I am getting the following error when running on macOS with latest versions (vapoursynth R36 and KNLMeansCL built from master - commit 08755c5). Anyone got an idea how to fix ?

Script evaluation failed:
Python exception: knlm.KNLMeansCL: build programm error!
Please report Log-KNLMeansCL.txt.
Traceback (most recent call last):
File "src/cython/vapoursynth.pyx", line 1712, in vapoursynth.vpy_evaluateScript (src/cython/vapoursynth.c:34991)
File "VIVTC_with_TComb_script.vpy", line 11, in <module>
clip = core.knlm.KNLMeansCL(clip=clip)
File "src/cython/vapoursynth.pyx", line 1604, in vapoursynth.Function.__call__ (src/cython/vapoursynth.c:33131)
vapoursynth.Error: knlm.KNLMeansCL: build programm error!

script:

import vapoursynth as vs
core = vs.get_core()
core.max_cache_size = 12000

clip = core.ffms2.Source(source=filename)
clip = core.knlm.KNLMeansCL(clip=clip)

[Khanattila]

Originally Posted by KingLir

I am getting the following error when running on macOS. Anyone got an idea how to fix ?

Script evaluation failed:
Python exception: knlm.KNLMeansCL: build programm error!
Please report Log-KNLMeansCL.txt.
Traceback (most recent call last):
File "src/cython/vapoursynth.pyx", line 1712, in vapoursynth.vpy_evaluateScript (src/cython/vapoursynth.c:34991)
File "VIVTC_with_TComb_script.vpy", line 11, in <module>
clip = core.knlm.KNLMeansCL(clip=clip)
File "src/cython/vapoursynth.pyx", line 1604, in vapoursynth.Function.__call__ (src/cython/vapoursynth.c:33131)
vapoursynth.Error: knlm.KNLMeansCL: build programm error!

script:
clip = core.knlm.KNLMeansCL(clip=clip)

> Please report Log-KNLMeansCL.txt

[KingLir]

Originally Posted by Khanattila

> Please report Log-KNLMeansCL.txt

Sure, but where can I find it on macOS ? I searched and haven't found it.

[Khanattila]

Originally Posted by KingLir

Sure, but where can I find it on macOS ? I searched and haven't found it.

It is in the script folder.

[KingLir]

Originally Posted by Khanattila

It is in the script folder.

Thanks, sorry I missed it.
Here:

OpenCL Platform
------------------------------------------------------------
CL_PLATFORM_VENDOR: Apple
CL_PLATFORM_NAME: Apple
CL_PLATFORM_VERSION: OpenCL 1.2 (Jan 4 2017 22:35:59)
CL_PLATFORM_PROFILE: FULL_PROFILE

OpenCL Device
------------------------------------------------------------
CL_DEVICE_VENDOR: AMD
CL_DEVICE_NAME: AMD Radeon R9 M395X Compute Engine
CL_DRIVER_VERSION: 1.2 (Jan 10 2017 22:25:08)
CL_DEVICE_VERSION: OpenCL 1.2
CL_DEVICE_PROFILE: FULL_PROFILE
CL_DEVICE_IMAGE_SUPPORT: 1
CL_DEVICE_IMAGE2D_MAX_WIDTH: 16384
CL_DEVICE_IMAGE2D_MAX_HEIGHT: 16384
CL_DEVICE_IMAGE_MAX_ARRAY_SIZE: 2048

Program Build
------------------------------------------------------------
CL_PROGRAM_BUILD_OPTIONS:
CL_PROGRAM_BUILD_LOG:


RETURN: 0

[KingLir]

Any ideas ?

[Khanattila]

Originally Posted by KingLir

Any ideas ?

v1.0.2, definitely

[Khanattila]

@ KingLir
https://github.com/Khanattila/KNLMea...ive/master.zip
Can you test this version and report log?

[KingLir]

Originally Posted by Khanattila

@ KingLir
https://github.com/Khanattila/KNLMea...ive/master.zip
Can you test this version and report log?

Thanks and sorry for the late reply.

Here is the new output:

Script evaluation failed:
Python exception: knlm.KNLMeansCL: build programm error!
Please report Log-KNLMeansCL.txt.
Traceback (most recent call last):
File "src/cython/vapoursynth.pyx", line 1712, in vapoursynth.vpy_evaluateScript (src/cython/vapoursynth.c:34991)
File "VIVTC_with_TComb_script.vpy", line 16, in <module>
clip = core.knlm.KNLMeansCL(clip=clip)
File "src/cython/vapoursynth.pyx", line 1604, in vapoursynth.Function.__call__ (src/cython/vapoursynth.c:33131)
vapoursynth.Error: knlm.KNLMeansCL: build programm error!

And the new log:

OpenCL Platform
------------------------------------------------------------
CL_PLATFORM_VENDOR: Apple
CL_PLATFORM_NAME: Apple
CL_PLATFORM_VERSION: OpenCL 1.2 (Jan 4 2017 22:35:59)
CL_PLATFORM_PROFILE: FULL_PROFILE

OpenCL Device
------------------------------------------------------------
CL_DEVICE_VENDOR: AMD
CL_DEVICE_NAME: AMD Radeon R9 M395X Compute Engine
CL_DRIVER_VERSION: 1.2 (Jan 10 2017 22:25:08)
CL_DEVICE_VERSION: OpenCL 1.2
CL_DEVICE_PROFILE: FULL_PROFILE
CL_DEVICE_IMAGE_SUPPORT: 1
CL_DEVICE_IMAGE2D_MAX_WIDTH: 16384
CL_DEVICE_IMAGE2D_MAX_HEIGHT: 16384
CL_DEVICE_IMAGE_MAX_ARRAY_SIZE: 2048

Program Build
------------------------------------------------------------
CL_PROGRAM_BUILD_ERROR: CL_INVALID_BUILD_OPTIONS
CL_PROGRAM_BUILD_OPTIONS:
CL_PROGRAM_BUILD_LOG:


RETURN: 0

[Khanattila]

Originally Posted by KingLir

Thanks and sorry for the late reply.

Here is the new output:

Script evaluation failed:
Python exception: knlm.KNLMeansCL: build programm error!
Please report Log-KNLMeansCL.txt.
Traceback (most recent call last):
File "src/cython/vapoursynth.pyx", line 1712, in vapoursynth.vpy_evaluateScript (src/cython/vapoursynth.c:34991)
File "VIVTC_with_TComb_script.vpy", line 16, in <module>
clip = core.knlm.KNLMeansCL(clip=clip)
File "src/cython/vapoursynth.pyx", line 1604, in vapoursynth.Function.__call__ (src/cython/vapoursynth.c:33131)
vapoursynth.Error: knlm.KNLMeansCL: build programm error!

And the new log:

OpenCL Platform
------------------------------------------------------------
CL_PLATFORM_VENDOR: Apple
CL_PLATFORM_NAME: Apple
CL_PLATFORM_VERSION: OpenCL 1.2 (Jan 4 2017 22:35:59)
CL_PLATFORM_PROFILE: FULL_PROFILE

OpenCL Device
------------------------------------------------------------
CL_DEVICE_VENDOR: AMD
CL_DEVICE_NAME: AMD Radeon R9 M395X Compute Engine
CL_DRIVER_VERSION: 1.2 (Jan 10 2017 22:25:08)
CL_DEVICE_VERSION: OpenCL 1.2
CL_DEVICE_PROFILE: FULL_PROFILE
CL_DEVICE_IMAGE_SUPPORT: 1
CL_DEVICE_IMAGE2D_MAX_WIDTH: 16384
CL_DEVICE_IMAGE2D_MAX_HEIGHT: 16384
CL_DEVICE_IMAGE_MAX_ARRAY_SIZE: 2048

Program Build
------------------------------------------------------------
CL_PROGRAM_BUILD_ERROR: CL_INVALID_BUILD_OPTIONS
CL_PROGRAM_BUILD_OPTIONS:
CL_PROGRAM_BUILD_LOG:


RETURN: 0

Apple... why not follow the standard?

[Khanattila]

@ KingLir
https://github.com/Khanattila/KNLMea...ive/master.zip
now, it should work for you.