[Neo] Vague-Denoiser

[real.finder]

ColorBars
converttoyv12
AddGrainC
Interleave(neo_vd.luma_histogram(),convertbits(16).neo_vd().convertbits(8).luma_histogram())

[MeteorRain]

Removing float to int rounding solved the problem. But to be honest I'm not quite sure we should remove the rounding.

The following code

ptr[x] = std::min(std::max(static_cast<int>(pad[x] + 0.5f), 0), ep.peak);

0.5f does not scale with bit depth, so if input is 158.5 in 8bit then it rounds up to 159, but 2536 in 12bit rounds to 2536 and bit-shifting to 158 in 8bit.

If I remove +0.5 then the results are identical, but the truncated result may not be as accurate as rounded.

What do you think?

[real.finder]

Originally Posted by MeteorRain

Removing float to int rounding solved the problem. But to be honest I'm not quite sure we should remove the rounding.

The following code

ptr[x] = std::min(std::max(static_cast<int>(pad[x] + 0.5f), 0), ep.peak);

0.5f does not scale with bit depth, so if input is 158.5 in 8bit then it rounds up to 159, but 2536 in 12bit rounds to 2536 and bit-shifting to 158 in 8bit.

If I remove +0.5 then the results are identical, but the truncated result may not be as accurate as rounded.

What do you think?

identical mean both be like 8bit or like 16bit? the 8bit should be the reference (since it like the old Vague-Denoiser)

and why it add 0.5f?

and since I am not a programmer, let's see what others say like pinterf

[pinterf]

For most cases float intermediate value is always rounded before casting (=truncating) to an integer. Adding a 0.5 plus a truncate to integer is like rounding to the nearest integer.
If the missing rounding is probably a bug and incorrect then we shouln't keep any plugin with the old (wrong) behaviour.

[kedautinh12]

real.finder updated new commits to fix Update AVS headers and copy frame properties for AVS+ and VS. If anyone interested
https://github.com/HomeOfAviSynthPlu...9311366112ed64

[joearmstrong]

I don't want to remove all noise from the video source, I just want to clean the video a bit for better compressibility. I refuse temporal denoisers because of the annoying scene change issue - during scene changes some frames are noisier than others due to temporal processing. After many testings I finally found this fantastic spatial denoiser which gave me the best results. With threshold=3.5 I succesfully cleaned a very noisy video - compressibility is much better now. Thank you for this useful denoiser!

[joearmstrong]

I'm missing the Wiener option from the original VagueDenoiser for 2-pass denoising. Can this function be implemented again?

[Ceppo]

MeteorRain:
I don't know where to write this, since I can't find a post. But "minideen" doesn't work if I preview the avs with a player. Is it just me?

[kedautinh12]

You can create issue here
https://github.com/HomeOfAviSynthPlu...iniDeen/issues

[Ceppo]

Thank you!

[banaguitar]

Use AVSPmod32 and 32 bit dll, but it crashes
Don't know why