YV12: mpeg2dec, mpeg2dec2 and mpeg3dec developers

[Marc FD]

> I also noticed that there's somenthing in the left border.

yellow dots, right ? might be the know bug of XviD old colorconv.

[Gaia]

Originally posted by Marc FD
> I also noticed that there's somenthing in the left border.

yellow dots, right ? might be the know bug of XviD old colorconv.

Not quite sure how to descripe it. Maybe dots maybe somekind of line too...

[Rrrough]

do they also appear when using another compressor (e.g. DivX) ?

[Marc FD]

>Not quite sure how to descripe it. Maybe dots maybe somekind of line too...

a bit this way :

-- normal pixels
xx yellow dots

------
xx----
------
xx----
------

on the left side only.

>do they also appear when using another compressor (e.g. DivX) ?

if i remember well, it's only on decoding, so it's not in the bitstream.
and i think the new color convertions fixed it. but i'm not sure it's been commited to CVS now.

[Rrrough]

f i remember well, it's only on decoding, so it's not in the bitstream.

maybe gaia could change the 4cc to divx and use divx decompression or try ffdshow and see if it's still there...

cheers

[Gaia]

Originally posted by Marc FD
>Not quite sure how to descripe it. Maybe dots maybe somekind of line too...

a bit this way :

-- normal pixels
xx yellow dots

------
xx----
------
xx----
------

on the left side only.

>do they also appear when using another compressor (e.g. DivX) ?

if i remember well, it's only on decoding, so it's not in the bitstream.
and i think the new color convertions fixed it. but i'm not sure it's been commited to CVS now.

I have to try Divx but yes i quess it's like you descriped them.

[Koepi]

Your description looks exactly like the xvid decoder bug. If isibaar finds some time and is bored (means: has no other interesting features to play with), he'll fix that MMX code. Go to XviD configuration and there to the CPU tab and disable all mmx/sse stuff and you'll see the yellow spots are gone.

Regards,
Koepi

[Marc FD]

if you see it in VDub, i'm pretty sure it's the YV12->RGB32 convertion.
try with DX50 fourcc and see.

@Koepi

could you commit the checkbox in vfw to CVS, i'd like to test it, and i'm a noob to change the interface. thanks.

[Koepi]

Marc,

I'll send you the sources. They are for current CVS, thus already supporting chroma me The first test run here looks very promising, but since gruel's a little angry with me I fear I won't release a binary until it proved to work alright here.

Regards,
Koepi

[Marc FD]

just send vfw, i've a 5 min old xvidcore, i guess it's okay (i've the last ME)

but i don't have checkboxes ^^

BTW, i'll apply the patch to test the new color convertions

[Gaia]

Thanks for help. Now only problem is that green line at the bottom.

[Marc FD]

@Koepi

thx.

@Gaia

i think Sh0dan will fix that very fast as always.

[Koepi]

XviD-04112002-1:
- Fresh CVS checkout. GMC improvements.
- New mod. HQ quant type reimplemented.
- Added checkbox for chroma motion estimation (slow but better PSNR).

So now everyone can test it...

Regards,
Koepi

[Rrrough]

@all,

as you can see that there's a lot of changes going on on the XVID-development branch, please make sure when reporting possible avisynth problems/bugs that you test with another codec as well, as there might be some problems/bugs related with these _unstable_ xvid dev builds.
just an idea to make avisynth debugging easier.

cheers

[iago]

@Rrrough and all,

Regarding the green line problem, With all my XviD encodes (including Koepi's 04112002-1 build) and today's AviSynth 2.5 binary too, the green (or sometimes pinkish) line is still there at the bottom. Changing the FourCC to Divx, decoding with ffdshow or DivX 5.02 decoder or using Nic's latest DSF, or disabling XviD optimizations (though I don't know if the green line is the same issue as the yellow dots mentioned) doesn't change a thing.

To make sure I did a test encode with DivX 5.02 as well, and the green line problem persists with DivX 5.02 too (decoded with DivX Decoder - 5.02).

Below is my avs script:

--------------------------------------------------------
LoadPlugin("C:\FILTERS\mpeg2dec3 YV12.dll")
mpeg2source("D:\RIP\RIP.d2v",blend=true,cpu=4,lumoff=-2)
crop(12,8,-12,-8)
BicubicResize(512,288,0,0.75)
--------------------------------------------------------

regards,
iago


edit1: Windows XP - Celeron 900 - ZoomPlayer and MPC

edit2: Tom, it's really nice to hear that you're gonna release UnFilter YV12, though you say it's not in your utmost-priority list!

edit3: Koepi, many thanks for the new toy to play with, which has a lot of new features as well!

edit4: Rewriting the crop parameters in the above script as crop(16,8,-16,-8) and encoding with it doesn't make a difference either.

edit5: I tried with mpeg2source("D:\RIP\RIP.d2v") as well, to check if the problem is related with mpeg2dec3 YV12 parameters, but it does not seem to be related with mpeg2dec3 YV12 either.

[sh0dan]

The thin green line is probably an AviSynth resizer bug I haven't found yet. I'm working on it however

Edit: (and it isn't an easy one to find)

[iago]

@shOdan

Many thanks for your time and effort regarding the "green line" issue. I'm almost sure it will be resolved very soon, since it's under your very investigation!

best regards,
iago

[HarryM]

Originally posted by iago
@shOdan

Many thanks for your time and effort regarding the "green line" issue. I'm almost sure it will be resolved very soon, since it's under your very investigation!

best regards,
iago

You can crop this green line away...

[sh0dan]

Originally posted by iago
Many thanks for your time and effort regarding the "green line" issue. I'm almost sure it will be resolved very soon, since it's under your very investigation!

Got it (almost sure) - One of the more stange bugs I've had. What you can learn from this is: Never use the same variable name for a private class variable and a local function variable. (This bug is a very old one, but it just never showed up until multiple planes were added

You can expect a speedup from this too (wow - a bugfix with a speedup!)

[iago]

@shOdan

Great news that you have pinpointed and solved the problem! And the solution comes with even more speed gain! What can I say?!

thanks a lot for all your great work,
iago

Edit: Tested and confirmed! Green line is history now!