Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
17th October 2015, 20:59 | #33681 | Link | |
Registered User
Join Date: Feb 2012
Posts: 54
|
Quote:
However it would be interesting to know if superres in chrome upscaling is really not visible and what is the real influence of the image enhancement when there is not upscaling... |
|
17th October 2015, 21:02 | #33682 | Link | |
Registered User
Join Date: Jun 2007
Posts: 655
|
Quote:
Yes, with the option checked the subs size changes. I didn't pay attention to this because with the option checked subs stayed inside the video frame and were not moved to the black bars, hence I mentally discarded it.
__________________
LG 77C1 - Denon AVC-X3800H - Windows 10 Pro 22H2 - Kodi DSPlayer (LAV Filters, xySubFilter, madVR, Sanear) - RTX 4070 - Ryzen 5 3600 - 16GB RAM |
|
17th October 2015, 21:03 | #33683 | Link |
Registered User
Join Date: Dec 2014
Posts: 1,127
|
Image Enhancements will do the same thing as Upscaling Refinement when applied to an image already resized. It sharpens the luma to add detail to the image. Upscaling Refinement does the same but waits for resizing to take place. So, both could be considered post-resize sharpening.
__________________
HOW TO - Set up madVR for Kodi DSPlayer & External Media Players |
17th October 2015, 21:07 | #33684 | Link | |
Registered User
Join Date: Dec 2011
Posts: 1,812
|
Quote:
With DXVA2 CB you will get the same performance & quality like with CUVID, just without the drawbacks. |
|
17th October 2015, 21:19 | #33685 | Link |
Registered User
Join Date: Nov 2012
Posts: 36
|
Inferior video quality? Why is that? Isn't copyback the same as native, plus one additional step of copying the data back from GPU to main memory (which would from a purely logical perspective make it slower and more resource-demanding)?
Last edited by tahaa7; 17th October 2015 at 21:42. |
17th October 2015, 21:31 | #33686 | Link |
Registered User
Join Date: Dec 2011
Posts: 1,812
|
It should be, but due to driver limitations, it isn't:
An ugly chroma conversion will make it look like bilinear scaling. Copyback of LAV Filters is efficient, you won't notice it (unless you stare at the memory consumption of the media player or the very few percent additional CPU load). |
17th October 2015, 21:44 | #33688 | Link | |
Registered User
Join Date: Nov 2012
Posts: 36
|
Quote:
Last edited by tahaa7; 17th October 2015 at 22:10. |
|
17th October 2015, 22:13 | #33689 | Link |
Registered User
Join Date: Dec 2011
Posts: 1,812
|
I'm not an expert either, but it'd assume there gets some control lost for the renderer when you want the GPU to output DXVA frames (with copyback, you can do whatever you want with the frame).
There was an option to prevent this via OpenCL (some kind of frame copy on the GPU?), but it didn't work with Nvidia. I don't know if it's silently activated for AMD or Intel with DXVA2 native or if they would suffer worse quality too. In the end, this is quite a luxury problem with DXVA2 CB of LAV. It's a good thing that madshi currently spends his time on more useful things. |
17th October 2015, 22:19 | #33690 | Link | |
Registered Developer
Join Date: Sep 2006
Posts: 9,140
|
Ah, thanks, that's as expected.
To explain: madVR has no direct control over the font size selected by any subtitle renderer. All madVR delivers to the subtitle renderer are rectangles into which the sub renderers are asked to draw, and then the sub renderers themselves pick the font size they find suitable for each such rectangle. In older madVR builds (builds before v0.89.7) madVR always asked XySubFilter to draw the subs into the active video area, which is similar to what the MPC-HC internal subtitle renderer does when the option "position subtitles relative to the video frame" is checked. Starting with v0.89.7 (up to v0.89.9) madVR tried to simulate what the MPC-HC ISR does when unchecking the mentioned option. However, this caused all sorts of trouble with SSA/ASS subtitles. Also it made the font size change, when users activated or deactivated the "move subtitles" option in madVR, which some users complained about. Some users also found the font sizes to simply be too large overall. So in v0.89.10+ I went back to let XySubFilter render into the active video rect, and then afterwards I'm simply changing the positions of the subtitles to go into the black bars. The benefit of this solution is that when users activate and deactivate the "move subtitles" option in madVR, the font size does *not* change. It stays the same. However, the disadvantage is that now depending on the video aspect ratio, the font size might differ somewhat. That's really out of my control, though. The final solution should be for XySubFilter itself to be more consistent about font sizes. cyberbeing (the XySubFilter maintainer) has already invested some thoughts about this. But he isn't really a developer, so don't expect anything any time soon. As it stands, it is what it is. Both solutions I could implement have their own advantages and disadvantages. Quote:
Native DXVA saves the copyback, so it lowers CPU usage. However, DXVA decodes to a format that it hard to work with for madVR. This results in a certain loss in chroma quality. In most situations you probably won't see the difference, but it's there. So unless you have to use native DXVA for some reason, using copyback DXVA is the better choice. Personally, I even use straight software decoding because for me it's the fastest and most reliable decoder. |
|
17th October 2015, 23:23 | #33691 | Link | |
Registered User
Join Date: Jun 2007
Posts: 655
|
Quote:
I'm asking because I don't know if something could be done for ASS/SSA subs but the "moving subs up and down depending on videos" seems like a less likely scenario than just wanting subs to be at the right size for reading them at any given distance... I don't think I'm that peculiar in my use case, am I?
__________________
LG 77C1 - Denon AVC-X3800H - Windows 10 Pro 22H2 - Kodi DSPlayer (LAV Filters, xySubFilter, madVR, Sanear) - RTX 4070 - Ryzen 5 3600 - 16GB RAM |
|
17th October 2015, 23:43 | #33692 | Link | |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,346
|
Quote:
Right now, madVR works like it has always worked (except for 3 recent versions where a new way was tested and deemed not ideal). It just lets the subtitle renderer control the font size. That seems like its the most logical solution. If more control about the size is needed, the subtitle renderer should control that.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders Last edited by nevcairiel; 17th October 2015 at 23:46. |
|
18th October 2015, 00:03 | #33693 | Link |
Registered User
Join Date: Jun 2007
Posts: 655
|
I was asking because I don't fully understand what were the reasons that led to the previous 3 versions being deemed not ideal, in case those solved this problem.
If the problem was with people wanting to move subs up and down, I simply state that it seems less likely than people wanting to choose one subs size and forget about it. The way it is now, they're either too small on 2.35 material or too large on 1.78 material (covering more picture than necessary, by the way, considering the length we go to get that same picture at its best possible quality...). If it's not solvable... I'll go back hoping somebody will start to take more care of XySubsFilter in the future. I get it that madshi is already going above and beyond what one could reasonably expect. Actually, thanks again madshi for trying.
__________________
LG 77C1 - Denon AVC-X3800H - Windows 10 Pro 22H2 - Kodi DSPlayer (LAV Filters, xySubFilter, madVR, Sanear) - RTX 4070 - Ryzen 5 3600 - 16GB RAM |
18th October 2015, 10:51 | #33697 | Link | |
Registered User
Join Date: Nov 2012
Posts: 36
|
Quote:
So, when you say "DXVA decodes to a format that it hard to work with for madVR", that would mean that it's a general DXVA issue, not a native vs copyback issue. Last edited by tahaa7; 18th October 2015 at 10:54. |
|
18th October 2015, 10:52 | #33698 | Link | |
Registered User
Join Date: Feb 2012
Posts: 54
|
Quote:
Another thing that really interest me is to understand the "real" difference between xbr-100 and 150, I could not find any comparison but just people preferring one or the other but without a real explanation of the reason. |
|
18th October 2015, 10:58 | #33699 | Link | |
Registered User
Join Date: Oct 2012
Posts: 7,923
|
Quote:
DXVA copy back is not effected and AMD/INTEL DXVA native is not known for this issue. |
|
18th October 2015, 11:35 | #33700 | Link | |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,346
|
Quote:
Some more "tricky" ways to perform this conversion have different levels of success on different GPUs. It can result in a slightly blurred chroma channel. Software decoding or DXVA-CopyBack don't have this issue, because madVR doesn't have to perform such a conversion then and can instead feed the texture from the memory buffer instead. Trying to do the same for DXVA-Native would end up being practically the same as a CopyBack operation, so madshi decided to just let the user use LAV's copyback instead, since thats rather optimized.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders Last edited by nevcairiel; 18th October 2015 at 11:41. |
|
Tags |
direct compute, dithering, error diffusion, madvr, ngu, nnedi3, quality, renderer, scaling, uhd upscaling, upsampling |
Thread Tools | Search this Thread |
Display Modes | |
|
|