Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
25th January 2006, 16:15 | #1521 | Link | |
Registered User
Join Date: Sep 2005
Location: Germany
Posts: 68
|
Thanks for your reply Doom9. I've already tried it, without success. That's why
I was asking. I will ask in another thread then. Sorry! Quote:
|
|
25th January 2006, 17:16 | #1522 | Link | |
BeHappy/MeGUI developer
Join Date: Oct 2003
Location: Moscow, Russia
Posts: 1,727
|
Quote:
Code:
if (!inf.IsYV12() ) { res = env->Invoke("ConvertToYV12", AVSValue(&res, 1)); }
__________________
BeHappy - AviSynth-based audio transcoding tool Audio encoding via AviSynth On2 VP7 is great in quality but it is unusable for long-term video backup puposes! Sincerely Yours, MCPD/MCTS |
|
25th January 2006, 17:18 | #1523 | Link |
clueless n00b
Join Date: Oct 2001
Location: somewhere over the rainbow
Posts: 10,579
|
well.. considering how many times the error has come up and nothing had been done I doubt there ever will.. we should proceed under the assumption that encoders stay the way they are, and editing and reloading the avs input file.. that's not really the job of an encoder.
__________________
For the web's most comprehensive collection of DVD backup guides go to www.doom9.org |
25th January 2006, 17:27 | #1524 | Link | |
BeHappy/MeGUI developer
Join Date: Oct 2003
Location: Moscow, Russia
Posts: 1,727
|
Quote:
really, it encoder reques avs with yv12 support it means encoder are working with avs via avisynth.dll (there are no other way to get yv12 from it, AviFile32 API performs RGB24 conversion). In this case is pretty easy to invoke additional AviSynth function like ConvertToYV12()...
__________________
BeHappy - AviSynth-based audio transcoding tool Audio encoding via AviSynth On2 VP7 is great in quality but it is unusable for long-term video backup puposes! Sincerely Yours, MCPD/MCTS |
|
25th January 2006, 17:47 | #1525 | Link | |
Registered User
Join Date: Feb 2005
Posts: 39
|
Quote:
Code:
AVIReader *reader=new AVIReader(fileName); if (!reader) blahblah |
|
25th January 2006, 17:50 | #1526 | Link | |
BeHappy/MeGUI developer
Join Date: Oct 2003
Location: Moscow, Russia
Posts: 1,727
|
Quote:
__________________
BeHappy - AviSynth-based audio transcoding tool Audio encoding via AviSynth On2 VP7 is great in quality but it is unusable for long-term video backup puposes! Sincerely Yours, MCPD/MCTS |
|
25th January 2006, 18:01 | #1527 | Link |
Registered User
Join Date: Apr 2004
Posts: 287
|
I wrote that particular piece of code as DirectShowSource wasn't loading my AVI files at all. It needed me to pass the FPS parameter to it before it would load my AVI files. I can guarantee no-one else spotted this problem before i added that code because the AVS generation was broken in MeGUI for AVI sources, and i only encountered the FPS problem after i fixed the AVS generation for AVI sources.
What do you mean by two local objects? There's only one reader there...
__________________
Nothing to see here... |
25th January 2006, 18:09 | #1528 | Link | |
BeHappy/MeGUI developer
Join Date: Oct 2003
Location: Moscow, Russia
Posts: 1,727
|
Quote:
Thanx!
__________________
BeHappy - AviSynth-based audio transcoding tool Audio encoding via AviSynth On2 VP7 is great in quality but it is unusable for long-term video backup puposes! Sincerely Yours, MCPD/MCTS |
|
25th January 2006, 18:11 | #1529 | Link |
Registered User
Join Date: Feb 2005
Posts: 39
|
Ups, I forgot you where using C#, perhaps its different than in C++
Code:
AVIReader reader; Code:
reader = new AVIReader Sorry to confuse you. If your code would create 2 Instances it wouldn't compile anyway <- never trys to understand C# |
25th January 2006, 18:43 | #1530 | Link | |
Registered User
Join Date: Jun 2002
Location: On thin ice
Posts: 6,837
|
Quote:
@pest Yes, .NET is different.
__________________
https://github.com/stax76/software-list https://www.youtube.com/@stax76/playlists Last edited by stax76; 25th January 2006 at 18:46. |
|
25th January 2006, 22:28 | #1531 | Link | |
Registered User
Join Date: Apr 2005
Posts: 1,740
|
To all devs:
Quote:
Also, I think it would generally be a good idea to look at the first post of the Feature Request thread, as there are quite a few new requests (mostly from me), once Doom9 approves them. Last edited by berrinam; 25th January 2006 at 22:33. |
|
25th January 2006, 23:45 | #1535 | Link | |
Registered User
Join Date: Apr 2004
Posts: 287
|
Quote:
I suppose that that makes my little addition redundant. I'll investigate further and see if i can figure out why i got the FPS error. But for the moment, i think its looking like that bit of code is just a waste of CPU cycles. EDIT: Just a heads up, i'm finishing off a report for college, so i should be back into coding again by saturday. So if someone wants to grab the bitrate calculator before then, feel free. Otherwise i'll take a look at it on saturday.
__________________
Nothing to see here... Last edited by Mutant_Fruit; 25th January 2006 at 23:51. |
|
26th January 2006, 01:18 | #1537 | Link | |
Registered User
Join Date: Apr 2005
Posts: 1,740
|
Quote:
Code:
svn co svn://svn.videolan.org/x264/trunk x264 However, it may not be such a good idea to add ConvertToYV12 silently, because it means that AviSynth error clips will also be encoded without realising it. In my opinion, a better idea would be for MeGUI to check the colorspace before it sends it to the encoder (I mentioned that here: http://forum.doom9.org/showthread.ph...47#post772747), because it should be the GUI's job. If someone knows enough to use the commandline, they will know what a colorspace error is, and they will prefer to know about it, so that they can fix it in a (perhaps) better way than simply converttoyv12. Last edited by berrinam; 26th January 2006 at 04:40. |
|
26th January 2006, 09:26 | #1538 | Link | |
Squeeze it!
Join Date: Oct 2003
Location: Germany
Posts: 472
|
Quote:
Here a piece of code Code:
BITMAPINFOHEADER bih; ZeroMemory(&bih, sizeof(BITMAPINFOHEADER)); bih.biBitCount=24; //24 bit per pixel bih.biClrImportant=0; bih.biClrUsed = 0; bih.biCompression = BI_RGB; bih.biPlanes = 1; bih.biSize = 40; bih.biXPelsPerMeter = 0; bih.biYPelsPerMeter = 0; //calculate total size of RGBQUAD scanlines (DWORD aligned) bih.biSizeImage = (((bih.biWidth * 3) + 3) & 0xFFFC) * bih.biHeight ; PGETFRAME pFrame; // Let the Handler decide which Colorspace matches best your display: pFrame=AVIStreamGetFrameOpen(pStream, AVIGETFRAMEF_BESTDISPLAYFMT); // Or do force the decompressor to use the Cspace as given in the bih above: pFrame=AVIStreamGetFrameOpen(pStream, &bih); This weekend Ill add to the AvsRedirect/AvsWrapper some calls to avs's streamdetection (cspace etc etc etc). Btw. In the avs_openscript command I did implement a routine so you can force the outputted Cspace via a simple String ("YV12","YUY2", "RGB24", "RGB32"). So depending on the encoder the user choosed you can force in MeGUI to serve the encoders native Cspace. Last edited by Inc; 26th January 2006 at 09:47. |
|
26th January 2006, 11:15 | #1539 | Link | |
clueless n00b
Join Date: Oct 2001
Location: somewhere over the rainbow
Posts: 10,579
|
Quote:
__________________
For the web's most comprehensive collection of DVD backup guides go to www.doom9.org |
|
Tags |
development, megui, not a help thread |
Thread Tools | Search this Thread |
Display Modes | |
|
|