Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
27th February 2014, 21:45 | #23961 | Link | ||
Registered User
Join Date: Oct 2009
Posts: 930
|
Quote:
Quote:
It guesses bt.709 here too but I don't get a proper image. I previously tried using those flags, but it didn't do anyhting it already guessed the same thing (bt.709) for both. I noticed that the madvr allows me to cycle between colormatrices. If I choose bt.709 manually the colors were wrong in a different way. The image became more purplish. So that's weird... http://screenshotcomparison.com/comparison/64650 It didn't let me change the color primries though (gamut conversion disabled). Why is that? Is it important? Could you (or someone else) upload my transcoded sample somewhere? If it would be good there and bad here, at least I would know that I'm not doing anything wrong... Last edited by mzso; 27th February 2014 at 21:55. |
||
27th February 2014, 22:00 | #23962 | Link | |
Registered User
Join Date: Dec 2008
Posts: 496
|
Quote:
Last edited by iSunrise; 27th February 2014 at 22:07. |
|
27th February 2014, 22:01 | #23963 | Link |
Registered User
Join Date: Dec 2002
Posts: 5,565
|
@mzso @aufkrawall (@madshi)
It's not an issue with wrong flags, the file is correctly detected as full range BT.709. I made a lossless encode and the YUV 4:4:4 part looks different through madVR: http://abload.de/img/ll_dither_madvr_ccujp.png (MPC-HC snapshot function of avs script opened with madVR) http://abload.de/img/ll_dither_imagewriter5iu8w.png (screen from avs script through ImageWriter()) http://abload.de/img/ll_112_madvr2hu21.png (MPC-HC snapshot function of sample opened with madVR) http://www.file-upload.net/download-...ut_ll.mkv.html Script for the screenshots: Code:
lwlibavvideosource("output_ll.mkv") Dither_convert_yuv_to_rgb(matrix="709", tv_range=false, output="rgb24") |
27th February 2014, 22:02 | #23964 | Link | |
Broadband Junkie
Join Date: Oct 2005
Posts: 1,859
|
Quote:
For calibration, Argyll takes single measurements until it hits a target threshold with dE repeatability. For profiling, it takes single measurements of all test patches as well. If you have duplicate patches, it will average them when creating a LUT or matrix though. That said, targen only adds duplicates for 100% white by default. In the past, I actually suggested adding an averaging function to make measurements more reliable, but Graeme rejected it. Instead he implemented an option for adaptive integration time, which was overall faster solution for my i1pro low-light measurement woes. He has generally been very adverse to making changes which increase (already comparatively very slow) calibration and profiling times even more. Reading every patch multiple times, would just make Argyll CMS orders of magnitude slower. Nothing would prevent you from creating custom patch sets with lots of duplicates, but I don't see him as making this the default. With massive patch sets, instrument drift starts to become a concern as well. Last edited by cyberbeing; 27th February 2014 at 22:12. |
|
27th February 2014, 22:17 | #23965 | Link | |
Registered User
Join Date: Dec 2011
Posts: 1,812
|
Quote:
|
|
27th February 2014, 22:17 | #23966 | Link | |
Registered User
Join Date: Dec 2008
Posts: 496
|
Quote:
Last edited by iSunrise; 27th February 2014 at 22:20. |
|
27th February 2014, 22:22 | #23967 | Link | |
Registered User
Join Date: Dec 2013
Posts: 753
|
Quote:
In this case the vast majority of pixels are green, which isn't supposed to happen. To illustrate this I created the following images by lowering the bitdepth to 3 bits, blurring the image, and then increasing the saturation by 100: Ordered dithering Error Diffusion Clearly something is off with the ordered dithering, nearly all pixels are green. Edit: This also seems to occur in 8bit but this is somewhat harder to show. Last edited by Shiandow; 27th February 2014 at 22:28. |
|
27th February 2014, 22:26 | #23968 | Link | |
Audiophile
Join Date: Oct 2006
Posts: 353
|
Quote:
Right now I have madVR set to 7-bit with NO dithering. Turning dithering on seems to be counter-productive as it costs performance and I see absolutely no difference in the video, even when I look at the video very closely. My initial thought about dithering was that it helps mainly with madVR's processing of the video(upscaling, debanding, etc...) but now it looks like it doesn't. |
|
27th February 2014, 22:51 | #23971 | Link |
Registered User
Join Date: May 2012
Posts: 447
|
Converting from YUV420 to RGB, chroma doubling, image upscaling and downscaling will all generate values with a fractional part, so dithering will almost always be needed. Does 6-bit + dithering look good to you, or does it just look noisier than 7 or 8 bit without dithering?
__________________
Test patterns: Grayscale yuv444p16le perceptually spaced gradient v2.1 (8-bit version), Multicolor yuv444p16le perceptually spaced gradient v2.1 (8-bit version) |
27th February 2014, 23:39 | #23973 | Link |
Broadband Junkie
Join Date: Oct 2005
Posts: 1,859
|
I think that may just be how it is, at least with the Ordered Dither method madshi has chosen. This is part of the reason why I mentioned earlier that people should reassess the use of monoColor dynamic instead of oppositeColor dynamic for Ordered Dither. If the luma noise level of monoColor (like the OD32 test build) is found to be within an acceptable range, it may make a better default for madVR. Otherwise, maybe madshi should toss multiColor at it and see if it behaves any better.
Last edited by cyberbeing; 27th February 2014 at 23:42. |
28th February 2014, 00:14 | #23974 | Link |
Registered User
Join Date: Dec 2013
Posts: 753
|
Well, I don't know what the exact reason is behind the 'green tint' but it is definitely something which can (and should) be fixed. Whether chroma noise is preferrable to luma noise is a different debate and this issue is almost completely irrelevant. In fact depending on what the reason behind this bug is the monoColored build might be 'wrong' as well except it isn't noticeable since all channels behave the same way.
|
28th February 2014, 00:48 | #23975 | Link |
Broadband Junkie
Join Date: Oct 2005
Posts: 1,859
|
Well the other part of the reason I mentioned it, was that some of the dense heavy patterns ordered dither produces at times seemed more noticeable with colored vs mono, though I guess it's possible both could be related.
monoColor ordered dither also seemed to have a tendency towards combining luma with single color dots, but rarely two different colors dots + luma like monoColored error-diffusion does. I had assumed this was intentional, but if not, the bug probably does affect monoColor as well. From what I remember, the oppositeColor color noise distribution seemed logical based on monoColor luma noise, as both shared identical patterns. Last edited by cyberbeing; 28th February 2014 at 01:13. |
28th February 2014, 05:56 | #23979 | Link | ||
Registered User
Join Date: Sep 2013
Posts: 919
|
I can't reproduce the green tint effect with OD32 & 3-bit.
I have equal balance between Green and Magenta. Did you disable 3DLUT? Here is a screenshot from my setup: 3bit OD32 Color Quote:
With a single measurement, Static will be more reliable.
__________________
System: i7 3770K, GTX660, Win7 64bit, Panasonic ST60, Dell U2410. Last edited by James Freeman; 28th February 2014 at 06:21. |
||
28th February 2014, 06:43 | #23980 | Link |
Registered User
Join Date: Feb 2002
Location: San Jose, California
Posts: 4,407
|
The new dithering options are great! I like Error Diffusion - option 2, no colored noise, and change dither for every frame. Never looked better.
I finally figured out how to make madVR handle GPU gamma ramps and 3DLUTs in the way I want. The only problem is that I needed to use a hex editor to remove the linear gamma ramps from the 3DLUT created by argyllcms. I want madVR to ignore the GPU's gamma ramps (use only the 3DLUT for calibration) while not resetting the gamma ramps for everything else. I discovered "disable GPU gamma ramps" only has an effect if the 3DLUT does not have an attached set of ramps. "disable GPU gamma ramps" does exactly what I want when used with a 3DLUT without attached ramps. The issue is that to get a good white point with argyllcms I need to include the calibrated gamma ramps in the 3DLUT creation, if I do that linear gamma ramps are appended to the 3DLUT which get applied by madVR (changing the white point for Windows). I think these ramps should not be applied if "disable GPU gamma ramps" is checked, that setting should over-write argyll instead of the other way around. It isn't really a major issue, the linear ramp that needs deleting is at the end of the file and its start is obvious when looking at the file in a hex editor. I do like the ramp being included in the file, I just want madVR to ignore it sometimes. |
Tags |
direct compute, dithering, error diffusion, madvr, ngu, nnedi3, quality, renderer, scaling, uhd upscaling, upsampling |
Thread Tools | Search this Thread |
Display Modes | |
|
|