Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > General > Subtitles

Reply
 
Thread Tools Search this Thread Display Modes
Old 7th May 2018, 20:29   #1421  |  Link
hubblec4
Matroska Dev-Helper
 
Join Date: Apr 2008
Posts: 892
Ok fine, I thought you ignore me :-)
hubblec4 is offline   Reply With Quote
Old 7th May 2018, 22:29   #1422  |  Link
amichaelt
Registered User
 
Join Date: Apr 2018
Posts: 51
Quote:
Originally Posted by hubblec4 View Post
Ok fine, I thought you ignore me :-)
Nope. Also one of your issues was not an issue (running on Linux as it already can) and the other was one I had already been fixed and committed and will be in the future build (embedding the version info in the exe itself rather than relying on the file name). The other two I have put on my backlog of stuff to do.
__________________
My project BDSup2Sub++: https://github.com/amichaeltm/BDSup2SubPlusPlus
amichaelt is offline   Reply With Quote
Old 9th May 2018, 13:36   #1423  |  Link
BizkitBoy
Registered User
 
Join Date: Dec 2017
Posts: 1
BDSup2Sub++ 1.0.2 forced subs issue

Sorry if this has been posted/reported before, but I have searched the forum and didn't manage to find an answer.

I have an issue with BDSup2Sub++ 1.0.2
The Global Forced Flags setting isn't working properly when importing an XML file and then trying to export it as SUP.
Although the XML file does contain for each PNG the Forced flag which is set to either Forced="False" or Forced="True", when selecting in BDSup2Sub++ 1.0.2 the Force All flag to "keep" and exporting to SUP, it just marks as forced all the PNGs. Actually, this happens no matter what value you set in the Force All flag.

I noticed this happens only when importing XML files.

Has anyone found a fix or workaround?
BizkitBoy is offline   Reply With Quote
Old 9th May 2018, 15:58   #1424  |  Link
r0lZ
PgcEdit daemon
 
r0lZ's Avatar
 
Join Date: Jul 2003
Posts: 7,207
Indeed, the ++ version has a bug. Just tried to convert an XML with the first subtitle forced and all others normal. In the GUI, the forced: yes or no information is correct, but when the stream is saved as a BD SUP, all subtitles are marked as forced. The Export Only Forced option works correctly.
The Java version of BDSup2Sub (v5.1.2) has not that bug.
__________________
r0lZ
PgcEdit homepage (hosted by VideoHelp)
BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV
r0lZ is offline   Reply With Quote
Old 9th May 2018, 16:36   #1425  |  Link
von Suppé
Registered User
 
Join Date: Dec 2013
Posts: 235
I can confirm BDSup2Sub++'s behaviour as BizkitBoy told.
It even doesn't recognize the forced lines in it's own created XML-PNG (with forced flags).

Indeed the Java version works for this.
BTW, I always check the "Change frame rate" window and set both "FPS Source" - and "FPS Target" rates, even when no framerate change is needed.

amichaelt will be busy...

Last edited by von Suppé; 9th May 2018 at 16:44.
von Suppé is offline   Reply With Quote
Old 9th May 2018, 16:54   #1426  |  Link
amichaelt
Registered User
 
Join Date: Apr 2018
Posts: 51
Quote:
Originally Posted by BizkitBoy View Post
Sorry if this has been posted/reported before, but I have searched the forum and didn't manage to find an answer.

I have an issue with BDSup2Sub++ 1.0.2
The Global Forced Flags setting isn't working properly when importing an XML file and then trying to export it as SUP.
Although the XML file does contain for each PNG the Forced flag which is set to either Forced="False" or Forced="True", when selecting in BDSup2Sub++ 1.0.2 the Force All flag to "keep" and exporting to SUP, it just marks as forced all the PNGs. Actually, this happens no matter what value you set in the Force All flag.

I noticed this happens only when importing XML files.

Has anyone found a fix or workaround?
The fix will be me debugging the code. Don't be sorry, I appreciate all these reports. Please keep them coming.

https://github.com/amichaeltm/BDSup2SubPlusPlus/issues

I finished up all the current cleanup stuff I want to do and I'll tag a 1.3 release later today and then start working on the next version in the coming days.
__________________
My project BDSup2Sub++: https://github.com/amichaeltm/BDSup2SubPlusPlus

Last edited by amichaelt; 9th May 2018 at 16:56.
amichaelt is offline   Reply With Quote
Old 9th May 2018, 17:06   #1427  |  Link
hubblec4
Matroska Dev-Helper
 
Join Date: Apr 2008
Posts: 892
Quote:
Originally Posted by von Suppé View Post
BTW, I always check the "Change frame rate" window and set both "FPS Source" - and "FPS Target" rates, even when no framerate change is needed.
Yes I can confirm this and this little workaround is used in my cE.
hubblec4 is offline   Reply With Quote
Old 9th May 2018, 21:10   #1428  |  Link
hubblec4
Matroska Dev-Helper
 
Join Date: Apr 2008
Posts: 892
Thanks for the new version. Why is the exe(x64 over 15mb) so big? Version 1.02 is smaller then 4mb.
hubblec4 is offline   Reply With Quote
Old 9th May 2018, 21:47   #1429  |  Link
amichaelt
Registered User
 
Join Date: Apr 2018
Posts: 51
Quote:
Originally Posted by hubblec4 View Post
Thanks for the new version. Why is the exe(x64 over 15mb) so big? Version 1.02 is smaller then 4mb.
Forgot to run UPX on it. Will fix that and reupload.

Also, despite what I said earlier about Linux binaries since I got Travis-CI working I'm now working on getting it to output appimages for Linux. Will need other people to test though since I don't run Linux anymore and I'm not gonna make a bunch of distro-specific packages.

Edit to add: The uploaded files are now fixed.
__________________
My project BDSup2Sub++: https://github.com/amichaeltm/BDSup2SubPlusPlus

Last edited by amichaelt; 9th May 2018 at 22:18.
amichaelt is offline   Reply With Quote
Old 9th May 2018, 22:20   #1430  |  Link
hubblec4
Matroska Dev-Helper
 
Join Date: Apr 2008
Posts: 892
Quote:
Originally Posted by amichaelt View Post
...
Also, despite what I said earlier about Linux binaries since I got Travis-CI working I'm now working on getting it to output appimages for Linux. Will need other people to test though since I don't run Linux anymore and I'm not gonna make a bunch of distro-specific packages.
...
Thats sounds great, I will use it for my cE on Linux. I can/will test some feaures. I use LinuxMint (and I will try the new Ubuntu).

Last edited by hubblec4; 9th May 2018 at 22:23.
hubblec4 is offline   Reply With Quote
Old 9th May 2018, 22:22   #1431  |  Link
amichaelt
Registered User
 
Join Date: Apr 2018
Posts: 51
Quote:
Originally Posted by hubblec4 View Post
Thats sounds great, I will use it for my cE on Linux. I can/will test some feaures.
Thanks. I'll let you know when it's ready if you can be my first tester.
__________________
My project BDSup2Sub++: https://github.com/amichaeltm/BDSup2SubPlusPlus
amichaelt is offline   Reply With Quote
Old 10th May 2018, 02:39   #1432  |  Link
amichaelt
Registered User
 
Join Date: Apr 2018
Posts: 51
AppImage build finally worked and deployed. It can be grabbed here. Please let me know if it works or has any issues.
__________________
My project BDSup2Sub++: https://github.com/amichaeltm/BDSup2SubPlusPlus
amichaelt is offline   Reply With Quote
Old 10th May 2018, 08:35   #1433  |  Link
von Suppé
Registered User
 
Join Date: Dec 2013
Posts: 235
amichaelt, call me stupid, but where the heck can I find the latest for Windows?
I don't know what file I must download?
von Suppé is offline   Reply With Quote
Old 10th May 2018, 08:52   #1434  |  Link
r0lZ
PgcEdit daemon
 
r0lZ's Avatar
 
Join Date: Jul 2003
Posts: 7,207
Quote:
Originally Posted by von Suppé View Post
BTW, I always check the "Change frame rate" window and set both "FPS Source" - and "FPS Target" rates, even when no framerate change is needed.
As far as I know, only the Java versions are affected by that bug. The ++ version sets correctly the FPS Target to the same frame rate as the FPS Source, and therefore there is no need to force the conversion of the frame rate to avoid the small timecode changes due to the alignment of the timecodes to the video frames.
IMO, there is nothing to fix here.
__________________
r0lZ
PgcEdit homepage (hosted by VideoHelp)
BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV
r0lZ is offline   Reply With Quote
Old 10th May 2018, 08:59   #1435  |  Link
von Suppé
Registered User
 
Join Date: Dec 2013
Posts: 235
Quote:
Originally Posted by r0lZ View Post
As far as I know, only the Java versions are affected by that bug. The ++ version sets correctly the FPS Target to the same frame rate as the FPS Source, and therefore there is no need to force the conversion of the frame rate to avoid the small timecode changes due to the alignment of the timecodes to the video frames.
IMO, there is nothing to fix here.
I agree.
But as I am using both versions I sometimes forget or get confused what version has what bugs to take into account. So, to avoid problems I got myself used to always do this framerate setting. Thanks for the reminder r0lZ.
von Suppé is offline   Reply With Quote
Old 10th May 2018, 09:35   #1436  |  Link
r0lZ
PgcEdit daemon
 
r0lZ's Avatar
 
Join Date: Jul 2003
Posts: 7,207
Quote:
Originally Posted by von Suppé View Post
amichaelt, call me stupid, but where the heck can I find the latest for Windows?
I don't know what file I must download?
Click the "4 releases" link just above the red line. You will be redirected here.
__________________
r0lZ
PgcEdit homepage (hosted by VideoHelp)
BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV
r0lZ is offline   Reply With Quote
Old 10th May 2018, 10:59   #1437  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,641
@amichaelt
Didn't you say you wanted to create a specific thread specific for the ++ version, discussion bugs, etc...
__________________
My github.
jpsdr is offline   Reply With Quote
Old 10th May 2018, 14:26   #1438  |  Link
hubblec4
Matroska Dev-Helper
 
Join Date: Apr 2008
Posts: 892
Quote:
Originally Posted by amichaelt View Post
AppImage build finally worked and deployed. It can be grabbed here. Please let me know if it works or has any issues.
My first quick tests works perfect. Many thanks.

EDIT:
Could you also the linux binary(exe) named BDSup2Sub++ only?

Last edited by hubblec4; 10th May 2018 at 15:02.
hubblec4 is offline   Reply With Quote
Old 14th May 2018, 14:29   #1439  |  Link
amichaelt
Registered User
 
Join Date: Apr 2018
Posts: 51
Yeah, I’ll fix the naming on the appimage when I push the next next version.

Also, I’ve been able to fix two of the more egregious bugs from r0lz fairly easily. The one where subtitle positions would get messed up was a lack of an absolute value being applied to the X and Y offsets after transparency cropping. The one with the borked up XML+PNG with empty PNGs was do to the coden iterating over a map of the composition objects incorrectly. I’m moving on now to the forced flags issues from hubble. Once I get those figured out I’ll push out a test build for people to beat on and start a new thread then.
__________________
My project BDSup2Sub++: https://github.com/amichaeltm/BDSup2SubPlusPlus
amichaelt is offline   Reply With Quote
Old 14th May 2018, 19:25   #1440  |  Link
r0lZ
PgcEdit daemon
 
r0lZ's Avatar
 
Join Date: Jul 2003
Posts: 7,207
Thanks. Very good news! I can't wait for the new version...
__________________
r0lZ
PgcEdit homepage (hosted by VideoHelp)
BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV
r0lZ is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 21:39.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.