Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Hardware & Software > Software players

Reply
 
Thread Tools Search this Thread Display Modes
Old 18th November 2014, 04:38   #41  |  Link
Neet009
Registered User
 
Join Date: Jan 2014
Posts: 21
Quote:
Originally Posted by -Vit- View Post
One of those days... Link in the OP fixed.
Thank you for updating. It works well now.
Neet009 is offline   Reply With Quote
Old 18th November 2014, 04:42   #42  |  Link
-Vit-
Registered User
 
Join Date: Jul 2010
Posts: 448
Quote:
Originally Posted by fairchild View Post
I can't seem to get any sharpening to work/be noticeable to my eyes with latest 1.7.7 MPC-HC using the CTRL+Y toggle which basically just toggles through all the different shader presets. I have the default set to no shaders, then I have one setup/labeled as FineSharp which has the order as detailed in first post for pre-size (figured this one would be the best to use to not over sharpen)
Ctrl+Y - that does nothing by default, did you add it manually to the options? If not, then select with right-click>>Shaders..., or edit the keys in the options.

I finally noticed the Next Shader Preset and Prev Shader Preset option far down the list in Options>>Player>>Keys in the recent version. I didn't know about that, can finally upgrade, lol.

Works fine for me. Maybe you're expecting a stronger result, or a different look. Try pre and post resize together, or set sstr=4.0 and cstr=1.19 in FineSharpA, which is about as far as I would take things.

Last edited by -Vit-; 18th November 2014 at 05:18.
-Vit- is offline   Reply With Quote
Old 18th November 2014, 05:16   #43  |  Link
fairchild
Registered User
 
Join Date: Sep 2010
Posts: 319
Quote:
Originally Posted by -Vit- View Post
Ctrl+Y - that does nothing by default, did you add it manually to the options?

But I finally noticed the Next Shader Preset and Prev Shader Preset option far down the list in Options>>Player>>Keys in the recent version. I didn't know about that, can finally upgrade, lol.

Works fine for me. Maybe you're expecting a stronger result, or a different look. Try changing sstr=4.0 and cstr=1.19 in FineSharpA, which is as far as I would take things.
It's working now, I guess 1.11 did the trick. I see a clear difference now when doing CTRL+Y from my default of no shader preset, to the pre-size one. So I guess to obtain the mildest sharpening using it as a post-resize shader would be the best.
__________________
MPC-HC/MPC-BE, Lav Filters, MadVR
CPU: AMD Ryzen 5 1600, Video: AMD Radeon RX Vega 56 -> TCL S405 55", Audio: Audio-Technica M50S

Last edited by fairchild; 18th November 2014 at 05:24.
fairchild is offline   Reply With Quote
Old 18th November 2014, 05:27   #44  |  Link
-Vit-
Registered User
 
Join Date: Jul 2010
Posts: 448
That's up to your eyes. And depends on how clean your source is and the amount of upscale you are doing. And the size of your screen I suppose.

In general (upscaling) pre-resize is light, post is stronger, both together is strongest. The default sstr is sensible but can go down to 0.5 or up to about 4.0, with cstr changed to match. You can set a different sstr/cstr for the pre- and post- resize step (make two FineSharpA files) when using both together.

The stronger you apply this filter, the more it will pull out really faint detail, but then the more likely you will see grain like artefacts, especially around detail and edges, and also some fine bright halos. How much you can live with that determines the settings to use.
-Vit- is offline   Reply With Quote
Old 18th November 2014, 10:48   #45  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,137
Quote:
Originally Posted by -Vit- View Post
I guess you should give me a list of scripts that need HLSL versions. No promises, but on the rare occasions that I get some time I can have a look.
Oh, that would be just wonderful!!!!! I don't expect anything, but if you do find a bit of time at some point in the future, I'd be very happy. Here are my wishes, but to be honest, I don't know how much work converting any of these scripts would cost. Some might be too much work. Some might be relatively easy. I'd be very happy about any of them:

(1) A good general purpose de-noising shader. Ideal would be an algorithm which works reasonably well with the majority of content without needing content specific tweaks (other than a simple "denoise strength" slider). After a quick search maybe FluxSmoothST would be a good choice. Other alternatives might be SMDegain or MCTemporalDenoise.

(2) A basic version of QTGMC (or even TempGaussMC). I wouldn't need all the hoops and hopplas, just the most important core functionality. I could live with losing a few percent of quality by skipping some complicated/difficult algorithms. You could use bicubic interpolation instead of NNEDI3. I could then optionally replace that with NNEDI3 in madVR. But I suppose doing the motion estimation could be problematic in HLSL? Maybe OpenCL or DirectCompute would be more suitable for that?

(3) DeHalo_alpha.

(4) LimitedSharpenFaster.

(5) aWarpSharp2.

(6) Maybe just the part of QTGMC which removes the grain, scales it separately (or replaces it with noise with the same local properties) and later puts it back in. This would help making debanding work better for grainy sources.

BTW, if I allowed your shaders to access to a compute language, would you prefer DirectCompute or OpenCL? If you have no preferences, I might prefer DirectCompute because driver support from the various GPU manufacturers seems to be better, and because it's the same HLSL language, once again.
madshi is offline   Reply With Quote
Old 18th November 2014, 17:16   #46  |  Link
-Vit-
Registered User
 
Join Date: Jul 2010
Posts: 448
Quote:
Originally Posted by madshi View Post
Here are my wishes...
All of these will need intermediate textures. I could only do finesharp because it only needed one intermediate value at a time and only the luma, so I could use the alpha. Rarely that simple

(2) - QTGMC in shaders . Well, basic TGMC is pretty short, but needs MVTools2. Has that been converted to GPU yet? Doable with compute shaders but would take more time than I have.

(1) - SMDegain is just a indirect way of using MVTools. So same point as above. MCTemporalDenoise is pretty huge if I recall (and uses MVTools). FluxSmooth is a C(++) plugin, not a script - it's method is the simplest, so probably the most approachable.

(3),(4) dehalo, LSF - need intermediate textures but otherwise very doable.

(5) aWarpSharp. Another C++ plugin. Not looked at it so I don't know the algorithm.

(6) QTGMC noise pathway. Once you have (1), then storing and adding the noise back later is simple. So this is about rescaling noise. Fairly straightforward this one, but whether it will be effective for general rescaling I don't know. More complex if you think about interlaced sources. It's better to denoise prior to deinterlacing then add it back full frame.

DirectCompute or OpenCL is OK. I prefer DirectCompute.
-Vit- is offline   Reply With Quote
Old 18th November 2014, 17:40   #47  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,137
Quote:
Originally Posted by -Vit- View Post
All of these will need intermediate textures. I could only do finesharp because it only needed one intermediate value at a time and only the luma, so I could use the alpha. Rarely that simple
Makes sense. I'll move the extended shader support up in my to do list, with intermediate textures, maybe DirectCompute etc.

Quote:
Originally Posted by -Vit- View Post
(2) - QTGMC in shaders . Well, basic TGMC is pretty short, but needs MVTools2. Has that been converted to GPU yet? Doable with compute shaders but would take more time than I have.
AFAIK MVTools2 has not been converted to GPU yet, unfortunately. Maybe I'll put that on my to do list. Do QTGMC, SMDegrain, MCTemporalDenoise etc just use a subset of MVTools2? Or would all of MVTools2 have to be converted to GPU?

Quote:
Originally Posted by -Vit- View Post
(6) QTGMC noise pathway. Once you have (1), then storing and adding the noise back later is simple. So this is about rescaling noise. Fairly straightforward this one, but whether it will be effective for general rescaling I don't know. More complex if you think about interlaced sources. It's better to denoise prior to deinterlacing then add it back full frame.
Interesting. I didn't think about doing noise reduction before deinterlacing and later putting it back to the full frame. Makes sense, though. In any case, having this work just for progressive sources would already be a good start. Extending it for interlaced sources later should then not be such a big problem.
madshi is offline   Reply With Quote
Old 18th November 2014, 23:39   #48  |  Link
kasper93
MPC-HC Developer
 
Join Date: May 2010
Location: Poland
Posts: 556
Quote:
Originally Posted by -Vit- View Post
but that's doesn't have shortcut keys for shaders, which makes using them annoying.
You can make preset with shader and toggle through them with hotkeys.
kasper93 is offline   Reply With Quote
Old 20th November 2014, 07:15   #49  |  Link
BetA13
cosmic entity
 
BetA13's Avatar
 
Join Date: May 2011
Location: outside the Box
Posts: 217
tiny question?!?!?!

"Attachments Pending Approval
File Type: zip finesharp_shaders_1.11.zip"

why does this approval take so loong.. its been over 3 days now? isnt it??!?!?!

i wanna test this new version, hehe..

gretez
BetA13 is offline   Reply With Quote
Old 20th November 2014, 08:56   #50  |  Link
Shiandow
Registered User
 
Join Date: Dec 2013
Posts: 752
The first post also contains this link, just below the caption "installation".
Shiandow is offline   Reply With Quote
Old 20th November 2014, 08:59   #51  |  Link
BetA13
cosmic entity
 
BetA13's Avatar
 
Join Date: May 2011
Location: outside the Box
Posts: 217
Quote:
Originally Posted by Shiandow View Post
The first post also contains this link, just below the caption "installation".
i didnt saw it as link, haha...

much apprechiated..
BetA13 is offline   Reply With Quote
Old 19th December 2014, 08:06   #52  |  Link
RainyDog
Registered User
 
Join Date: May 2009
Posts: 174
Thanks very much for this -Vit-.

I've been happily using lumasharpen from the CeeJay's SweetFX shaders for the past few months. Can any of you technical fellows explain the main difference between that and FineSharp please?

RainyDog is offline   Reply With Quote
Old 23rd December 2014, 09:50   #53  |  Link
TheElix
Registered User
 
Join Date: May 2010
Posts: 236
Did anyone try combining this shader with ffdshow's unsharp mask (or with Darbee)?
TheElix is offline   Reply With Quote
Old 6th February 2015, 23:17   #54  |  Link
kasper93
MPC-HC Developer
 
Join Date: May 2010
Location: Poland
Posts: 556
Quote:
Originally Posted by -Vit- View Post
It was written for madVR (need the 16-bit accuracy in the shader chain), but also works in MPDN.
We can also enable full/half floating point processing in EVR-CP. And it works just fine with this package.

Last edited by kasper93; 30th March 2015 at 14:48.
kasper93 is offline   Reply With Quote
Old 7th February 2015, 11:57   #55  |  Link
feelingblue
Registered User
 
Join Date: Nov 2011
Posts: 48
Quote:
Originally Posted by TheElix View Post
Did anyone try combining this shader with ffdshow's unsharp mask (or with Darbee)?
I have HTPC and darbee as external video preocessor.
I also have the DVD iscan mini.

I have done a lot of test but.. finesharp is is made to be used alone, without other PP.
Best PQ is with FS alone, the only other PP that is acceptable is Unsharp mask used after fine sharp.

The worst of all group is Darbee.
I don't like it. the immage become unnatural, overprocessed and to countered
feelingblue is offline   Reply With Quote
Old 7th February 2015, 22:51   #56  |  Link
shaolin95
Registered User
 
Join Date: Aug 2005
Posts: 241
Quote:
Originally Posted by feelingblue View Post
I have HTPC and darbee as external video preocessor.
I also have the DVD iscan mini.

I have done a lot of test but.. finesharp is is made to be used alone, without other PP.
Best PQ is with FS alone, the only other PP that is acceptable is Unsharp mask used after fine sharp.

The worst of all group is Darbee.
I don't like it. the immage become unnatural, overprocessed and to countered
Thanks for the beedback on Darbee. Some people at avsforum swear by it but I had my doubts though I never have seen it
shaolin95 is offline   Reply With Quote
Old 30th March 2015, 14:50   #57  |  Link
kasper93
MPC-HC Developer
 
Join Date: May 2010
Location: Poland
Posts: 556
New madVR v0.87.15 added option, which is enabled by default:
Quote:
* new trade option "lose BTB and WTW if it improves performance"
You need to disable this option in order to make this shader pack work. I figured I tell you now to avoid questions later
kasper93 is offline   Reply With Quote
Old 30th March 2015, 17:12   #58  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,137
Thanks for the heads-up, kasper93, that's good to know.
madshi is offline   Reply With Quote
Old 1st April 2015, 00:15   #59  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,137
FWIW, I'd suggest to modify the ToYUV und ToRGB shaders slightly like this:

ToYUV:
Code:
float3 yuv = mul( height<576 ? RGBtoYUV_601 : RGBtoYUV_709, Src(0,0).rgb ) + float3(0.0, 0.5, 0.5);
ToRGB:
Code:
float4 o = Src(0,0) - float4(0.0, 0.5, 0.5, 0.0);
These changes simply move the chroma channels from the [-0.5..+0.5] range to the [0..1] range, which means that we don't have to use floating point textures, anymore.
madshi is offline   Reply With Quote
Old 1st April 2015, 00:42   #60  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
Yes this change would be necessary for MPDN's UNORM (which is the default now) texture too.
Zachs is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 22:27.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.