Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Hardware & Software > Software players

Reply
 
Thread Tools Search this Thread Display Modes
Old 19th July 2013, 23:28   #19641  |  Link
xabregas
Registered User
 
Join Date: Jun 2011
Posts: 121
Quote:
Originally Posted by cyberbeing View Post
To-do list. The subtitle interface was explicitly designed to support this, but madVR doesn't yet expose this functionality to users.
so for me MPC internal subtitle renderer is still needed
xabregas is offline   Reply With Quote
Old 20th July 2013, 02:38   #19642  |  Link
cyberbeing
Broadband Junkie
 
Join Date: Oct 2005
Posts: 1,859
Quote:
Originally Posted by huhn View Post
will it only move subtitle without positioning information.

like top/bot subs but not typesets?
That's the plan. This is the next feature we plan to implement in XySubFilter.
cyberbeing is offline   Reply With Quote
Old 20th July 2013, 04:14   #19643  |  Link
shimaflarex
Registered User
 
Join Date: Oct 2011
Posts: 41
It seems the alpha blending bug only happens for me if I start playback with "optimize subtitle quality for performance instead of quality". Is that supposed to happen?
Changing it during playback has no effect.

As madshi said, using 10bit image buffer also fixes it.
shimaflarex is offline   Reply With Quote
Old 20th July 2013, 07:43   #19644  |  Link
bugmen0t
Banned
 
Join Date: May 2012
Location: _Lies|Greed|Misery_
Posts: 114
Quote:
Originally Posted by DragonQ View Post
madshi, I have a log where I closed MPC-HC 1-2 seconds after I saw a black frame using smooth motion. How much of the 3.25 GiB log do you need?
Hallelujah! I tried several weeks without success.
Madshi only needs a short part around the black frame. So maybe the last 10 or 30 seconds will do. Note that the log can be heavily compressed by 7zip or WinRAR with text compression enabled.
bugmen0t is offline   Reply With Quote
Old 20th July 2013, 10:54   #19645  |  Link
DragonQ
Registered User
 
Join Date: Mar 2007
Posts: 934
Yeah but the timestamping isn't clear, I have no idea how much of it is the last 30 seconds. The final timestamp is labelled "00977632" and the penultimate line is "00977608". :/
__________________
TV Setup: LG OLED55B7V; Onkyo TX-NR515; ODroid N2+; CoreElec 9.2.7
DragonQ is offline   Reply With Quote
Old 20th July 2013, 12:13   #19646  |  Link
Soukyuu
Registered User
 
Soukyuu's Avatar
 
Join Date: Apr 2012
Posts: 169
Quote:
Originally Posted by shimaflarex View Post
It seems the alpha blending bug only happens for me if I start playback with "optimize subtitle quality for performance instead of quality". Is that supposed to happen?
Changing it during playback has no effect.

As madshi said, using 10bit image buffer also fixes it.
I noticed the same and made a new issue summarizing everything on madshi's bugtracker
Soukyuu is offline   Reply With Quote
Old 20th July 2013, 12:27   #19647  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Quote:
Originally Posted by cyberbeing View Post
Can you detect such GPUs and do this automatically?
Yes.

Quote:
Originally Posted by xabregas View Post
As for the refresh rate, not sure whats the correct refresh rate of my screen but CTRL+ J gives me 60.0014HZ on my sony TV and 59,9475HZ on my DELL desktop monitor
That's the refresh rate your GPU is outputting. It's still possible that your display runs at a different internal refresh rate. If so, there's no way to find out, except by either trying to get the information from some tech forum, or by trying to output various refresh rates via your GPU and checking which one results in the ghosting going away...

Quote:
Originally Posted by xabregas View Post
i`ve just installed xysub but i dont know where is the option to put subtitles in the botton black bar on 2.35 movies
Not sure I understand that. What kind of subtitles are we talking about? ASS? SRT? VOB? PGS? Is that a Blu-Ray movie? Or a custom encode where the black bars have been removed and are not encoded in the movie?

Quote:
Originally Posted by Soukyuu View Post
Currently, madvr sets both the decoding and subtitle queue via cpu queue parameter. Could we have those separated in the future (if it makes sense internally)?

edit: About the only reason I'd want to have it is for more responsive jumping, since the decoding queue never falls below 63/64 while subtitle queue does drop to 11/64 on some heavily styled subs (and that's on a 4GHz X4 970BE cpu...)
So you want a larger subtitle queue than decoder queue? Not sure if I want to offer that functionality. I guess it depends on how many people really need it. It might be a better idea to get the XySubFilter devs to implement proper multi-threading.

Quote:
Originally Posted by DragonQ View Post
madshi, I have a log where I closed MPC-HC 1-2 seconds after I saw a black frame using smooth motion. How much of the 3.25 GiB log do you need?
Great!! The last maybe 1-2 minutes of playback would be great.

Quote:
Originally Posted by DragonQ View Post
Yeah but the timestamping isn't clear, I have no idea how much of it is the last 30 seconds. The final timestamp is labelled "00977632" and the penultimate line is "00977608". :/
Those are milliseconds. So if 00977632 is the last line then substract 2 * 60 * 1000 to get the last 2 minutes of playback. So that would be everything higher than 857632.

Quote:
Originally Posted by shimaflarex View Post
It seems the alpha blending bug only happens for me if I start playback with "optimize subtitle quality for performance instead of quality". Is that supposed to happen?
Changing it during playback has no effect.

As madshi said, using 10bit image buffer also fixes it.
This will be fixed in the next build.
madshi is offline   Reply With Quote
Old 20th July 2013, 12:42   #19648  |  Link
DragonQ
Registered User
 
Join Date: Mar 2007
Posts: 934
Quote:
Originally Posted by madshi View Post
Those are milliseconds. So if 00977632 is the last line then substract 2 * 60 * 1000 to get the last 2 minutes of playback. So that would be everything higher than 857632.
I see. Log is here.
__________________
TV Setup: LG OLED55B7V; Onkyo TX-NR515; ODroid N2+; CoreElec 9.2.7
DragonQ is offline   Reply With Quote
Old 20th July 2013, 12:47   #19649  |  Link
xabregas
Registered User
 
Join Date: Jun 2011
Posts: 121
Quote:
Originally Posted by madshi View Post


That's the refresh rate your GPU is outputting. It's still possible that your display runs at a different internal refresh rate. If so, there's no way to find out, except by either trying to get the information from some tech forum, or by trying to output various refresh rates via your GPU and checking which one results in the ghosting going away...


Not sure I understand that. What kind of subtitles are we talking about? ASS? SRT? VOB? PGS? Is that a Blu-Ray movie? Or a custom encode where the black bars have been removed and are not encoded in the movie?

The ghosting is like the 100HZ option that some LCDs come with, but much better, sometimes i cant even notice, only in very slow scenes like when people are talking, for instance, 007 skyfall when 007 is talking with Q in the Museum i notest some ghosting, but i didnt notice any ghosting in Avengers movie for example.

As for the subtitles its the last thing u said, like itunes 2.35 movies

MPC Int subtitle renderer has that option "Position subtitles relative to the video frame", with 3 options, uncheck, default and check, where default is a square inside the checking slot that makes srt subtitles go to the botton of the screen in 2.35 movies. Xy-Vsfilter only do that if i choose "Extend to 16:9" option in the menu, similar to what ffdshow subtitle filter does.

TIA

Last edited by xabregas; 20th July 2013 at 13:00.
xabregas is offline   Reply With Quote
Old 20th July 2013, 13:10   #19650  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Quote:
Originally Posted by DragonQ View Post
Great - thanks! On a quick check the log seems to contain helpful information!

Quote:
Originally Posted by xabregas View Post
As for the subtitles its the last thing u said

MPC Int subtitle renderer has that option "Position subtitles relative to the video frame", with 3 options, uncheck, default and check, where default is a square inside the checking slot that makes srt subtitles go to the botton of the screen in 2.35 movies. Xy-Vsfilter only do that if i choose "Extend to 16:9" option in the menu, similar to what ffdshow subtitle filter does.
Currently madVR is limited to only render subtitles onto the active video rect. So if the black bars in a 2.35 movie are stripped from the encoding, madVR can't render the subtitles into them. This will be fixed in some future version. For now I don't have a quick fix available, unfortunately...
madshi is offline   Reply With Quote
Old 20th July 2013, 13:29   #19651  |  Link
clsid
*****
 
Join Date: Feb 2005
Posts: 5,643
I hope the position override functionality will be made smart enough to known when accurate positioning is desired and restrict re-positioning to 'basic' subtitles? Then a single (default) setting would allow the casual viewer to see subs in the black bars (during fullscreen playback) and anime lovers will get accurate positioning for their complex animations and overlays.
__________________
MPC-HC 2.1.7.2
clsid is offline   Reply With Quote
Old 20th July 2013, 13:33   #19652  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
The new subtitle interface is designed in that way that the subtitle consumer (madVR) asks the subtitle provider (XySubFilter) to reposition the subtitles, and the subtitle provider then decides whether the repositioning is acceptable. For styled ASS subtitles the repositioning should be rejected. That's the duty of the subtitle provider to make this decision smartly and correctly. If that fails at some point, I would consider that a bug which needs to be fixed.
madshi is offline   Reply With Quote
Old 20th July 2013, 13:49   #19653  |  Link
Soukyuu
Registered User
 
Soukyuu's Avatar
 
Join Date: Apr 2012
Posts: 169
Quote:
Originally Posted by madshi View Post
So you want a larger subtitle queue than decoder queue? Not sure if I want to offer that functionality. I guess it depends on how many people really need it. It might be a better idea to get the XySubFilter devs to implement proper multi-threading.
Yes, precisely. I think most low end systems or AMD users (since AMD sucks single-threaded) would appreciate that. From what I understood, making xySubFilter multithreaded is not that trivial/not high priority cause the majority seems to be using Intel -_-
Soukyuu is offline   Reply With Quote
Old 20th July 2013, 13:53   #19654  |  Link
xabregas
Registered User
 
Join Date: Jun 2011
Posts: 121
Quote:
Originally Posted by madshi View Post
Currently madVR is limited to only render subtitles onto the active video rect. So if the black bars in a 2.35 movie are stripped from the encoding, madVR can't render the subtitles into them. This will be fixed in some future version. For now I don't have a quick fix available, unfortunately...
ah ok, np, just knowing its going to be done is good. For now MPC int subtitle renderer is just fine. I know that consumes a lot of cpu power but nothing my phenom X4 965 cant handle

Still im doing several tests and im now with this settings. Just to see if there is something that can be doing minor ghosting or not.

Devices:

Sony TV:

edid version 1.3
manufacturer id SNY
manufacturer name Sony
product code 801
product name Sony TV
serial number 01010101
manufacturer date 2007, week 1

Raw Edid data:
00 FF FF FF FF FF FF 00 4D D9 01 08 01 01 01 01
01 11 01 03 80 A0 5A 78 0A 0D C9 A0 57 47 98 27
12 48 4C 21 08 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 66 21 50 B0 51 00 1B 30 40 70
36 00 40 84 63 00 00 1E 01 1D 00 72 51 D0 1E 20
6E 28 55 00 40 84 63 00 00 18 00 00 00 FC 00 53
4F 4E 59 20 54 56 0A 20 20 20 20 20 00 00 00 FD
00 30 3E 0E 30 09 00 0A 20 20 20 20 20 20 01 72

Properties: PC Levels (0-255) and 8bit (or higher)

calibration disabled

Display modes at madvr default values

Color and gamma (brightness at 11) all the rest at default or zero and gama processing disabled

Processing:

Everything at default values

scaling algorithms:

chroma: Jinc 3 taps AR enabled
Image UP: Jinc 3 taps AR enabled
Image Down: Catmull-ROM AR & Linear light enabled

Rendering:

Checked:
Delay playback start until render queue is full;
Delay playback start after seeking, too;
Enable automatic fullscreen esclusive mode

All the rest is unchecked

CPU queue = 64
GPU queue = 14

Windowed Mode:

8 buffers and default flushs

Exclusive Mode:

Checked:
show seek bar;
prevent several frames in advance;

Unchecked:
delay switch to exclusive mode by 3 sec

16 buffers and default flush settings

Smooth Motion:

enabled (first i put it to always but now ive changed to default)

Trade quality for performance:

Everything unchecked except "optimize subtitle quality for performance instead of quality". Not sure what it does to subtitles when they are rendered by MPC Int sub filter.

Everything else is at default values.

I have an ati HD7770, 4GB RAM DDR3 1333, amd phenom x4 965
My desktop resolution is 1360x768 60HZ (Sony TV)
my OS is windows 8 x64
xabregas is offline   Reply With Quote
Old 20th July 2013, 14:26   #19655  |  Link
konakona
Registered User
 
Join Date: Dec 2012
Posts: 26
i've a question about madvr processing when using 3d lut files-why is it mandatory for input and output to be rgb_video?
from what i understand madvr first does ycbcr-rgb conversion on its own,and then rgb data goes through the 3dlut,and then,finally everything is dithered to output bit-depth.
Why is it better method than allowing 3dlut to use YCbCr as input format and rgb_video 16 bits as output?

This is my current 3dlut created by making icc profile with xy values and then reading luminance (Y) values for rgbw by icc profile inspector, is it a correct 3dlut config file? (madvr accepts it but its better to be sure i did everything right)

Quote:
Input_Format HD RGB_Video 8
Output_Format HD RGB_Video 16

Input_Primaries 0.640000000000000 0.330000000000000 0.300000000000000 0.600000000000000 0.150000000000000 0.060000000000000 0.31272661468101209 0.32902313032606195

Gamut_Measurements 1
0.24252 0.638760 0.324968
0.70639 0.300233 0.597345
0.05113 0.154012 0.059413
1.00000 0.312699 0.329001

Gamma_Curve 1.0 2.35
also,how are 10-bit files processed if input bitdepth has to be 8 bits? 10 bits are first dithered to 8,and then 3dlut does its magic?
konakona is offline   Reply With Quote
Old 20th July 2013, 14:41   #19656  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
RGB 3dlut input is mandatory because that's the way madVR is designed. Of course I could add support for YCbCr 3dlut input, but I don't really see what benefit it would bring. Your current 3dlut seems to be created by yCMS? I'd suggest trying ArgyllCMS as a hopefully better alternative. yCMS is somewhat outdated now.
madshi is offline   Reply With Quote
Old 20th July 2013, 15:03   #19657  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
madVR v0.86.10 released

http://madshi.net/madVR.zip

Code:
* fixed: #084: occasional black frames with smooth motion
* fixed: #115: XySubFilter: opaque black box on older GPUs
* fixed: smooth motion FRC could artifact with bilinear scaling
* added support for disabling XySubFilter auto-loading
* added "madVR_GetDeviceGammaRamp" calibration test pattern API
* when closing madTPG, original VideoLUTs gets restored at once
madshi is offline   Reply With Quote
Old 20th July 2013, 15:45   #19658  |  Link
06_taro
soy sauce buyer
 
Join Date: Mar 2010
Location: United Kingdom
Posts: 164
Awesome for the fix of opaque black box on legacy GPUs!
06_taro is offline   Reply With Quote
Old 20th July 2013, 16:29   #19659  |  Link
Soukyuu
Registered User
 
Soukyuu's Avatar
 
Join Date: Apr 2012
Posts: 169
I'm more thrilled about the black frames being possibly fixed
Thanks for the fast update on the opaque box problem nonetheless!
Soukyuu is offline   Reply With Quote
Old 20th July 2013, 19:38   #19660  |  Link
dansrfe
Registered User
 
Join Date: Jan 2009
Posts: 1,210
Does LAV notify madVR if the source is telecined fim? Or do we have to change it manually in madVR? Also, is it possible to coordinate telling Reclock that the refresh rate is 23.976 and not 29.97? As of now I have to manually set Reclock to 23.976fps when IVTC'ing in madVR.

EDIT: force film mode fixes this.

Last edited by dansrfe; 20th July 2013 at 21:13.
dansrfe is offline   Reply With Quote
Reply

Tags
direct compute, dithering, error diffusion, madvr, ngu, nnedi3, quality, renderer, scaling, uhd upscaling, upsampling

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 06:05.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.