Vapoursynth

[hydra3333]

OK thank you, looked for that and it worked.

For posterity and other under-educated people like me who do this rarely, a quick web searched indicated this was how to do it.
"To use this script simply run 'install_script.bat' from a VS2017 elevated command prompt."

In Windows 10
  Open the Start menu, by pressing the Windows logo key Windows logo on your keyboard for example.
  On the Start menu, enter dev. 
  This will bring a list of installed apps that match your search pattern. 
  If you're looking for a different command prompt, try entering a different search term such as prompt.
  Choose the Developer Command Prompt (or the command prompt you want to use) and right click and run as admin.
In Windows 8.1
  Go to the Start screen, by pressing the Windows logo key Windows logo on your keyboard for example.
  On the Start screen, press CTRL + TAB to open the Apps list and then enter V. 
  This will bring a list that includes all installed Visual Studio command prompts.
  Choose the x64 vs2017 Developer Command Prompt (or the command prompt you want to use) and right click and run as admin.

edit 1: no, that only appeared to work but didn't. This did though from inside an admin cmd box

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\BuildCustomizations>copy C:\Users\u\Desktop\Vapoursynth\VSNASM\VSNASM-master\na*.* .\
C:\Users\u\Desktop\Vapoursynth\VSNASM\VSNASM-master\nasm.props
C:\Users\u\Desktop\Vapoursynth\VSNASM\VSNASM-master\nasm.targets
C:\Users\u\Desktop\Vapoursynth\VSNASM\VSNASM-master\nasm.xml
        3 file(s) copied.

And also remembering to set a system environment variable (right click on "This PC", properties, "environment variables") named NASMPATH equal to the folder (with trailing slash) where you placed the downloaded nasm.exe.

[Myrsloik]

This is something you have to tell the vsnasm people about. I don't write their installation instructions

[hydra3333]

Originally Posted by Myrsloik

This is something you have to tell the vsnasm åeople about. I don't write their installation instructions

Yes, and thank you for the info anyway, it led to a way to get it done !

[Boulder]

I finally upgraded to R39 from R36 I think. I'm using this kind of a part in my cleanup script to compare the changes in the luma plane between the cleaned video and the original one. With R39, I'm only getting a black screen for the frame showing the differences. What am I doing wrong? I couldn't find anything in the "possibly breaking" parts.

planes = [0]
expr = ('{median} x + y -').format(median=1<<(src.format.bits_per_sample-1))
expr = [(i in planes) * expr for i in range(1)]
result = core.std.Expr([src, finalclip], expr)
result = core.std.Levels(result, min_in=127, max_in=132,min_out=0, max_out=255, planes=0)
finalclip = core.std.Interleave(clips=[finalclip, result])

[gonca]

Originally Posted by Myrsloik

I already support all the avs+ formats. This is something else. I also have no intention of paying (I mean compulsory donation hahahahaha) to debug this. Or buying an nvidia graphics card for that matter.

Let the butthurt commence!

code in avisynth_compat.cpp

static void VS_CC avisynthFilterInit(VSMap *in, VSMap *out, void **instanceData, VSNode *node, VSCore *core, const VSAPI *vsapi) {
    WrappedClip *clip = (WrappedClip *) * instanceData;

    if (!clip->preFetchClips.empty())
        clip->fakeEnv->uglyNode = clip->preFetchClips.front();

    const VideoInfo &viAvs = clip->clip->GetVideoInfo();
    ::VSVideoInfo vi;
    vi.height = viAvs.height;
    vi.width = viAvs.width;
    vi.numFrames = viAvs.num_frames;
    vi.fpsNum = viAvs.fps_numerator;
    vi.fpsDen = viAvs.fps_denominator;
    vs_normalizeRational(&vi.fpsNum, &vi.fpsDen);

    if (viAvs.IsYV12())
        vi.format = vsapi->getFormatPreset(pfYUV420P8, core);
    else if (viAvs.IsYV24())
        vi.format = vsapi->getFormatPreset(pfYUV444P8, core);
    else if (viAvs.IsYV16())
        vi.format = vsapi->getFormatPreset(pfYUV422P8, core);
    else if (viAvs.IsYV411())
        vi.format = vsapi->getFormatPreset(pfYUV411P8, core);
    else if (viAvs.IsColorSpace(VideoInfo::CS_YUV9))
        vi.format = vsapi->getFormatPreset(pfYUV410P8, core);
    else if (viAvs.IsY8())
        vi.format = vsapi->getFormatPreset(pfGray8, core);
    else if (viAvs.IsYUY2())
        vi.format = vsapi->getFormatPreset(pfCompatYUY2, core);
    else if (viAvs.IsRGB32())
        vi.format = vsapi->getFormatPreset(pfCompatBGR32, core);
    else
        vsapi->setError(out, "Avisynth Compat: Only YV12, YUY2 and RGB32 supported");

    vi.flags = 0;
    vsapi->setVideoInfo(&vi, 1, node);
}

add two lines to the if-else

else if (viAvs.IsColorSpace(VideoInfo::CS_YUV420P16))
    vi.format = vsapi->getFormatPreset(pfYUV420P16, core);

[Myrsloik]

Originally Posted by gonca

code in avisynth_compat.cpp

static void VS_CC avisynthFilterInit(VSMap *in, VSMap *out, void **instanceData, VSNode *node, VSCore *core, const VSAPI *vsapi) {
    WrappedClip *clip = (WrappedClip *) * instanceData;

    if (!clip->preFetchClips.empty())
        clip->fakeEnv->uglyNode = clip->preFetchClips.front();

    const VideoInfo &viAvs = clip->clip->GetVideoInfo();
    ::VSVideoInfo vi;
    vi.height = viAvs.height;
    vi.width = viAvs.width;
    vi.numFrames = viAvs.num_frames;
    vi.fpsNum = viAvs.fps_numerator;
    vi.fpsDen = viAvs.fps_denominator;
    vs_normalizeRational(&vi.fpsNum, &vi.fpsDen);

    if (viAvs.IsYV12())
        vi.format = vsapi->getFormatPreset(pfYUV420P8, core);
    else if (viAvs.IsYV24())
        vi.format = vsapi->getFormatPreset(pfYUV444P8, core);
    else if (viAvs.IsYV16())
        vi.format = vsapi->getFormatPreset(pfYUV422P8, core);
    else if (viAvs.IsYV411())
        vi.format = vsapi->getFormatPreset(pfYUV411P8, core);
    else if (viAvs.IsColorSpace(VideoInfo::CS_YUV9))
        vi.format = vsapi->getFormatPreset(pfYUV410P8, core);
    else if (viAvs.IsY8())
        vi.format = vsapi->getFormatPreset(pfGray8, core);
    else if (viAvs.IsYUY2())
        vi.format = vsapi->getFormatPreset(pfCompatYUY2, core);
    else if (viAvs.IsRGB32())
        vi.format = vsapi->getFormatPreset(pfCompatBGR32, core);
    else
        vsapi->setError(out, "Avisynth Compat: Only YV12, YUY2 and RGB32 supported");

    vi.flags = 0;
    vsapi->setVideoInfo(&vi, 1, node);
}

add two lines to the if-else

else if (viAvs.IsColorSpace(VideoInfo::CS_YUV420P16))
    vi.format = vsapi->getFormatPreset(pfYUV420P16, core);

I meant avs 2.6 since avs+ keeps changing the api. Screw that.

[TheFluff]

Last time an implementation of the Avs+-specific high bitdepth stuff was attempted, the VideoInfo API in Avs+ was kinda immature. See here and the following posts. I think the suggestions were merged into pinterf's avs+ but it's been mucked around with again after that and I think there are still some outstanding weird edge cases and other oddities. Hence VS pretends to be vanilla 2.6 when loading plugins.

[Myrsloik]

The reason I confused myself is that I added avs+ support to avfs. That was a bit of a mistake due to its extreme pre-alpha state. And can you even name a single avisynth plugin that doesn't already have a port you need it for? I can't think of any...

[videoh]

Here are some changes I made to AvsCompat to support CS_YUV420P16 from an Avisynth+ filter.

http://rationalqm.us/misc/Vapoursynth Usage.zip

[hydra3333]

+1

[Myrsloik]

Since the avs+ api is apparently quite stable now (nobody seems to have stated this before I asked) I'll put proper support on my todo list. Your hack is rejected since it causes a pile of interesting issues because no plugin ever handles a partial avs+ feature level properly.

2.5 compatibility may or may not disappear (it's exclusive to 32bit anyway) to make the process simpler.

[Myrsloik]

Originally Posted by Boulder

I finally upgraded to R39 from R36 I think. I'm using this kind of a part in my cleanup script to compare the changes in the luma plane between the cleaned video and the original one. With R39, I'm only getting a black screen for the frame showing the differences. What am I doing wrong? I couldn't find anything in the "possibly breaking" parts.

planes = [0]
expr = ('{median} x + y -').format(median=1<<(src.format.bits_per_sample-1))
expr = [(i in planes) * expr for i in range(1)]
result = core.std.Expr([src, finalclip], expr)
result = core.std.Levels(result, min_in=127, max_in=132,min_out=0, max_out=255, planes=0)
finalclip = core.std.Interleave(clips=[finalclip, result])

Definitely an unintended change. Will fix.

[pinterf]

A question:
In the Expr filter source a load-type enum appears instead of a store-type. Is it a typo? It perhaps does not matter because the condition is never true, just asking.
See here: https://github.com/vapoursynth/vapou...ilter.cpp#L799

And a comment for Expr filter documentation: the maximum number of clips is 26 instead of 3.
Now it says: "Expr evaluates an expression per pixel for up to 3 input *clips*."

[Myrsloik]

Originally Posted by pinterf

A question:
In the Expr filter source a load-type enum appears instead of a store-type. Is it a typo? It perhaps does not matter because the condition is never true, just asking.
See here: https://github.com/vapoursynth/vapou...ilter.cpp#L799

And a comment for Expr filter documentation: the maximum number of clips is 26 instead of 3.
Now it says: "Expr evaluates an expression per pixel for up to 3 input *clips*."

That code should never be reached and is probably just a leftover. It's possible some path passes a null vi but throws an error later and this makes the check easier.

[Myrsloik]

Proper avs+ support is mostly finished, expect test builds in a day or two. The only removed feature is mvtools compatibility since that hack was exceptionally ugly and a superior native version exists.

[hydra3333]

Originally Posted by Myrsloik

Proper avs+ support is mostly finished, expect test builds in a day or two.

Thank you.

[Boulder]

The Vapoursynth version of QTGMC (in havsfunc) works with the VS-native MVTools. Both have their own sticky threads in this forum section.

[Myrsloik]

R40-test1

It should be release quality so if you reported one of the issues go test it.

Changes:

r40:
fixed rgb output sometimes being flipped in avisource
added alpha output settings to avisource, the default is no alpha output
fixed gamma being infinite if not set in levels, bug introduced in r39
removed the hack needed to support avisynth mvtools, the native mvtools has been superior for several years now and removing the hack makes avisynth filter creation much faster
added avisynth+ compatibility
only do prefetching in avfs with vs script when linear access is detected, fixes excessive prefetching that could make opening scripts very slow

[ChaosKing]

Why is there a restart computer option at the end of the installer? Is it really necessary? Bad User Experience

[Myrsloik]

Originally Posted by ChaosKing

Why is there a restart computer option at the end of the installer? Is it really necessary? Bad User Experience

Because a file was in use when you installed. Bad User.