Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Usage

Reply
 
Thread Tools Search this Thread Display Modes
Old 18th January 2018, 04:28   #301  |  Link
Micheal813
Registered User
 
Join Date: Nov 2015
Posts: 59
MClean is working fin with 64 bit Avisynth+. When I try to use 32 bit with Avisynth 2.6, I get:

Avisynth open failure:
Script error: there is no function named "bitspercomponent"
mClean.avsi, line 72
Micheal813 is offline   Reply With Quote
Old 18th January 2018, 04:33   #302  |  Link
StainlessS
HeartlessS Usurer
 
StainlessS's Avatar
 
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
bitspercomponent is AVS+. [If using 32bit Avs+, then maybe need update]
__________________
I sometimes post sober.
StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace

"Some infinities are bigger than other infinities", but how many of them are infinitely bigger ???
StainlessS is offline   Reply With Quote
Old 18th January 2018, 10:50   #303  |  Link
drizzit
Registered User
 
Join Date: Jul 2016
Posts: 11
Edited, Never mind problem is fixed, found an older post by burfadel with the version he uses and it now works!
(did go to https://forum.doom9.org/showthread.php?t=161411 for the ones I tried but had no luck with those)

Quote:
Originally Posted by burfadel View Post
That's weird. I've uploaded the version used here. It's the latest version (for now). 7-Zip archive.
https://1drv.ms/u/s!AmGuHbW3zvrBmb4tmBP2-KUToKUpVQ
-----------------------Problem Fixed but leaving incase it helps anyone else-----------------
Trying to update to the latest version while using staxrip I get the following error

Code:
System exception - Access Violation
(D:\StaxRip-x64\Apps\Plugins\avs\mClean\mClean.avsi, line 143)
(D:\Temp movies\Stax\random.file.name_temp\random.file.name, line 13)

Line 142 and 143 being the following

Code:
filt_chroma      =  deband==0 ? filt_chroma : deband<>2 ? mt_adddiff (combined, TemporalSoften(mt_makediff(combined, f3kdb (combined, preset=chroma?"high":"luma", range=17,
                 \  grainY=35, grainC=chroma?38:0)), 1, 255, chroma?255:0, 255, 2)) : combined
I saw Michael813 got an error on the same line but mine does not mention preset and I did make sure I have the 64bit 2pre version of f3kdb.
could it still be the same problem @pinterf found? And if so any chance you could send me that test version too?


My Basic specs
Code:
-------------------------- System Environment --------------------------

StaxRip    : 1.7.0.4
Windows    : Windows 7 Professional
Language   : Swedish (Sweden)
CPU        : Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz
GPU        : NVIDIA GeForce GTX 980, VNC Mirror Driver
Resolution : 2560 x 1440
DPI        : 96

Last edited by drizzit; 18th January 2018 at 15:06.
drizzit is offline   Reply With Quote
Old 19th January 2018, 11:22   #304  |  Link
burfadel
Registered User
 
Join Date: Aug 2006
Posts: 2,229
It can be downloaded from here:
http://nmm.me/10z

It doesn't have 'modern' high bit depth support along with autolevels, although there is a workaround for that which I'll use. This is just in case it doesn't get updates. Autoadjust is an issue though, since it appears closed source it's up to LaTo to fix it and it appears he may not longer be active on this forum. Ideally f3kdb and autoadjust should be combined. I did try the major change to renoise, but it wasn't any better in 90 percent of cases so I scrapped that particular concept, but there are some other changes I can make to improve it
burfadel is offline   Reply With Quote
Old 27th January 2018, 11:50   #305  |  Link
burfadel
Registered User
 
Join Date: Aug 2006
Posts: 2,229
Updated first post to version 2.1. There are lots of changes . I still haven't added the depth and detail enhancement options, I will need to look into the most optimal base settings for these. Additionally, I need to change the sharpness parameter scaling .

I probably should also add a list linking the latest required filters, at some stage. In any case, hope you like the new version and it would be great to know what people think of the changes.

Last edited by burfadel; 27th January 2018 at 11:55.
burfadel is offline   Reply With Quote
Old 27th January 2018, 14:43   #306  |  Link
ChaosKing
Registered User
 
Join Date: Dec 2005
Location: Germany
Posts: 1,795
It produces artifacts for me. Tested version 2.1 and also some previous versions.
Lower thSAD dosen't seem to affect (or reduce) the "artifacts".


__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth
VapourSynth Portable FATPACK || VapourSynth Database

Last edited by ChaosKing; 27th January 2018 at 14:46.
ChaosKing is offline   Reply With Quote
Old 27th January 2018, 15:07   #307  |  Link
burfadel
Registered User
 
Join Date: Aug 2006
Posts: 2,229
The source look pretty clean apart from the aliasing and 'clean' pixellation, so in general the denoising probably isn't necessary. Were those artifacts in areas where there is motion? I can look into it, but on the test clips I have I didn't notice them. Do you have a clip of a few seconds including the above frame? On a side note, it may be possible another feature I will be adding could remove the aliasing. I'll also make it so you can run it independently from denoising, as Avisynth+ allows scripts to contain more than one function. That way, I can call the function from within the mClean part of the script, whilst also allowing the other functions to be applied independently.
burfadel is offline   Reply With Quote
Old 27th January 2018, 16:22   #308  |  Link
ChaosKing
Registered User
 
Join Date: Dec 2005
Location: Germany
Posts: 1,795
I used PointResize to better show the problem hence the pixelation.
I think the artifacts mostly appear on large flat areas with strong edges.

Here's a sample https://www.dropbox.com/s/ktizz9vxwt...clean.mkv?dl=1
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth
VapourSynth Portable FATPACK || VapourSynth Database
ChaosKing is offline   Reply With Quote
Old 27th January 2018, 17:21   #309  |  Link
burfadel
Registered User
 
Join Date: Aug 2006
Posts: 2,229
Thanks, I'll look in to that!
burfadel is offline   Reply With Quote
Old 28th January 2018, 09:33   #310  |  Link
burfadel
Registered User
 
Join Date: Aug 2006
Posts: 2,229
Updated to v2.2. Fixed chroma not being processed with deband, resolved an issue with chroma debanding features (which didn't affect anything since it wasn't applied!), and added a luma diff so higher bitdepth detail isn't lost when using deband, since it can only be done in 8 bit.

@ Chaosking
I was intending to look into that issue of yours, but instead resolved the issues above. I'll look into soon .
burfadel is offline   Reply With Quote
Old 28th January 2018, 18:57   #311  |  Link
MysteryX
Soul Architect
 
MysteryX's Avatar
 
Join Date: Apr 2014
Posts: 2,559
Can debanding be enabled/disabled?
MysteryX is offline   Reply With Quote
Old 28th January 2018, 19:22   #312  |  Link
ChaosKing
Registered User
 
Join Date: Dec 2005
Location: Germany
Posts: 1,795
Code:
# +++ Deband +++
# This will perceptibly improve the quality of the image by reducing banding effect and adding a small amount of temporally stabilised grain to
# both luma and chroma. The settings are not adjustable as the default settings are suitable for most cases without having a large effect on
# compressibility. Auto balance uses Autoadjust, it calculates statistics of the clip, stabilises temporally and adjusts luminance gain & colour
# balance of the noise reduced clip.
# 0=disabled, 1=deband only, 2=auto balance only, 3=both deband and auto balance, 4=deband and veed, 5=all
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth
VapourSynth Portable FATPACK || VapourSynth Database
ChaosKing is offline   Reply With Quote
Old 29th January 2018, 06:56   #313  |  Link
burfadel
Registered User
 
Join Date: Aug 2006
Posts: 2,229
Updated first post to v2.3.

Quote:
Originally Posted by ChaosKing View Post
I think the artifacts mostly appear on large flat areas with strong edges.
Issue should be resolved now!

Quote:
Originally Posted by MysteryX View Post
Can debanding be enabled/disabled?
As Chaosking highlighted, yes, deband etc can be disabled.
burfadel is offline   Reply With Quote
Old 29th January 2018, 08:19   #314  |  Link
lansing
Registered User
 
Join Date: Sep 2006
Posts: 1,657
Quote:
Originally Posted by burfadel View Post
Issue should be resolved now!
No it still doesn't. Seriously have you ever test out your script on actual videos? I mean the issue existed for 4+ months and it was so obvious to spot.

UPDATE:
I double checked on every plugin I have for the script and looks like I have an outdated RGtools.dll. Artifacts are gone now.

Last edited by lansing; 29th January 2018 at 14:34. Reason: update
lansing is offline   Reply With Quote
Old 29th January 2018, 10:05   #315  |  Link
ChaosKing
Registered User
 
Join Date: Dec 2005
Location: Germany
Posts: 1,795
Unfortunately the artifacts are still present. I also updated all plugins just in case.
The only older version I have on my drive is 1.3c_2 (29 August 2017), and it produces artifacts too.

EDIT

Sorry, I forgot the dehalo filter in my script. It seems like the problem is fixed now!
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth
VapourSynth Portable FATPACK || VapourSynth Database

Last edited by ChaosKing; 29th January 2018 at 13:11.
ChaosKing is offline   Reply With Quote
Old 29th January 2018, 12:46   #316  |  Link
Taurus
Registered User
 
Taurus's Avatar
 
Join Date: Mar 2002
Location: Krautland
Posts: 903
@burfadel
You should really make it clear in the first post of your thread, that your script is only running on Avisynth+.
Would have saved me a lot of messing around with plugins and error messages...
Groucho2004's AVSMeter finally sorted it out for me.
And an exact list of all the needed plugins with download list would really be appreciated.
Thank you.
Taurus is offline   Reply With Quote
Old 3rd February 2018, 13:45   #317  |  Link
zub35
Registered User
 
Join Date: Oct 2016
Posts: 56
There is a great plugin chroma denoise for VirtualDub - "Camcorder color denoise" http://acobw.narod.ru
If use it before mClean, on the digital record / very-lossy encode, gives excellent results. Alas, only 32bit and rgb

Last edited by zub35; 3rd February 2018 at 13:49.
zub35 is offline   Reply With Quote
Old 3rd February 2018, 15:52   #318  |  Link
burfadel
Registered User
 
Join Date: Aug 2006
Posts: 2,229
Yes, chroma is probably more difficult than luma. Currently making some changes, although there will likely be a delay as I may have found an issue with MVTools that affects one of the changes.
burfadel is offline   Reply With Quote
Old 4th February 2018, 09:14   #319  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 7,259
Quote:
You should really make it clear in the first post of your thread, that your script is only running on Avisynth+.
I agree, since a few users asked me about adding support for the filter in Hybrid, but I had to decline that request due to the Avisynth+ dependency. (I only use AvisynthMT and Vapoursynth in Hybrid.)

That said, are there any plans to port this to Vapoursynth?

Cu Selur
__________________
Hybrid here in the forum, homepage
Selur is offline   Reply With Quote
Old 6th February 2018, 07:59   #320  |  Link
burfadel
Registered User
 
Join Date: Aug 2006
Posts: 2,229
Quote:
Originally Posted by Selur View Post
I agree, since a few users asked me about adding support for the filter in Hybrid, but I had to decline that request due to the Avisynth+ dependency. (I only use AvisynthMT and Vapoursynth in Hybrid.)

That said, are there any plans to port this to Vapoursynth?

Cu Selur
I'll make a list of required depenedencies and versions with the next release. No plans for vapoursynth conversion, as not sure the actual syntax. Also aren't the plugins a little different now, such that the output wouldn't be the same?
burfadel is offline   Reply With Quote
Reply

Tags
cleaning, denoise, denoiser, mclean

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 03:30.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.