Dup 2.0 for Avisynth 2.5 - Page 2

sh0dan · 3rd January 2003, 14:30

Link corrected (the experienced hax0r would still try to download avisynth_a_0301003.zip

FuPP · 3rd January 2003, 21:12

@Donald+Shodan

hem, hem...

Well, thanks a lot for your efforts, but I still have the problem both with avs 2.5 03/01 + dupyv12b2 or with Dupyv12b3.

Here's my script (I could have start with that last time...

)

LoadPlugin("C:\video\avsfilters\MPEG2DEC3yv12.dll")
LoadPlugin("C:\video\avsfilters\dupyv12.dll")
mpeg2source("f:\tests\vts_01.d2v",CPU=6,IDCT=2)
Crop(8,4,704,568)
Dup(threshold=5,maxcopies=10,chroma=false,show=true)
BilinearResize(448,542)
AddBorders(16,17,16,17)

FuPP

XP1800+, W2K

FuPP · 3rd January 2003, 21:13

Quote:

Originally posted by Gant
Now that i was about to say that i found thta "weird" frame problem someone was ahead of me... lol

Sorry for that !

FuPP · 3rd January 2003, 22:09

Oh !

I've discovered that putting another filter (ex : convolution3d or... warpsharp

) after Dup make things works : it seems very similar to the problem I've reported to Sansgrip about fluxsmooth...

Hope it can help.

Guest · 4th January 2003, 19:32

@FuPP

Thank you for your results. I was indeed able to duplicate the problem using your script.

Apparently the vi->IsWritable() is not reliable. I've temporarily removed the test of it in MakeWritable2(). The problem seems to go away. Please test with the attached beta 4 and let me know.

@sh0dan

Any comments about vi->IsWritable()?

Guest · 4th January 2003, 19:55

Quote:

Originally posted by sh0dan
Seems like Pitch isn't being respected properly - is this something only happening in newer versions, or has all 2.5 alphas had this bug?

Don't know because I've been upgrading faithfully and only run the newest versions.

Quote:

Are your CPU's ISSE capable? - otherwise that could be the root of the problem (a faulty MMX bitblit).

Athlon XP.

Quote:

Are you using the newest avisynth.h (from CVS).

No. Should I be? Why? Can you attach it here, please?

FuPP · 4th January 2003, 21:01

@neuron

yes yes yes yes yes !

Nice shot ! It works fine now (and is fast !) Thx a lot for your time.

Best regards,
FuPP.

Guest · 4th January 2003, 22:03

Quote:

Originally posted by FuPP
yes yes yes yes yes !

Nice shot ! It works fine now (and is fast !) Thx a lot for your time.

Thank you again, FuPP, for your assistance. I'd better have a look at Decomb. It has the same code.

sh0dan · 5th January 2003, 10:39

Quote:

Originally posted by neuron2
No. Should I be? Why? Can you attach it here, please?

The latest is on the alpha site

Another possible problem could be, that you read pitches _before_ making the image writable. Pitch might change when you make an image writeable. Could that be the cause?

Guest · 5th January 2003, 20:05

Thank you, sh0dan. I will get the new header file and check my pitch usage, as you suggest.

Guest · 8th January 2003, 19:23

Here is Dup 2.00 beta 6.

It adds a requested feature: blend. When blend=true, the copy frame will be generated from an averaging of all the duplicate frames. This should give some noise reduction. Please read the help file for details. Of course, with blend=true, the filter will be slower.

Now even MarcFD can't argue that Dup is useless.

Feedback will be appreciated.

sh0dan · 8th January 2003, 20:17

You might want to check out the Fluxsmooth thread - this could be the reason for your crashes.

Guest · 8th January 2003, 20:39

You say that it should be fixed BOTH in the resizer and the application! How would we fix it in the application?

Also, I made the problem go away by removing the test for IsWritable() and its return in MakeWritable(), so that it always copies to a new frame. That doesn't seem to fit with the mechanism you are suggesting?

sh0dan · 8th January 2003, 20:54

What happends is that your filter returns frames with different pitches.
If you don't make all frames writable, but only some of them, it returns the source frame.

If the source has been cropped right before your filter, it results in a pitch much larger than the image. When you make an image writable, a new frame is created, with a smaller pitch, and the image is copied to this frame. If you make all images writable the new pitch is consistent. But if you on some occations returns the same frame with a old pitch it causes an error in resize.

I've corrected the error in resize.

The easiest way for you to fix it is to create a new frame, and bitblit to it, if there are no changes - otherwise, just make _all_ frames writeable, no matter which frames are requested.

Guest · 8th January 2003, 20:59

Thank you for the explanation. I did notice it didn't happen if I removed the resize after Dup.

Can I get the corrected Avisynth to test the fix?

sh0dan · 8th January 2003, 21:01

I'll upload a new binary tomorrow - I don't have access to the server right now. Hope you can wait that long!

Guest · 8th January 2003, 21:03

No problem, Sir. Thank you for your excellent analysis and debugging on this issue.

FuPP · 8th January 2003, 21:27

I have tested b6, but only on a short clip (about 1700 frames). I will try to make more serious tests later in the week.

b6 is stable

b6 without blend : gain in compressibility (mpeg2) : 4 %
b6 with blend : gain = 5.5 %

command : Dup(threshold=5,maxcopies=20,chroma=false,blend=true)

Cheers,
FuPP.

MaTTeR · 8th January 2003, 21:47

It's a free lunch so I couldn't resist

Has anyone been successful using Dup on clean progressive movies? Just curious more than anything.

FuPP · 8th January 2003, 23:01

I've made some attempts a few weeks ago (with avs 2.0x compatible version); the filter did not detect subtle movements in still scenes (like a far character walking in the background), the movie got then jumpy.

But seems really efficient on animes !

Regards
FuPP.

3rd January 2003, 14:30	#21 \| Link
sh0dan Retired AviSynth Dev ;) Join Date: Nov 2001 Location: Dark Side of the Moon Posts: 3,480	Link corrected (the experienced hax0r would still try to download avisynth_a_0301003.zip __________________ Regards, sh0dan // VoxPod

8th January 2003, 19:23	#31 \| Link
Guest Guest Join Date: Jan 2002 Posts: 21,901	frame blending now supported Here is Dup 2.00 beta 6. It adds a requested feature: blend. When blend=true, the copy frame will be generated from an averaging of all the duplicate frames. This should give some noise reduction. Please read the help file for details. Of course, with blend=true, the filter will be slower. Now even MarcFD can't argue that Dup is useless. Feedback will be appreciated. Last edited by Guest; 8th January 2003 at 19:30.

8th January 2003, 20:17	#32 \| Link
sh0dan Retired AviSynth Dev ;) Join Date: Nov 2001 Location: Dark Side of the Moon Posts: 3,480	You might want to check out the Fluxsmooth thread - this could be the reason for your crashes. __________________ Regards, sh0dan // VoxPod

8th January 2003, 20:39	#33 \| Link
Guest Guest Join Date: Jan 2002 Posts: 21,901	You say that it should be fixed BOTH in the resizer and the application! How would we fix it in the application? Also, I made the problem go away by removing the test for IsWritable() and its return in MakeWritable(), so that it always copies to a new frame. That doesn't seem to fit with the mechanism you are suggesting? Last edited by Guest; 8th January 2003 at 20:55.

8th January 2003, 20:54	#34 \| Link
sh0dan Retired AviSynth Dev ;) Join Date: Nov 2001 Location: Dark Side of the Moon Posts: 3,480	What happends is that your filter returns frames with different pitches. If you don't make all frames writable, but only some of them, it returns the source frame. If the source has been cropped right before your filter, it results in a pitch much larger than the image. When you make an image writable, a new frame is created, with a smaller pitch, and the image is copied to this frame. If you make all images writable the new pitch is consistent. But if you on some occations returns the same frame with a old pitch it causes an error in resize. I've corrected the error in resize. The easiest way for you to fix it is to create a new frame, and bitblit to it, if there are no changes - otherwise, just make _all_ frames writeable, no matter which frames are requested. __________________ Regards, sh0dan // VoxPod Last edited by sh0dan; 8th January 2003 at 20:59.

3rd January 2003, 21:12	#22 \| Link
FuPP TotalEclipseOfTheBrain Join Date: Sep 2002 Posts: 347	@Donald+Shodan hem, hem... Well, thanks a lot for your efforts, but I still have the problem both with avs 2.5 03/01 + dupyv12b2 or with Dupyv12b3. Here's my script (I could have start with that last time... ) LoadPlugin("C:\video\avsfilters\MPEG2DEC3yv12.dll") LoadPlugin("C:\video\avsfilters\dupyv12.dll") mpeg2source("f:\tests\vts_01.d2v",CPU=6,IDCT=2) Crop(8,4,704,568) Dup(threshold=5,maxcopies=10,chroma=false,show=true) BilinearResize(448,542) AddBorders(16,17,16,17) FuPP XP1800+, W2K

3rd January 2003, 22:09	#24 \| Link
FuPP TotalEclipseOfTheBrain Join Date: Sep 2002 Posts: 347	Oh ! I've discovered that putting another filter (ex : convolution3d or... warpsharp ) after Dup make things works : it seems very similar to the problem I've reported to Sansgrip about fluxsmooth... Hope it can help.

4th January 2003, 19:32	#25 \| Link
Guest Guest Join Date: Jan 2002 Posts: 21,901	@FuPP Thank you for your results. I was indeed able to duplicate the problem using your script. Apparently the vi->IsWritable() is not reliable. I've temporarily removed the test of it in MakeWritable2(). The problem seems to go away. Please test with the attached beta 4 and let me know. @sh0dan Any comments about vi->IsWritable()?

4th January 2003, 21:01	#27 \| Link
FuPP TotalEclipseOfTheBrain Join Date: Sep 2002 Posts: 347	@neuron yes yes yes yes yes ! Nice shot ! It works fine now (and is fast !) Thx a lot for your time. Best regards, FuPP.

5th January 2003, 20:05	#30 \| Link
Guest Guest Join Date: Jan 2002 Posts: 21,901	Thank you, sh0dan. I will get the new header file and check my pitch usage, as you suggest.

8th January 2003, 20:59	#35 \| Link
Guest Guest Join Date: Jan 2002 Posts: 21,901	Thank you for the explanation. I did notice it didn't happen if I removed the resize after Dup. Can I get the corrected Avisynth to test the fix?

8th January 2003, 21:01	#36 \| Link
sh0dan Retired AviSynth Dev ;) Join Date: Nov 2001 Location: Dark Side of the Moon Posts: 3,480	I'll upload a new binary tomorrow - I don't have access to the server right now. Hope you can wait that long! __________________ Regards, sh0dan // VoxPod

8th January 2003, 21:03	#37 \| Link
Guest Guest Join Date: Jan 2002 Posts: 21,901	No problem, Sir. Thank you for your excellent analysis and debugging on this issue.

8th January 2003, 21:27	#38 \| Link
FuPP TotalEclipseOfTheBrain Join Date: Sep 2002 Posts: 347	I have tested b6, but only on a short clip (about 1700 frames). I will try to make more serious tests later in the week. b6 is stable b6 without blend : gain in compressibility (mpeg2) : 4 % b6 with blend : gain = 5.5 % command : Dup(threshold=5,maxcopies=20,chroma=false,blend=true) Cheers, FuPP. Last edited by FuPP; 8th January 2003 at 21:31.

8th January 2003, 21:47	#39 \| Link
MaTTeR AC3 5.1 Addict Join Date: Nov 2001 Location: Big Blue Nation_USA Posts: 2,036	It's a free lunch so I couldn't resist Has anyone been successful using Dup on clean progressive movies? Just curious more than anything. __________________ Need AC3 & SPDIF setup info?

8th January 2003, 23:01	#40 \| Link
FuPP TotalEclipseOfTheBrain Join Date: Sep 2002 Posts: 347	I've made some attempts a few weeks ago (with avs 2.0x compatible version); the filter did not detect subtle movements in still scenes (like a far character walking in the background), the movie got then jumpy. But seems really efficient on animes ! Regards FuPP.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode