aWarpSharp2 – rewrite of aWarpSharp - Page 3

SEt · 30th June 2009, 17:08

Rebuilt version 2009.06.19 with new header to correct threading problems.

MyCometG3 · 3rd July 2009, 23:27

SEt
Thank you for your effort.
I have ported this plug-in to GCC. Impemented into my CoreVF framework, under MacOS X env. It runs well. Great!

One thing, Warp() function seems to check CPU is SSSE3 ready every line inside asm, is this required?
I have split SSSE3 loop and SSE2 loop, seems to run well. It could be faster.

(I am not sure, but original code does not run well under CoreDuo - no SSSE3 support; Of course not original, but gas rewritten code though. Splitting loops works well both on Core2Duo and CoreDuo)

SEt · 4th July 2009, 03:41

There should be no problem with that conditional jump - any modern cpu should be able to always correctly predict it so it will consume no time at all. And even mispredicted once per line is very small cost. What you are observing might be cache related - it has far more serious impact on performance. But of course it's only a theory.

Monamona · 15th July 2009, 23:45

Is there any chance that the filter will be modified to work under YUY2?

lych_necross · 16th July 2009, 07:07

I like the rewritten aWarpSharp. Now, if only Toon.dll would get updated to support the new version...

SEt · 18th July 2009, 16:47

I'm not going to add YUY2 support, but probably will add YV16.

Lynx Pardinus · 20th July 2009, 22:28

You mean YV16, wich won't be supported until Avisynth 2.60, or the planar YUY2 supported by MVTools, masktools and many others ?

SEt · 21st July 2009, 02:57

YV16 of Avisynth 2.60+.

lych_necross · 21st July 2009, 07:09

Supporting yv16 instead of yuy2 is odd, but okay. I waited 1+ years for for 2.58, whats another couple of years

thewebchat · 21st July 2009, 20:13

In the awarpsharp.txt file included with your filter, you mention that the mapping between "thresh" in aWarpSharp2 and aWarpSharp is "aWarpSharp2 value * 256" but the aWarpSharp documentation says that thresh goes from 0.0 to 1.0. How does this work?

Edit: Oh, sorry, read the equation the wrong away around. Sorry about that. Someone can delete this post.

Edit2: I am getting an access violation (reading from 0x0 at 0xfaa1415) when setting blur to "1". The documentation says that values from 0 to 100 are supported.

Edit3: Oh wait, that's just a mod16 error.

Soulhunter · 26th July 2009, 14:52

I thought green border artifact bug was fixed years ago... >.>

SEt · 26th July 2009, 21:55

As requested, i've updated Toon to use aWarpSharp2 instead of aWarpSharp. As i don't see the sources - made it by patching the dll, so no optimizations or bugfixes in this v1.1.

lych_necross, YUY2 is very inconvenient format for vectorized processing (MMX/SSE) while YV16 has no such problems and adding its support to YV12 code is almost trivial.

lych_necross · 27th July 2009, 07:16

Oh, I didn't know that. Thats cool as I usually use YV12 anyways.
P.S. SWEET!!!

new toon.dll!! I think Soulhunter originally posted toon.dll, so he would probably have the sources.

Adub · 27th July 2009, 18:24

Soulhunter didn't make Toon, he just posted it on behalf of the author, who I'm pretty sure is mf.

Soulhunter · 28th July 2009, 14:39

Quote:

Originally Posted by Adub

Soulhunter didn't make Toon, he just posted it on behalf of the author, who I'm pretty sure is mf.

...who was banned here some time ago
...so he cant post here anymore
...so I do it for him

But, the aWarpSharp version in his dumpster (2nd Google result when searching for aWarpSharp.dll) should already contain the fixed version I mentioned in my last post... So, is there really a reason to update Toon.dll besides the minimal (the old aWarpSharp already runs way above realtime, doesn't it?) speed gain?

SEt · 29th July 2009, 04:14

I don't see any fixed version of aWarpSharp.dll. I prefer to have one WarpSharp filter for everything and it's always better to be faster.

Great Dragon · 30th April 2010, 20:09

Hi guys.
I have VD crash with this script:

Code:

s=AVISource("h:\dt_314.avi")
a1=trim(s,0,13566).crop(10,0,-6,0)
a2=trim(s,13567,22584).crop(6,0,-10,0)
a3=trim(s,22585,32818).crop(8,0,-8,0)
a1++a2++a3
mergechroma(awarpsharp2(blur=16,thresh=128, type=1))

and if I put mergechroma code right after input clip like this:

Code:

a1=AVISource("h:\dt_314.avi").mergechroma(awarpsharp2(blur=16,thresh=128, type=1)).trim(0,13566).crop(10,0,-6,0)
a2=AVISource("h:\dt_314.avi").mergechroma(awarpsharp2(blur=16,thresh=128, type=1)).trim(13567,22584).crop(6,0,-10,0)
a3=AVISource("h:\dt_314.avi").mergechroma(awarpsharp2(blur=16,thresh=128, type=1)).trim(22585,32818).crop(8,0,-8,0)
a1++a2++a3

I have an error: "Invalid arguments to function "awarpsharp2".

In same with simple usage like this:

Code:

AVISource("h:\dt_314.avi")
mergechroma(awarpsharp2(blur=16,thresh=128, type=1))

filter works like a charm.

Gavino · 30th April 2010, 20:33

Quote:

Originally Posted by Great Dragon

if I put mergechroma code right after input clip like this:

Code:

a1=AVISource("h:\dt_314.avi").mergechroma(awarpsharp2(blur=16,thresh=128, type=1)).trim(0,13566).crop(10,0,-6,0)
...

I have an error: "Invalid arguments to function "awarpsharp2".

That's because the input clip for the call to awarpsharp2() is not explicitly provided, and 'last' is not defined at that point in the script.
You need to do it like this:

Code:

AVISource("h:\dt_314.avi") 
mergechroma(awarpsharp2(blur=16,thresh=128, type=1))
a1=trim(0,13566).crop(10,0,-6,0)
a2=trim(13567,22584).crop(6,0,-10,0)
a3=trim(22585,32818).crop(8,0,-8,0)
a1++a2++a3

Don't know why VD should crash with your original script though.

Keiyakusha · 30th April 2010, 20:43

This script crashes for me even without aWarpsharp2.

Quote:

s=AVISource("something.avi")
a1=trim(s,0,13566).crop(10,0,-6,0)
a2=trim(s,13567,22584).crop(6,0,-10,0)
a3=trim(s,22585,32818).crop(8,0,-8,0)
a1++a2++a3

Access Violation in Decoder ffdshow (libavcodec or xvid) for divx 720p video. When awarpsharp2 is present, Access Violation is reported for awarpsharp2

EDIT: oops, quoted wrong script. now is fine.

Great Dragon · 1st May 2010, 21:34

Gavino, Thanks man. I still need to learn avisynth language a lot.

21st July 2009, 20:13	#50 \| Link
thewebchat Advanced Blogging Join Date: May 2009 Posts: 480	Mapping of parameters to original aws In the awarpsharp.txt file included with your filter, you mention that the mapping between "thresh" in aWarpSharp2 and aWarpSharp is "aWarpSharp2 value * 256" but the aWarpSharp documentation says that thresh goes from 0.0 to 1.0. How does this work? Edit: Oh, sorry, read the equation the wrong away around. Sorry about that. Someone can delete this post. Edit2: I am getting an access violation (reading from 0x0 at 0xfaa1415) when setting blur to "1". The documentation says that values from 0 to 100 are supported. Edit3: Oh wait, that's just a mod16 error. Last edited by thewebchat; 21st July 2009 at 20:59.

26th July 2009, 14:52	#51 \| Link
Soulhunter Bored... Join Date: Apr 2003 Location: Unknown Posts: 2,812	I thought green border artifact bug was fixed years ago... >.> __________________ Visit my IRC channel

27th July 2009, 07:16	#53 \| Link
lych_necross ZZZzzzz... Join Date: Jan 2007 Location: USA Posts: 303	Oh, I didn't know that. Thats cool as I usually use YV12 anyways. P.S. SWEET!!! new toon.dll!! I think Soulhunter originally posted toon.dll, so he would probably have the sources. Last edited by lych_necross; 27th July 2009 at 07:22. Reason: added ps

27th July 2009, 18:24	#54 \| Link
Adub Fighting spam with a fish Join Date: Sep 2005 Posts: 2,699	Soulhunter didn't make Toon, he just posted it on behalf of the author, who I'm pretty sure is mf. __________________ FAQs:Bond's AVC/H.264 FAQ Site:Adubvideo

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

30th June 2009, 17:08	#41 \| Link
SEt Registered User Join Date: Aug 2007 Posts: 374	Rebuilt version 2009.06.19 with new header to correct threading problems.

3rd July 2009, 23:27	#42 \| Link
MyCometG3 Registered User Join Date: May 2008 Posts: 35	SEt Thank you for your effort. I have ported this plug-in to GCC. Impemented into my CoreVF framework, under MacOS X env. It runs well. Great! One thing, Warp() function seems to check CPU is SSSE3 ready every line inside asm, is this required? I have split SSSE3 loop and SSE2 loop, seems to run well. It could be faster. (I am not sure, but original code does not run well under CoreDuo - no SSSE3 support; Of course not original, but gas rewritten code though. Splitting loops works well both on Core2Duo and CoreDuo)

4th July 2009, 03:41	#43 \| Link
SEt Registered User Join Date: Aug 2007 Posts: 374	There should be no problem with that conditional jump - any modern cpu should be able to always correctly predict it so it will consume no time at all. And even mispredicted once per line is very small cost. What you are observing might be cache related - it has far more serious impact on performance. But of course it's only a theory.

15th July 2009, 23:45	#44 \| Link
Monamona Registered User Join Date: Aug 2002 Posts: 34	Is there any chance that the filter will be modified to work under YUY2?

16th July 2009, 07:07	#45 \| Link
lych_necross ZZZzzzz... Join Date: Jan 2007 Location: USA Posts: 303	I like the rewritten aWarpSharp. Now, if only Toon.dll would get updated to support the new version...

18th July 2009, 16:47	#46 \| Link
SEt Registered User Join Date: Aug 2007 Posts: 374	I'm not going to add YUY2 support, but probably will add YV16.

20th July 2009, 22:28	#47 \| Link
Lynx Pardinus Registered User Join Date: Dec 2008 Posts: 16	You mean YV16, wich won't be supported until Avisynth 2.60, or the planar YUY2 supported by MVTools, masktools and many others ?

21st July 2009, 02:57	#48 \| Link
SEt Registered User Join Date: Aug 2007 Posts: 374	YV16 of Avisynth 2.60+.

21st July 2009, 07:09	#49 \| Link
lych_necross ZZZzzzz... Join Date: Jan 2007 Location: USA Posts: 303	Supporting yv16 instead of yuy2 is odd, but okay. I waited 1+ years for for 2.58, whats another couple of years

26th July 2009, 21:55	#52 \| Link
SEt Registered User Join Date: Aug 2007 Posts: 374	As requested, i've updated Toon to use aWarpSharp2 instead of aWarpSharp. As i don't see the sources - made it by patching the dll, so no optimizations or bugfixes in this v1.1. lych_necross, YUY2 is very inconvenient format for vectorized processing (MMX/SSE) while YV16 has no such problems and adding its support to YV12 code is almost trivial.

29th July 2009, 04:14	#56 \| Link
SEt Registered User Join Date: Aug 2007 Posts: 374	I don't see any fixed version of aWarpSharp.dll. I prefer to have one WarpSharp filter for everything and it's always better to be faster.

1st May 2010, 21:34	#60 \| Link
Great Dragon Registered User Join Date: Feb 2005 Location: Ukraine, Lviv Posts: 121	Gavino, Thanks man. I still need to learn avisynth language a lot.