MeGUI development - Page 53

charleski · 5th January 2006, 21:55

0.2.3.1032 6 Jan 2006
Added a button to the Queue tab on the main form: "Add Shutdown". This adds a shutdown job to the end of the queue. Automatic shutdown can still be set using the checkbox in the Settings form.
Fixed tri-state GUI display dependencies in x264ConfigDialog.cs

Actually, the tri-state problem was a side-effect of not allowing showCommandLine() to run when the dialog is first being initialised. I just added a separate call at the end of the load process.

Sharktooth · 5th January 2006, 21:56

?!? Where was the error ?!?

berrinam · 5th January 2006, 22:01

@jmk: Bug reports should really be posted on the bug report thread. Similarly with feature requests and the feature request thread.

Quote:

Originally Posted by jmk

- the window title of MeGui stays at 99% even though everything is finished

Yep, it happens to me, too. Will go on the bug report thread.

Quote:

- add a button "hide" or "close" or something in the process window. it took me a while before i realized it can be closed without aborting the process.

Will put this on the feature request thread.

As to the other bugs you mentioned, they don't happen for me, so you should post a more detailed explanation on the MeGUI Bug Report Thread. This thread is for developers.

charleski · 5th January 2006, 22:03

The tri-state stuff is only called by showCommandLine(), and this was disabled when the dialog is being loaded:

Code:

        private void showCommandLine()
        {
        --> if (!loaded)
        -->     return;
            if (!x264ConfigurationDialog.levelEnforced)
                EnforceLevel(this.CodecSettings);
            x264DialogTriStateAdjustment();

So when the dialog loads it doesn't go through the x264DialogTriStateAdjustment() code and only adjusts to the right state if you change something.

Doom9 · 5th January 2006, 22:05

Quote:

- add a button "hide" or "close" or something in the process window. it took me a while before i realized it can be closed without aborting the process.

Hmm.. I don't agree on that.. I took VDub as a model for the progress window and that one also allows closing by pressing X.

berrinam · 5th January 2006, 22:08

Quote:

Originally Posted by charleski

The tri-state stuff is only called by showCommandLine(), and this was disabled when the dialog is being loaded:

Code:

        private void showCommandLine()
        {
        --> if (!loaded)
        -->     return;
            if (!x264ConfigurationDialog.levelEnforced)
                EnforceLevel(this.CodecSettings);
            x264DialogTriStateAdjustment();

So when the dialog loads it doesn't go through the x264DialogTriStateAdjustment() code and only adjusts to the right state if you change something.

I added those two lines because otherwise, MeGUI was sometimes being forced to do a TriStateAdjustment before all the values had been set, leading to a NullReferenceException. Sorry to cause the problem.

charleski · 5th January 2006, 22:13

Quote:

Originally Posted by berrinam

I added those two lines because otherwise, MeGUI was sometimes being forced to do a TriStateAdjustment before all the values had been set, leading to a NullReferenceException. Sorry to cause the problem.

Yeah, one of the problems with event handlers is that the code can waste a fair amount of time needlessly thrashing through them. It just needed an extra explicit call at the end of the load routine.

bob0r · 5th January 2006, 22:54

Using megui-x264-svn.exe:

- Selecting profiles HQ-Insane and HQ-slowest then hit config (or select these profiles in config) crashes.

Code:

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.ArgumentOutOfRangeException: InvalidArgument=Value of '6' is not valid for 'SelectedIndex'.
Parameter name: SelectedIndex
   at System.Windows.Forms.ComboBox.set_SelectedIndex(Int32 value)
   at MeGUI.x264ConfigurationDialog.set_CodecSettings(x264Settings value)
   at MeGUI.x264ConfigurationDialog.videoProfile_SelectedIndexChanged(Object sender, EventArgs e)
   at System.Windows.Forms.ComboBox.OnSelectedIndexChanged(EventArgs e)
   at System.Windows.Forms.ComboBox.WmReflectCommand(Message& m)
   at System.Windows.Forms.ComboBox.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
megui-x264-svn
    Assembly Version: 0.2.3.1032
    Win32 Version: 0.2.3.1032
    CodeBase: file:///G:/msys/1.0/home/user/pack/megui-x264-svn.exe
----------------------------------------
System.Windows.Forms
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
System.Xml
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Xml/2.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Configuration
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Configuration/2.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
_7rwuzjn
    Assembly Version: 0.2.3.1032
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Profiles used:
http://forum.doom9.org/showthread.php?t=101813
MeGUI-x264_generic_profiles_v20.7z

Doom9 · 5th January 2006, 22:59

Quote:

- Selecting profiles HQ-Insane and HQ-slowest then hit config (or select these profiles in config) crashes.

It appears to me that those use subme7.. don't try to use non SVN features with a built that only supports SVN features.. you're the one who wanted that build - I think it was pointed out that this could happen when I added the additional conditional code.

bob0r · 5th January 2006, 23:27

Ah ok, i understand.
Coding an option to detect valid profiles can be touch i guess.

Thanks (And yes svn only still is perfect, profiles do not come with the package, i only report what i see

)

Edit:
Moved the other report to the bug report thread, i just noticed it

charleski · 6th January 2006, 01:51

Ok, doom9 pointed out that the Oneclick code actively modifies the queue during processing, which makes it hard to insert jobs that require absolute placement without a lot of special handling. So I revised things back to using the settings shutdown code, but modified the window title so that the application's behaviour won't cause any nasty surprises. I also added in something to deal with the progress percentage appearing to hang at the end (really just a display issue).

0.2.3.1032 6 Jan 2006
Added a button to the Queue tab on the main form: "Add Shutdown". This adds a shutdown job to the end of the queue. Automatic shutdown can still be set using the checkbox in the Settings form.
Revised: Removed the use of system jobs and added shutdown checkboxes to the Oneclick window and queue tab.
Shutdown status is now displayed in the window title if it's enabled.
Modified main window title to revert to name+version after the job queue has finished.
Fixed tri-state GUI display dependencies in x264ConfigDialog.cs

Sharktooth · 6th January 2006, 05:10

x264 conditional compiling is broken again.

EDIT: Fixed and CVS updated.
0.2.3.1032a is "released". So please add any updates to the next version and make it 0.2.3.2

Doom9 · 6th January 2006, 09:11

I have something for discussion: with the addition of XviD AVC, we'll have two AVC and two ASP encoders.. and we already have two AAC encoder (perhaps three once dimzon integrated behappy?). There are two approaches to handle the two codec/one format approach. One is to have everything available in the appropriate dropdowns. That makes it very easy to see what you get, on the other hand it's more cumbersome internally because you have an xyzSetting object with the settings for each type of codec.. The other alternative is to offer just the codec type (like ASP, AVC, AAC) and have the encoder selection done in the settings. This makes it easier to integrate additional encoders, on the other hand, it's no longer apparent at first glance what is being used. And I'm sure you can come up with more pros and cons for each approach. Which one do you prefer?

Doom9 · 6th January 2006, 09:21

and about the shutdown: I think it wouldn't be such a bad idea to remove that from the settings, and have it in the queue, in addition to allowing to set it in the automated encoding setup windows.. and that checkbox should be non persistent.. so that in case you do want to shut down after processing, you actively requested it each time. That most certainly would get rid of the accidental shutdown problem, and at the same time I don't think it's so much a hassle to actively set this flag if you really want the PC to shut down.. it's a rather big step after all.

max-holz · 6th January 2006, 09:30

A little style point; the left border of the video codec dropdown combo seems to be disapperead.

Ciao

charleski · 6th January 2006, 10:19

0.2.3.1034 7 Jan 2006
Added a few fixes for conditional compilation

0.2.3.1033 7 Jan 2006
Small fix to ensure all the shutdown checkboxes reflect the current state correctly
[Since this is a bug fix I kept it as 0.2.3.1xxx and added it as a release]

berrinam · 6th January 2006, 13:09

0.2.3.1035 6 Jan 2006
Fixed the x264 lossless bug
Fixed the x264 threads bug

This means (according to the bug thread) all known bugs have been solved, so we are ready for a new version number in that respect.

Doom9 · 6th January 2006, 13:57

btw, depending on how encraw comes along, we might also get tri-state in the xvid config dialog and certainly in the xvid avc dialog as well

More fun for me and more opportunities to introduce new bugs...

Sharktooth · 6th January 2006, 15:42

Quote:

Originally Posted by Doom9

I have something for discussion: with the addition of XviD AVC, we'll have two AVC and two ASP encoders.. and we already have two AAC encoder (perhaps three once dimzon integrated behappy?). There are two approaches to handle the two codec/one format approach. One is to have everything available in the appropriate dropdowns. That makes it very easy to see what you get, on the other hand it's more cumbersome internally because you have an xyzSetting object with the settings for each type of codec.. The other alternative is to offer just the codec type (like ASP, AVC, AAC) and have the encoder selection done in the settings. This makes it easier to integrate additional encoders, on the other hand, it's no longer apparent at first glance what is being used. And I'm sure you can come up with more pros and cons for each approach. Which one do you prefer?

I'm for the first method.

@devs: when you're releasing a new build on SF ensure you check the "Preserve my pre-formatted text" just below the changelog...

Sharktooth · 6th January 2006, 16:22

CVS Update:

0.2.3.1036 (work in progress)
Changed "Codec" in "Encoder" in x264, snow, xvid and lavc dialogs titles
Fixed some conditional compilation warnings

5th January 2006, 21:55	#1041 \| Link
charleski Registered User Join Date: Jul 2004 Posts: 383	0.2.3.1032 6 Jan 2006 Added a button to the Queue tab on the main form: "Add Shutdown". This adds a shutdown job to the end of the queue. Automatic shutdown can still be set using the checkbox in the Settings form. Fixed tri-state GUI display dependencies in x264ConfigDialog.cs Actually, the tri-state problem was a side-effect of not allowing showCommandLine() to run when the dialog is first being initialised. I just added a separate call at the end of the load process. Last edited by charleski; 5th January 2006 at 21:57.

5th January 2006, 21:56	#1042 \| Link
Sharktooth Mr. Sandman Join Date: Sep 2003 Location: Haddonfield, IL Posts: 11,768	?!? Where was the error ?!? __________________ MPEG-4 ASP Custom Matrices: EQM V1(old), EQM AutoGK Sharpmatrix (aka EQM V2), EQM V3HR (updated 01/10/2004), EQM V3LR, EQM V3ULR (updated 04/02/2005), EQM V3UHR (updated 17/12/2004) and EQM V3EHR (updated 05/10/2004) Info about my ASP matrices. MPEG-4 AVC Custom Matrices: EQM AVC-HR Info about my AVC matrices My x264 builds. Mooo!!!

5th January 2006, 22:03	#1044 \| Link
charleski Registered User Join Date: Jul 2004 Posts: 383	The tri-state stuff is only called by showCommandLine(), and this was disabled when the dialog is being loaded: Code: private void showCommandLine() { --> if (!loaded) --> return; if (!x264ConfigurationDialog.levelEnforced) EnforceLevel(this.CodecSettings); x264DialogTriStateAdjustment(); So when the dialog loads it doesn't go through the x264DialogTriStateAdjustment() code and only adjusts to the right state if you change something.

5th January 2006, 23:27	#1050 \| Link
bob0r Pain and suffering Join Date: Jul 2002 Posts: 1,337	Ah ok, i understand. Coding an option to detect valid profiles can be touch i guess. Thanks (And yes svn only still is perfect, profiles do not come with the package, i only report what i see ) Edit: Moved the other report to the bug report thread, i just noticed it Last edited by bob0r; 5th January 2006 at 23:31.

6th January 2006, 05:10	#1052 \| Link
Sharktooth Mr. Sandman Join Date: Sep 2003 Location: Haddonfield, IL Posts: 11,768	x264 conditional compiling is broken again. EDIT: Fixed and CVS updated. 0.2.3.1032a is "released". So please add any updates to the next version and make it 0.2.3.2 __________________ MPEG-4 ASP Custom Matrices: EQM V1(old), EQM AutoGK Sharpmatrix (aka EQM V2), EQM V3HR (updated 01/10/2004), EQM V3LR, EQM V3ULR (updated 04/02/2005), EQM V3UHR (updated 17/12/2004) and EQM V3EHR (updated 05/10/2004) Info about my ASP matrices. MPEG-4 AVC Custom Matrices: EQM AVC-HR Info about my AVC matrices My x264 builds. Mooo!!! Last edited by Sharktooth; 6th January 2006 at 05:28.

6th January 2006, 01:51	#1051 \| Link
charleski Registered User Join Date: Jul 2004 Posts: 383	Ok, doom9 pointed out that the Oneclick code actively modifies the queue during processing, which makes it hard to insert jobs that require absolute placement without a lot of special handling. So I revised things back to using the settings shutdown code, but modified the window title so that the application's behaviour won't cause any nasty surprises. I also added in something to deal with the progress percentage appearing to hang at the end (really just a display issue). 0.2.3.1032 6 Jan 2006 Added a button to the Queue tab on the main form: "Add Shutdown". This adds a shutdown job to the end of the queue. Automatic shutdown can still be set using the checkbox in the Settings form. Revised: Removed the use of system jobs and added shutdown checkboxes to the Oneclick window and queue tab. Shutdown status is now displayed in the window title if it's enabled. Modified main window title to revert to name+version after the job queue has finished. Fixed tri-state GUI display dependencies in x264ConfigDialog.cs

6th January 2006, 09:11	#1053 \| Link
Doom9 clueless n00b Join Date: Oct 2001 Location: somewhere over the rainbow Posts: 10,579	I have something for discussion: with the addition of XviD AVC, we'll have two AVC and two ASP encoders.. and we already have two AAC encoder (perhaps three once dimzon integrated behappy?). There are two approaches to handle the two codec/one format approach. One is to have everything available in the appropriate dropdowns. That makes it very easy to see what you get, on the other hand it's more cumbersome internally because you have an xyzSetting object with the settings for each type of codec.. The other alternative is to offer just the codec type (like ASP, AVC, AAC) and have the encoder selection done in the settings. This makes it easier to integrate additional encoders, on the other hand, it's no longer apparent at first glance what is being used. And I'm sure you can come up with more pros and cons for each approach. Which one do you prefer? __________________ For the web's most comprehensive collection of DVD backup guides go to www.doom9.org

6th January 2006, 09:21	#1054 \| Link
Doom9 clueless n00b Join Date: Oct 2001 Location: somewhere over the rainbow Posts: 10,579	and about the shutdown: I think it wouldn't be such a bad idea to remove that from the settings, and have it in the queue, in addition to allowing to set it in the automated encoding setup windows.. and that checkbox should be non persistent.. so that in case you do want to shut down after processing, you actively requested it each time. That most certainly would get rid of the accidental shutdown problem, and at the same time I don't think it's so much a hassle to actively set this flag if you really want the PC to shut down.. it's a rather big step after all. __________________ For the web's most comprehensive collection of DVD backup guides go to www.doom9.org

6th January 2006, 09:30	#1055 \| Link
max-holz Registered User Join Date: Mar 2005 Posts: 173	A little style point; the left border of the video codec dropdown combo seems to be disapperead. Ciao

6th January 2006, 10:19	#1056 \| Link
charleski Registered User Join Date: Jul 2004 Posts: 383	0.2.3.1034 7 Jan 2006 Added a few fixes for conditional compilation 0.2.3.1033 7 Jan 2006 Small fix to ensure all the shutdown checkboxes reflect the current state correctly [Since this is a bug fix I kept it as 0.2.3.1xxx and added it as a release] Last edited by charleski; 6th January 2006 at 10:53.

6th January 2006, 13:09	#1057 \| Link
berrinam Registered User Join Date: Apr 2005 Posts: 1,740	0.2.3.1035 6 Jan 2006 Fixed the x264 lossless bug Fixed the x264 threads bug This means (according to the bug thread) all known bugs have been solved, so we are ready for a new version number in that respect.

6th January 2006, 13:57	#1058 \| Link
Doom9 clueless n00b Join Date: Oct 2001 Location: somewhere over the rainbow Posts: 10,579	btw, depending on how encraw comes along, we might also get tri-state in the xvid config dialog and certainly in the xvid avc dialog as well More fun for me and more opportunities to introduce new bugs... __________________ For the web's most comprehensive collection of DVD backup guides go to www.doom9.org

6th January 2006, 16:22	#1060 \| Link
Sharktooth Mr. Sandman Join Date: Sep 2003 Location: Haddonfield, IL Posts: 11,768	CVS Update: 0.2.3.1036 (work in progress) Changed "Codec" in "Encoder" in x264, snow, xvid and lavc dialogs titles Fixed some conditional compilation warnings __________________ MPEG-4 ASP Custom Matrices: EQM V1(old), EQM AutoGK Sharpmatrix (aka EQM V2), EQM V3HR (updated 01/10/2004), EQM V3LR, EQM V3ULR (updated 04/02/2005), EQM V3UHR (updated 17/12/2004) and EQM V3EHR (updated 05/10/2004) Info about my ASP matrices. MPEG-4 AVC Custom Matrices: EQM AVC-HR Info about my AVC matrices My x264 builds. Mooo!!! Last edited by Sharktooth; 6th January 2006 at 16:38.