MeGUI development

[Sharktooth]

Berrinam is still MIA?

[Kurtnoise]

Hi,

Should I rebuild the old x264 config (to have zones, extra commands, etc...) for the dev branch or we wait the berrinam's back ?

[Kurtnoise]

Originally Posted by Sharktooth

Berrinam is still MIA?

falling in love maybe...

[Sharktooth]

Originally Posted by Kurtnoise13

Hi,

Should I rebuild the old x264 config (to have zones, extra commands, etc...) for the dev branch or we wait the berrinam's back ?

lets wait few other days. if he's still MIA we can either:
1- Revert to the old profiles code
2- Complete the profiles refactor adding the missing zones and custom CLI options fox x264
3- Go ahead without zones and add custom CLI options only.

[Kurtnoise]

ok...shouln't be too complicated anyway.


btw, last night I checked the new DGindex stuff for audio streams extraction and it seems to be more complicated than I thought. We need to run a special command first to create a logfile to have each tracks IDs, then read those datas from the file and put them in the current DGindex command...so, great. :-/

I'll see what can I do for this part....

[Sharktooth]

eh, i had a look at it some time ago and i gave up since i had not enough time to get it working.

[buzzqw]

@Kurtonise13

yea, confirm; i use the same approach on automkv
First check if stream is mpeg2 (mediainfo) if yes, lauch dgindex in info mode, parse the log and add the audio tracks to list
If video is mpeg4, run dgavcdec demuxing all audio tracks and indexing the file, then add audio to list

BHH

[Kurtnoise]

Originally Posted by Kurtnoise13

btw, last night I checked the new DGindex stuff for audio streams extraction and it seems to be more complicated than I thought. We need to run a special command first to create a logfile to have each tracks IDs, then read those datas from the file and put them in the current DGindex command...so, great. :-/

I'll see what can I do for this part....

There is also an alternative: using the track IDs supply by the DVDDecrypter stream infos file. Several parts in the current code use this. But an issue remains if we use this way : when users don't have a such file. So, the right trick seems to use the logfile created by DGindex. What do you think ?

[Sharktooth]

DVD Decrypter is dead and in some countries even illegal.
Sadly, we should not rely on it anymore but that means rewriting some code...
Buzzqw method is the right way to go (yeah italians do it better) but as i said, it needs some time and will to rewrite some parts of megui.

[stax76]

I extract all streams and rename the files replacing the index with language code and name extracted from IFO.

[buzzqw]

yes.. if have an ifo.. but with a mpeg stream, not belonging to dvd.. it's hard to tell language
on automkv i use vstrip to determine audio id/languages (on ifo) and then allow dgindex to demux only tracks user selected

BHH

[Mutant_Fruit]

This is the current constructor. This throws a null ref exception in Mono because of a a missing null-check which prevents MeGUI from loading:

    class JobQueueSettings : ApplicationSettingsBase
    {
        public JobQueueSettings(IComponent c, string k)
            :base(c, k)
        {}
    }

If i use an alternate base constructor, everything loads up fine

    class JobQueueSettings : ApplicationSettingsBase
    {
        public JobQueueSettings(IComponent c, string k)
            :base(k)
        {}
    }

My understanding of the whole ApplicationSettingsBase stuff isn't good enough to know if that's a safe change or not. If that's a safe change, am i good to commit that? That'll allow MeGUI to run on Mono.

[bob0r]

Megui x264 config: RC and ME > Macroblock Options

When you select Adaptive DCT (--8x8dct), --i8x8 should be enabled also, this is a bug. Please fix it

Also i8x8 is on by default default: --partitions "p8x8,b8x8,i8x8,i4x4"

Edit:
Also please update --analyse to --partitions. Thanks

[Kurtnoise]

Originally Posted by Mutant_Fruit

This is the current constructor. This throws a null ref exception in Mono because of a a missing null-check which prevents MeGUI from loading:

    class JobQueueSettings : ApplicationSettingsBase
    {
        public JobQueueSettings(IComponent c, string k)
            :base(c, k)
        {}
    }

If i use an alternate base constructor, everything loads up fine

    class JobQueueSettings : ApplicationSettingsBase
    {
        public JobQueueSettings(IComponent c, string k)
            :base(k)
        {}
    }

It's fine for me if it doesn't break anything else...

[Kurtnoise]

Originally Posted by bob0r

Megui x264 config: RC and ME > Macroblock Options

When you select Adaptive DCT (--8x8dct), --i8x8 should be enabled also, this is a bug. Please fix it

ok...

Originally Posted by bob0r

Edit:
Also please update --analyse to --partitions. Thanks

both are correct...

[Mutant_Fruit]

Originally Posted by Kurtnoise13

It's fine for me if it doesn't break anything else...

From what i can tell, it's ok to make this change, so i'm going to go ahead and commit this. Let me know if any issues pop up that i've missed. The fix is in revision 479, so things should Just Work (TM) on Linux now. Encoding and all that doesn't work, that needs to be set up, but MeGUI starts up.

[bob0r]

Originally Posted by Kurtnoise13

ok...


both are correct...

Yes, but x264 --help shows --partitions, why not make it match the x264 git code, just logical.

Thanks

[Kurtnoise]

why ? lazyness probably..

Anyway, if you check the current x264 code (formely common.c), you can see that it's still there fortunately...

[bob0r]

Originally Posted by Kurtnoise13

why ? lazyness probably..

Anyway, if you check the current x264 code (formely common.c), you can see that it's still there fortunately...

YES i know that, pengvado left it there because he is such a nice guy

I just say: It would be better if you renamed it just to match Current x264 settings when you type x264 --help.
Clarity > Sanity!


P.S.
If you fixed the i8x8 issue, please update the stable version on the updater.... Okay Sahrktooth?
Sharktooth come on irc tonight 00:00-04:00 or tomorrow please, got something to run by you

[Sharktooth]

ill see what i can do