LameXP v4.21 Final · Build #2382 (2023-12-29) - Page 41

LoRd_MuldeR · 25th October 2012, 22:46

Okay, after some debugging I found the cause of the issue!

When FAAD2 prints out the current Progress, it first writes the text "[x%] decoding <filename>" into an internal buffer, before it then actually prints that text out to the console. And, as this text includes the filename, the size of the buffer that is required to hold the text, depends on the length of the file name, obviously. For some reason, however, they made the buffer only 200 characters long. With very long file names this can be too short and we get a nice buffer overrun!

Motenai Yoda · 26th October 2012, 06:29

how do u fixed? Can I suggest to simply use cout<< operator to concatenate and push out the strings, or use something like strCount() or size_of() to know how long the filename is?

LoRd_MuldeR · 26th October 2012, 12:47

I increased the buffer from 200 to 300 char's, which should be enough, assuming file name won't exceed MAX_PATH char's. But to be sure, and because in UTF-8 encoding one "character" can take multiple char's (bytes), I also replaced the highly unsafe sprintf() with the safe snprintf_s(). Using the "cout" object is not possible in a plain C program, that is C++ stuff. And sizeof() doesn't tell you anything, if you have char* pointer.

BTW: It seems all the reason why they print into a buffer first, instead of using printf() right away, is because they are going to pass the same text into SetConsoleTitle() too.

(The patch will be included in the LameXP repository, as always)

LoRd_MuldeR · 27th October 2012, 16:32

LameXP v4.06 RC-3

Quote:

Changes between v4.05 and v4.06 [unreleased]:
* Updated Opus encoder/decoder libraries to v1.0.1 and Opus-Tools to v0.1.5 (2012-09-22)
* Updated mpg123 decoder to v1.14.4+ (2012-09-24), compiled with GCC 4.7.1
* Updated Qt runtime libraries to v4.8.3 (2012-09-13), compiled with MSVC 10.0
* Updated MediaInfo to v0.7.60 (2012-09-07), compiled with ICL 12.1.7 and MSVC 10.0
* Updated language files (big thank-you to all contributors !!!)
* Fixed a bug with the "Store temporary files in your system's default TEMP director" checkbox
* Fixed a buffer overflow in FAAD2 decoder which could cause crashes with very long file names
* Fixed a regression in Qt v4.8.3 that broke Drag&Drop support (details #1) (details #2)
* Reworked the "About..." dialog – now using a custom dialog instead of message boxes

Note: Because home.pages.at has stopped the service after many years, my web-site sadly is no longer available under the "free.pages.at" address

The following mirrors are still available: #1 #2 #3 #4

LoRd_MuldeR · 29th October 2012, 00:07

LameXP v4.06 RC-4

Quote:

Changes between v4.05 and v4.06 [unreleased]:
* Updated Opus encoder/decoder libraries to v1.0.1 and Opus-Tools to v0.1.5 (2012-09-22)
* Updated mpg123 decoder to v1.14.4+ (2012-09-24), compiled with GCC 4.7.1
* Updated Qt runtime libraries to v4.8.3 (2012-09-13), compiled with MSVC 10.0
* Updated MediaInfo to v0.7.61+ (2012-10-28), compiled with ICL 12.1.7 and MSVC 10.0
* Updated language files (big thank-you to all contributors !!!)
* Fixed a bug with the "Store temporary files in your system's default TEMP director" checkbox
* Fixed a buffer overflow in FAAD2 decoder which could cause crashes with very long file names
* Fixed a regression in Qt v4.8.3 that broke Drag&Drop support (details #1) (details #2)
* Reworked the "About..." dialog – now using a custom dialog instead of message boxes

LoRd_MuldeR · 1st November 2012, 01:51

LameXP v4.06 RC-5

Quote:

Changes between v4.05 and v4.06 [unreleased]:
* Updated Opus encoder/decoder libraries to v1.0.1 and Opus-Tools to v0.1.5 (2012-09-22)
* Updated mpg123 decoder to v1.14.4+ (2012-09-24), compiled with GCC 4.7.1
* Updated ALAC decoder to refalac v0.56 (2012-10-24), based on reference implementation by Apple
* Updated Qt runtime libraries to v4.8.3 (2012-09-13), compiled with MSVC 10.0
* Updated MediaInfo to v0.7.61+ (2012-10-28), compiled with ICL 12.1.7 and MSVC 10.0
* Updated language files (big thank-you to all contributors !!!)
* Fixed a bug with the "Store temporary files in your system's default TEMP director" checkbox
* Fixed a buffer overflow in FAAD2 decoder which could cause crashes with very long file names
* Fixed a regression in Qt v4.8.3 that broke Drag&Drop support (details #1) (details #2)
* Reworked the "About..." dialog – now using a custom dialog instead of message boxes

LoRd_MuldeR · 4th November 2012, 18:34

LameXP v4.06 has been released

Quote:

Changes between v4.05 and v4.06 [2012-11-04]:
* Updated Opus encoder/decoder libraries to v1.0.1 and Opus-Tools to v0.1.5 (2012-09-22)
* Updated mpg123 decoder to v1.14.4+ (2012-09-24), compiled with GCC 4.7.1
* Updated ALAC decoder to refalac v0.56 (2012-10-24), based on reference implementation by Apple
* Updated Qt runtime libraries to v4.8.3 (2012-09-13), compiled with MSVC 10.0
* Updated MediaInfo to v0.7.61+ (2012-10-28), compiled with ICL 12.1.7 and MSVC 10.0
* Updated language files (big thank-you to all contributors !!!)
* Fixed a bug with the "Store temporary files in your system's default TEMP director" checkbox
* Fixed a buffer overflow in FAAD2 decoder which could cause crashes with very long file names
* Fixed a regression in Qt v4.8.3 that broke Drag&Drop support (details #1) (details #2)
* Reworked the "About..." dialog – now using a custom dialog instead of message boxes

SeeMoreDigital · 4th November 2012, 18:44

Downloading and installing now.... Many thanks

Dogway · 8th November 2012, 01:49

at last LameXP doesn't have any conflict with Comodo on the new version.
The bad news is it doesn't recognise qaac.exe.
If you care for presentation, there's a mispell in spanish "Mostar DropBox", where it should be "Mostrar".
You're welcome : P

edit: found the hidden gem qaac.exe v.1.39, working great now, thanks!

LoRd_MuldeR · 8th November 2012, 12:46

Quote:

Originally Posted by Dogway

at last LameXP doesn't have any conflict with Comodo on the new version.

I didn't change anything... because there is nothing I could do, on my side, against buggy A/V software.

So I guess, whatever the problem in Comodo was, they have fixed the bug on their side...

See also:
http://lamexp.sourceforge.net/doc/FAQ.html#96205e91

Quote:

Originally Posted by Dogway

The bad news is it doesn't recognise qaac.exe.

Please follow the install instructions here:
http://lamexp.sourceforge.net/doc/FAQ.html#71a113b0

You may need to update your QAAC add-in for LameXP, if yours is too old...

Quote:

Originally Posted by Dogway

If you care for presentation, there's a mispell in spanish "Mostar DropBox", where it should be "Mostrar".
You're welcome : P

Well, I have to rely on traslators for all languages, except for English and German.

If you think you can improve the Spanish translation, please feel free to have a look at:
http://lamexp.sourceforge.net/doc/Translate.html

I will fix this one typo for the next release. So thanks for the report.

Dogway · 8th November 2012, 17:37

Quote:

Originally Posted by LoRd_MuldeR

You may need to update your QAAC add-in for LameXP, if yours is too old...

Yes I found out just right after posting.

I didn't do anything to Comodo (update database nor software) so I don't know, maybe it was something on your side (without noticing) or that I correctly enabled permissions, although I doubt I didn't do this the first time.

Thank you.

LoRd_MuldeR · 15th November 2012, 19:05

For anybody who cares, here is the first Visual Studio 2012 build of LameXP:
http://www.mediafire.com/file/rl546g...Build-1188.exe

As one might expect, this build will not run on Windows XP (or even older). It also will need a CPU with SSE2 support, because Visual Studio defaults to /arch:SSE2 now and I didn't see a reason to change that. If the binary doesn't run on older OS anyway, it doesn't make any sense to still care about archaic CPU's. Other than that, you shouldn't see any difference with the new build.

SeeMoreDigital · 15th November 2012, 20:22

Quote:

Originally Posted by LoRd_MuldeR

For anybody who cares, here is the first Visual Studio 2012 build of LameXP:
http://www.mediafire.com/file/rl546g...Build-1188.exe

Thanks... It opens fine with Win7 32-bit

manolito · 15th November 2012, 20:55

Quote:

Originally Posted by LoRd_MuldeR

For anybody who cares, here is the first Visual Studio 2012 build of LameXP:
http://www.mediafire.com/file/rl546g...Build-1188.exe

I just hope that you are not planning to abandon XP support any time soon...

Cheers
manolito

LoRd_MuldeR · 15th November 2012, 21:27

Don't worry, I won't drop Windows XP support!

Maybe I will make the switch to VS2012 after Microsoft has finally released the "Update 1" for VS2012, which is supposed to restore Windows XP targeting support, yay

I don't know if it will be possible to restore Windows 2000 support the same way I could do it with VS2010, so I might be forced to drop Windows 2000 support.

(Currently I'm still undecided whether my eyes will be able to permanently bear the clunky interface of VS2012, but "Update 1" is also supposed to bring back some colors ^^)

Przemek_Sperling · 20th November 2012, 11:12

I ripped some CDs and coded them with Opus. The quality is great but one thing seems to be a bit weird to me. As I ripped them from CDs the source is sampled at 44 kHz, but if I compress it with Opus and play with AIMP or foobar the players show 48 kHz sampling rate. Are the files resampled? Is it usual behavior for the codec orI am doing something wrong?

LoRd_MuldeR · 20th November 2012, 11:45

Please see:
http://www.hydrogenaudio.org/forums/...dpost&p=808895

Opus does not natively support 44Khz. The idea is that since 48Khz can store a 44Khz signal, this simplifies the algorithm. Then, it just stores the original format and size so that a decoder could decode to the same values, but a decoder is allowed to decode at another samplerate. [...] Every non-48Khz input rate will internally be converted to 48Khz. So the output will always be at 48Khz. If you don't trust the internal resampler then you could always go and use something like SoX.

See also:
http://wiki.xiph.org/OpusFAQ#How_do_...ted_by_Opus.3F

Note that it's generally preferable for a decoder to output at 48kHz even when you know the original input was 44.1kHz, not only because you can skip resampling but also because many inexpensive audio interfaces have poor quality output for 44.1k. [...] input files at these rates [above 48 kHz] are internally converted to 48 kHz, and then only frequencies up to 20 kHz are encoded. The reason is simple: lossy codecs are designed to preserve audible details while discarding irrelevant information. Since the human ear can only hear up to 20 kHz at best (usually lower than that), frequency content above 20 kHz is the first thing to go.

Przemek_Sperling · 20th November 2012, 15:55

Thank you for the links. They explain everything

LoRd_MuldeR · 28th November 2012, 02:00

LameXP v4.07 Alpha-4

Quote:

Changes between v4.06 and v4.07:
* Upgraded build environment to Microsoft Visual Studio 2012 with Update-1
* Added option to select the "overwrite mode" to advanced options tab
* Added option to filter the log entries on the "processing" dialog (see context menu)
* Updated Qt runtime libraries to v4.8.4 (2012-11-23), compiled with MSVC 11.0
* Updated Opus encoder/decoder libraries to v1.1.x and Opus-Tools to v0.1.5 (2012-11-23)

Note: This build was made with "Update 1" of Visual Studio 2012, so this build is supposed to work under Windows XP again (as opposed to Visual Studio 2012 RTM). If you encounter any issues under Windows XP, please report!

Kadai · 2nd December 2012, 08:33

Not sure if someone has reported it yet... but (at least on Linux / Kubuntu 12.10 ... running LameXP on top of Wine) I have got a consistent problem when the tags of the files being encoded have quotes on the name.

For example, if the file has a title tag like (and named also): マジカ"ルゼ"アクション編曲バトル! ... the file won't convert and will threw a error.

This have happened to me with flac files, but they have something in common... the tags are UTF-8 encoded (so far I know).

Now, I'm not sure if this also happens on Windows (because I do not have a windows box at hand), but this error has been consistent with me, with the 4.06 final version, so I decided to report it.

Other one I have seen that threw me the error is:
ゆうかぜ (Yoshino Yoshikawa "Pollarstars" remix)

Hope it is helpful.

25th October 2012, 22:46	#801 \| Link
LoRd_MuldeR Software Developer Join Date: Jun 2005 Location: Last House on Slunk Street Posts: 13,248	Okay, after some debugging I found the cause of the issue! When FAAD2 prints out the current Progress, it first writes the text "[x%] decoding <filename>" into an internal buffer, before it then actually prints that text out to the console. And, as this text includes the filename, the size of the buffer that is required to hold the text, depends on the length of the file name, obviously. For some reason, however, they made the buffer only 200 characters long. With very long file names this can be too short and we get a nice buffer overrun! __________________ Go to https://standforukraine.com/ to find legitimate Ukrainian Charities 🇺🇦✊ Last edited by LoRd_MuldeR; 27th October 2012 at 01:44.

26th October 2012, 06:29	#802 \| Link
Motenai Yoda Registered User Join Date: Jan 2010 Posts: 709	how do u fixed? Can I suggest to simply use cout<< operator to concatenate and push out the strings, or use something like strCount() or size_of() to know how long the filename is? __________________ powered by Google Translator

26th October 2012, 12:47	#803 \| Link
LoRd_MuldeR Software Developer Join Date: Jun 2005 Location: Last House on Slunk Street Posts: 13,248	I increased the buffer from 200 to 300 char's, which should be enough, assuming file name won't exceed MAX_PATH char's. But to be sure, and because in UTF-8 encoding one "character" can take multiple char's (bytes), I also replaced the highly unsafe sprintf() with the safe snprintf_s(). Using the "cout" object is not possible in a plain C program, that is C++ stuff. And sizeof() doesn't tell you anything, if you have char* pointer. BTW: It seems all the reason why they print into a buffer first, instead of using printf() right away, is because they are going to pass the same text into SetConsoleTitle() too. (The patch will be included in the LameXP repository, as always) __________________ Go to https://standforukraine.com/ to find legitimate Ukrainian Charities 🇺🇦✊ Last edited by LoRd_MuldeR; 26th October 2012 at 14:24.

4th November 2012, 18:44	#808 \| Link
SeeMoreDigital Life's clearer in 4K UHD Join Date: Jun 2003 Location: Notts, UK Posts: 12,227	Downloading and installing now.... Many thanks __________________ \| I've been testing hardware media playback devices and software A/V encoders and decoders since 2001 \| My Network Layout & A/V Gear \|

8th November 2012, 01:49	#809 \| Link
Dogway Registered User Join Date: Nov 2009 Posts: 2,361	at last LameXP doesn't have any conflict with Comodo on the new version. The bad news is it doesn't recognise qaac.exe. If you care for presentation, there's a mispell in spanish "Mostar DropBox", where it should be "Mostrar". You're welcome : P edit: found the hidden gem qaac.exe v.1.39, working great now, thanks! Last edited by Dogway; 8th November 2012 at 01:57.

15th November 2012, 19:05	#812 \| Link
LoRd_MuldeR Software Developer Join Date: Jun 2005 Location: Last House on Slunk Street Posts: 13,248	For anybody who cares, here is the first Visual Studio 2012 build of LameXP: http://www.mediafire.com/file/rl546g...Build-1188.exe As one might expect, this build will not run on Windows XP (or even older). It also will need a CPU with SSE2 support, because Visual Studio defaults to /arch:SSE2 now and I didn't see a reason to change that. If the binary doesn't run on older OS anyway, it doesn't make any sense to still care about archaic CPU's. Other than that, you shouldn't see any difference with the new build. __________________ Go to https://standforukraine.com/ to find legitimate Ukrainian Charities 🇺🇦✊ Last edited by LoRd_MuldeR; 15th November 2012 at 20:39.

15th November 2012, 21:27	#815 \| Link
LoRd_MuldeR Software Developer Join Date: Jun 2005 Location: Last House on Slunk Street Posts: 13,248	Don't worry, I won't drop Windows XP support! Maybe I will make the switch to VS2012 after Microsoft has finally released the "Update 1" for VS2012, which is supposed to restore Windows XP targeting support, yay I don't know if it will be possible to restore Windows 2000 support the same way I could do it with VS2010, so I might be forced to drop Windows 2000 support. (Currently I'm still undecided whether my eyes will be able to permanently bear the clunky interface of VS2012, but "Update 1" is also supposed to bring back some colors ^^) __________________ Go to https://standforukraine.com/ to find legitimate Ukrainian Charities 🇺🇦✊ Last edited by LoRd_MuldeR; 15th November 2012 at 21:30.

20th November 2012, 11:12	#816 \| Link
Przemek_Sperling Registered User Join Date: Jun 2009 Location: Poland Posts: 125	Opus codec coding question I ripped some CDs and coded them with Opus. The quality is great but one thing seems to be a bit weird to me. As I ripped them from CDs the source is sampled at 44 kHz, but if I compress it with Opus and play with AIMP or foobar the players show 48 kHz sampling rate. Are the files resampled? Is it usual behavior for the codec orI am doing something wrong?

20th November 2012, 11:45	#817 \| Link
LoRd_MuldeR Software Developer Join Date: Jun 2005 Location: Last House on Slunk Street Posts: 13,248	Please see: http://www.hydrogenaudio.org/forums/...dpost&p=808895 Opus does not natively support 44Khz. The idea is that since 48Khz can store a 44Khz signal, this simplifies the algorithm. Then, it just stores the original format and size so that a decoder could decode to the same values, but a decoder is allowed to decode at another samplerate. [...] Every non-48Khz input rate will internally be converted to 48Khz. So the output will always be at 48Khz. If you don't trust the internal resampler then you could always go and use something like SoX. See also: http://wiki.xiph.org/OpusFAQ#How_do_...ted_by_Opus.3F Note that it's generally preferable for a decoder to output at 48kHz even when you know the original input was 44.1kHz, not only because you can skip resampling but also because many inexpensive audio interfaces have poor quality output for 44.1k. [...] input files at these rates [above 48 kHz] are internally converted to 48 kHz, and then only frequencies up to 20 kHz are encoded. The reason is simple: lossy codecs are designed to preserve audible details while discarding irrelevant information. Since the human ear can only hear up to 20 kHz at best (usually lower than that), frequency content above 20 kHz is the first thing to go. __________________ Go to https://standforukraine.com/ to find legitimate Ukrainian Charities 🇺🇦✊ Last edited by LoRd_MuldeR; 20th November 2012 at 12:05.

20th November 2012, 15:55	#818 \| Link
Przemek_Sperling Registered User Join Date: Jun 2009 Location: Poland Posts: 125	Thank you for the links. They explain everything

2nd December 2012, 08:33	#820 \| Link
Kadai Registered User Join Date: Jun 2012 Posts: 3	Not sure if someone has reported it yet... but (at least on Linux / Kubuntu 12.10 ... running LameXP on top of Wine) I have got a consistent problem when the tags of the files being encoded have quotes on the name. For example, if the file has a title tag like (and named also): マジカ"ルゼ"アクション編曲バトル! ... the file won't convert and will threw a error. This have happened to me with flac files, but they have something in common... the tags are UTF-8 encoded (so far I know). Now, I'm not sure if this also happens on Windows (because I do not have a windows box at hand), but this error has been consistent with me, with the 4.06 final version, so I decided to report it. Other one I have seen that threw me the error is: ゆうかぜ (Yoshino Yoshikawa "Pollarstars" remix) Hope it is helpful. Last edited by LoRd_MuldeR; 2nd December 2012 at 21:24.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode