Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
25th September 2014, 06:30 | #21 | Link |
ангел смерти
Join Date: Nov 2004
Location: Lost
Posts: 9,558
|
The first script hello_hello posted didn't have proper quoted argument names in the function definition, which is how Avisynth defines an optional argument. By quoting them, you can call it without passing everything. The limit = default(limit,6) without limit being quoted is obviously an error.
|
25th September 2014, 06:50 | #22 | Link |
Banned
Join Date: Sep 2014
Location: https://t.me/pump_upp
Posts: 10
|
i have tried this
function RemoveDirt(clip input, bool "_grey", int "repmode") { _grey=default(_grey, false) repmode=default(repmode, 16) clmode=17 clensed=Clense(input, grey=_grey, cache=4) sbegin = ForwardClense(input, grey=_grey, cache=-1) send = BackwardClense(input, grey=_grey, cache=-1) alt=Repair(SCSelect(input, sbegin, send, clensed, debug=true), input, mode=repmode, modeU = _grey ? -1 : repmode ) restore=Repair(clensed, input, mode=repmode, modeU = _grey ? -1 : repmode) corrected=RestoreMotionBlocks(clensed, restore, neighbour=input, alternative=alt, gmthreshold=70, dist=1, dmode=2, debug=false, noise=10, noisy=12, grey=_grey) return RemoveGrain(corrected, mode=clmode, modeU = _grey ? -1 : clmode ) } ...it loads up on vituraldub no problem only thing is there is no changes..so now what ? i have seen clips where all the dirt and pops go away...but for me nothing. so far the only way i have i have cleaned up old film is frame by frame and thats over 1,300 frames for about 1min of film and treating each frame has if i am cleaning old photos..but this takes almost a day and next month i will have 25min film to do. but at the looks of things..i have tried it all...i have copy and paste and i have tried fiddling with numbers and nothing...the only thing works for me in avisynth is the basic scripts thats on the wiki site other then nothing else works just either an error or no changes at some point i will give up and face facts that this will not work |
25th September 2014, 09:40 | #24 | Link | |
Registered User
Join Date: Mar 2011
Posts: 4,823
|
flashmaster,
You really need to be fairly specific as to what you're doing otherwise you'll find most of the time is spent playing 20 questions. Posting your entire script might help. I'm not sure what "loads up on VirtualDub" means. The script you copied specifies the functions and default values etc, but it won't do anything if you just copy and paste it into a script for encoding. You need to follow it with RemoveDirt(), so if you're going to copy and paste it into a script, you'd need to end up with something like this: Quote:
Keep in mind there's a few RemoveDirt scripts, so if you do create an avsi file with a function RemoveDirt and put it in the Avisynth plugins folder, don't put more than one in their at a time. Anyway, my next post contains step by step instructions for getting the above script to work..... I hope. Last edited by hello_hello; 25th September 2014 at 09:46. |
|
25th September 2014, 09:43 | #25 | Link |
I'm Siri
Join Date: Oct 2012
Location: void
Posts: 2,633
|
@TurboPascal7
here are some buggy sample scripts. first, the working one Code:
lwlibavvideoSource("xxx") super=msuper () vectors=super.manalyse (multi=true,delta=6) mdegrainn (super,vectors,6) Code:
lwlibavvideoSource("xxx") super=msuper () vectors=super.manalyse (multi=true,delta=6) mdegrainn (super,vectors,tr=6) #the script returns "Script error: Invalid arguments to function 'mdegrainn'" while "tr=6" works with no error in mcompensate Code:
super=msuper () vectors=manalyse (super=super,multi=true,delta=6) #manalyse (super,multi=true,delta=6) works mdegrainn (super,vectors,6) #the script returns "Script error: manalyse does not have a named argument "super"", but it's clearly written in MVtools2 document that the first parameter of manalyse is "clip super" |
25th September 2014, 09:45 | #26 | Link | ||
Registered User
Join Date: Mar 2011
Posts: 4,823
|
flashmaster,
copy the text below and paste it into a new text file. Save it as RemoveDirt.txt and then change the extension to RemoveDirst.avsi (or simply call it RemoveDirst.avsi in the first place). Copy it to your Avisynth plugins folder. I'm running XP so the folder location would be "C:\Program Files\AviSynth 2.5\plugins". Quote:
http://home.arcor.de/kassandro/prere...eGrain-1.0.rar http://home.arcor.de/kassandro/prere...GrainT-1.0.rar Download both the above, unzip them and copy every file inside with an SSE2 at the end of it's name to your Avisynth plugins folder. I honestly can't remember if they're all required but it can't hurt. When that's done, add this to a script you're using for encoding: RemoveDirt() If all went well...... If you get an error along the lines of "no function named RemoveDirt" then the avsi script you created isn't being auto-loaded for some reason, or you've done something wrong. There's a slightly modified version of the above script. You can copy and paste the text below again and use it to create a file called RemoveSpots.avsi which you'd copy to your Avisynth plugins folder and add to a script like this: RemoveSpots() Quote:
Last edited by hello_hello; 25th September 2014 at 10:05. |
||
25th September 2014, 09:54 | #27 | Link | |
Registered User
Join Date: Mar 2011
Posts: 4,823
|
feisty2,
In this case the problem seemed to be the script not having proper quoted argument names, as foxyshadis suggested. When I changed it to this, the error messages went away. Quote:
I experimented with it a little and couldn't seem to get any action out of it unless I cranked up the limit value quite a bit: RemoveDirt(limit = 60) flashmaster, If you want to try the above script it also requires mvtools.dll be in the Avisynth plugins folder. http://avisynth.org.ru/mvtools/mvtools-v1.11.4.5.zip |
|
25th September 2014, 10:21 | #28 | Link |
I'm Siri
Join Date: Oct 2012
Location: void
Posts: 2,633
|
"Mxx" is the format of mvtools2, mvtools 1.x script would be "MVxx" format
you don't need old mvtools 1 see #785 at http://forum.doom9.org/showthread.php?t=168856&page=40 you can run that script with mvtools2 and other modern filters |
25th September 2014, 10:28 | #29 | Link |
Registered User
Join Date: Mar 2014
Posts: 308
|
Fun fact: non-optional arguments cannot be used with name=value syntax. If I'm not wrong, the Avisynth API treats named arguments as being optional so there's no way to have a named but non-optional argument for a C/C++ plugin.
__________________
Say no to AviSynth 2.5.8 and DirectShowSource! |
25th September 2014, 17:43 | #32 | Link | ||
Registered User
Join Date: Mar 2011
Posts: 4,823
|
Quote:
I'll confess you did help me to conclude mvtools was required given you posted about it being buggy directly below the script I posted. Cheers. While I was encoding some old video I thought I'd try some spot removal. There's a zip file at the bottom of this post with some samples. Re-encode.mkv is a re-encode only. No filtering. QTGMC.mkv is a re-encode while running QTGMC in progressive mode. That's my benchmark against which I often compare other filters. QTGMC(InputType=1) was added to the script. RemoveSpots.mkv is an encode using the RemoveSpots script here (second script). RemoveSpots() was all that was added to the script. RemoveDirt.mkv is an encode using the RemoveDirt script here. RemoveDirt() was all that was added to the script. RemoveDirty.mkv is an encode using the RemoveDirty script below. It's the RemoveDirtMC script with a name change so I could put them all in the plugins folder. RemoveDirty(limit=12) was added to the script. QTGMC leaves the most spots behind but also tends to improve the quality in other areas rather than reduce it. As many of us know, it's very slow. RemoveDirt blurs to much for me but it did remove all the spots. RemoveSpots blurs less than RemoveDirt and seems to do a pretty good job. RemoveDirty is the script below which was originally RemoveDirtMC. I'm guessing the idea is it removes dirt where there's no motion, but not so much where there is motion to cut down on the blurring? Or something like that? Quote:
No doubt each of the scripts could be tweaked for better results. I just used the default settings for each, except for the last one. I seemed to need to bump it up a bit. samples.zip 20.2MB Last edited by hello_hello; 25th September 2014 at 17:49. |
||
25th September 2014, 18:59 | #36 | Link | |
Registered User
Join Date: Mar 2011
Posts: 4,823
|
Quote:
ie You put a filter in a VirtualDub script which turns the entire frame purple, you open the script with VirtualDub, you'll see a purple frame. As far as VirtualDub's concerned, that's the original video. Or try adding this to a script: ColorBars() If you put it at the end you should see nothing but colour bars when you open the script. You're making it too hard to help you. You need to post a detailed description of what you're doing. What does "trying the scripts" involve? I mentioned why they may be having no effect here, but you haven't replied to say if that's what you're doing. Try MeGUI instead of VirtualDub. I mentioned it here. Use the File/Open menu and follow the prompts. Eventually the script creator will open with a preview. MeGUI creates a basic script for you but it's easy to modify the script manually. You can switch between the original unfiltered video and the video with the script applied using the Preview button. I quite often use MPC-HC to compare scripts. You need to change the setting to view "all files" to see scripts when you use the File/Open menu. I've also put a shortcut to MPC-HC in the Windows SendTo folder, so to open a script I can right click on one and select SendTo/MPC-HC. Often I'll create a simple script with virtually no filtering, then another with filtering, maybe a third etc.... then I use 3 instances of MPC-HC to open them all at the same time. You can open them as if they were the original video and run them full screen etc. I have my PC connected to my TV so I use the TV for viewing scripts in full screen mode before encoding. Anyway.... please explain exactly what you're doing as it's impossible to help otherwise. The easier you make it for someone to help you..... Maybe also explaining which scripts and/or plugins you have in the Avisynth plugins folder might help. Last edited by hello_hello; 25th September 2014 at 19:09. |
|
26th September 2014, 15:43 | #37 | Link |
Banned
Join Date: Sep 2014
Location: https://t.me/pump_upp
Posts: 10
|
well i am truly giving up..avisynth just does not work on my pc, had days of help from anther form with links, scrips, tips and i tried all..he even showed me how he had cleaned up some frames with the script he gave me. no matter what i do i can't load up removedirt or removespots i have tried dll, avs and avsi but all have errors
|
26th September 2014, 16:38 | #38 | Link | |
Excessively jovial fellow
Join Date: Jun 2004
Location: rude
Posts: 1,100
|
Quote:
Last edited by TheFluff; 26th September 2014 at 16:46. |
|
26th September 2014, 18:12 | #39 | Link |
Registered User
Join Date: Mar 2011
Posts: 4,823
|
"It doesn't work on my PC" is obviously nonsense, given it'd appear from the tiny bit of information we've been given, you've been able to create a basic script and open it in VirtualDub. If that's the case, then Avisynth works. You posted a screenshot of AvsPmod showing a preview of a script, and another screenshot of an Avisynth error message regarding a function in a script. Therefore, Avisynth is working. You've just not managed to get the plugins to load/work, but given you won't provide the slightest detail regarding what you've tried, giving up does seem like the sensible choice at this point.
I've no idea how much time you spent trying to sort the problem via the other forum you referred to, but if it's anything like the time you've put into posting here..... writing detailed posts gets frustrating pretty quickly when the person asking for help won't even make the effort to answer a single question. |
27th September 2014, 03:48 | #40 | Link | ||
Moderator
Join Date: Oct 2001
Location: Hawaii
Posts: 7,406
|
Quote:
Quote:
They're having the same problem over there. |
||
Thread Tools | Search this Thread |
Display Modes | |
|
|