MPC-HC tester builds for internal renderer fixes

[Hera]

D3DFS works now again.

[JanWillem32]

With which one of the two edited versions do you mean?

[Hera]

I think that ones in post #200 & #196 work.

[JanWillem32]

Did enabling the 10-bit output in exclusive mode crash the player?

[Hera]

Originally Posted by JanWillem32

Did enabling the 10-bit output in exclusive mode crash the player?

Well I don't use that setting but yes, yes it did.

[JanWillem32]

Thank you, although that means that I still have to fix that problem. I've used several methods to detect 10-bit display output capability already, and none of them work.

[TheElix]

What's up with subtitle renderer? On same settings in MPC-HC:
EVR CP: http://rghost.ru/15318001/image.png
madVR: http://rghost.ru/15318061/image.png
(don't mind Russian, haha)

[JanWillem32]

Can I have a sample of the .ASS, .SSA or ,SRT embedded item?
I haven't seen distortions like that yet, and as far as I know, the same sampling and alpha blending render states are used.

[TheElix]

These are external .srt, nothing irregular.

1
00:00:11,596 --> 00:00:14,098
Как веснушки эти ненавижу я

2
00:00:14,223 --> 00:00:17,059
И вздыхаю, только новую завижу я.

3
00:00:17,393 --> 00:00:19,729
Любовь на плечи тяжким грузом давит,

Basically, your version has no shadows and a very thin outline for some reason.

[JanWillem32]

The .SRT text subtitle works for me (saved as UTF-8). The text looks as it should.
What settings do you have in the "Default Style" tab of the options menu? What do you see during playback in the "Play", "Subtitles", "Styles" menu? Does editing the style or using "Reload" under "Play", "Subtitles" work?

[TheElix]

Here're my settings. I've always used them and have never experienced this before.

[JanWillem32]

Does the same layout for the default font appear during playback in the styles menu?
The next question would probably be about how does it fare with styled .SSA or .ASS subtitles, but I'll probably have to look for a suitable sample for that...

[Sievert]

Hi JW

Would chroma interpolation shaders work as efficient on interlaced sources?
If using NV12 output in the decoder, either dxva or software, is it correct to use "optimized for floating point surfaces" in the case you're using Full Floating Point Processing? Can you elaborate on the use of the 3 chroma shaders available, depending on the Presentation settings?

Thank you for your work so far.

[TheElix]

Here're embedded styled subtitles.
EVR CP: http://rghost.ru/15469531/image.png
madVR: http://rghost.ru/15469571/image.png

[JanWillem32]

@Sievert: Chroma up-sampling is normally done as one of the first things in a mixer (sometimes several stages before deinterlacing). Only the weave and bob deinterlacing types don't interpolate in a way that it distorts chroma. That means that the chroma up-sampling "trick" I made can be used to up-sample original 4:2:2 sources with weave and bob deinterlacing types. For the vertical stage of 4:2:0, the sampling distance has to change from 2 to 4 pixels to make that one work, too. The problem is that bob deinterlacing exists only as a last resort for if a previous deinterlacer failed. Weave is normally only activated on sources that are progressive-inside-interlaced. There are 3 common types of this (ignoring NTSC 1/1.001 rates at the moment): 24p or 30p content inside 60i, or 25p inside 50i. Many TV streams feature actual "hard" interlacing, generated by converting 60p to 60i and 50p to 50i. Those can't be weaved without heavy artifacts, so most deinterlacers do an adaptive form of frame interpolation.
The chroma interpolation shaders I wrote are an imperfect solution to the problem. I have plenty of filters ready to make all mixer stages work without those of EVR or VMR-9. I just never managed to get either of both output a completely unprocessed sample for me to work on. It would be very nice to be able to choose the resizers for chroma up-sampling, video image and bitmap-based subtitles. (That last one is in a testing phase.) The same thing for other filters, such as color controls, too.
For when it matters, I've made special shaders for when FFPP and HFPP are enabled. Those make more efficient use of the format. For the new line of chroma interpolation shaders, I'm only keeping the optimized forms, and the single-pass bilinear filter.

@TheElix: The blending stage looks okay to me. The only thing I can think of is that something is overwriting the styles. Can you check the "Styles" menu? You can also reset all settings temporarily by using :
REG EXPORT "HKCU\Software\Gabest\Media Player Classic" "%USERPROFILE%\Desktop\settings.reg"
REG DELETE "HKCU\Software\Gabest\Media Player Classic"

That way, full settings are saved as settings.reg on the desktop, and the registry is cleared. You can always run the settings.reg to set up the old settings again.

[kostik]

Hey!
When playing a movie with CMS enabled I get strange "color artifacts" specially on white . Tried disabling and changing settings in CMS and nothing helps but disabling the CMS. Tried disabling 10 BIT, playing in FS mode, nothing works.
see please the pics .
Thanks

[JanWillem32]

Some time ago, janos666 sent his profile so I could see it too. I believe it's the gamma + matrix type profile that's giving problems. I use a XYZ LUT + matrix profile and had never seen the problem of that type of color artifacts before. We are already assessing whether it's a problem in the implementation, or if there's something wrong in the profiles themselves. I'm not very sure yet what it is, unfortunately.

[kostik]

Originally Posted by JanWillem32

Some time ago, janos666 sent his profile so I could see it too. I believe it's the gamma + matrix type profile that's giving problems. I use a XYZ LUT + matrix profile and had never seen the problem of that type of color artifacts before. We are already assessing whether it's a problem in the implementation, or if there's something wrong in the profiles themselves. I'm not very sure yet what it is, unfortunately.

Where can I find a good profile with d65 and 2.2 gamma?
Can some1 upload pls.

[JarrettH]

I haven't tried these builds, but do you know when the new resizers will be incorporated? Right now there's just bilinear and bicubic right?

[Hera]

IMO, when this work will be incorporated, I think a new major release is justified (post-testing on main branch).
Any work on fixing the pixelated upscaled video when opening a file the 1st time?

Been testing subtitles with animation turned on,
- Only one file I know caused the EVR to stutter
- When there are supposed to be animated subs on top while at the same time on the bottom stationary subs, stationary subs blink when top subs animate karaoke style (need to test against VLC or something... eww, but will do it... for science!)
- When subs are on the screen (not animated, not even changing) - the graph is a bit more bumpy