Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

 
 
Thread Tools Search this Thread Display Modes
Prev Previous Post   Next Post Next
Old 24th March 2003, 19:26   #1  |  Link
sh0dan
Retired AviSynth Dev ;)
 
sh0dan's Avatar
 
Join Date: Nov 2001
Location: Dark Side of the Moon
Posts: 3,480
Continued from this thread.

Quote:
@sh0dan

Please don't tell me 0 pitch is forbidden.
No - 0 pitch is no problem. Can't see any problems arising from it.

Regarding your hierarchy - problem is that it's not an easy distinction - is seems ok. But it should also be remembered, that both YV12 and YUY2 are YUV formats - however I still like your distinction better.

So the complete hierarchy could look like this:

Code:
General --- IsInterLeaved() --------+--- IsYUV() -- YUY2
         \                           \
          \ IsPlanar()                -- IsRGB() -- RGB24 / RGB32
           |-- IsRGB()
           |__ IsYUV() - IsYV12() - YV12 / I420
I still don't like that you using switch to choose an algorithm - IMO using the functions are both more readable, and safer. For instance, your filter will NOT process I420 material, because the enum is different, for internal purposes that filter writers shouldn't care about.
__________________
Regards, sh0dan // VoxPod

Last edited by sh0dan; 25th March 2003 at 21:50.
sh0dan is offline   Reply With Quote
 

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 20:14.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.