Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
|
|
Thread Tools | Search this Thread | Display Modes |
3rd July 2012, 01:26 | #1082 | Link | |
Registered User
Join Date: May 2012
Posts: 92
|
Quote:
So the problem is not my configuration Last edited by mood; 3rd July 2012 at 02:18. |
|
3rd July 2012, 10:32 | #1085 | Link |
PgcEdit daemon
Join Date: Jul 2003
Posts: 7,469
|
Here it is: http://download.videohelp.com/r0lZ/t...titles_test.7z
The archive contains the original SUP, the IFO and the Subtitles_palette.ini I've used to generate the SUB/IDX files. The IDX files generated by SubtitleCreator and the java and c++ versions of BDSub2Sub are also included. The two log files are stripped down versions of the output of the BDSup2Sub programs. The command lines were: Code:
SubtitleCreator.exe Subpictures_22.sup -vfr -iSubpictures_22.IFO bdsup2sub++.exe --language fr --palette-file Subtitles_palette.ini --alpha-thr 40 --minimum-time 0 -o Subpictures_22.sub Subpictures_22.IFO java -Xmx256m -jar BDSup2Sub.jar /forced- /res:keep /fps:keep /lang:fr /pal:Subtitles_palette.ini /dly:0 /atr:40 ^ /scale:1.0,1.0 /tmin:0 /swap- /forceall- /exppal- /fixinv- /verbatim- Subpictures_22.IFO Subpictures_22.sub Note that my GUI overwrites the original palette of the INI saved by SubtitleCreator, as I can't be sure that it picks the palette of the right PGC in the IFO. I can of course do it also for BDSup2Sub++, but the bug must be fixed anyway. All other fields of the IDX files are identical, except the "custom colors:" line, that should be ignored anyway. I can't understand why the outline is not visible in both versions of BDSup2Sub. IMO, there is also a bug in the SUB files, related to the transparency or the way the colours are mapped to the pixels. Anyway, there must be some differences in the SUB files as well, but I can't easily locate them.
__________________
r0lZ PgcEdit homepage (hosted by VideoHelp) BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV Last edited by r0lZ; 3rd July 2012 at 10:44. |
3rd July 2012, 11:01 | #1086 | Link |
PgcEdit daemon
Join Date: Jul 2003
Posts: 7,469
|
Just did another test with ++. Same command as above, except that I've removed the "--palette-file Subtitles_palette.ini" option, to check if the program takes the IFO palette into account when no external palette is provided. Same bug.
Then, I've loaded the IFO file in the GUI, and verified the palette. It was correct. I've exported the SUB, and the palette was again wrong in the IDX. So, IMO, the bug is not when the IFO/SUP/palette are loaded, but when the palette is saved. It saves always the default palette, instead of the imported palette.
__________________
r0lZ PgcEdit homepage (hosted by VideoHelp) BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV |
3rd July 2012, 12:14 | #1087 | Link | |
Guest
Posts: n/a
|
Quote:
Thank you for the files you posted r0lz. Last edited by SassBot; 3rd July 2012 at 12:19. |
|
3rd July 2012, 12:53 | #1088 | Link |
Guest
Posts: n/a
|
Ok, I found the problem. It had to do with how the palette files were written out. I copied some code straight from the Java that was causing problems. deadbeef had written code to do his own number to hex string which added a 0x to the beginning so he was creating a substring to clip off the 0x. I copied over this behavior without realizing it even though Qt's string class does hex string creation without the 0x. So what was happening was the first 2 bytes of each hex color was trimmed off giving the erroneous result. I now get the proper output for that IFO/SUP when outputting to IDX/SUB. No longer green.
|
3rd July 2012, 13:08 | #1089 | Link |
PgcEdit daemon
Join Date: Jul 2003
Posts: 7,469
|
Good.
Can you have also a look at the problem of the missing outline? The original java version has that bug too, so I guess it will be harder to fix. (BTW, when the SUB/IDX is reloaded in BDSup2Sub, the outline seems correct. But it is not when the movie is played with my LaCie LaCinema HD box. It's not a bug of the LaCie, as the subtitles generated with SubtitleCreator do not have that problem.)
__________________
r0lZ PgcEdit homepage (hosted by VideoHelp) BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV |
3rd July 2012, 13:21 | #1091 | Link |
PgcEdit daemon
Join Date: Jul 2003
Posts: 7,469
|
__________________
r0lZ PgcEdit homepage (hosted by VideoHelp) BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV |
3rd July 2012, 13:40 | #1092 | Link | |
Guest
Posts: n/a
|
Quote:
Edit to add: So the issue is that when you choose to export to IDX/SUB it has "create new" selected for the palette mode by default so it will only output the default palette. You have to select "keep existing" to get the palette that you want. Last edited by SassBot; 3rd July 2012 at 13:46. |
|
3rd July 2012, 13:59 | #1093 | Link |
PgcEdit daemon
Join Date: Jul 2003
Posts: 7,469
|
OK, but IMO it should set "keep existing" by default. I don't see any reason to overwrite the (theoretically) right palette with the default one, almost always wrong. Anyway, it copies the default palette to the existing one if no palette has been provided (in blu-ray mode). If the user provides a palette (either with the IFO or with the palette CLI arg), why should it ignore it by default?
__________________
r0lZ PgcEdit homepage (hosted by VideoHelp) BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV |
3rd July 2012, 14:04 | #1094 | Link |
Guest
Posts: n/a
|
The behavior I described is only when you use the GUI. If you specify a palette file from the CLI it sets the flag to use the imported palette. The GUI on the other hand always defaults to "create new" when you choose IDX/SUB output and I just copied what the Java version did. Why deadbeef chose that I have no clue but I'm fine with changing it.
|
3rd July 2012, 14:08 | #1095 | Link |
PgcEdit daemon
Join Date: Jul 2003
Posts: 7,469
|
__________________
r0lZ PgcEdit homepage (hosted by VideoHelp) BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV |
3rd July 2012, 15:32 | #1097 | Link | |
Guest
Posts: n/a
|
Quote:
|
|
3rd July 2012, 15:35 | #1098 | Link |
PgcEdit daemon
Join Date: Jul 2003
Posts: 7,469
|
Palette bug fixed and it is now possible to specify CLI arguments and open the source SUP. Good job!
However, in the export dialogue, the default language is always English, even if another language has been specified from the CLI. Can you change that? Also, I've noticed a new "Subtitle language" dropdown box in the main window, but it is always disabled. What is (or will be) its usage? Will you remove the same option from the export dialogue? (IMO, that will be a good thing.)
__________________
r0lZ PgcEdit homepage (hosted by VideoHelp) BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV |
3rd July 2012, 15:38 | #1099 | Link | |||
Guest
Posts: n/a
|
Quote:
Quote:
Quote:
|
|||
3rd July 2012, 15:54 | #1100 | Link |
PgcEdit daemon
Join Date: Jul 2003
Posts: 7,469
|
That will be OK, although IMO that flag is not necessary. If some settings are provided via the command line, I suppose that the program can assume that the user wants them by default. You can simply overwrite all defaults that have been specified with the CLI. (I've not verified, but according to the original doc, it's what the original version is supposed to do.)
Thanks for the other info, and for the very informative link. I'm currently doing some tests with colour indexes different than the last one, but I can already confirm that the last colour was used, and was black. But if it's really a bug of the player, I don't understand why SubtitleCreator doesn't have the same issue. Will try to understand...
__________________
r0lZ PgcEdit homepage (hosted by VideoHelp) BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV |
Thread Tools | Search this Thread |
Display Modes | |
|
|